---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122926/#review77503
---
Umm; this seems to break source compatibilty maybe? For
On March 15, 2015, 11:10 a.m., Bhushan Shah wrote:
Umm; this seems to break source compatibilty maybe? For example
plasma-workspace Plasma/5.2 branch which compiled with older revisions fine
seems to fail with this commit
23:07:43 Building CXX object
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77511
---
src/kmoretools/kmoretools.cpp
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 36
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line36
Proper doxygen would look like this: The first sentence is always the
brief documentation.
Currently,
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 394
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394
Do we need the kmt-prefix? Why not just
KMoreToolsService * service();
I am not completely that happy
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 287
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287
@return, never @returns.
Further, can you be mor verbose?
@return Returns the tools
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122937/#review77531
---
Makes sense to me. Also did a bit of testing with a few
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122918/#review77498
---
Without testing anything, I think that this will break
On mar. 15, 2015, 11:10 a.m., Bhushan Shah wrote:
Umm; this seems to break source compatibilty maybe? For example
plasma-workspace Plasma/5.2 branch which compiled with older revisions fine
seems to fail with this commit
23:07:43 Building CXX object
On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote:
Without testing anything, I think that this will break QWidget's file
dialog when set to modal. Iirc this breaks for example the open dialogs in
qt creator.
Yeah, that's the wrong approach, though I'm not sure what the right one is
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 412
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line412
Qt API never returns a this pointer when settings some properties.
While not explicitely stated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
I don't think that the patch in it's current form is ok to
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 412
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line412
Qt API never returns a this pointer when settings some properties.
While not explicitely stated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 15, 2015, 5:07 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/
---
(Updated March 15, 2015, 5:18 p.m.)
Review request for KDE Frameworks
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 287
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287
@return, never @returns.
Further, can you be mor verbose?
@return Returns the tools
16 matches
Mail list logo
