Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89105 --- Please include Hugo for a review on the KStyle changes. I'd

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

2015-12-03 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/ --- (Updated Dec. 3, 2015, 9:56 a.m.) Review request for KDE Frameworks,

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

2015-12-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/#review89085 --- This looks interesting, but it seems like it would make it

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

2015-12-03 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/ --- (Updated Dec. 3, 2015, 1:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

2015-12-03 Thread Lamarque Souza
> On Dec. 2, 2015, 4:45 p.m., Lamarque Souza wrote: > > That code was added to fix this bug > > https://bugs.kde.org/show_bug.cgi?id=171343#c6 > > Xuetian Weng wrote: > Emm.. interesting feature. But code inside mouseMoveEvent looks fishy, > and this feature shouldn't be used when

Re: Purpose as a KDE Framework

2015-12-03 Thread Marco Martin
On Tuesday 01 December 2015, Aleix Pol wrote: > Hi, > I've been working on Purpose since some months now, with the intention > of becoming a framework some day. Some information about it can be > read here: > https://projects.kde.org/projects/playground/libs/purpose/repository/revisi >

Review Request 126231: Fix a small artifact of kratingwidget on hidpi

2015-12-03 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126231/ --- Review request for KDE Frameworks, Christoph Feck and David Edmundson.

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

2015-12-03 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/ --- (Updated Dec. 3, 2015, 10:19 a.m.) Review request for KDE Frameworks,

Re: Review Request 126226: kdetemplate_add_app_templates installs previews

2015-12-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126226/#review89081 --- Ship it! Ship It! - Marco Martin On Dec. 3, 2015, 1:27

Re: Purpose as a KDE Framework

2015-12-03 Thread Marco Martin
On Tuesday 01 December 2015, Martin Graesslin wrote: > > As it is right now it's a tier 2 framework (kcoreaddons and ki18n) > > plus the plugins. Plugins raise the tier to 3 because of KIO which is > > used by some plugins. > > do plugins have to be inside the framework? Otherwise an option might

KTabBar/QTabBar and documentMode

2015-12-03 Thread René J . V . Bertin
Hi, I've been looking into ways to configure (improve) the look and feel using the native platform theme on OS X, and was reminded quite quickly about one of the nuisances that can arise with the default look of the native widget used by QTabBar. It's easy to reach the number of open tabs

Re: Purpose as a KDE Framework

2015-12-03 Thread David Edmundson
On Thu, Dec 3, 2015 at 6:16 PM, Aleix Pol wrote: > On Tue, Dec 1, 2015 at 4:37 PM, David Edmundson > wrote: > > AlternativesModel doesn't seem like a good name. Alternate to what? > > > > - > > > > /** @returns the job that will perform the

Re: Purpose as a KDE Framework

2015-12-03 Thread Boudhayan Gupta
Hi Aleix, On 3 December 2015 at 23:51, Aleix Pol wrote: > On Tue, Dec 1, 2015 at 5:10 PM, Boudhayan Gupta wrote: >> On 1 December 2015 at 20:42, Aleix Pol wrote: 1. I'd like to be able to load the list of plugins available per

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

2015-12-03 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/ --- (Updated Dec. 3, 2015, 7:16 p.m.) Review request for KDE Frameworks and

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-03 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 3, 2015, 10:51 p.m.) Review request for KDE Software on

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Thu, Dec 3, 2015 at 8:15 PM, David Edmundson wrote: > > > On Thu, Dec 3, 2015 at 6:16 PM, Aleix Pol wrote: >> >> On Tue, Dec 1, 2015 at 4:37 PM, David Edmundson >> wrote: >> > AlternativesModel doesn't seem like a good

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89097 --- kde-modules/KDETemplateMacro.cmake (line 1)

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: > On Tue, Dec 1, 2015 at 3:01 PM, Aleix Pol wrote: >> >> Hi, >> I've been working on Purpose since some months now, with the intention >> of becoming a framework some day. Some information about it can be >>

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Tue, Dec 1, 2015 at 5:39 PM, Emmanuel Pescosta wrote: > On Dienstag, 1. Dezember 2015 15:01:10 CET Aleix Pol wrote: > > Hi, > looks really interesting! > >> I'd like to see it used in other cases than sharing as well as in other > applications > > Would you

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Tue, Dec 1, 2015 at 4:37 PM, David Edmundson wrote: > AlternativesModel doesn't seem like a good name. Alternate to what? > > - > > /** @returns the job that will perform the share of the specified @p data.*/ > > what data? Eh... right. I'll also change the

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Tue, Dec 1, 2015 at 5:10 PM, Boudhayan Gupta wrote: > On 1 December 2015 at 20:42, Aleix Pol wrote: >>> 1. I'd like to be able to load the list of plugins available per >>> mimetype a priori before the filename to share becomes available. >> You can pass {

Re: Purpose as a KDE Framework

2015-12-03 Thread Aleix Pol
On Thu, Dec 3, 2015 at 11:37 AM, Marco Martin wrote: > On Tuesday 01 December 2015, Aleix Pol wrote: >> Hi, >> I've been working on Purpose since some months now, with the intention >> of becoming a framework some day. Some information about it can be >> read here: >>

Re: KTabBar/QTabBar and documentMode

2015-12-03 Thread Jaroslaw Staniek
On Thursday, 3 December 2015, René J.V. wrote: > Hi, > > I've been looking into ways to configure (improve) the look and feel using the native platform theme on OS X, and was reminded quite quickly about one of the nuisances that can arise with the default look of the native