Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Thomas Lübking
> On Feb. 26, 2016, 2:14 p.m., Thomas Lübking wrote: > > src/kcompletionbox.cpp, line 66 > > > > > > q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken?? > > Marco Martin wrote: > ok, i'm blind :p >

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 18 February 2016 at 18:25, Kåre Särs wrote: > On Thursday, February 18, 2016 02:51:58 PM René J.V. Bertin wrote: > > On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote: > > >>> > since QIcon::fromTheme() apaprently isn't able to find app icons. > > > > Care to

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Martin Gräßlin
> On Feb. 26, 2016, 3:14 p.m., Thomas Lübking wrote: > > src/kcompletionbox.cpp, line 66 > > > > > > q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken?? > > Marco Martin wrote: > ok, i'm blind :p

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 7 March 2016 at 10:46, Jaroslaw Staniek wrote: > > > On 18 February 2016 at 18:25, Kåre Särs wrote: > >> On Thursday, February 18, 2016 02:51:58 PM René J.V. Bertin wrote: >> > On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote: >> > >>> > since

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Marco Martin
> On Feb. 26, 2016, 2:14 p.m., Thomas Lübking wrote: > > src/kcompletionbox.cpp, line 66 > > > > > > q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken?? > > Marco Martin wrote: > ok, i'm blind :p >

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review93251 --- any updates? - Marco Martin On Feb. 26, 2016, 2:18 p.m.,

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review93253 --- src/kcompletionbox.cpp (line 65)

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

2016-03-07 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127275/ --- (Updated March 7, 2016, 12:32 p.m.) Review request for KDE Frameworks

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

2016-03-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/ --- (Updated March 7, 2016, 11:35 a.m.) Status -- This change has been

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Kåre Särs
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote: > > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129 > > > > > > Thanks for the comment. However, as long as we don't know the root > > cause for the null

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 7, 2016, 2:35 nachm.) Review request for KDE Frameworks

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-03-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review93261 --- Ship it! Ship It! - Martin Gräßlin On March 4, 2016,

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
Real data for a single Kexi start + opening a single document on Linux, SSD: strace kexi 2>&1 | grep ^stat | wc -l 1. Traditional icon files: 78k calls 2. .rcc icon files: 11k calls, starts ~14% faster And for #2 there are still a few thousands of lookups (*/icons/hicolor/16x16/devices etc.)

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-03-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated März 7, 2016, 2:34 nachm.) Review request for KDE Frameworks

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread René J . V . Bertin
On Monday March 07 2016 12:41:52 Jaroslaw Staniek wrote: >I am trying to use app-defined icons through QIcon::fromTheme() in Kexi. That sounds inherently wrong unless the application adds icons to specific themes. Icons that are specific to an application are (almost) by definition not part of

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

2016-03-07 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127275/#review93265 --- Ship it! Ship It! - Chusslove Illich On Март 7, 2016,

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 7 March 2016 at 14:45, René J.V. wrote: > On Monday March 07 2016 12:41:52 Jaroslaw Staniek wrote: > >I am trying to use app-defined icons through QIcon::fromTheme() in Kexi. > > That sounds inherently wrong unless the application adds icons to specific > themes. Icons

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/#review93270 --- src/kmoretools/kmoretoolsmenufactory.cpp (lines 128 - 129)

Re: Review Request 127237: Fix crash in kmore tools on Windows

2016-03-07 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ --- (Updated March 7, 2016, 8:38 p.m.) Review request for KDE Frameworks and

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 7 March 2016 at 17:29, Jaroslaw Staniek wrote: > > On 7 March 2016 at 13:05, Kåre Särs wrote: > >> Hi, >> >> On Monday, March 07, 2016 12:41:52 PM Jaroslaw Staniek wrote: >> > > >> > > ​Thanks, it works on Windows (no platform theme). >> > > ​​How to make

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 7 March 2016 at 14:45, René J.V. wrote: > On Monday March 07 2016 12:41:52 Jaroslaw Staniek wrote: > > BTW, am I right that using a builtin binary rcc icon set could make you > lose in terms of memory (RAM) footprint overhead what you gain in terms of > disk space

Re: RCC for icons - update: Re: Icons installed by apps

2016-03-07 Thread Jaroslaw Staniek
On 7 March 2016 at 13:05, Kåre Särs wrote: > Hi, > > On Monday, March 07, 2016 12:41:52 PM Jaroslaw Staniek wrote: > > > > > > ​Thanks, it works on Windows (no platform theme). > > > ​​How to make it work on Linux too (KF5 5.19.0, Qt 5.5.1), i.e. I'd > like > > > to have only

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-03-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/ --- (Updated March 8, 2016, 12:17 a.m.) Status -- This change has been