Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98254 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 10,

Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/ --- Review request for KDE Frameworks and Plasma. Repository:

Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/ --- Review request for KDE Frameworks, Plasma and David Faure. Repository:

Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/ --- Review request for KDE Frameworks, Plasma and David Faure. Repository:

Re: Review Request 128638: Move kwallet-query docbook to correct subdir

2016-08-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128638/#review98251 --- Ship it! It's useful when copying stuff around to use

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98252 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016,

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

2016-08-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/#review98253 --- Ship it! Ship It! - Sebastian Kügler On Aug. 9, 2016,

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/#review98255 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 10,

Re: Review Request 128608: Add Donate entry to KStandardShortcut

2016-08-09 Thread Matthew Dawson
> On Aug. 9, 2016, 11:23 p.m., Matthew Dawson wrote: > > LGTM. I can't speak for the other review. Sorry, one other thing: Please make sure to put a CHANGELOG: entry in the commit message. Thanks! - Matthew --- This is an

Re: Review Request 128608: Add Donate entry to KStandardShortcut

2016-08-09 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128608/#review98258 --- Ship it! LGTM. I can't speak for the other review. -

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 11 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 11 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 9 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 133 - Fixed!

2016-08-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/133/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 09:41:34 + Build duration: 9 min 32 sec CHANGE SET Revision

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated Aug. 9, 2016, 8:37 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 132 - Failure!

2016-08-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/132/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 09 Aug 2016 08:37:25 + Build duration: 55 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 132 - Unstable!

2016-08-09 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/132/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 08:37:24 + Build duration: 3 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 132 - Failure!

2016-08-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/132/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 09 Aug 2016 08:37:25 + Build duration: 10 sec CHANGE SET Revision

Re: Review Request 128612: Add translation domain to wallpaper QML object

2016-08-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128612/ --- (Updated Aug. 9, 2016, 8:37 a.m.) Status -- This change has been

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-08-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review98219 --- Ship it! Ship It! - Martin Gräßlin On July 21, 2016,

Review Request 128635: [knewstuff] Fix build with Qt 5.8

2016-08-09 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128635/ --- Review request for KDE Frameworks. Repository: knewstuff Description

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-09 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/ --- (Updated Aug. 9, 2016, 3:20 p.m.) Review request for KDE Frameworks and

Review Request 128638: Move kwallet-query docbook to correct subdir

2016-08-09 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128638/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and