[Differential] [Updated] D4575: add a popupmenuabouttoshow version that exposes the menu

hein added a comment. In the review comment you write that users of the API can use the MIME data to decide whether to call setApplicationActions, but in https://phabricator.kde.org/D4576 you end up manipulating the provided QMenu instance directly, including code written in awareness of

[Differential] [Accepted] D4603: Use sentence style capitalization with label texts of edit fields

cullmann accepted this revision. cullmann added a reviewer: cullmann. cullmann added a comment. This revision is now accepted and ready to land. Ok with that, thanks! REPOSITORY R39 KTextEditor BRANCH improveLabelTexts REVISION DETAIL https://phabricator.kde.org/D4603 EMAIL

[Differential] [Changed Subscribers] D4234: Change algorithm for autobrace.

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.cpp:2920-2921 > +(isEndBracket(chars[0]) || > + chars[0] == QLatin1Char('\'') || > + chars[0] == QLatin1Char('\"'))) { > + Why seach a checks ? REPOSITORY R39 KTextEditor

[Differential] [Commented On] D4537: EditorConfig support

cullmann added a comment. The problem with // reading .editorconfig files is loosely based on gnome-builder’s // libide/editorconfig/editorconfig-glib.c is that that code is GPL. On the other side, I see no real copyrightable material beside you are using the editor config

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In https://phabricator.kde.org/D4537#86356, @cullmann wrote: > On the other side, I see no real copyrightable material beside you are using the editor config API. As I’ve written, I used Builder’s source to //learn// that (1) I have to call

[Differential] [Commented On] D4537: EditorConfig support

cullmann added a comment. Ok, then I would opt for removing the comment. Beside that, I think in some places early outs would be preferable to nesting, e.g. like if (code != 0) { if (code == EDITORCONFIG_PARSE_MEMORY_ERROR) { ​qCDebug(LOG_KTE) << "Failed to parse

[Differential] [Commented On] D4234: Change algorithm for autobrace.

anthonyfieroni added a comment. In https://phabricator.kde.org/D4234#85804, @brauch wrote: > Sorry, I wanted to write a reply but failed. My idea was simply to have the algorithm always aim to make parentheses balanced when closing one. You mean when we have 3 open when 1 is

[Differential] [Commented On] D4234: Change algorithm for autobrace.

cullmann added a comment. As I don't use this myself, my opinion won't really matter. Sven, is the new proposed behavior really worse than the old? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 EMAIL PREFERENCES

[Differential] [Closed] D4603: Use sentence style capitalization with label texts of edit fields

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a2bc24bd3e59: Use sentence style capitalization with label texts of edit fields (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. Yes, it was good when actual parsing was delegated to a separate function, but we’ve decided to merge all parsing-related functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4537 EMAIL PREFERENCES

[Differential] [Commented On] D4190: Update file type on save only if path changes

cullmann added a comment. If you have no commit rights, pass me your mail address for the commit, will do that for you. REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mperttunen, #ktexteditor,

[Differential] [Updated, 254 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11349. gszymaszek added a comment. Simplified the constructor and reduced parser indentation. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4537?vs=11279=11349 REVISION DETAIL

[Differential] [Commented On] D4342: Use texture atlas for static icon item

davidedmundson added a comment. This shouldn't have any impact to it being pixelated, it just changes where the texture is stored, it can't make it any smaller. Are you sure it's definitely this change? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Commented On] D4589: EditorConfig module

dhaumann added inline comments. INLINE COMMENTS > Findeditorconfig.cmake:2 > +# > +# Copyright (c) 2016 João Valverde > +# All rights reserved. 1. Please add yourself as copyright holder. 2. Could you have a look at the comments at the very top of the other

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. I start to agree that it's probably better to revert this patch, for the simple reason: We might break compilation of a project using boost if boost decides to add code which uses alternative tokens to any of its headers. This is not under our control. On the

[Differential] [Commented On] D4342: Use texture atlas for static icon item

drosca added a comment. This broke rendering of icons in Quicklaunch plasmoid for me (Sandy Bridge GPU), you can see on the screenshot that it is pixelated. Also the image slightly moves during the active animation, as texture atlas is used only when animation is not running. I can only

[Differential] [Updated] D4342: Use texture atlas for static icon item

drosca added a comment. Yes. Latest master https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 - broken. Latest master https://phabricator.kde.org/R242:263f119e17df7c24f8372710c555486429b57971 with this change reverted - fixed. REPOSITORY R242 Plasma

[Differential] [Closed] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

This revision was automatically updated to reflect the committed changes. Closed by commit R236:8ab5a291e855: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3826: Detect inotify.

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH inotify REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: adridg, apol,

[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

sitter accepted this revision. sitter added a comment. Ah! I hadn't even thought of QSettings. Love the change. FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing `parseContext`

[Differential] [Updated, 88 lines] D4589: EditorConfig module

gszymaszek updated this revision to Diff 11329. gszymaszek added a comment. Added description. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4589?vs=11308=11329 REVISION DETAIL https://phabricator.kde.org/D4589 AFFECTED FILES

[Differential] [Request, 22 lines] D4607: finish support for opening compressed packages

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY it's possible to do setPath(zipfile path) and open a compressed package as it was a real

[Differential] [Abandoned] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D4455 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4190: Update file type on save only if path changes

mperttunen added a comment. Thanks, I don't think I do. My mail address is 'cyn...@kapsi.fi'. REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mperttunen, #ktexteditor, cullmann Cc: cullmann,

[Differential] [Closed] D4448: Don't use tier3 frameworks in unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b42483f4cbdb: Rewrite tests to not use tier3 frameworks (authored by svuorela). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4448?vs=10942=11351#toc REPOSITORY R266 Breeze Icons CHANGES

[Differential] [Commented On] D4234: Change algorithm for autobrace.

brauch added a comment. In https://phabricator.kde.org/D4234#86372, @anthonyfieroni wrote: > You mean when we have 3 open when 1 is close to be inserted 2 more to balance counting ? It's not a good idea, about me. No, but if you type a closing one right before a closing one,

[Differential] [Updated] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

jsalatas added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jsalatas, #frameworks, #plasma, #ktexteditor Cc: plasma-devel, kwrite-devel, lesliezhai,

Baloo and Application using it

Hello, I am using Baloo to collect all audio files in its database. I would like to keep the list up to date with the Baloo database when my application is running. Currently Baloo DBus interface provides two information: * the files currently being scanned: could help discover new files ; * a