D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15238. jpoelen edited the summary of this revision. jpoelen added a comment. - Update test reference data REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15237=15238 BRANCH upstream REVISION

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15239. jpoelen added a comment. Previous diff on bad branch REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15238=15239 BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15240. jpoelen added a comment. - cmake test: add an expression with nested parenthesis REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15239=15240 BRANCH upstream REVISION DETAIL

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

kfunk added a comment. +1 from my side -- Please wait for another +1 from another person. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks Cc: kfunk

D6104: Use the right scope for the installpath variable

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Personally less fond of auto than you are... But, that is just me, and this is a framework, and it's fine :) A massive reduction in allocations is a very good thing, go for it :)

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

leinir added a comment. On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained

D6008: Give a parent to KMoreToolsMenuFactory menus

elvisangelaccio updated this revision to Diff 15197. elvisangelaccio added a comment. - Bumped @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6008?vs=14932=15197 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6008 AFFECTED FILES

Re: Review Request 122551: New feature: Open all recent files

> On Feb. 13, 2015, 12:06 a.m., Kevin Funk wrote: > > You're aware that Kate (and any other decent editor) has session management > > which probably solves your issue? It saves the session when you close it, > > and re-opens all the files that had been opened. > > Thomas Murach wrote: >

D6086: Left-click mini-map to jump to clicked area

kfunk added a comment. There are a couple of problems with the new behavior -- though I can't tell precisely when they're caused. And not sure they're new or not either. Things I'm seeing while mini map is enabled, only in some documents though: - When the slider is position at the

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

This revision was automatically updated to reflect the committed changes. Closed by commit R304:00aa6b29644b: Make it possible to use QXmlStreamReader to read a KNS registry file (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D6104: Use the right scope for the installpath variable

This revision was automatically updated to reflect the committed changes. Closed by commit R304:75031fb7a53a: Use the right scope for the installpath variable (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6104?vs=15181=15219 REVISION

KDE CI: Frameworks khtml kf5-qt5 XenialQt5.7 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks khtml kf5-qt5 XenialQt5.7 Date of build: Tue, 06 Jun 2017 15:09:55 + Build duration: 5 min 9 sec and counting JUnit Tests

KDE CI: Frameworks khtml kf5-qt5 XenialQt5.7 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20khtml%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks khtml kf5-qt5 XenialQt5.7 Date of build: Tue, 06 Jun 2017 15:05:15 + Build duration: 3 min 50 sec and counting CONSOLE OUTPUT

RFC: Packaging of KF5 API dox QCH files and their devel helper files

Hi packagers, (cc: to kde-frameworks-devel only for heads-up) with ECM/KF5 5.35.0 now snapshot and being prepared for release, a new feature has already been pushed to the master branches of ECM and almost all the non- deprecated KF5 modules, which might need some more fine-tuning in the few

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6128 To: jpoelen, #framework_syntax_hightlighting Cc: #frameworks

D6126: Support fractional scaling in generating the sidebar preview

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, kwrite-devel, plasma-devel. REVISION SUMMARY QPaintDevice::devicePixelRatio was replaced by devicePixelRatioF when Qt supported fractional

D6042: Don't use the path as is if it's a data: url

apol abandoned this revision. apol added a comment. dfaure fixed it separately in commit https://phabricator.kde.org/R241:aafa5b7bbc89301c478f8089d6738a4c5896bcac REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6042 To: apol, #frameworks

D6126: Support fractional scaling in generating the sidebar preview

apol added a comment. +1 would it make sense to add a clazy check that identifies uses of this method? Or deprecating the method altogether? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6126 To: davidedmundson, #plasma Cc: apol, plasma-devel, kwrite-devel,

D6128: CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted.

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128 AFFECTED FILES data/syntax/cmake.xml To:

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug 360656 - CMake: OR/AND not highlighted after expr in ()". jpoelen edited the summary of this revision. jpoelen edited the test plan for this

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

apol added a comment. In https://phabricator.kde.org/D6067#114498, @leinir wrote: > On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly

D6116: Add new stateChanged() signal to active connection

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY There is a new additional StateChanged() signal coming from NetworkManager with additional reason property so with that we can now check

D6116: Add new stateChanged() signal to active connection

jgrulich added a reviewer: lvsouza. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6116 To: jgrulich, lvsouza Cc: #frameworks

D6115: Update introspections (NM 1.8.0)

This revision was automatically updated to reflect the committed changes. Closed by commit R282:ffb40b433368: Update introspections (NM 1.8.0) (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6115?vs=15209=15211#toc REPOSITORY R282 NetworkManagerQt CHANGES SINCE

Re: extra-cmake-modules in kdesupport?

On Sat, Jun 3, 2017 at 11:32 AM, David Faure wrote: > On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote: >> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano > wrote: >> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: >> >> Is there a reason

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D6067#114528, @apol wrote: > In https://phabricator.kde.org/D6067#114498, @leinir wrote: > > > On a similar note to handling comments, how does it now

D6115: Update introspections (NM 1.8.0)

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add new stateChanged() signal to active connection There is a new additional StateChanged() signal coming from NetworkManager with

D6115: Update introspections (NM 1.8.0)

jgrulich abandoned this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6115 To: jgrulich Cc: #frameworks

D6041: Port a bunch of classes away from Plasma::Package

This revision was automatically updated to reflect the committed changes. Closed by commit R242:563011436d5f: Port a bunch of classes away from Plasma::Package (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/7/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Tue, 06 Jun 2017 13:33:52 + Build duration: 37 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kpackage kf5-qt5 XenialQt5.7 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/8/ Project: Frameworks kpackage kf5-qt5 XenialQt5.7 Date of build: Tue, 06 Jun 2017 13:36:17 + Build duration: 55 sec and counting JUnit Tests

D6121: Angular modifiers in HTML attributes added

zhigalin added reviewers: Kate, KTextEditor. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6121 To: zhigalin, #kate, #ktexteditor Cc: #frameworks

D6121: Angular modifiers in HTML attributes added

zhigalin created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Angular uses special characters in HTML atributes This disables the error highlighting for []()*# in HTML tag attributes TEST PLAN

D6122: Add since tags.

tfry created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY I hate having to look up when interesting new classes were added. Patch is straight-forward (I think), but: - should @since be added on all memebers, when it's already on the class? - would

D6086: Left-click mini-map to jump to clicked area

sars added a comment. I think I fixed it. The comment about the dragging was only partially correct. The press must be inside the slider for dragging, so when the initial press is outside or not translated from the mini-map coordinates, the dragging does not start. My solution is to

D6086: Left-click mini-map to jump to clicked area

dhaumann added a comment. Hi, I'm sorry I am a bit late to the game: I once also tried to implement this, but the result was a messy patch that did not always get the location right. So I would not be surprised if there are corner cases that do not work. In any case, either we stabilize

D6122: Add since tags.

cfeck added a comment. The patch is simple, but it is always a good idea to ask for a review. Since this frameworks is new as of 5.28, should we really mark each class this way? We did not do this for other "new" frameworks, such as prison or kwayland. REPOSITORY R216 Syntax