D7458: Show icons in icon border context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5118d39bb24e: Show icons in icon border context menu (authored by croick). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7458?vs=18554=18558#toc REPOSITORY R39 KTextEditor CHANGES SINCE

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

ngraham added a comment. I haven't forgotten about this, but life has intervened and I'm not going to have time to work on it for a few days, maybe even a couple of weeks. If anyone else wants to run with it and take over, I won't be in the least bit offended. If not, I'll resume work at

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

cfeck added a comment. https://phabricator.kde.org/D7316 has been committed, and the referenced bug marked as fixed. Reading above comments, this patch can/should be committed, too. Please check if this is still true, and either approve this patch, or discard it. REPOSITORY R127

D7460: Treat input RGB buffers as premultiplied

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH mart/xdgforeign REVISION DETAIL https://phabricator.kde.org/D7460 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff,

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/5/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 22 Aug 2017 14:44:46 + Build duration: 3 min 47 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/51/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 16:12:22 + Build duration: 42 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/55/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 22 Aug 2017 16:12:22 + Build duration: 1 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/54/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 22 Aug 2017 14:22:21 + Build duration: 1 min 16 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/50/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 14:22:21 + Build duration: 59 sec and counting JUnit Tests

D7463: Really rate-limit INF_PROCESSED_SIZE messages

This revision was automatically updated to reflect the committed changes. Closed by commit R241:801f58e7e76a: Really rate-limit INF_PROCESSED_SIZE messages (authored by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7463?vs=18535=18541 REVISION DETAIL

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/52/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 16:42:26 + Build duration: 55 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/56/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 22 Aug 2017 16:42:26 + Build duration: 1 min 14 sec and counting JUnit Tests

D7458: Show icons in icon border context menu

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. I think we need one more iteration, then this is good to go, see the comments. INLINE COMMENTS > kfunk wrote in kateviewhelpers.cpp:2253 > Less code with: > > if (auto

D7458: Show icons in icon border context menu

croick updated this revision to Diff 18554. croick added a comment. - use icon without checking REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7458?vs=18519=18554 BRANCH iconbordermenu REVISION DETAIL https://phabricator.kde.org/D7458 AFFECTED

D7162: KSqueezedTextLabel: Add isSqueezed() for convenience

dhaumann accepted this revision. dhaumann added a comment. Please commit (also https://phabricator.kde.org/D7161) REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D7162 REVISION DETAIL https://phabricator.kde.org/D7162 To: rkflx, #frameworks, dhaumann Cc: dhaumann

D7175: Redesign CMake syntax

dhaumann added a comment. What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right? I would be fine with this change, but the other point still stand: remove hard-coded

D7164: KSqueezedTextLabel: Respect indent, margin and frame width

dhaumann added a subscriber: cfeck. dhaumann added a comment. To me this looks good. It seems Q_PROPERTYs can be overridden (at least, this follows imho from "The presence of the FINAL attribute indicates that the property will not be overridden by a derived class" from

Re: relocatable kdoctools

Harald Sitter wrote: > Ahoy ahoy > > I've just stumbled upon a rather puzzling situation with kdoctools. It > has code branching to turn its assets relocatable [1] (i.e. resolve > paths relative rather than hardcode their location). Now the weird bit > about this is that it is only used on

D7458: Show icons in icon border context menu

croick marked an inline comment as done. croick added a comment. Yes, the QAction simply overwrites its icon, which then just stays null. Works fine, thank you! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7458 To: croick, #ktexteditor, dhaumann Cc: dhaumann,

D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter

dhaumann added a comment. @atomsymbol I would love to get this into KTextEditor. Would you mind having another look? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4619 To: atomsymbol, mwolff, dhaumann, kfunk Cc: dhaumann, kwrite-devel, #frameworks

D7458: Show icons in icon border context menu

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Good patch, thanks a lot! You can make the QPixmap const, if you want: const QPixmap icon = ...; Please commit. REPOSITORY R39 KTextEditor BRANCH iconbordermenu REVISION

D7175: Redesign CMake syntax

turbov added a comment. In https://phabricator.kde.org/D7175#138554, @dhaumann wrote: > What is still unclear to me: As I understand we from time to time run the generator script (point 2 in my list). So this is not automatically run when executing "make", right? correct. it

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/62/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 21:11:34 + Build duration: 7 min 47 sec and counting JUnit

Re: relocatable kdoctools

Hi, I'm using the following patch to cross build kdoctools for windows https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:KF536/mingw32-kdoctools/0001-Generate-xml-files-containing-relative-pathes-to-dtd.patch?expand=1 It requires only a little platform

D7318: KFileItemDelegate: Always reserve space for icons

fvogt added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7318 To: fvogt, #frameworks Cc: cfeck, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/49/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 08:40:40 + Build duration: 1 min 0 sec and counting JUnit Tests

D7459: Use config.h more

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0ee0be681108: Use config.h more (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7459?vs=18526=18529 REVISION DETAIL

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/61/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 08:47:56 + Build duration: 11 min and counting JUnit Tests

D7460: Treat input RGB buffers as premultiplied

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Currently the server treats incoming buffers as not premultiplied. KWayland::Client sends data

D7461: Add syntax highlighting for AppArmor Profiles.

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY AppArmor is a Linux security module that provides mandatory access control on Linux. The AppArmor Profiles are plain text files that

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 9:25 PM, Harald Sitter wrote: > Ahoy ahoy Hi Harald, > > I've just stumbled upon a rather puzzling situation with kdoctools. It > has code branching to turn its assets relocatable [1] (i.e. resolve > paths relative rather than hardcode their location).

Re: relocatable kdoctools

On Tue, Aug 22, 2017 at 11:32 AM, Ben Cooksley wrote: > On Tue, Aug 22, 2017 at 9:25 PM, Harald Sitter wrote: >> Ahoy ahoy > > Hi Harald, > >> >> I've just stumbled upon a rather puzzling situation with kdoctools. It >> has code branching to turn its assets

D7239: Drop unused dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R169:478b31fd1b92: Drop unused dependency (authored by heikobecker). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7239?vs=17984=18528 REVISION DETAIL

D7239: Drop unused dependency

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/53/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 22 Aug 2017 08:40:40 + Build duration: 54 sec and counting JUnit Tests

relocatable kdoctools

Ahoy ahoy I've just stumbled upon a rather puzzling situation with kdoctools. It has code branching to turn its assets relocatable [1] (i.e. resolve paths relative rather than hardcode their location). Now the weird bit about this is that it is only used on windows. The reason this puzzles me is

D7461: Add syntax highlighting for AppArmor Profiles.

nibags added a reviewer: Framework: Syntax Hightlighting. nibags added a project: Framework: Syntax Hightlighting. nibags added a subscriber: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate,

D7462: [kiocore] assert that klauncher is running or not

bshah created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY We are currently checking if the klauncher is running under different user, and if so, we decide to fork the slave. In addition to that also assert that klauncher is actually running or

D7461: Add syntax highlighting for AppArmor Profiles.

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. See Christoph's comments. And indeed, please remove all hard-coded colors. Also, please provide a test file that is preferrably licensed under MIT. INLINE COMMENTS >

D7245: Improve reStructuredText highlighting

dhaumann added a comment. Looks better, but still, could you provide an autotest case for unit testing, licensed under MIT ? REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks

D7461: Add syntax highlighting for AppArmor Profiles.

nibags added a comment. OK, I'll correct it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_hightlighting, #frameworks, vkrause

D7462: [kiocore] assert that klauncher is running or not

bshah updated this revision to Diff 18534. bshah added a comment. more references of downstream bug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7462?vs=18532=18534 BRANCH klauncher-fix REVISION DETAIL https://phabricator.kde.org/D7462 AFFECTED FILES

D7462: [kiocore] assert that klauncher is running or not

bshah edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks, sitter, dfaure

D7461: Add syntax highlighting for AppArmor Profiles.

cullmann added a comment. Three things I see ATM: 1. Please no hard coded colors, are they really necessary? 2. I think we want some test file for it with reference in the autotests directory 3. If possible please MIT license REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D7462: [kiocore] assert that klauncher is running or not

sitter added a comment. LGTM. Also can confirm this fixes the original problem of defunct kfileopen dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7462 To: bshah, #frameworks, sitter, dfaure

D7443: Fix compilation on windows with editorconfig-c-core available

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7458: Show icons in icon border context menu

kfunk added a comment. Other than that the patch looks sensible to me. INLINE COMMENTS > kateviewhelpers.cpp:2253 > +dMA = > selectDefaultMark.addAction(m_doc->markDescription(markType)); > +} else { > +mA = markMenu.addAction(icon, >

D7459: Use config.h more

kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This also fixes an issue with regards to HAVE_FDATASYNC: src/buffer/katesecuretextbuffer.cpp:157:5: warning:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/60/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 22 Aug 2017 07:17:43 + Build duration: 18 min and counting JUnit Tests

D7459: Use config.h more

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D7459 To: kfunk, cullmann Cc: cullmann, kwrite-devel, #frameworks

D7463: Really rate-limit INF_PROCESSED_SIZE messages

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fixing an ancient porting bug which popped up when porting from Qt4 to Qt5. FIXED-IN: 5.38 BUG: 383843 REPOSITORY R241 KIO BRANCH

D7463: Really rate-limit INF_PROCESSED_SIZE messages

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7463 To: kfunk, dfaure Cc: dfaure, #frameworks

D7464: fix: plaintext is highlighted as powershell

tillschafer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY see Bug 383848 REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7464 AFFECTED