D10450: Generate a custom target in kcoreaddons_desktop_to_json

tcberner added a comment. I think as @adridg points out that it should be a target, this should go in -- and the @kossebau already committed the proper workaround in D10485 , right? REPOSITORY R244 KCoreAddons REVISION DETAIL

D10600: Set ANDROID in the Android toolchain file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10600 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

D10578: balooctl monitor: Wait for dbus interface

michaelh added a comment. In D10578#208132 , @alexeymin wrote: > There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style. ... and it refers to Qt. > I've never seen commas at the start of the line. It's part of

D10599: Fix include path for x86 targets

This revision was automatically updated to reflect the committed changes. Closed by commit R240:16844390dab7: Fix include path for x86 targets (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10599?vs=27392=27396 REVISION

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:cbe5085a646e: Mac/IOKit backend: support for drives, discs and volumes (authored by rjvbb). CHANGED PRIOR TO COMMIT

D10603: Make DMTX dependency optional

vkrause created this revision. vkrause added reviewers: Frameworks, svuorela. Restricted Application added a project: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This simplifies deployment on Android, a platform that libdmtx doesn't seem to support out of the box.

D10578: balooctl monitor: Wait for dbus interface

alexeymin added a comment. There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style. Guess I was wrong about `#include`s order, but honestly I've never seen commas at the start of the line. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10578 To:

D10599: Fix include path for x86 targets

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY ANDROID_TOOLCHAIN is "x86" there, while the

D10599: Fix include path for x86 targets

apol added subscribers: dfaure, apol. apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM. @dfaure was looking into this as well earlier this week, he may have feedback. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION

D10578: balooctl monitor: Wait for dbus interface

alexeymin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH wait-for-dbus (branched from master) REVISION DETAIL https://phabricator.kde.org/D10578 To: michaelh, dfaure, alexeymin Cc: alexeymin, #frameworks, ashaposhnikov, michaelh,

D10578: balooctl monitor: Wait for dbus interface

michaelh added inline comments. INLINE COMMENTS > alexeymin wrote in monitorcommand.cpp:45 > Strange formatting of commas in above 3 lines. It looks OK in constructor, > where member initialization may be added later, but here, when the parameter > count is fixed, no need to start new line

D10578: balooctl monitor: Wait for dbus interface

michaelh updated this revision to Diff 27394. michaelh marked an inline comment as done. michaelh added a comment. - balooctl monitor: Fix memory leak - balooctl monitor: Whitespace cleanup REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D10450: Generate a custom target in kcoreaddons_desktop_to_json

rakuco added a comment. Per my previous comment, I still don't see how changing this to a target would solve anything. For one, the CMake implementation allows both files and targets to

D10602: Remove obsolete policy settings

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY Those affect policy propagation and search

D10600: Set ANDROID in the Android toolchain file

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This allows easy platforms checks in CMake

D10578: balooctl monitor: Wait for dbus interface

alexeymin added a comment. Looks almost fine, just fix these: INLINE COMMENTS > monitorcommand.cpp:45 > +, QDBusConnection::sessionBus() > +, this > +); Strange formatting of commas in above 3 lines. It looks OK in constructor, where member initialization may be added

D10599: Fix include path for x86 targets

vkrause added a comment. Interesting, @dfaure, does setting a different ABI/compiler via the command line actually work for you? Here the command-line parameters are not propagated to compiler runs for configure checks, so they run with the defaults from the toolchain file, which fails at

D10601: Extend search path for NDK dependencies

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This allows e.g. KArchive to find zlib

D10600: Set ANDROID in the Android toolchain file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:132b95190a31: Set ANDROID in the Android toolchain file (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10600?vs=27393=27397

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Feb 2018 17:38:18 + Build duration: 3 min 15 sec and counting JUnit Tests Name:

D9675: Don't show context menu menu if right-clicking outside

elvisangelaccio added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks, dfaure Cc: wbauer, michaelh

D9675: Don't show context menu menu if right-clicking outside

elvisangelaccio added a comment. +1 works for me. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks, dfaure Cc: elvisangelaccio, wbauer, michaelh

D10578: balooctl monitor: Wait for dbus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R293:94da1850ec6c: balooctl monitor: Wait for dbus interface (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10578?vs=27416=27417 REVISION DETAIL

D10578: balooctl monitor: Wait for dbus interface

cfeck added inline comments. INLINE COMMENTS > michaelh wrote in monitorcommand.cpp:45 > You're right. I just looked at the example in Qt's coding style rules. In > fact it is operators BOL, commas EOL. > I'm ok with putting the commas at EOL (it's the rule, after all). Since to me > it is

D10578: balooctl monitor: Wait for dbus interface

michaelh marked 11 inline comments as done. REPOSITORY R293 Baloo BRANCH wait-for-dbus (branched from master) REVISION DETAIL https://phabricator.kde.org/D10578 To: michaelh, dfaure, alexeymin Cc: cfeck, alexeymin, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella

D10578: balooctl monitor: Wait for dbus interface

michaelh updated this revision to Diff 27416. michaelh added a comment. - balooctl monitor: Adhere to KDE coding-style REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10578?vs=27394=27416 BRANCH wait-for-dbus (branched from master) REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 33 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/33/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 17:38:18 + Build duration: 5 min 29 sec and counting JUnit Tests Name:

D10340: Clean up old, unreachable code

elvisangelaccio added a reviewer: dfaure. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D10340 To: heikobecker, #frameworks, dfaure Cc: michaelh

D10340: Clean up old, unreachable code

elvisangelaccio added a comment. +1 REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D10340 To: heikobecker, #frameworks, dfaure Cc: elvisangelaccio, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. Yes, I think I agree with @rakuco. Especially since the fix for D10485 ended up being reverted. I still think a separate fix is needed for kcm_lookandfeel, but the issue is that the `kcoreaddons_desktop_to_json` macro generates a

D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R241 KIO BRANCH solve-file-dialog-ambiguous-shortcut-issue (branched from master) REVISION DETAIL https://phabricator.kde.org/D10617 To: ngraham,

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. OK then, I think @kossebau is right in that this is a dependency issue in the `lookandfeel` part of plasma-desktop. The `kcm_lookandfeel` target declares the JSON dependency (with the CMake macro) in time for CMake to care about it and ensure the generated build

D10414: Add move semantics support to KIO::UDSEntry.

bcooksley added a comment. Looks like QT_LSTAT doesn't exist on Windows - see https://git.reviewboard.kde.org/r/127727/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: bcooksley, apol, #frameworks, michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate updated this revision to Diff 27429. jtamate added a comment. I still can trigger the crash without the patch with KF5 5.42 (opensuse) Improved the patch it a little bit, including a QASSERT to know where the double finish originates. REPOSITORY R244 KCoreAddons CHANGES SINCE

D10450: Generate a custom target in kcoreaddons_desktop_to_json

kossebau added a comment. In D10450#208413 , @mpyne wrote: > Yes, I think I agree with @rakuco. Especially since the fix for D10485 ended up being reverted. Would be happy if anyone on KDE neon could

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/137/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Feb 2018 22:19:44 + Build duration: 13 min and counting JUnit Tests Name: (root)

D10450: Generate a custom target in kcoreaddons_desktop_to_json

rakuco added a comment. > This isn't just a problem on KDE Neon though, is it? I thought FreeBSD is also affected? To be clear, FreeBSD is affected by not having any fix in the tree (i.e. the json file not being present when moc is invoked), whereas Neon fails with D10485

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 193 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/193/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 17 Feb 2018 22:19:44 + Build duration: 15 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/135/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 22:19:44 + Build duration: 15 min and counting JUnit Tests Name: (root)

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. Would be nice to get more feedback before choosing a shortcut that affects many applications. I don't think that F12 is a good choice. The F keys are few and some of them are already taken (Help, Rename, Reload, Fullscreen - and yes, it's bad that

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham added a comment. The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there's no "ambiguous shortcut" issue. That said, I'm not wedded to F12 by any stretch of the

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/118/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Feb 2018 22:28:39 + Build duration: 1 hr 25 min and counting JUnit Tests Name:

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. What about this? I can't change the diff since I didn't create the RR, but this seems to cause the required dependency rules to be added and works for me to build plasma-desktop. The only real addition is the `add_dependencies` call. I tried this without the

D10450: Generate a custom target in kcoreaddons_desktop_to_json

bcooksley added a comment. For the record, the FreeBSD builds on the CI system hit this fairly regularly. As shown by https://build.kde.org/view/Plasma/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/136/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 22:35:21 + Build duration: 8 min 14 sec and counting JUnit Tests Name:

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 390527 Like D10558: Also use standard keyboard shortcut for "show/hide hidden

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, markg, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY My patch D10314 was insufficiently tested

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9862 To: jtamate, #frameworks, dfaure Cc: michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9862 To: jtamate, #frameworks, dfaure Cc: michaelh

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Fine by me. I do wonder why it used to be in an if statement though. It would have added a nullptr if the "if (showHidden)" check failed (which would fail when it's a nullptr). REPOSITORY

D10617: Fix "ambiguous shortcut" issue introduced with D10314

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2a80e71b39d: Fix ambiguous shortcut issue introduced with D10314 (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10617?vs=27428=27430 REVISION

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/116/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Feb 2018 21:37:54 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/74/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Thu, 15 Feb 2018 19:06:30 + Build duration: 2 days 3 hr and counting CONSOLE OUTPUT

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

anthonyfieroni added a comment. What is state of this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9829 To: jtamate, #frameworks, anthonyfieroni, dfaure Cc: ngraham, michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10617 To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/134/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 21:37:54 + Build duration: 20 min and counting JUnit Tests Name: (root)

D10450: Generate a custom target in kcoreaddons_desktop_to_json

mpyne added a comment. In D10450#208453 , @kossebau wrote: > So just to make sure we are all on the same page: for what I have understood meanwhile is what is missing but needed here is a dependency rule between > a) the generated JSON file

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/117/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Feb 2018 22:19:44 + Build duration: 8 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 75 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/75/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 22:24:56 + Build duration: 4 min 42 sec and counting JUnit Tests

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

ngraham added a comment. The file dialog uses two different methods of setting shortcuts. Most are set in `kdiroperator.cpp`, but only few are set in `kfilewidget.cpp` I suspect legacy code, and it seems sensible to use the more standard, consistent style whenever possible. REPOSITORY

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/136/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Feb 2018 21:37:54 + Build duration: 11 min and counting JUnit Tests Name: (root)

D10414: Add move semantics support to KIO::UDSEntry.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:d8414425acc5: Add move semantics support to KIO::UDSEntry. (authored by markg). REPOSITORY R241 KIO CHANGES SINCE

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 27431. markg added a comment. Add @since lines where for the move assignment operator and constructor. Typo fix. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=27028=27431 BRANCH udsentry_move REVISION DETAIL

D10414: Add move semantics support to KIO::UDSEntry.

markg marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/138/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Feb 2018 22:33:28 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 194 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/194/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 17 Feb 2018 22:36:29 + Build duration: 9 min 23 sec and counting CONSOLE OUTPUT

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Right, this one is my fault: https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/193/ Weird that QT_LSTAT is no problem on linux without including qplatformdefs.h, on windows it apparently is. I pushed the fix:

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Right, it didn't fix it... https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/195/console Could someone with a windows setup (compiler and kio) compile kio and tell me what is wrong here? REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 195 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/195/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 17 Feb 2018 23:08:20 + Build duration: 8 min 34 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/137/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sat, 17 Feb 2018 23:08:19 + Build duration: 8 min 59 sec and counting JUnit Tests Name:

D10621: Highlighting Indexer: list of suggestions

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Proposes mergers of rules and the replacement of: -

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/139/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Feb 2018 23:08:19 + Build duration: 1 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/119/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Feb 2018 23:54:34 + Build duration: 24 min and counting JUnit Tests Name:

D10621: Highlighting Indexer: list of suggestions

jpoelen added a project: Framework: Syntax Highlighting. jpoelen added a subscriber: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: #framework_syntax_highlighting, dhaumann, #frameworks,