D10251: [RFC] Use mipmap filtering in window thumbnails

broulik added a comment. What's the state of this? Bug 391915 just cropped up REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D11360: provide sample rate in kHz

astippich updated this revision to Diff 29662. astippich added a comment. - use qlatin1string for comparison and do not display trailing zeros REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11360?vs=29621=29662 BRANCH sample_rate REVISION DETAIL

D6313: WIP: Support device pixel ratio in icon loader and engine

broulik added a comment. Not really, I recently wanted to update this patch to include support for Icon Scale definition but ran into a dead-end of having to pass through the scale in 50 places... I think I'll give it a go once more but only special casing SVGs and leaving everything

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 29668. broulik retitled this revision from "WIP: Support device pixel ratio in icon loader and engine" to "Support Icon Scale from Icon naming specification 0.13". broulik edited the summary of this revision. broulik edited the test plan for this revision.

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/74/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Mar 2018 15:16:29 + Build duration: 30 min and counting

D11390: new icons for disconnected/disabled devices

acrouthamel added a comment. They look great! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11390 To: mart, #plasma, #vdg, andreask Cc: acrouthamel, andreask, #frameworks, michaelh, ngraham

D11285: Introduce sanitizer class

michaelh marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin

D11285: Introduce sanitizer class

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9de78becc063: Introduce sanitizer class (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29683=29684 REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. Thanks for working on this again, it really helps. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,

D11392: sanitizer: Move implementation into Baloo namespace

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH namespace REVISION DETAIL https://phabricator.kde.org/D11392 AFFECTED FILES

D11365: also test for value types in taglibextractortest and fix errors

michaelh added a comment. Just in case you didn't use data-driven tests on purpose: https://doc.qt.io/qt-5/qttestlib-tutorial2-example.html REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo Cc: michaelh, #frameworks,

D11285: Introduce sanitizer class

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. +2 for me but I don't know baloo code :) REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh,

D10243: Improve visibility of disconnected Wi-Fi icons

mart added a comment. changes of this are included in D11390 , this should be closed REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas, ngraham Cc: mart,

D11388: Provide androiddeployqt with all prefix paths

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11388 To: vkrause, #build_system, apol Cc: #frameworks, michaelh, ngraham

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:46 > +public: > +FileInfo(const quint32 d = 0, const quint32 i = 0, > +const QString& u = QString(),

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Fri, 16 Mar 2018 14:54:19 + Build duration: 3 min 41 sec and counting JUnit Tests Name:

D11390: new icons for disconnected/disabled devices

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5163e3e9ff69: new icons for disconnected/disabled devices (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11390: new icons for disconnected/disabled devices

mart added a comment. ah, if i push this, it will override D10243 which shouldn't be pushed anymore (it contains all the new darker icons) REPOSITORY R242 Plasma Framework (Library) BRANCH phab/network REVISION DETAIL

D11285: Introduce sanitizer class

michaelh updated this revision to Diff 29683. michaelh added a comment. - Turn FileInfo into a struct again REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29594=29683 BRANCH sanitize-class (branched from master) REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 16 Mar 2018 14:54:19 + Build duration: 5 min 42 sec and counting JUnit Tests Name:

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a dependent revision: D11390: new icons for disconnected/disabled devices. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas, ngraham Cc: abetts, plasma-devel, #frameworks,

D11390: new icons for disconnected/disabled devices

ngraham edited the summary of this revision. ngraham added a dependency: D10243: Improve visibility of disconnected Wi-Fi icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11390 To: mart, #plasma, #vdg Cc: #frameworks, michaelh, ngraham

D11390: new icons for disconnected/disabled devices

mart added a comment. In D11390#227284 , @andreask wrote: > look good to me thanks should i go hunting in breeze icons as well to see if there are some to update to make it look the same? REPOSITORY R242 Plasma Framework (Library)

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham accepted this revision. ngraham added a comment. The icon changes themselves are done in D11390 . Since this patch just touches the opacity, +1 from me. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D11388: Provide androiddeployqt with all prefix paths

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This is needed for a new feature in Qt 5.12,

D11390: new icons for disconnected/disabled devices

andreask accepted this revision. andreask added a comment. This revision is now accepted and ready to land. look good to me thanks REPOSITORY R242 Plasma Framework (Library) BRANCH phab/network REVISION DETAIL https://phabricator.kde.org/D11390 To: mart, #plasma, #vdg, andreask Cc:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/99/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 16 Mar 2018 15:16:29 + Build duration: 3 min 45 sec and counting

D11287: Introduce baloodb CLI tool

michaelh updated this revision to Diff 29694. michaelh added a comment. - Rebase on master - Improve help message REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11287?vs=29525=29694 BRANCH sanitize-cmd (branched from master) REVISION DETAIL

D11392: sanitizer: Move implementation into Baloo namespace

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Only looked at the diff, but nothing suspicious seen. If it builds and works, should be fine :) Perhaps mention in the commit message also that this moving into the namespace

D11392: sanitizer: Move implementation into Baloo namespace

michaelh edited the summary of this revision. REPOSITORY R293 Baloo BRANCH namespace REVISION DETAIL https://phabricator.kde.org/D11392 To: michaelh, #baloo, #frameworks, kossebau Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Fri, 16 Mar 2018 18:43:25 + Build duration: 13 min and counting JUnit Tests Name: (root)

D11392: sanitizer: Move implementation into Baloo namespace

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5e471c3d39b3: sanitizer: Move implementation into Baloo namespace (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11392?vs=29689=29692

D11392: sanitizer: Move implementation into Baloo namespace

michaelh edited the summary of this revision. REPOSITORY R293 Baloo BRANCH namespace REVISION DETAIL https://phabricator.kde.org/D11392 To: michaelh, #baloo, #frameworks, kossebau Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11287: Introduce baloodb CLI tool

michaelh added a comment. Should there be a note in `--help` message like "This is an experimental tool. The command like interface is subject to change."? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks Cc: ngraham,

D11287: Introduce baloodb CLI tool

michaelh edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks Cc: ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 50 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Fri, 16 Mar 2018 18:43:25 + Build duration: 9 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 FreeBSDQt5.9 - Build # 43 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.9/43/ Project: Frameworks baloo kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Mar 2018 20:54:12 + Build duration: 3 min 13 sec and counting JUnit Tests

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. Those all look pretty great to me, honestly. A nice upgrade from the current icons. For the pink column, does it look bad if you raise the projection screen so that it's only a little bit higher than the laptop on the large icons? It seems like there's room to

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. In D10937#227525 , @ngraham wrote: > Those all look pretty great to me, honestly. A nice upgrade from the current icons. > > For the pink column, does it look bad if you raise the projection screen so that it's only

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/100/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 16 Mar 2018 22:27:26 + Build duration: 5 min 40 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/75/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Mar 2018 22:27:26 + Build duration: 4 min 20 sec and counting

D10937: Retouching of Screen Layout Selection OSD Icons

emateli added a comment. Hi, while I do appreciate the icons I also have a question: Why the use of laptop and projector over of two simple generic screens. Wouldn't that be better for all use cases? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To:

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a21bc11fe116: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is… (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. Friendly ping! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: mart, broulik, #frameworks, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. An update: F5756024: thick_or_Thipng.png Green column: I still haven't found a better metaphor. With the slightly rotated window metaphors to its sides I can just leave out the window at smaller sizes, but I can't

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D11244 REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: mart, broulik, #frameworks, michaelh,

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/76/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 17 Mar 2018 04:06:14 + Build duration: 7 min 48 sec and counting

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. In D10937#227537 , @pstefan wrote: > In D10937#227525 , @ngraham wrote: > > > Those all look pretty great to me, honestly. A nice upgrade from the current icons. > > >

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/101/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Mar 2018 04:06:13 + Build duration: 27 min and counting JUnit

D10251: [RFC] Use mipmap filtering in window thumbnails

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11390: new icons for disconnected/disabled devices

mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY there were some icons which conveyed meaning solely by color which

D11390: new icons for disconnected/disabled devices

mart added a comment. F5755807: Spectacle.W12059.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11390 To: mart, #plasma, #vdg Cc: #frameworks, michaelh, ngraham