D11278: [KateCompletionWidget] Create configuration interface on demand

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. See: Git commit 7f3d9e774129618dfb9fd871d5d5c8fbb66b4d9a by Christoph Cullmann. Committed on

D11278: [KateCompletionWidget] Create configuration interface on demand

cullmann added a comment. Perhaps one has not thought about the side-effects of the construction of the KateCompletionConfig. It looks like it does a readConfig and that triggers applyInternal() which in return will configure the m_presentationModel. I will revert this commit for the

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh updated this revision to Diff 29833. michaelh added a comment. - Clean up whitespace REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11238?vs=29276=29833 BRANCH enforce-locale (branched from master) REVISION DETAIL

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/38/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 18 Mar 2018 12:34:50 + Build duration: 11 min and counting JUnit Tests

D11287: Introduce baloodb CLI tool

michaelh added a dependent revision: D11452: sanitizer: Improve device listing. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks Cc: ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin

D11452: sanitizer: Improve device listing

michaelh added a dependency: D11287: Introduce baloodb CLI tool. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11452 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11452: sanitizer: Improve device listing

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Print more info about devices TEST PLAN Example: $ baloodb devices Listing database

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sun, 18 Mar 2018 12:34:50 + Build duration: 14 min and counting JUnit Tests

D11452: sanitizer: Improve device listing

michaelh updated this revision to Diff 29827. michaelh edited the test plan for this revision. michaelh added a comment. - Fix typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11452?vs=29825=29827 BRANCH sanitize-devices (branched from master)

D11360: provide sample rate in kHz

elvisangelaccio removed a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11360 To: astippich, #baloo, elvisangelaccio, #frameworks Cc: elvisangelaccio, ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11360: provide sample rate in kHz

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > widgetfactory.cpp:122-124 > +if (prop == QLatin1String("duration")) { > valueString = form.formatDuration(value.toInt()

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik updated this revision to Diff 29832. fredrik added a comment. Rebase on master. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10251?vs=26374=29832 REVISION DETAIL https://phabricator.kde.org/D10251 AFFECTED FILES

D11278: [KateCompletionWidget] Create configuration interface on demand

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. If we want that, one needs to take care of the config loading/initial setup of the m_presentationModel in a different way than relying on the config widget to do it.

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Sun, 18 Mar 2018 12:34:50 + Build duration: 9 min 21 sec and counting JUnit Tests

D11457: decrease bitrate precision for display

astippich added reviewers: Frameworks, Baloo. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11457 To: astippich, #frameworks, #baloo Cc: ashaposhnikov, astippich, spoorun, nicolasfella, alexeymin

D11461: rename 64 px icons added for elisa

astippich created this revision. astippich added reviewers: Breeze, VDG, andreask. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY see D10492

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. I still don't understand what's the difference between this test and the kio ones, but this fixes the problem so I'd say let's go with it for now.

D11457: decrease bitrate precision for display

This revision was automatically updated to reflect the committed changes. Closed by commit R824:e9f00ca876a2: decrease bitrate precision for display (authored by astippich). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11457?vs=29840=29849 REVISION

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D10251: [RFC] Use mipmap filtering in window thumbnails

progwolff added a comment. Thanks! I tested it with several running applications, including windows with different apect ratios and combined previews for multiple instances of the same application. Looks great in every case. +1 from me! REPOSITORY R242 Plasma Framework (Library)

D11365: also test for value types in taglibextractortest and fix errors

astippich added a comment. In D11365#227241 , @michaelh wrote: > Just in case you didn't use data-driven tests on purpose: https://doc.qt.io/qt-5/qttestlib-tutorial2-example.html Thanks for the hint, that's new for me. Anyways, there are

D11457: decrease bitrate precision for display

elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH bitrate_precision REVISION DETAIL https://phabricator.kde.org/D11457 To: astippich, #frameworks, #baloo, elvisangelaccio Cc: ashaposhnikov,

D11365: also test for value types in taglibextractortest and fix errors

astippich added reviewers: mgallien, michaelh. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11038: balooctl: Add prune option to remove stale file index entries

michaelh added a comment. Sorry I took so long to respond. I needed to get the tools ready to see whats going on (D11285 and D11287 ) . Wrt this patch - You forgot to open the database in ReadWrite mode. - To

D10621: Highlighting Indexer: list of suggestions

jpoelen updated this revision to Diff 29869. jpoelen added a comment. More suggestions and fixes some false positives. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10621?vs=27439=29869 BRANCH suggest REVISION DETAIL

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added a project: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Previously, the variables prefixed by if / case / loop / end are a mix of keywords

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 29866. jpoelen added a comment. File mode restored for autotests/input/highlight.sh and autotests/input/highlight.sh.syntax REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=29865=29866 BRANCH sql

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. There is a bug on which I fell while completing the tests: the output is not stable. Several successive calls to `./bin/kate-syntax-highlighter $PROJ/autotests/input/test.sql` give a different result. `valgrind` returns a lot of "Conditional jump or move

D11038: balooctl: Add clean option to remove stale file index entries

smithjd retitled this revision from "balooctl: Add prune option to remove stale file index entries" to "balooctl: Add clean option to remove stale file index entries". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc:

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29879. smithjd added a comment. Change the 'prune' option to 'clean'. The database must open in ReadWrite mode. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29290=29879 BRANCH master-purgeDb (branched

D11038: balooctl: Add clean option to remove stale file index entries

smithjd added a comment. In D11038#228379 , @michaelh wrote: > Sorry I took so long to respond. I needed to get the tools ready to see whats going on (D11285 and D11287 )

D11080: Make org.kde. components include a donate URL

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:af8721a5ccca: Make org.kde. components include a donate URL (authored by apol). REPOSITORY R290 KPackage CHANGES

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/64/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Mar 2018 02:20:47 + Build duration: 8 min 49 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Mar 2018 01:43:27 + Build duration: 2 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Mar 2018 01:43:27 + Build duration: 1 min 39 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Mar 2018 01:43:27 + Build duration: 2 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Mar 2018 02:20:47 + Build duration: 4 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/47/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Mar 2018 02:20:47 + Build duration: 6 min 51 sec and counting JUnit