KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 48 - Fixed!

2018-05-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:10 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 5 - Fixed!

2018-05-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:15:46 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:08 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 07:16:15 + Build duration: 44 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:16:40 + Build duration: 50 min and counting

D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12865: transferjob new connect syntax

2018-05-14 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use the new connect syntax. A new

D12867: Fix minor documentation typos

2018-05-14 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks. Please use the GIT_SILENT keyword for typo fixes. REPOSITORY R240 Extra CMake Modules BRANCH doc_typos (branched from master) REVISION DETAIL

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:15:23 + Build duration: 19 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:14:40 + Build duration: 18 min and counting JUnit Tests Name:

D12848: Set fix steps for icon sizes

2018-05-14 Thread Henrik Fehlauer
rkflx added a comment. In D12848#262008 , @broulik wrote: > I would vote for removing the buttons We already discussed this and decided to keep the buttons. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To:

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:16:15 + Build duration: 43 min and counting JUnit

D12787: Ignore more types of source files

2018-05-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > fileexcludefilters.cpp:69 > +"*.css.map," > +"*.so", > +"*.db", Don't we ignore blobs already? If not, we should also add stuff like `qmlc` and `jsc` > fileexcludefilters.cpp:77 > "*.elc", // Emacs Lisp > +"*.qrc", //

D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, alexmerry, kossebau. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. maximilianocuria requested review of this

D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria added a comment. Please let me know if it's okay to land this kind of changes directly. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau Cc: kde-frameworks-devel,

D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:15:46 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 158 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/158/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:41 + Build duration: 31 min and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 07:16:08 + Build duration: 46 min and counting JUnit Tests Name:

D12867: Fix minor documentation typos

2018-05-14 Thread Maximiliano Curia
maximilianocuria added a comment. Thanks. Sadly the commit went without the GIT_SILENT, sorry about that. I did: arc amend git commit -amend # to add the GIT_SILENT arc land I guess that the arc land called another arc amend. REPOSITORY R240 Extra CMake Modules REVISION

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 110 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/110/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 07:14:40 + Build duration: 38 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 07:16:18 + Build duration: 48 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 07:16:48 + Build duration: 49 min and counting JUnit Tests Name:

D12848: Set fix steps for icon sizes

2018-05-14 Thread Kai Uwe Broulik
broulik added a comment. > if we keep the buttons, having predefined sizes in the slider is not needed anymore… I would vote for removing the buttons, you can also click the slider left or right of its handle to move it one step at a time. However, since it's in the toolbar and not

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:15:45 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:48 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10 - Build # 5 - Fixed!

2018-05-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:15:59 + Build duration: 27 min and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:16:08 + Build duration: 40 min and counting JUnit Tests

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:15 + Build duration: 21 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 07:15:35 + Build duration: 21 min and counting JUnit Tests Name:

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:16:18 + Build duration: 21 min and counting JUnit Tests Name:

D12689: Lua: updated for Lua5.3

2018-05-14 Thread Dominik Haumann
dhaumann added a subscriber: vkrause. dhaumann added a comment. @jpoelen And why is it a problem with Kate? This means the C++ implementation of the highlighting rules is different in KSyntaxHighlighting and KTextEditor? If so, this would be an important catch. Can you elaborate why this is

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 261 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/261/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 07:14:40 + Build duration: 39 min and counting JUnit Tests Name: (root)

D12872: ScalableTest, add "scalable" plasma-browser-integration

2018-05-14 Thread Maximiliano Curia
maximilianocuria edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12872: ScalableTest, add "scalable" plasma-browser-integration

2018-05-14 Thread Maximiliano Curia
maximilianocuria created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY With the introduction of the plasma-browser-integration icon (Add

D12820: Add KWayland virtual desktop protocol

2018-05-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > bshah wrote in registry.h:154 > This should be added at end and not in middle and also add `@since 5.47(?)` you're right this breaks ABI REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma,

D12872: ScalableTest, add "scalable" plasma-browser-integration

2018-05-14 Thread Maximiliano Curia
maximilianocuria added reviewers: Frameworks, dfaure, andreaska, andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34141. ngraham added a comment. Add more blobs REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=33920=34141 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham, michaelh, bruns Cc: broulik, cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in fileexcludefilters.cpp:69 > Don't we ignore blobs already? If not, we should also add stuff like `qmlc` > and `jsc` As far as I can tell, we do not, and they have to be manually listed.

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34143. ngraham added a comment. More buildy files REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34141=34143 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked an inline comment as done. ngraham added a comment. How do people feel about adding `*.ini` to the exclusions list? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham, michaelh, bruns Cc: broulik, cfeck, kde-frameworks-devel, #baloo,

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34146. ngraham added a comment. Add some more REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34145=34146 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

2018-05-14 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > ngraham wrote in fileexcludefilters.cpp:154 > My impression is that Baloo is really intended for user files; SVGs only get > their content indexed by accident, because they happen to be textual. I don't > think there's any textual content inside

D12734: Scale up folder icon before creating preview overlays

2018-05-14 Thread Peter Mühlenpfordt
muhlenpfordt added a comment. In D12734#259515 , @rkflx wrote: > Nevertheless, let's check the impact of this again: https://lxr.kde.org/ident?_i=thumbForDirectory > Does not look too critical to me, and we probably tested most of the code

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34151. ngraham added a comment. Revert change to omit SVG files REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34146=34151 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

2018-05-14 Thread Stefan Brüns
bruns added a comment. Does anyone know if there are any artifacts generated by the meson build system? INLINE COMMENTS > fileexcludefilters.cpp:74 > > // Compiled files > "*.class", // Java Probably `Bytecode` - we have `.o` above, which is also compiled >

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34145. ngraham added a comment. Fix misinterpretation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34143=34145 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D12787: Ignore more types of source files

2018-05-14 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > fileexcludefilters.cpp:154 > +"image/svg+xml", > +"image/svg+xml-compressed", > "application/x-awk", Hm, not to sure about this one - SVG typically has RDF metadata, and also everything in `` tags qualifies as "content". Do we have a

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham, michaelh, bruns Cc: broulik, cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12787: Ignore more types of source files

2018-05-14 Thread Stefan Brüns
bruns added a comment. If you want to read more about text in SVG: http://tavmjong.free.fr/blog/ To show a generalized XML extractor is sufficient for SVG: - Path data: `` - Single Line: `Single line` - Multiline: `This is some multiline Text` Non-text tags are empty

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked 5 inline comments as done. ngraham added inline comments. INLINE COMMENTS > bruns wrote in fileexcludefilters.cpp:82 > Thats not what I meant (I am not aware of anything generating a `Bytecode` > file literally). > I meant changing the `// Compiled files` comment to `// Bytecode

D12787: Ignore more types of source files

2018-05-14 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > fileexcludefilters.cpp:82 > +"*.jsc", // Javascript > +"Bytecode", > Thats not what I meant (I am not aware of anything generating a `Bytecode` file literally). I meant changing the `// Compiled files` comment to `// Bytecode files`,

D12876: [Dialog] Handle dialog being minimized gracefully

2018-05-14 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > dialog.cpp:1371 > +// Bug 381242: Qt remembers minimize state and re-applies it when > showing > +setWindowStates(windowStates() & ~Qt::WindowMinimized); > +#endif We don't know the previous state of the window with `windowState`

D12877: GIT_SILENT fix minor typo in the license name

2018-05-14 Thread Maximiliano Curia
maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, bshah. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REPOSITORY R237 KConfig BRANCH

D12848: Set fix steps for icon sizes

2018-05-14 Thread Nathaniel Graham
ngraham added a comment. IMHO what we really need is a standard size slider widget so that each app doesn't need to reinvent the wheel. Right now Gwenview, Dolphin, and the file dialogs each implement their own, and they're all subtly (or very) different from each other. That said, I

D12876: [Dialog] Handle dialog being minimized gracefully

2018-05-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Dialogs don't show up in task bar and also don't have

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > bruns wrote in fileexcludefilters.cpp:154 > Hm, not to sure about this one - SVG typically has RDF metadata, and also > everything in `` tags qualifies as "content". > Do we have a generalized XML extractor? My impression is that Baloo is really

D12820: Add KWayland virtual desktop protocol

2018-05-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > romangg wrote in org_kde_plasma_virtual_desktop.xml:45 > This event is redundant with the current implementation. A client can infer > the number of rows and columns from the org_kde_plasma_virtual_desktop > objects it receives and their maximum

D12820: Add KWayland virtual desktop protocol

2018-05-14 Thread Bhushan Shah
bshah added inline comments. INLINE COMMENTS > registry.h:154 > PlasmaShell, ///< Refers to org_kde_plasma_shell interface > +PlasmaVirtualDesktopManagement, ///< Refers to > org_kde_plasma_virtual_desktop_management interface > PlasmaWindowManagement, ///< Refers to

D12820: Add KWayland virtual desktop protocol

2018-05-14 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > isn't better the layout to be communicated by the manager? the reasoning was > to have it loosely map on models. > the model tells how many rows it has, then the single item on what row it is

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12787 To: ngraham, michaelh, bruns Cc: broulik, cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D12787: Ignore more types of source files

2018-05-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 34155. ngraham added a comment. Omit all .map files, and also .ini files REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34151=34155 BRANCH more-excluded-source-files (branched from master) REVISION DETAIL

D11891: Fix crashes in NotifyByAudio when closing applications

2018-05-14 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R289:59bfcffc43d2: Fix crashes in NotifyByAudio when closing applications (authored by aacid). Restricted Application

Re: kfilemetadata compile failure

2018-05-14 Thread Albert Astals Cid
El diumenge, 13 de maig de 2018, a les 23:15:56 CEST, Matthieu Gallien va escriure: > On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote: > > El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va > > > > escriure: > > > On Thu, Apr 26, 2018 at 08:31:46AM +0200,

Re: kfilemetadata compile failure

2018-05-14 Thread Albert Astals Cid
El dilluns, 14 de maig de 2018, a les 22:33:12 CEST, Matthieu Gallien va escriure: > I was meaning to have a fix on top of v5.46.0 that may be released as a > v5.46.1 if needed. Ah, that's up to David if he thinks it makes sense to have such a release or not. Worst case scenario you can always

Re: kfilemetadata compile failure

2018-05-14 Thread Matthieu Gallien
On lundi 14 mai 2018 19:57:58 CEST Albert Astals Cid wrote: > El diumenge, 13 de maig de 2018, a les 23:15:56 CEST, Matthieu Gallien va > > escriure: > > On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote: > > > El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell >

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 May 2018 23:16:16 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

2018-05-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 14 May 2018 23:16:16 + Build duration: 1 min 38 sec and counting JUnit Tests

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

2018-05-14 Thread Matthieu Gallien
mgallien created this revision. mgallien added reviewers: dfaure, michaelh, jriddell. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY check that ffmpeg