D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:12-13 > Please consider using json metadata and installing the plugin into the > `kf5/kfileitemaction` namespace. Sorry, I don't quite understand what I am supposed to do REPOSITORY R495 Purpose

D13590: Use QUrl < instead of QString.compare

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13590 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13535: Do not cancel old clipboard selection if it is same as the new one.

fvogt updated this revision to Diff 36286. fvogt added a comment. - Add unittest. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13535?vs=36154=36286 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 AFFECTED FILES

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:12-13 > Sorry, I don't quite understand what I am supposed to do I recommend to use the `kcoreaddons_add_plugin` cmake macro. Something like this: kcoreaddons_add_plugin(purposefileitemaction

D13571: Correct KFormat::formatBytes examples

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > apol wrote in kformat.h:184 > What's "resp."? respectively REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13571 To: bruns, #frameworks Cc: apol, kde-frameworks-devel,

D13571: Correct KFormat::formatBytes examples

apol added a comment. Then explain why it works? Actually the former behaviour is what I'd expect. INLINE COMMENTS > kformat.h:184 > + *1 by default so when in doubt use 1. Integral values less than > 1000 > + *resp. 1024 always omit the fractional part. > *

D13571: Correct KFormat::formatBytes examples

bruns marked an inline comment as done. bruns added a comment. In D13571#279453 , @apol wrote: > Then explain why it works? Actually the former behaviour is what I'd expect. The given example is just plain wrong. It does not work, it is

D13590: Use QUrl < instead of QString.compare

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Well then you can just remove lessThan altogether, and call std::sort with only 2 arguments instead of 3 ;) REPOSITORY R241 KIO REVISION DETAIL

D13590: Use QUrl < instead of QString.compare

jtamate updated this revision to Diff 36283. jtamate edited the summary of this revision. jtamate added a comment. You're right :-) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36279=36283 REVISION DETAIL https://phabricator.kde.org/D13590

D13571: Correct KFormat::formatBytes examples

bruns added a comment. In D13571#279550 , @apol wrote: > > The given example is just plain wrong. It does not work, it is just some false prosa. > > Fair enough, yet the API user may want to be able to understand what's the logic behind it,

D13571: Correct KFormat::formatBytes examples

bruns added inline comments. INLINE COMMENTS > kformattest.cpp:37 > QCOMPARE(format.formatByteSize(0), QStringLiteral("0 B")); > QCOMPARE(format.formatByteSize(50), QStringLiteral("50 B")); > QCOMPARE(format.formatByteSize(500), QStringLiteral("500 B")); See here for handling of

D13590: Use QUrl < instead of QString.compare

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use the available Qurl < operator (since

D13571: Correct KFormat::formatBytes examples

apol added a comment. > The given example is just plain wrong. It does not work, it is just some false prosa. Fair enough, yet the API user may want to be able to understand what's the logic behind it, so if it can be explained on the documentation that could be useful. INLINE

D13394: C++: update for c++20 and fix some syntax errors

jpoelen added inline comments. INLINE COMMENTS > dhaumann wrote in gcc.xml:576-577 > These can be WordDetect as well, right? It does not work because of ':'. But Putting it in `weakDeliminator` will break things. For this to work, it would need `additionalDeliminator` and `weakDeliminator`

D13216: Overhaul the file index scheduler.

bruns added a comment. This still contains two unrelated changes. Can you please submit each one individually? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13403: Android: Make it possible to override a target's APK directory

apol added a comment. Ping REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13403 To: apol, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

bruns added a comment. Two independent changes. Please provide a more useful commit message (for each one). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh,

D13425: Quit the file indexer when closing.

bruns added a comment. Please provide a more specific commit message, i.e. what is "closing" The commit message should be understandable *without* reading the code change. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc:

D13482: Implement support for the Voice and Call interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D13554: [Properties dialog] Make all field values on general tab selectable

ngraham added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13597: Use a correct emblem icon for readonly files and folders

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 360980 FIXED-IN: 5.48 TEST PLAN

D13552: [Properties dialog] Improve some permissions-related strings

ngraham added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns