KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 17 Jul 2018 12:41:02 + Build duration: 6 min 22 sec and counting

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. @dfaure great.. thanks INLINE COMMENTS > anthonyfieroni wrote in kmainwindow_unittest.cpp:267 > mw->setAttribute(Qt::WA_DeleteOnClose); > Then post event close or deleteLater should work KMainWindowPrivate::init() which is called from constructor already does

D14183: Fix selection and seat auto tests

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fixAutotests REVISION DETAIL https://phabricator.kde.org/D14183 To: romangg, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14184: Reduce unnecessary long wait times on failing signal spies

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Several signal spies, which were supposed to fail,

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in pluginloader.cpp:195 > Seems the wrong approach we know the ID, there's no point iterating in the > first place. > >

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/36/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 17 Jul 2018 13:53:40 + Build duration: 2 min 58 sec and counting

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0351ea74b24e: [Containment] Dont load containment actions with plasma/containment_actions… (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14009: [Plasma PluginLoader] Cache plugins during startup

davidedmundson added inline comments. INLINE COMMENTS > pluginloader.cpp:195 > // COMPAT CODE for applets installed into the toplevel plugins dir > by mistake. > -plugins = KPluginLoader::findPlugins(QString(), filter); > } Seems the wrong approach we know the ID, there's

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Events from the window system seem to be handled after normal events. http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70 Is there a way to send the event so qt processes it as window system event? Have

D14009: [Plasma PluginLoader] Cache plugins during startup

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14009 To: broulik, #plasma, davidedmundson, mart Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14187: Fix variable definition check

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY We'd check if the variable's

D12820: Add KWayland virtual desktop protocol

hein added a comment. I have a problem: When I restart plasmashell, I don't get any desktops again. I think the code may not be re-sending the data when the client goes away and comes a second time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart,

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 updated this revision to Diff 37950. maxrd2 added a comment. Rebased to master REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=37211=37950 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/57/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 17 Jul 2018 16:10:02 + Build duration: 2 min 5 sec and counting JUnit Tests Name:

D14052: Add bluetooth plugin

apol added a comment. Yes, I can reproduce too. `qmlplugindump-qt5 org.kde.bluezqt 1.0` returns 2 for some reason. Will have to investigate. Land this for now if you want. REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052 To:

D14052: Add bluetooth plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37583=37969 REVISION DETAIL

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37971. romangg added a comment. - Add hint getter - Add since keyword REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37938=37971 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175

D14175: Support cursor hints on locked pointer

romangg marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. I'd say make the casing consistent, otherwise it's a clear improvement in my opinion. INLINE COMMENTS > containment.cpp:127 > if (closeApplet) { > -

D14194: Fix the configure check for _nl_msg_cat_cntr

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We need to pass -Wl,--no-undefined to the linker for this to fail when the symbol

D14193: Don't generate files in the source directory

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14193 AFFECTED

D14118: Improve "Remove this [widget]" text

ngraham added a comment. Ping? Is the proposed wording good enough, or should we maybe instead just remove the word "this" and make it use "Remove ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham, #plasma, #vdg Cc:

D14187: Fix variable definition check

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14187 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14193: Don't generate files in the source directory

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14193 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14187: Fix variable definition check

This revision was automatically updated to reflect the committed changes. Closed by commit R240:17158129a853: Fix variable definition check (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14187?vs=37958=37987 REVISION DETAIL

D14194: Fix the configure check for _nl_msg_cat_cntr

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! Had to workaround this earlier today. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14194 To: vkrause, apol Cc: apol, kde-frameworks-devel,

D13926: Avoid warnings for PolkitQt5-1 headers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:9fe09a1dff85: Avoid warnings for PolkitQt5-1 headers (authored by kossebau). REPOSITORY R283 KAuth CHANGES SINCE

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 81 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/81/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 18 Jul 2018 03:32:43 + Build duration: 2 min 36 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 58 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/58/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 18 Jul 2018 03:32:43 + Build duration: 9 min 51 sec and counting JUnit Tests Name:

D14160: [KMessageBox] Call style for icon

rkflx added a comment. > Dialog icons are correct on Linux with Breeze …if you also apply D14161 . Otherwise LGTM. > This needs testing on Windows and Mac You could add or ping more reviewers who happen to have a dev setup on those

D14161: [KStyle] Use dialog-question for question icon

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks for noticing, LGTM and restores the proper icon indeed. > This was changed in `KMessageBox` in 9b05a12a43dbe2b31a4655052f20de0832ac7a61

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 326 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/326/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 18 Jul 2018 03:32:29 + Build duration: 7 min 30 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/83/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 18 Jul 2018 03:32:29 + Build duration: 6 min 33 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 173 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/173/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 18 Jul 2018 03:32:29 + Build duration: 6 min 55 sec and counting JUnit Tests Name:

D13488: Make XDGShellV5 co-compilable with XDGWMBase

davidedmundson added a comment. It was an exported symbol, but the relevant header was never exposed REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma, romangg Cc: rikmills, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37938. romangg added a comment. - Add autotest REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37917=37938 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED FILES

D13808: Fix KMainWindow saving incorrect widget settings

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I just pushed the fix https://commits.kde.org/kxmlgui/d35a88289513c0420863b80aa6c1cb7d2c6e978f Please continue working on the unittest here ;) REPOSITORY R263 KXmlGui

D13488: Make XDGShellV5 co-compilable with XDGWMBase

rikmills added a comment. In libkf5waylandclient5 and libkf5waylandserver5 I see the previously emitted symbol xdg_shell_interface@Base is now reported as MISSING. Can you confirm this is private and/or not an ABI break? Build symbols output: https://paste.kde.org/pfpkps1mb#line-109

D13808: Fix KMainWindow saving incorrect widget settings

anthonyfieroni added inline comments. INLINE COMMENTS > maxrd2 wrote in kmainwindow_unittest.cpp:267 > Retried with all of these... none of them causes the failure, only closing > the window manually cause it > > QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window > manager

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. No problem @siddharthasahu. For the issue you're having with bindings i'd suggest raising a separate thread about that on kde-frameworks-devel as others might have missed it buried in this review. REPOSITORY R244 KCoreAddons REVISION DETAIL

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Tue, 17 Jul 2018 07:46:38 + Build duration: 2 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Tue, 17 Jul 2018 07:46:38 + Build duration: 2 min 18 sec and counting JUnit Tests

D14175: Support cursor hints on locked pointer

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in pointerconstraints_interface.h:126 > do we not want a getter method? > > One of kwayland's main roles is to be a property cache The hint is used by the compositor after unlock again. This unlock can also happen on

D14183: Fix selection and seat auto tests

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The selection test is broken since 5e195c2a67ce

D14183: Fix selection and seat auto tests

romangg edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14183 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14184: Reduce unnecessary long wait times on failing signal spies

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH autotestsWaits REVISION DETAIL https://phabricator.kde.org/D14184 To: romangg, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 186 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/186/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 17 Jul 2018 13:53:40 + Build duration: 5 min 44 sec and counting

D14137: CSS: update syntax and fix some errors

dhaumann added a comment. Thanks for pushing. Could you have a quick look at https://build.kde.org and search for "syntax-highlighting"? It seems the unit tests do not pass since this change, probably a minor issue:

D14175: Support cursor hints on locked pointer

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_pointer_constraints.cpp:258 > +QVERIFY(hintChangedSpy.wait()); > + > // and unlock again We should check the value of