D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. This shows up in the unit tests. Whether it has any effect in real life is unknown. FreeBSD often -- sometimes, maybe, depending on FS setup and layout -- has /home -> /usr/home or /home -> usr/home, and of course there could be weird user setups as well where .cache

D14952: Fix includedDefinitions, handle definition change in context switch

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns,

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

dakon added inline comments. INLINE COMMENTS > CMakeLists.txt:14 > + check_function_exists(statx HAVE_STATX) > + set(HAVE_STATX ${HAVE_STATX}) > endif() This line looks needless. > file.cpp:86 > +#include > +// 332 on my system > +#define STAT(path, buf) >

D14952: Fix includedDefinitions, handle definition change in context switch

cullmann added a comment. If we want a nice order, we should sort them at the end like the repo does. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas,

D14952: Fix includedDefinitions, handle definition change in context switch

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9cfb8fa9a684: Fix includedDefinitions, handle definition change in context switch… (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14952: Fix includedDefinitions, handle definition change in context switch

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. cullmann added projects: Framework: Syntax Highlighting, Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION

D14955: Move example from techbase to own repo

ochurlaud added reviewers: Frameworks, valir. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann created this revision. cullmann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Format() is used as invalid return value in some places. At

D14952: Fix includedDefinitions, handle definition change in context switch

cullmann added a comment. kate *.* in the autotests/input folder works now without any crash, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas,

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8606d4d97f3e: [recentdocuments:/] Filter out files that cant be browsed with a file manager (authored by ngraham).

D14952: Fix includedDefinitions, handle definition change in context switch

dhaumann added a comment. Looks ok to me. Only thing is: with takeLast() you now changed the order of the IncludedDefinitions compared to the previous version. This is of course ok, but in the color config dialog the order is now different than before. Whatever this means... I liked that

D14955: Move example from techbase to own repo

ochurlaud created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ochurlaud requested review of this revision. REVISION SUMMARY Add example based on https://techbase.kde.org/Development/Tutorials/KWallet so that it can be kept up-to-date. The

D14952: Fix includedDefinitions, handle definition change in context switch

ngraham edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14952 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars,

D14955: Move example from techbase to own repo

elvisangelaccio added a comment. +1 Do we need a license for the example source files? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

dhaumann added a comment. Btw, would it also work to point to an internal static d-pointer to avoid all the d-pointer checking? The current patch is likely fine, but it feels a bit messy... But I'd agree to this if other solutions are not feasible. REPOSITORY R216 Syntax Highlighting

D14957: Create a first example of the use of KMessageBox

ochurlaud created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ochurlaud requested review of this revision. REVISION SUMMARY Based on https://techbase.kde.org/Development/Tutorials/First_program TEST PLAN It compiles REPOSITORY R236

D14237: Make Konqi look good in HiDPI

ngraham added a reviewer: bruns. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg, bruns Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14955: Move example from techbase to own repo

dfaure added a comment. (or maybe the wiki was explicit about what the license was?) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.cpp:33 > +// Define a button > +KGuiItem yesButton( QStringLiteral("Hello"), // the button label > +QStringLiteral("view-filter"),

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40099. ngraham added a comment. Simplify, simplify REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40083=40099 BRANCH hidpi-konqi (branched from master) REVISION DETAIL https://phabricator.kde.org/D14237

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40104. ngraham added a comment. Un-simplify; the previous version was better REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40101=40104 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. But I can call all accessors on some default constructed Format() if that increases the confidence, if this patch is at all wanted. It saves heap allocations but adds some branches. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40083. ngraham added a comment. Rebase on current master REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40081=40083 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. Just for the implementation: Is the static default than just a e.g. function static QExplicitlySharedDataPointer(new FormatPrivate()) like: QExplicitlySharedDataPointer () { static QExplicitlySharedDataPointer default(new FormatPrivate()); return

D14957: Create a first example of the use of KMessageBox

ochurlaud updated this revision to Diff 40092. ochurlaud added a comment. Added licences and add some changes to fit what was done on D14955 REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14957?vs=40082=40092

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40080. ngraham added a comment. Use @bruns' awesome SVG REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=38367=40080 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14237: Make Konqi look good in HiDPI

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14955: Move example from techbase to own repo

ochurlaud added a comment. In D14955#312279 , @aacid wrote: > -1 > > The example is not getting compiled it will rot I'm not sure to understand: it *can* be compiled, whereas on the current status (in the wiki) it will never be !

D14927: KConfig: handle directory symlinks correctly.

adridg added a comment. Without patch, all tests Totals: 44 passed, 2 failed, 0 skipped, 0 blacklisted, 225ms The two failed tests are: - testThreads - testDelete With patch, all tests = Totals: 45 passed, 1 failed, 0

D14723: Add option to disable KWallet entirely in the new wallet dialog

fvogt added inline comments. INLINE COMMENTS > aacid wrote in knewwalletdialog.h:67 > do we really need to rename this? It's not just a rename - it's doing the opposite now as there are three instead of two actions. If you follow which slot this ends up, it's responsible for switching between

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

vkrause added a comment. A shared static null object should work with QExplicitlySharedDataPointer as with any other d pointer type: just copy the null object into d in the default ctor. Trades the conditions per call for an atomic increment/decrement per instance. REPOSITORY R216 Syntax

D14955: Move example from techbase to own repo

aacid added a comment. In D14955#312287 , @ochurlaud wrote: > In D14955#312279 , @aacid wrote: > > > -1 > > > > The example is not getting compiled it will rot > > > I'm not sure to

D14723: Add option to disable KWallet entirely in the new wallet dialog

dfaure added a comment. The patch looks OK to me, but yeah, it should be emphasized that disabling KWallet *reduces* security greatly. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14723 To: fvogt, #frameworks Cc: aacid, dfaure, kde-frameworks-devel, ngraham,

D14955: Move example from techbase to own repo

ochurlaud updated this revision to Diff 40090. ochurlaud added a comment. Added Licence, made it compile within the whole project and fix issues raised by dfaure. I think we shouldn't care about making the example self-standing. It's aimed at tutoring people to use the lib, not ECM nor

D14955: Move example from techbase to own repo

ochurlaud marked 4 inline comments as done. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. I am a QExplicitlySharedDataPointer noob ;=) Perhaps Volker can tell about that ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,

D13227: update mailto kioslave docbook

This revision was automatically updated to reflect the committed changes. Closed by commit R241:84436b0d4874: update mailto kioslave docbook (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13227?vs=35228=40086#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D14955: Move example from techbase to own repo

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham,

D14955: Move example from techbase to own repo

dfaure added a comment. +1, OK, this works for me. Simpler indeed. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir, dfaure Cc: dfaure, aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

ochurlaud added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14957 To: ochurlaud, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KF5Syndication

On samedi 18 août 2018 15:38:48 CEST Volker Krause wrote: > On Wednesday, 22 April 2015 21:44:05 CEST Daniel Vrátil wrote: > > Hi all, > > > > I'd like to ask for review of another Framework from kdepimlibs: > > KF5Syndication > > > > KF5Syndication is an RSS/Atom parsing library. It also

D14957: Create a first example of the use of KMessageBox

ochurlaud marked an inline comment as done. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14957 To: ochurlaud, #frameworks, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14957: Create a first example of the use of KMessageBox

ochurlaud updated this revision to Diff 40094. ochurlaud added a comment. Fix as dfaure said REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14957?vs=40092=40094 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14957 AFFECTED FILES

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40101. ngraham added a comment. Simplify even more (maybe this is too much simplification though?) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40099=40101 BRANCH hidpi-konqi (branched from master)

D14723: Add option to disable KWallet entirely in the new wallet dialog

fvogt updated this revision to Diff 40079. fvogt added a comment. Quit kwalletd if option was selected. The .sync is necessary because the change is made in a KSharedConfig but read by the simple KConfig in reconfigure. I guess it should use KSharedConfig everywhere and just call

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

dhaumann added a comment. Unit test missing ... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40081. ngraham added a comment. ...Actually add the SVG image :) REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40080=40081 BRANCH hidpi-konqi (branched from master) REVISION DETAIL

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

vkrause added a comment. I have no strong preference for either of those approaches, but I do agree with this optimization of course :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-devel,

D14955: Move example from techbase to own repo

aacid added a comment. -1 The example is not getting compiled it will rot REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14955 To: ochurlaud, #frameworks, valir Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

[Tutorials] Proposition of tutorial organization

Dear framework maintainers, Hidden somewhere on techbase.kde.org, one can find this: https://techbase.kde.org/Development/Tutorials Not everything is up-to-date nor at the right level. It's often too complex, not showing fully that Framework libs can be used alone (currently it seems that if

D14955: Move example from techbase to own repo

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. And yes this needs a license, obviously. If the original author(s) can't be reached anymore, that means rewriting the example :( INLINE COMMENTS > CMakeLists.txt:3 > + >

D14955: Move example from techbase to own repo

This revision was automatically updated to reflect the committed changes. Closed by commit R311:87a84ac866c5: Move example from techbase to own repo (authored by ochurlaud). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14955?vs=40090=40093 REVISION DETAIL

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. There is no test missing, these code paths are anyways already tested. ;=) Otherwise I would not have found all segfaults. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14956 To: cullmann, vkrause Cc: dhaumann, kwrite-devel,

D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

cullmann added a comment. If that is more elegant, I would be happy with this a solution, too. The Format() allocations just showed up as a few MBs during heaptrack profiling of KWrite (just loading one large file and rehighlighting it). REPOSITORY R216 Syntax Highlighting REVISION

D14955: Move example from techbase to own repo

dfaure added a comment. Yes this needs to be compiled so it doesn't rot. The solution is obviously not add_subdirectory since that wouldn't catch missing find_packages etc. One way is to have cmake run cmake, like ki18n/autotests/CMakeLists.txt does to run cmake on the ki18n_install

D14957: Create a first example of the use of KMessageBox

This revision was automatically updated to reflect the committed changes. Closed by commit R236:6748d24d5fb2: Create a first example of the use of KMessageBox (authored by ochurlaud). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14957?vs=40094=40095

D14940: kformattest: Use plural suffix (s) consequently

habacker created this revision. habacker added a reviewer: aacid. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Mixing plural '(s)' and translated 's' suffix could not be correct. REPOSITORY

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. Thanks for this pointer - with this setting the german translation is not fetched anymore. But there is still the question open how to deal with plurals with and without installed kcoreaddons language package. I guess running tests without kcoreaddons-lang

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY On Wayland, DialogShadows doesn't attach empty tiles for disabled borders. Yet, it sets offset of 1 for them. This results

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

dfaure added a comment. Use qputenv instead of setenv. Example: kio/autotests/kdirmodeltest.cpp:qputenv("LC_ALL", "en_US.UTF-8"); REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14779 To: habacker, #frameworks Cc: dfaure, aacid, kde-frameworks-devel,

D14940: kformattest: Use plural suffix (s) consequently

habacker updated this revision to Diff 40038. habacker added a comment. - type fix in KFormatTest::formatDecimalDuration - missing plural fix in KFormatPrivate::formatDecimalDuration REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14940?vs=40027=40038

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. In D14779#311511 , @aacid wrote: > Can you please replace your setLocale call in initTestCase for > > void initLocale() > { > setenv("LC_ALL", "en_US.utf-8", 1); Just to inform you: this will not

D14724: autotests: don't fail if an unrelated window shows up.

dfaure added reviewers: broulik, davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a subscriber: gladhorn. ngraham added a comment. In D10937#311297 , @bruns wrote: > I think this works better if you actually rotate the screen: > F6203935: rotate2.png In KScreen,

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham added a comment. In D14893#311411 , @markg wrote: > It "looks" oke to me, but i don't know this code one bit. Give it a try, it's pretty easy to test with the test plan. REPOSITORY R320 KIO Extras REVISION DETAIL

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: markg

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham updated this revision to Diff 40054. ngraham added a comment. Move comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14893?vs=39892=40054 BRANCH arcpatch-D14893 REVISION DETAIL https://phabricator.kde.org/D14893 AFFECTED FILES

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

elvisangelaccio added a comment. +1, lgtm REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: elvisangelaccio, markg