D13700: implement reading of the replaygain tags

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH replaygain REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun

D13700: implement reading of the replaygain tags

mgallien added a comment. Thanks for your hard work. This is a really nice addition to audio tags. I no longer have objections. Please finish to take into account feedback from @bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgal

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm really not convinced about this. What about all the cases where you do want to see the redirection happen? - Redirection from http to https - Redirection from some outda

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. OK after reading the bug report, I think this is more about "KRun as used by kde-open5 vs KRun as used by other apps such as konqueror". We want e.g. konqueror to follow the redirection. On the other hand we don't want kde-open5 to follow the redirection. Then what w

Re: ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

On vendredi 31 août 2018 10:50:53 CEST Ben Cooksley wrote: > On Tue, Aug 28, 2018 at 10:35 PM Ben Cooksley wrote: > > Hi all, > > Hi all, > > > We currently have a severe bug in ECM's AddTest macro due to it's > > behaviour around the setting of QT_PLUGIN_PATH. On Windows it would > > appear tha

D13034: Add mechanism to notify other clients of config changes over DBus

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigtest.cpp:1793 > +#if !KCONFIG_USE_DBUS > +QEXPECT_FAIL("", "KConfig notification requires DBus", > QTest::Continue) > +Q_ASSERT(false);

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/16/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Sat, 08 Sep 2018 09:08:51 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/14/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 Date of build: Sat, 08 Sep 2018 09:09:52 + Build duration: 1 min 26 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/109/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 09:05:34 + Build duration: 17 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/63/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 09:06:05 + Build duration: 18 min and counting JUnit Tests

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added reviewers: kossebau, habacker. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D15251 To: heikobecker, kossebau, habacker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/83/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 09:10:04 + Build duration: 32 min and counting JUnit Tests Name: (

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 09:10:16 + Build duration: 33 min and counting JUnit Tests

D6513: Add support for Attica tags support

leinir added a comment. In D6513#322078 , @ngraham wrote: > So is this enough for people to start tagging KDE4 content as such? Or is anything else still required before that capability lands? In short, this is basically enough :) When peo

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Ouch. Guess I should build my KF with clean build dirs every few weeks, as well as request to finally enable BUILD_QCH on CI, so this is covered. Looks good from pure reading. REPO

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 219 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/219/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 09:10:57 + Build duration: 54 min and counting JUnit Te

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/54/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 08 Sep 2018 09:05:34 + Build duration: 59 min and counting JUnit Tests Nam

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

This revision was automatically updated to reflect the committed changes. Closed by commit R249:7b2936a6d673: Fix autotests with -DBUILD_QCH:BOOL=TRUE (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15251?vs=40932&id=41194 REVISION DET

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

heikobecker added a comment. In D15251#322168 , @kossebau wrote: > ...as well as request to finally enable BUILD_QCH on CI, so this is covered. I wondered why that's not the case. I, for one, would welcome it. REPOSITORY R249 KI18n REV

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 08 Sep 2018 09:10:16 + Build duration: 1 hr 45 min and counting JUnit Tests

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.11/4/ Project: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 08 Sep 2018 09:07:28 + Build duration: 2 hr 5 min and counting JU

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

bcooksley added a comment. Please note that even if the generation of QCH files is enabled on the CI system, the resulting artifacts won't be made available outside the CI system itself. Availability of these files beyond the CI system would depend on separate work to improve api.kde.org,

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

kossebau added a comment. In D15251#322202 , @bcooksley wrote: > Please note that even if the generation of QCH files is enabled on the CI system, the resulting artifacts won't be made available outside the CI system itself. > Availability o

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

bcooksley added a comment. That being said, given that the Online and Offline documentation should be essentially the same thing, it may be worth looking into basing the tooling for API.kde.org and utilising the QCH build process (however that works) to generate both the website version as w

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

kossebau added a comment. In D15251#322205 , @bcooksley wrote: > That being said, given that the Online and Offline documentation should be essentially the same thing, it may be worth looking into basing the tooling for API.kde.org and utilisin

D15349: Update of the R indent script

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. devillemereuil requested review of this revision. REVISION SUMMARY Changing the licence and Kate versi

D15350: Unit tests for the R indent script

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. devillemereuil requested review of this revision. REVISION SUMMARY A series of unit tests as was reque

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Ping? This is a pretty obvious fix, desturl is QString which later becomes latin1 loosing characters... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure, #frameworks, #dolphin Cc: ngraham, kde-frameworks-devel, michaelh, b

D15350: Unit tests for the R indent script

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hi, thanks for that! Can you push yourself or shall I push your indenter + tests? Thanks for taking the time to create some tests! REPOSITORY R39 KTextEditor REVISION DETAIL htt

D15349: Update of the R indent script

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15349 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D15350: Unit tests for the R indent script

devillemereuil added a comment. I thought this phabricator review served as a push request? How can I push the revision myself? Can I push directly on annongit.kde.org? (Sorry for being yet again a newb!) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15350 To:

D15350: Unit tests for the R indent script

cullmann added a comment. :=) To push, you need some developer account, then you can just push to git.kde.org. It is no problem for me to just do that for you, like last time. I think for this time, it is the easiest and fastest thing that I just land your patches. If you wan

D15349: Update of the R indent script

This revision was automatically updated to reflect the committed changes. Closed by commit R39:57a531ed368c: Update of the R indent script (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15349?vs=41201&id=41204 REVISION DETAIL http

D15350: Unit tests for the R indent script

devillemereuil added a comment. Yes, let's do that for now. I'll get an account if this becomes a habit. Thanks for your help! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15350 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: cullmann, kwrite-devel, kd

D15350: Unit tests for the R indent script

cullmann added a comment. Ok ;=) Have pushed the indenter change, need to rebuild my local stuff here with kdesrc-build and will apply + test this change then, too again. Hope to see more contributions, guess R users will like improved indenting ;=) REPOSITORY R39 KTextEditor REVISION

D15350: Unit tests for the R indent script

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4c17dde71e20: Unit tests for the R indent script (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15350?vs=41203&id=41208#toc REPOSITORY R39 KTextEditor CHANGES SINCE L

D15350: Unit tests for the R indent script

cullmann added a comment. I needed to adjust R => r as mode, as the basename of the file is used for that, which is r. Seems to work locally that way, otherwise I got: org.kde.ktexteditor: mode "R" does not exist REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.o

D14006: Fix WebDAV destination header on COPY and MOVE operations

anthonyfieroni added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure, #frameworks, #dolphin Cc: anthonyfieroni, ngraham, kde-frameworks-devel, michaelh, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The EWMH spec doesn't have the _NET_WM_WINDOW_TYPE_COMBOBOX atom. Instead, it has _NET_WM_WINDO

D15340: Add Solarized Light and Dark themes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6d26c25fcfda: Add Solarized Light and Dark themes (authored by acrouthamel). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15340?vs=41179&id=41216 REV

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322112 , @dhaumann wrote: > Looks good to me. > > Related: in order to have better unit testing, would you be willing to add a unit test to https://github.com/KDE/syntax-highlighting/blob/master/autotes

D15358: Unit test: Check all shipped themes for completeness

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann, acrouthamel. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY The added unit test makes sure - the

D15358: Unit test: Check all shipped themes for completeness

dhaumann added a comment. Example output: dh@eriador:syntax-highlighting :-) $ ./bin/theme_test * Start testing of KSyntaxHighlighting::ThemeTest * Config: Using QtTest library 5.11.1, Qt 5.11.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. See D15358 :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortime

D15358: Unit test: Check all shipped themes for completeness

dhaumann updated this revision to Diff 41221. dhaumann added a comment. - Merge branch 'master' into check-themes - Include Solarized color themes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15358?vs=41219&id=41221 BRANCH check-themes (b

D14006: Fix WebDAV destination header on COPY and MOVE operations

bruns added a comment. In D14006#322270 , @dantti wrote: > Ping? This is a pretty obvious fix, desturl is QString which later becomes latin1 loosing characters... Can you add a test plan? Makes it much more obvious how to replicate the p

D15340: Add Solarized Light and Dark themes

dhaumann added a comment. Btw, we forgot to add the themes to the Qt resource file, see also D15358 You can test the theme with the demo app in ksyntaxhighlighting: Go to the build-directory, then type ./bin/codeeditor Then, you can switch the them

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. Thanks, I'll make sure to add to that file if I add more themes. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau updated this revision to Diff 41225. kossebau added a comment. Reaching review candidate state, please start reviewing the code. Target is Frameworks 5.52, so the one after the upcoming Frameworks version. The current planned consumer of the new API is KDevelop 5.4, which may be

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau retitled this revision from "[WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer" to "Introduce AbstractAnnotationItemDelegate for more control by consumer". kossebau edited the summary of this revision. kossebau added reviewers: Kate, KDevelop. REPOSITORY R39

D15358: Unit test: Check all shipped themes for completeness

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. +1 ;=) REPOSITORY R216 Syntax Highlighting BRANCH check-themes (branched from master) REVISION DETAIL https://phabricator.kde.org/D15358 To: dhaumann, vkrause, cullmann, acrouth

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/110/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 08 Sep 2018 21:50:35 + Build duration: 2 min 58 sec and counting JUnit Tests

D15251: Fix autotests with -DBUILD_QCH:BOOL=TRUE

bcooksley added a comment. Yeah, unfortunately getting consensus that we shouldn't be distributing them is difficult - I suspect the issue is that for the most part people are used to building all of our software on their system and therefore don't have the necessary tooling or options suppl

D15364: Plasma style: Remove hardcoded textFormat

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY This fixes all texts being displayed as Text.PlainText if not explicitly overriden. REPOSITORY R242 Plasma Fra

D15364: Plasma style: Remove hardcoded textFormat

ngraham added a reviewer: Plasma. ngraham added a comment. Is there a reason for this change, or a bug report that it fixes? How have you tested this? Do any visual changes result from this patch? If so, are they all desirable? Etc. Some more information would be nice. REPOSITORY R242 Plas

D15340: Add Solarized Light and Dark themes

acrouthamel added a comment. In D15340#322453 , @dhaumann wrote: > Btw, we forgot to add the themes to the Qt resource file, see also D15358 > > You can test the theme with the demo app in ksyntaxhighlight

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. Test plan: 1. Connecto to a WebDav server 2. Create a file named "foo" 3. Try to rename the file to "speçiál" - it should result in "spe" The COPY operation has the same issue but I'm not sure how to test it right now, probably it will also fail if the d