D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, this is amazingly better. Here's how it looks in the Places Panel at various sizes: Small (default): F6295828: Small.png Large:

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Nathaniel Graham
ngraham added a comment. In D15853#334425 , @ndavis wrote: > Ouch, I was not aware of this. All of the other monochrome icons I made that have been committed to master probably lack this as as well. It would be nice to have all the required

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-30 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Confirmed to work with PyQt 5.10.1 and Qt 5.11.1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter,

D15846: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Stefan Brüns
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R270:8c6ab8618eab: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R270 KCodecs

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R283:b3288d1464c9: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15845?vs=42577=42609

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis updated this revision to Diff 42621. ndavis added a comment. Fix stylesheet REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15853?vs=42591=42621 BRANCH new-harddisk-icons (branched from master) REVISION DETAIL

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334455 , @ngraham wrote: > In D15853#334425 , @ndavis wrote: > > > Ouch, I was not aware of this. All of the other monochrome icons I made that have been committed

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. In D15843#334230 , @bruns wrote: > Most obvious problem with this change - as far as I can deduce from your description, this is about runtime behaviour. The config class is the wrong place to add this method.

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Nathaniel Graham
ngraham added a task: T9740: Improve disk presentation in the Places panel. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-09-30 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread Stefan Brüns
bruns added a comment. To cite myself from the mentioned review: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is quite cheap. If you need the info in DatabaseSanitizer, create the

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. In D15853#334415 , @pstefan wrote: > In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. > You will have

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-30 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:05bd97492704: Compile python bindings with the same sip flags used by PyQt (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-09-30 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY An icon's emblem can take up 25% of the total icon area in certain

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-09-30 Thread Martin Koller
mkoller updated this revision to Diff 42626. mkoller added a comment. M$ -> windows About SSL: I have no idea how an SSL url from a sharepoint server would look like, since it seems the setup we use does not use ssl. The mentioned webdavsystem.com link just describes how it would look

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-09-30 Thread Nathaniel Graham
ngraham added a task: T9740: Improve disk presentation in the Places panel. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

2018-09-30 Thread Nathaniel Graham
ngraham added a dependent revision: D13887: use the new plasma virtual desktop protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham,

D15848: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Stefan Brüns
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:a66158ba350c: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R237 KConfig

D15847: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Stefan Brüns
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R284:754cd63a288e: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR (authored by bruns). REPOSITORY R284

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Nathaniel Graham
ngraham added a comment. Makes sense. @pstefan, could you take charge on that since you seem to have some knowledge about this process that the rest of us lack? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg, ngraham, pstefan Cc:

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread Stefan Brüns
bruns added a comment. As a side note - cross-device indexing is broken anyway and can never work reliably in the current scheme using device ids as part of the baloo document id. Device ids are not stable. For the home partition it works somewhat reliable as the device setup is

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-30 Thread jonathan poelen
jpoelen updated this revision to Diff 42628. jpoelen added a comment. - fix the recursion detection and handling of nested included keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41872=42628 BRANCH kwinclude REVISION

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Feel free to push all changes such as this one without review. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D15845 To: bruns, #frameworks, apol Cc:

D15845: Remove misleading use of KDE_INSTALL_PYTHONBINDINGSDIR

2018-09-30 Thread Stefan Brüns
bruns added a comment. Ok, will do for the few remaining ones, Thx. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D15845 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Phil Stefan
pstefan requested changes to this revision. pstefan added a comment. This revision now requires changes to proceed. In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme. You will

D15739: [Places panel] Don't show Root by default

2018-09-30 Thread Roman Gilg
romangg added a comment. Imo this patch can go in as it is, but before that I would like to see a patch to have the disk with the root file system getting specially marked (icon, color or text) for the case that several block devices are mounted at the same time. REPOSITORY R241 KIO

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread Nathaniel Graham
ngraham added a comment. Perhaps we should discuss the implementation of multi-device indexing in a Phab ticket instead of across the comments of multiple patches. Then we can settle on an agreed-upon approach and go implement it instead of going in circles with different approaches.

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

2018-09-30 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Frameworks, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The option is no longer used from any framework, and

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns added a dependency: D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh,

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns updated this revision to Diff 42629. bruns added a comment. Use same pattern as KDE_INSTALL_USE_QT_SYS_PATHS REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=42605=42629 BRANCH python3_support REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 414 - Still Unstable!

2018-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/414/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Oct 2018 03:47:29 + Build duration: 5 min 58 sec and counting JUnit Tests Name: (root) Failed:

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Phil Stefan
pstefan accepted this revision. pstefan added a comment. This revision is now accepted and ready to land. Thank you for the changes! And I will change once I come around to it. REPOSITORY R266 Breeze Icons BRANCH new-harddisk-icons (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 259 - Still Unstable!

2018-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/259/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 01 Oct 2018 03:47:29 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 1

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns added a comment. Thanks to arc for throwing my commit message away ... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread Stefan Brüns
bruns added a comment. In D15843#334515 , @smithjd wrote: > >> There is no need for this, just create a new StorageDevices where you need it. > >> Creating a second StorageDevices instance in a process is quite cheap. > > > > Creating a

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-09-30 Thread Noah Davis
ndavis added a comment. The emblem for the 16px version is too small to read. What if instead of the emblem being on top of the icon, it was off to the side? Then it wouldn't matter what size the emblem is as long as it looks good where it is. REPOSITORY R302 KIconThemes REVISION DETAIL

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

2018-09-30 Thread Stefan Brüns
bruns added a dependent revision: D15070: Bindings: Query the install directory from python. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15867 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. >> There is no need for this, just create a new StorageDevices where you need it. >> Creating a second StorageDevices instance in a process is quite cheap. > > Creating a separate object cluttered the console with duplicated debug output and raised a threading

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread James Smith
smithjd added a comment. >>> As a side note - cross-device indexing is broken anyway and can never work reliably in the current scheme using device ids as part of the baloo document id. Device ids are not stable. For the home partition it works somewhat reliable as the device setup is

D15070: Bindings: Support using sys paths for python install directory

2018-09-30 Thread Stefan Brüns
bruns updated this revision to Diff 42631. bruns retitled this revision from "Bindings: Query the install directory from python" to "Bindings: Support using sys paths for python install directory". bruns edited the summary of this revision. bruns edited the test plan for this revision. bruns

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-09-30 Thread Laurent Montel
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mtpstorage.cpp:176 > +case LIBMTP_FILETYPE_UNDEF_AUDIO: > +return QStringLiteral(""); > +case LIBMTP_FILETYPE_WMV: QString() directly no

D6513: Add support for Attica tags support

2018-09-30 Thread Christoph Feck
cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: rikmills, dfaure, cfeck, mlaurent, ngraham,

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-09-30 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Most obvious problem with this change - as far as I can deduce from your description, this is about runtime behaviour. The config class is the wrong place to add this method.

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Stefan Brüns
bruns added a comment. In D15853#334188 , @ndavis wrote: > I only added 16, 22 and 64 px icons in the current revision, but I also have a 32px version. Is there a reason that there are only 16, 22 and 64 px versions for all device icons? >

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-09-30 Thread Martin Koller
mkoller created this revision. mkoller added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mkoller requested review of this revision. REVISION SUMMARY In our mainly windows company environment, I often receive links in emails like this

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15070: Bindings: Query the install directory from python

2018-09-30 Thread Stefan Brüns
bruns updated this revision to Diff 42605. bruns added a comment. rebase REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15070?vs=40398=42605 BRANCH python3_support REVISION DETAIL https://phabricator.kde.org/D15070 AFFECTED FILES

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-09-30 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks. ngraham added a comment. Code change looks pretty sane to me. Can we change "M$" to "MS" or "Microsoft" though? It's not the most professional, and the symbolism is even rather dated; there are many many companies that have more money than Microsoft

D15859: allow non-local file:// redirect to a M$-WebDav URL

2018-09-30 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > file.cpp:338 > +// if we would redirect into the windows world, let's also check for the > +// DavWWWRoot "token" which in the m$-world tells win explorer to access > +// a webdav url Can you please replace the m$. Also, 'Windows' is

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis added a comment. I only added 16, 22 and 64 px icons in the current revision, but I also have a 32px version. Is there a reason that there are only 16, 22 and 64 px versions for all device icons? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853

D15851: Fix signals not being emitted when merging two persons

2018-09-30 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Frameworks, dvratil. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY If I have 4 contacts, i.e. `{A,B,C,D}`, then merge `{A,B}->1` and

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

2018-09-30 Thread Dan Leinir Turthra Jensen
leinir added a comment. Sorry for pinging again, but i'd really quite like to not have to wait (yet) another cycle for this to get out... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent,

D15853: Change drive-harddisk to more adaptable style

2018-09-30 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY T9740 The old 16 and 22 px drive-harddisk icons