KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/14/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 12 Dec 2018 16:16:56 + Build duration: 7 min 2 sec and counting JUnit Tests Name: (root) Failed: 0

D17498: Xdg Decoration Support

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17498 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

davidedmundson added a comment. What's the benefit? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17542 To: broulik, #plasma, mart Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

davidedmundson added a comment. Oh, to fix fallout from the other review. NM REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17542 To: broulik, #plasma, mart Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise we'll keep piling up custom tooltip items in the dialog. They're

D17518: Adapt favicon test to www.kde.org changes

bruns added a comment. In D17518#375713 , @broulik wrote: > I also thought the favicon was too large for `FavIconJob` to download The now existing www.kde.org/favicon.ico ideed was to large for the favicon job, so the unchanged code got

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R242 Plasma Framework (Library) BRANCH bluetooth-battery-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17505 To: ndavis, #vdg,

D17173: Add error value for job owner dying

broulik added a comment. Now that `ERR_FILE_TOO_LARGE_FOR_FAT32` is in you can rebase this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

broulik added a comment. The bug report is about checking whether it's writable, you're checking the protocol here, and `file` will always "support writing". This patch could still make sense, though. INLINE COMMENTS > copyjob.cpp:864 > +QPointer that = q; > +emit

D17173: Add error value for job owner dying

davidedmundson updated this revision to Diff 47464. davidedmundson added a comment. rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17173?vs=46261=47464 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17173 AFFECTED FILES

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17543: [Dialog] Don't alter mainItem's visibility

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The item's `visible` property is independent of the window visibility, which

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH bluetooth-battery-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17505 To: ndavis, #vdg, #plasma, broulik, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham created this revision. shubham added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY BUG: 141564 REPOSITORY R241 KIO REVISION DETAIL

D17173: Add error value for job owner dying

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17173 To: davidedmundson, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 375 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/375/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 12 Dec 2018 16:16:56 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 0

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham updated this revision to Diff 47465. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17545?vs=47462=47465 REVISION DETAIL https://phabricator.kde.org/D17545 AFFECTED FILES src/core/copyjob.cpp To: shubham, #frameworks Cc: broulik,

D17498: Xdg Decoration Support

davidedmundson updated this revision to Diff 47468. davidedmundson added a comment. remove unused REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17498?vs=47339=47468 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17498 AFFECTED FILES

D17055: Avoid Q_FOREACH

This revision was automatically updated to reflect the committed changes. Closed by commit R246:59fcd4bd2aff: Avoid Q_FOREACH (authored by loh.tar, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17055?vs=45897=47477 REVISION DETAIL

T3689: Add abi compliance checker to CI

knauss added subscribers: kde-frameworks-devel, dfaure. knauss added a comment. I now looked at every repository that failed to build successfully a ABI dump for Frameworks. As I'm not really deep into the Framworks code, so I'm unsure, if those are real issues or if those Frameworks need

D17457: use STL were no implicit sharing is required

cullmann marked an inline comment as done. cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in katetextblock.cpp:64 > Is there a reason why this assert is useless now? .at() will throw (or abort) REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D17457: use STL were no implicit sharing is required

cullmann marked 2 inline comments as done. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D17457 To: cullmann, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars

D17548: Fixed link to the coding style wiki page

janpr added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17548 To: janpr, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. If that helps the QtCreator implementation, I am ok with it, thought I would like to see that they use the framework :P REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 12 Dec 2018 19:34:30 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed:

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:abd1bb407e69: BrightScript: Add workaround for QtCreator endsub highlighting (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d338c398aa87: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16347?vs=47389=47475#toc

D17457: use STL were no implicit sharing is required

This revision was automatically updated to reflect the committed changes. Closed by commit R39:765d5674c5e5: use STL were no implicit sharing is required (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17457?vs=47378=47476 REVISION

T3689: Add abi compliance checker to CI

knauss added a comment. I now looked at every repository that failed to build successfully a ABI dump for Pim. Most of them build successful, but a few of them have issues: - kmime has an unexported header in kmime/kmime_newsarticle.h: `#include ` that lives in src/supertrait.h -

D17548: Fixed link to the coding style wiki page

janpr created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. janpr requested review of this revision. REVISION SUMMARY The page has been moved from the TechBase to the community wiki REPOSITORY R293 Baloo BRANCH

D17548: Fixed link to the coding style wiki page

janpr added a comment. Thanks for accepting the revision. I am not authorized to land it, someone else will have to do that. REPOSITORY R293 Baloo BRANCH fixed_typo_in_readme (branched from master) REVISION DETAIL https://phabricator.kde.org/D17548 To: janpr, #baloo, broulik Cc:

D17530: improve highlighting of complex numbers

dhaumann added a comment. Well, if it's copy & pasted, it must be correct ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17530 To: cullmann, dhaumann, vkrause, #frameworks Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

T3689: Add abi compliance checker to CI

knauss added a comment. I use the ci-docker images to test the create-abi, but I can't reproduce why those are failing: - messagelib - kdav - libksieve - akonadi-import-wizard - kpkpass - libkgapi maybe those are also fixed by D17534

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 12 Dec 2018 19:16:56 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed:

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

dlevin added a comment. Yeah, this might be another bug in the QtCreator (already fixed one crash in their highlighting implementation). They asked me to not put much effort because that code it deprecated anyway in favor or KDE lib. But they just released Creator 4.8.0 and I do not expect

D17500: Restore mobipocket extractor

aacid added a comment. In D17500#375753 , @astippich wrote: > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( > Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail

D17550: Make the open url in tab feature a bit more discoverable

apol added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17550 To: apol, #dolphin, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17550: Make the open url in tab feature a bit more discoverable

apol created this revision. apol added reviewers: Dolphin, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Introduce a context menu item that invites to open the button under the menu in a

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17550: Make the open url in tab feature a bit more discoverable

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. +1 for the idea and the UX as texted. No comment on the code change; I'm definitely not smart enough to understand it all! REPOSITORY R241 KIO BRANCH master REVISION

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 208 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/208/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 13 Dec 2018 07:18:27 + Build duration: 11 min and counting BUILD ARTIFACTS

D17500: Restore mobipocket extractor

mgallien added a comment. In D17500#376221 , @aacid wrote: > In D17500#375753 , @astippich wrote: > > > Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

broulik created this revision. broulik added reviewers: dfaure, davidedmundson, shubham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This was accidentally removed in

D17505: Add preferences-system-bluetooth-battery to preferences.svgz

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2f99869c1071: Add preferences-system-bluetooth-battery to preferences.svgz (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Dec 2018 07:18:27 + Build duration: 8 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 12 Dec 2018 10:10:32 + Build duration: 4 min 32 sec and counting JUnit Tests Name: (root)

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Use QLinkedList instead of a static array. Use QElapsedTimer instead of

D17530: improve highlighting of complex numbers

cullmann added a comment. I didn't include rules as I need to rule out the user literal suffixes. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17530 To: cullmann, dhaumann, vkrause, #frameworks Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh,

D17496: Change network/web color icons to consistent style

ndavis added a comment. In D17496#375658 , @ngraham wrote: > Looks good visually, but the `scalable` test now fails: > > $ grep -A 1 FAIL.*scalable Testing/Temporary/LastTest.log > FAIL! :

D17496: Change network/web color icons to consistent style

ndavis added a comment. I did notice that symlinks for `applications-internet` exist in `apps/16` and `apps/22`, so maybe there needs to be a scalable version in the same category? There was no `apps/48/applications-internet`, but there was a `preferences/32/applications-internet`. I

D17302: add simple test for string merging

astippich added a comment. I was recently wondering if this is actually desired behavior. Right now it is definitely required since KFileMetaData wrongly outputs QStrings instead of a QStringList, but when this is fixed, this behavior should be removed imho. Otherwise, querying metadata via

D16347: Expose KTextEditor::ViewPrivate:setInputMode(InputMode) to KTextEditor::View

cullmann added a comment. Hmm, actually, not sure if we need to make it virtual, on the other side, it avoids to maintain the redirection. I can add a KF6 todo and push it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16347 To: cullmann, mlaurent, vkrause,

D17500: Restore mobipocket extractor

astippich added a comment. Oh, thanks for the hint, didn't know that. That makes it a lot more complicated than a straight port :( Looking at the code of kdegraphics-mobipocket, shouldn't the thumbnail extractor actually be part of kio-extras? Seems quite kio-specific, and a quick look at

D17529: [proxysetting] Fix build with NM 1.4

wbauer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY The `NMSettingProxyMethod` enum only exists since NetworkManager 1.6. So define it appropriately when building with a

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a reviewer: jgrulich. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17530: improve highlighting of complex numbers

cullmann updated this revision to Diff 47430. cullmann added a comment. update unit tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17530?vs=47429=47430 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17530 AFFECTED FILES

D17530: improve highlighting of complex numbers

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY CHANGELOG: support more variants of C number literals BUG: 402002 TEST PLAN adapted unit

D17530: improve highlighting of complex numbers

cullmann added reviewers: dhaumann, vkrause, Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17530 To: cullmann, dhaumann, vkrause, #frameworks Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars,

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375867 , @jgrulich wrote: > I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines. Sure, that would work as well. But IMHO the version check would make

D17529: [proxysetting] Fix build with NM 1.4

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375882 , @wbauer wrote: > I don't think that really is a problem here though, as it is defined in libnm/nm-setting-proxy.h (in NM 1.6+) which is included by this file (via NetworkManager.h that's included by

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. I think the easiest solution here is just to set 0 and 1 to the enum values, instead of NM defines. I'm not sure if adding/removing enum is ABI compatible change, because the enum will disapper once you build it against NM 1.6.0+. REPOSITORY R282 NetworkManagerQt

D17491: Fix documentation, QValueList isn't a thing anymore

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17491 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17491: Fix documentation, QValueList isn't a thing anymore

apol closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17491 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. In D17529#375909 , @jgrulich wrote: > So maybe go with the easiest approach and just instead of defines use 0 and 1? Fine with me. Should I make that conditional depending on the NM version maybe, or just

D17530: improve highlighting of complex numbers

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Reviewing correct context popping is always not so easy - I trust this part is correct?! ;) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D17529: [proxysetting] Fix build with NM 1.4

wbauer updated this revision to Diff 47446. wbauer edited the summary of this revision. wbauer added a comment. Don't define the enum, rather use the numbers directly REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17529?vs=47426=47446 REVISION

D17529: [proxysetting] Fix build with NM 1.4

wbauer requested review of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

wbauer edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17530: improve highlighting of complex numbers

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ea5a88d1df28: improve highlighting of complex numbers (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17530?vs=47430=47450

D17529: [proxysetting] Fix build with NM 1.4

This revision was automatically updated to reflect the committed changes. Closed by commit R282:88f3093c5237: [proxysetting] Fix build with NM 1.4 (authored by wbauer). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17529?vs=47446=47454 REVISION

D17529: [proxysetting] Fix build with NM 1.4

wbauer added a comment. Hm, maybe I should add `extern "C"` though? This is inside `G_BEGIN_DECLS`/`G_END_DECLS` in nm-setting-proxy.h, which are defined as `extern "C" {` and `}` (according to the docs). REPOSITORY R282 NetworkManagerQt REVISION DETAIL

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. So maybe go with the easiest approach and just instead of defines use 0 and 1? REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

jgrulich added a comment. In D17529#375913 , @wbauer wrote: > In D17529#375909 , @jgrulich wrote: > > > So maybe go with the easiest approach and just instead of defines use 0 and 1? > > >

D17530: improve highlighting of complex numbers

cullmann added a comment. It's "stolen" 1:1 from the C++ stuff. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D17530 To: cullmann, dhaumann, vkrause, #frameworks Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

D17529: [proxysetting] Fix build with NM 1.4

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17529 To: wbauer, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns