D18612: Cache the default KColorScheme configuration

broulik added a comment. I also noticed that on application startup two default color schemes are created: One by plasma-integration set on `QApplication` and the other by `QStyle::standardPalette()` in the widget style. I couldn't figure out a way to avoid this (have QStyle use the

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

I'll try to get around to debugging this, but I'm surprised by one thing: doesn't the same issue happen in KIO's own tests? It also has several tests that make use of KIO slaves directly, skipping KLauncher. Ironically, the reason we skip klauncher is exactly to avoid this problem in the first

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

davidedmundson added a comment. Wait a few days. Frameworks tagging is the first Saturday of the month. We want some wider testing given this hits stable releases. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18545 To:

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. Nate, thank you for accepting the patch! Okay so the corner thing - that bug actually happens //everywhere.// **All of the following screenshots are of master, not this patch.** For example, Breeze Dark, Background Contrast on, Blur off F6580832:

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

On Fri, Feb 1, 2019 at 9:15 PM David Faure wrote: > > I'll try to get around to debugging this, but I'm surprised by one thing: > doesn't the same issue happen in KIO's own tests? It also has several tests > that make use of KIO slaves directly, skipping KLauncher. Indeed, I found it surprising

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

sitter added a comment. Even with the chances being low of a system having an old version, I'd say it's better to actually make find_package look for at least the version that introduced the import target. other than that  REPOSITORY R320 KIO Extras REVISION DETAIL

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#403143 , @davidedmundson wrote: > Wait a few days. Frameworks tagging is the first Saturday of the month. > > We want some wider testing given this hits stable releases. Not a bad idea. Next week then

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50648. loh.tar added a comment. - Move logic into document - Tiny docu fix + cosmettic CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17949?vs=50104=50648 REVISION DETAIL https://phabricator.kde.org/D17949 AFFECTED FILES

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. The blur effect is able to handle rounded corners, a client just has to upload proper blur region. Yes, I had the latest version of the diff. I don't use the zoom effect. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#403154 , @zzag wrote: > The blur effect is able to handle rounded corners, a client just has to upload proper blur region. Yes, I had the latest version of the diff. I don't use the zoom effect. I think

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. By the way guys, it does look sometimes better with the blur off: F6580935: image.png (and with the blur on, the corners behave weird F6580938: image.png , see bottom left corner)

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. It’s perso at hack-libre dot org REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, GB_2, ragreen, Pitel,

D18533: Improve the Notfication Bell Icon by using the KAlarm design

trickyricky26 added a comment. I changed the shape a bit, but making it less flat is difficult: Linear gradients look off because of the curvature of the bell. Other options are blurring a curved object or using mesh gradients, but I'm not sure how well, if it all, these will work in

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now the delegates' inline hover buttons can be very difficult to

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. Good idea, but I think it's a bit too dark. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Here's 0.65 opacity instead: F6581631: 0.65 opacity.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: GB_2, kde-frameworks-devel, michaelh, ngraham,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

GB_2 added a comment. In D18649#403326 , @ngraham wrote: > Here's 0.65 opacity instead: F6581631: 0.65 opacity.png Ok, the previous was better because you could see the red trash icon better.

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. Yeah, that was why I went with 0.8. :) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. There's definitely a legibility issue here. I do, however, think the gradient is a sleeker solution. The problem for me has actually been with the icons themselves. They're too scrawny and become more legible when thicker: F6582065: Screenshot_20190202_001342.png

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ndavis added a comment. F6581666: Screenshot_20190201_131014.png The colors are no so good, but this is what I was talking about. It looks more 3D. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To:

D18652: Improve weather-storm-* icons

ngraham created this revision. ngraham added reviewers: VDG, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Current icons are a bit too visually busy and cluttered. This patch corrects

D18652: Improve weather-storm-* icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18652 To: ngraham, #vdg, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Enables the KIO to react differently when being stat'd by the thumbnail

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ndavis added a comment. The ringer inside the bell has contrast issues with the standard Breeze Dark background color: F6581679: Screenshot_20190201_131929.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To:

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R126:484a7dc89a75: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior (authored by achauvel, committed by ngraham). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

broulik added a dependent revision: D18654: [fonts:/ KIO] Implement stat() call. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18653 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18652: Improve weather-storm-* icons

kossebau added a comment. > This patch corrects that by removing the background cloud Thanks for the proposal. Hm, removal of the second cloud not what I would have expected to be done, was actually fine with it. Not sure. > slightly resizing and repositioning the sun and moon.

D18652: Improve weather-storm-* icons

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18652 To: ngraham, #vdg, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. I love that implementation. I bounced back ideas with Marco long ago about this. I think we should implement it in all other KCMs with similar representations. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg,

D18533: Improve the Notfication Bell Icon by using the KAlarm design

abetts added a comment. In D18533#403337 , @ndavis wrote: > F6581666: Screenshot_20190201_131014.png > > The colors are not very good, but this is what I was talking about. It looks more 3D. I

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a comment. In D18649#40 , @abetts wrote: > I love that implementation. I bounced back ideas with Marco long ago about this. I think we should implement it in all other KCMs with similar representations. Yep, if this

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18653: [PreviewJob] Also pass along that we're the thumbnailer when stat'ing file

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18653 To: broulik, #frameworks, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

abetts added a comment. In D18649#403336 , @ngraham wrote: > In D18649#40 , @abetts wrote: > > > I love that implementation. I bounced back ideas with Marco long ago about this. I think we

D18652: Improve weather-storm-* icons

ngraham added a comment. Good point, I'll revert the sun/moon size+position changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18652 To: ngraham, #vdg, kossebau Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ngraham added a comment. How about putting a line under the little nubbin on top? F6581659: Bell with nubbin.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: ngraham, ndavis,

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ndavis added a comment. In D18533#403354 , @ngraham wrote: > In D18533#403351 , @ndavis wrote: > > > The ringer inside the bell has contrast issues with the standard Breeze Dark background color:

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ngraham added a comment. In D18533#403351 , @ndavis wrote: > The ringer inside the bell has contrast issues with the standard Breeze Dark background color: F6581679: Screenshot_20190201_131929.png

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau added a comment. In D18611#403137 , @sitter wrote: > Even with the chances being low of a system having an old version, I'd say it's better to actually make find_package look for at least the version that introduced the import target.

D18652: Improve weather-storm-* icons

ngraham updated this revision to Diff 50674. ngraham added a comment. Revert size + position changes for the sun and moon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18652?vs=50669=50674 BRANCH improve-storm-icons (branched from master)

D18652: Improve weather-storm-* icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH improve-storm-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18652 To: ngraham, #vdg, kossebau, ndavis Cc: ndavis, kde-frameworks-devel,

D18660: Add yast-upgrade

ndavis added a comment. It's just this with the arrow flipped upside down to indicate that it's for upgrading from installation media instead of installing F6582392: Screenshot_20190201_231228.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis added a subscriber: fvogt. ndavis added a comment. @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is? REPOSITORY R266 Breeze Icons REVISION

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 03:13:38 + Build duration: 1 min 41 sec and counting JUnit Tests Name:

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham planned changes to this revision. ngraham added a comment. I'll work on that. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham,

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

ngraham added a subscriber: andreask. ngraham added a comment. This is a variant of the issue we've seen with desktop icons and UI elements on the login screen: there is no way to ensure legibility against arbitrary backgrounds without a contrast-adding element of some sort, like a shadow or

D18652: Improve weather-storm-* icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Certainly an improvement, you just need to strip out all of the unnecessary Inkscape metadata. You can do that with, SVG Cleaner, SVGO, or go to "File->Save As" and save as a

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 02 Feb 2019 04:26:59 + Build duration: 14 min and counting BUILD ARTIFACTS

D18660: Add yast-upgrade

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH more-yast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18660 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 02 Feb 2019 04:26:59 + Build duration: 9 min 2 sec and counting BUILD ARTIFACTS

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The icons should have worked as they were because they have the correct fallback names.

D18652: Improve weather-storm-* icons

ngraham updated this revision to Diff 50689. ngraham added a comment. Optimize SVGs REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18652?vs=50674=50689 BRANCH improve-storm-icons (branched from master) REVISION DETAIL

D18660: Add yast-upgrade

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9555110c23c5: Add yast-upgrade (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18660?vs=50691=50692 REVISION DETAIL

D18660: Add yast-upgrade

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18660 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18660: Add yast-upgrade

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY An icon for doing an upgrade with the openSUSE YaST installer. Appears in the application

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 02 Feb 2019 04:26:59 + Build duration: 3 min 30 sec and counting JUnit Tests

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

filipf added a comment. ^ I agree, I really like that emblems solution now that I've seen it. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham,

D18652: Improve weather-storm-* icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:036f849a12ee: Improve weather-storm-* icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18652?vs=50689=50690 REVISION DETAIL

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ngraham added a comment. General policy surrounding workarounds that are committed to the repo is that you need to know and mention the specific bug(s) you're working around. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: ngraham,

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. Ping? Can someone please review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. Any more ideas?, I'm a bit confused REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure,