D18997: Add functions returning all definitions for a mimetype or file name

davschul added a comment. Created https://phabricator.kde.org/D19200 That should implement all the latest suggestions/comments REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: dhaumann, cullmann, kwrite-devel,

D19200: Return sorted definitions for file names and mime types

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ba615b22ece6: Return sorted definitions for file names and mime types (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D19200: Return sorted definitions for file names and mime types

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yes, this is nice, nice trick with value(0) to avoid adding an element to the vector but just letting the API default construct it. REPOSITORY R216 Syntax Highlighting REVISION

D19200: Return sorted definitions for file names and mime types

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Beside that this fails ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/41/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 14:27:24 + Build duration: 1 min 39 sec and counting JUnit Tests

D19200: Return sorted definitions for file names and mime types

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas,

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. I think the + 1 is the only real issue, the other issue stems from my local setting that I have no compiled in QRC. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel,

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns created this revision. bruns added reviewers: Frameworks, Baloo, astippich, ngraham. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY There is no need to do any Base64 encoding of the data. Also avoid streaming the data to an intermediate

D19200: Return sorted definitions for file names and mime types

davschul created this revision. davschul added reviewers: cullmann, vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 134 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/134/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 21 Feb 2019 14:16:34 + Build duration: 5 min 33 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 135 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/135/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 21 Feb 2019 14:27:24 + Build duration: 4 min 30 sec and counting JUnit

D18996: Fix building with namespaced Qt

cullmann added a comment. No problem, I just reopened it that I remember to take a look again at it myself. I just run into this issue wanting to land some patches on a openSUSE Leap machine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To:

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. The partial sort is bad ;=() REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, cullmann,

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. Actually, do we need a partial sort? Should we not just stable_sort the complete vector by prio? That should keep stuff with same prio untouched, or? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann,

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. I think one error is the sort of the empty vector with the begin() + 1 But even then, make test fails, after fixing this. Please take a look and run the tests. Thanks REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200

D18996: Fix building with namespaced Qt

davschul added a comment. Okay I've tested it with 3.12.2 and there were no issues. I'm not familiar enough with cmake to tell whether there is a simpler version for what I try to achieve here. I just need the -D QT_NAMESPACE compiler options. Is there someone in the community who might

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/40/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 14:16:34 + Build duration: 4 min 24 sec and counting JUnit Tests

D18997: Add functions returning all definitions for a mimetype or file name

cullmann closed this revision. cullmann added a comment. Ok ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

This revision was automatically updated to reflect the committed changes. Closed by commit R39:598b6c9ca58b: katetextbuffer: refactor TextBuffer::save() to better separate code paths (authored by mgerstner, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 12:40:13 + Build duration: 2 min 16 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Feb 2019 12:40:13 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner added a comment. >> @cullmann wrote: > > If you pass me your author email, I will push that. Sure, it's matthias.gerst...@suse.de REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel,

D18845: authority: add support for passing details to polkit

mgerstner added a comment. In D18845#416305 , @bruns wrote: > Does this solve part of T8075 ? Part of a part it seems. I am currently working towards T10480 . To

D19198: BrightScript: Unary and hex numbers, @attribute

dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Fixed small issues for rvalue highlighting: - Unary numbers,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 132 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/132/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 21 Feb 2019 12:30:43 + Build duration: 5 min 40 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 133 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/133/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 21 Feb 2019 12:40:13 + Build duration: 4 min 32 sec and counting JUnit

D19198: BrightScript: Unary and hex numbers, @attribute

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5c0f50026bfc: BrightScript: Unary and hex numbers, @attribute (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

kdbusaddons racing nameregistration with kcrash'd instance

Hey, I've found a tricky race condition in the startup of kdbusaddons and I need some thoughts on how to deal with it Let's assume binary foo is a dbus unique service on org.kde.foo that uses kcrash with autorestart enabled: - foo1 gets started - registers org.kde.foo - runs normally -

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/31/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Feb 2019 12:40:13 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/30/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Feb 2019 12:30:43 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Feb 2019 12:30:43 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 12:30:43 + Build duration: 2 min 31 sec and counting JUnit Tests

D18996: Fix building with namespaced Qt

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, there is one issue: With older cmake, aka cmake version 3.10.2 I get now: CMake Error at data/CMakeLists.txt:68 (target_link_libraries): Object library

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. Thanks, will apply this. Nice that you help to improve this code. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking,

D19198: BrightScript: Unary and hex numbers, @attribute

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable + we have a test => nice, merging. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19198 To: dlevin, cullmann Cc: kwrite-devel,

D18664: Baloo engine: treat every non-success code as a failure

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > bruns wrote in mtimedb.cpp:110 > `if (rc != MDB_NOTFOUND)` for the message **for the message** - you now only retrieve the first entry, spew an error

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 52229. valeriymalov added a comment. - fix MTimeDB::get loop REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=52216=52229 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18664 AFFECTED FILES

D19111: Have ShareFileItemAction provide an output or an error if they are provided

nicolasfella accepted this revision. nicolasfella added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:3 > +find_package(KF5Notifications COMPONENTS) > +if (NOT KF5KIO_FOUND OR NOT KF5Notifications_FOUND) > +return() Maybe move the check

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Feb 2019 16:59:59 + Build duration: 3 min 2 sec and counting BUILD ARTIFACTS

D19200: Return sorted definitions for file names and mime types

davschul added a comment. Ah sorry completely missed that part. Unfortunately I'm out of office already, I'll take a look as soon as I'm back tomorrow. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc:

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 21 Feb 2019 16:24:04 + Build duration: 3 min 41 sec and counting BUILD ARTIFACTS

D18664: Baloo engine: treat every non-success code as a failure

valeriymalov updated this revision to Diff 52216. valeriymalov marked 4 inline comments as done. valeriymalov added a comment. - review warning fixes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18664?vs=51284=52216 BRANCH master REVISION DETAIL

D19111: Have ShareFileItemAction provide an output or an error if they are provided

apol updated this revision to Diff 52218. apol added a comment. Remove unrelated debug info REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19111?vs=51940=52218 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19111 AFFECTED FILES

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/27/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 21 Feb 2019 16:24:04 + Build duration: 3 min 53 sec and counting BUILD ARTIFACTS

D19111: Have ShareFileItemAction provide an output or an error if they are provided

apol closed this revision. apol added a comment. Landed, don't know why this didn't update. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19111 To: apol, #dolphin, #frameworks, nicolasfella Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19111: Have ShareFileItemAction provide an output or an error if they are provided

apol added a comment. https://commits.kde.org/purpose/a6d93ff28f090dd0086301884a31e0eea0efd845 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19111 To: apol, #dolphin, #frameworks, nicolasfella Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18873: add baloo engine debugging category

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f5f1ae889fe9: add baloo engine debugging category (authored by valeriymalov). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51279=52220 REVISION DETAIL

D19098: Add PropertyMap to QVariantMap conversion function using names

bruns added a comment. In D19098#415713 , @astippich wrote: > In D19098#414973 , @bruns wrote: > > > In D19098#414729 , @astippich wrote: > > > > > It

D18853: Fix sharing files with spaces or quotes in names via Telegram

apol added a comment. Cool! :D welcome to KDE! REPOSITORY R495 Purpose Library BRANCH telegram-sharing-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D18853 To: mikhailru, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

GeeXT added a comment. @apol I didn't applied for KDE Developer Account yet (I'm new here) so I can't, sorry. REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc:

D19170: Fix crash while moving files

hallas added a comment. I think I have finally found the root cause of this. The following events occurs: 1. A FileCopyJob is created and added as a SubJob to CopyJob 2. CopyJob::slotResult is notified 3. CopyJobPrivate::slotResultCopyingFiles is called because it is in state

D19198: BrightScript: Unary and hex numbers, @attribute

dlevin added a comment. Thanks for cleaning up the tests after me! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19198 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19097: Add a test and document PropertyMap/VariantMap conversion

bruns added a comment. These two conversion functions should just be deprecated, as they are not expecially useful. `toPropertyMap` is only used (an no longer will be after D19088 ) inside baloo as a temporary for the Json conversion, and

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. I think this looks good now, but I would prefer an OK from another developer, as this has become quite large. Readability good profit from `if (rc)` -> `if (rc != MDB_SUCCESS)` resp. `if (rc == 0)` -> `if (rc == MDB_SUCCESS)`, but I am not sure about this.

D19156: port to findcanberra from ECM

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D19156 To: sitter, broulik, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

apol added a comment. Thanks! Can you land the patch or should we do it for you? REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh,

D18762: Add support for portals in KRun

ngraham added a comment. No problem, I'll take care of this for you! REPOSITORY R241 KIO BRANCH flatpak_open_url (branched from master) REVISION DETAIL https://phabricator.kde.org/D18762 To: GeeXT, jgrulich, apol, dfaure, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19170: Fix crash while moving files

hallas edited the summary of this revision. hallas edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19170 To: hallas, #frameworks, elvisangelaccio, dfaure Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

cfeck added a comment. That a nested event loop of an error dialog caused the crashes makes sense, because they were reported for alien drives (NTFS) or transfers with permission problems. What actual error dialogs did you get and are they reproducible? REPOSITORY R241 KIO REVISION

D18853: Fix sharing files with spaces or quotes in names via Telegram

This revision was automatically updated to reflect the committed changes. Closed by commit R495:b45535ee6e91: Fix sharing files with spaces or quotes in names via Telegram (authored by mikhailru, committed by apol). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D18762: Add support for portals in KRun

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c063b1ce8489: Add support for portals in KRun (authored by GeeXT, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=52163=52239 REVISION

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 21 Feb 2019 20:16:35 + Build duration: 6 min 46 sec and counting JUnit Tests Name:

D19170: Fix crash while moving files

hallas updated this revision to Diff 52240. hallas added a comment. Implement a proper fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19170?vs=52108=52240 BRANCH fix_crash_while_moving_files (branched from master) REVISION DETAIL

D19200: Return sorted definitions for file names and mime types

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a62af5713549: Return sorted definitions for file names and mime types (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D19215: Install DefinitionDownloader header

davschul created this revision. davschul added reviewers: cullmann, vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION

D19200: Return sorted definitions for file names and mime types

davschul updated this revision to Diff 52268. davschul added a comment. Yeah, I just missed to recheck the sorting logic. Before the change we just needed the best match so the partial sort was completely sufficient. Now we need a complete sorted vector, so stable sort is the way to go ;)

D19163: Make it possible to show all spaces in the document

cullmann added a comment. In D19163#417139 , @apol wrote: > In D19163#415907 , @cullmann wrote: > > > I like the feature, but for the implementation: Could we alter the config to itself hold the

D19200: Return sorted definitions for file names and mime types

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, this seems to work now here, too ;) Will merge it, thanks again. REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel,

D19200: Return sorted definitions for file names and mime types

dhaumann added inline comments. INLINE COMMENTS > repository.cpp:83 > { > -if (candidates.isEmpty()) > -return Definition(); > - > -std::partial_sort(candidates.begin(), candidates.begin() + 1, > candidates.end(), [](const Definition , const Definition ) { > +

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/25/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Feb 2019 04:35:28 + Build duration: 3 min 38 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/34/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 22 Feb 2019 04:34:48 + Build duration: 28 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 22 Feb 2019 04:35:28 + Build duration: 28 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.10 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Feb 2019 04:57:58 + Build duration: 5 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 22 Feb 2019 04:35:27 + Build duration: 38 min and counting JUnit Tests Name:

D18249: [datamodel] Rework items insert/remove

anthonyfieroni abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18249 To: anthonyfieroni, davidedmundson, broulik, ngraham, mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. Thanks for taking a look again ;=) I would propose to just stable_sort the vector, that should always yield the same result. And I think the sorting is the only issue, the other problem I got did only occur with non-QRC syntax files and was introduced by

D19163: Make it possible to show all spaces in the document

apol added a comment. In D19163#415907 , @cullmann wrote: > I like the feature, but for the implementation: Could we alter the config to itself hold the enum? We could do that, I just didn't not to break currently existing systems >

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52260. apol added a comment. oops REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52084=52260 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FILES src/dialogs/katedialogs.cpp

KDE CI: Frameworks » khtml » kf5-qt5 SUSEQt5.10 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/khtml/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 22 Feb 2019 04:34:38 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 77