D19307: Enforce new muted icon style in all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19263: Add more highlighting for nested languages in markdown.

cullmann added a comment. Jos fixed it in commit 1653403267ed9ad0a27ee4042be8e0d714a5dcc4 I made that check now required. All current files pass, people can comment out contexts during development.

D19307: Enforce new muted icon style in all action icons

ngraham added a comment. Can you verify the permissions of these files? when I apply this patch, build it, and run the tests, I get permissions errors: Running tests... Test project /home/dev/kde/build/breeze-icons CMake Error: Cannot open file for write:

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 43 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/43/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 23 Feb 2019 18:04:48 + Build duration: 2 days 1 hr and counting

D19319: make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R291 KPty BRANCH compile_without_foreach

D19307: Enforce new muted icon style in all action icons

trickyricky26 updated this revision to Diff 52543. trickyricky26 added a comment. - Lower opacity of inactive sound waves to 0.25 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19307?vs=52542=52543 BRANCH correct-muted-action-icons (branched from

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Good idea, thanks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

This revision was automatically updated to reflect the committed changes. Closed by commit R237:3bfe329b7136: KConfig: Assign documentation to correct enum value (authored by thomasfischer). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19320?vs=52558=52564

D19313: Remove URLs being fetched when listing job is `completed`

dpalacio created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dpalacio requested review of this revision. REVISION SUMMARY Currently `ExpandToUrl` may fail to fully expand to an existing folder if any parent folder in the path has several

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19320 To: thomasfischer, broulik, dfaure, davidedmundson Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

thomasfischer created this revision. thomasfischer added a project: Documentation. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thomasfischer requested review of this revision. REVISION SUMMARY In commit 8579ec54

D19320: Assign documentation to correct enum value (corrects commit 8579ec54)

thomasfischer added reviewers: broulik, dfaure, davidedmundson. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19320 To: thomasfischer, broulik, dfaure, davidedmundson Cc: kde-frameworks-devel, gennad, michaelh, ngraham, bruns, skadinna

D19317: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R287 KImageFormats BRANCH

D19318: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R274 KIdleTime BRANCH

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ce4194b5bc2e: try to improve painting height for text lines - bug 403868 avoid to cut _ and… (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19283?vs=52466=52544#toc

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. Hmpf :/ I improved my commit message and amended, but arc at it :/ I will BUG: and CCBUG: the bugs manually :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: loh.tar, thomassc, kwrite-devel,

D19313: Remove URLs being fetched when listing job is `completed`

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

trickyricky26 updated this revision to Diff 52566. trickyricky26 added a comment. - Change 16px player-volume-muted to symlink in order to pass duplicate test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19307?vs=52543=52566 BRANCH

D19016: Update Android toolchain files to reality

jjazeix added inline comments. INLINE COMMENTS > Android.cmake:150 > set_deprecated_variable(CMAKE_ANDROID_ARCH_ABI ANDROID_ABI "armeabi-v7a") > -set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "14") > +set_deprecated_variable(CMAKE_ANDROID_API ANDROID_API_LEVEL "21") > Sorry,

D19307: Enforce new muted icon style in all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19080: [WIP] Make file overwrite a bit safer

chinmoyr added a comment. @dfaure ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 26 Feb 2019 04:31:42 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Feb 2019 04:31:42 + Build duration: 7 min 54 sec and counting BUILD ARTIFACTS

D19324: Add code-oss icon

axionl updated this revision to Diff 52581. axionl added a comment. - Merge branch 'master' into code-oss REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52571=52581 BRANCH code-oss (branched from master) REVISION DETAIL

D19324: Add code-oss icon

ngraham added a comment. > `code-oss-dark.svg` Is this the correct name? I assume the app itself isn't named "code-oss-dark", right? Also screenshots are appreciated, as is filling in the test plan. :) https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

D19324: Add code-oss icon

rooty added a comment. There are quick commands/aliases here for how to take quick screenshots https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow I ran it and I got F6635927: new.png which looks really nice. However, is there some

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/27/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Feb 2019 04:31:42 + Build duration: 23 min and counting BUILD ARTIFACTS

D19324: Add code-oss icon

ndavis added a comment. In D19324#419766 , @axionl wrote: > I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I think I can redraw it by inkscape. Please do. KDE software is only made with free

D19326: Compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R237 KConfig BRANCH

D19324: Add code-oss icon

axionl created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. axionl requested review of this revision. REVISION SUMMARY Add the code-oss icons follow the breeze and breeze-dark style REPOSITORY R266 Breeze Icons BRANCH code-oss

D19324: Add code-oss icon

ndavis added a comment. Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape? Can you explain what process you used to make this icon? F6636063:

D19324: Add code-oss icon

rooty added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

axionl added a comment. In D19324#419702 , @rooty wrote: > There are commands/aliases here for how to take quick screenshots https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow > > I ran montage-breeze and I got F6635927: new.png

D19324: Add code-oss icon

axionl added a comment. In D19324#419751 , @ndavis wrote: > Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape?

D19324: Add code-oss icon

axionl added a comment. In D19324#419767 , @ndavis wrote: > In D19324#419766 , @axionl wrote: > > > I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I

D19307: Enforce new muted icon style in all action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH correct-muted-action-icons (branched from master) REVISION DETAIL

D19307: Enforce new muted icon style in all action icons

trickyricky26 edited the summary of this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19307: Enforce new muted icon style in all action icons

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19307 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas updated this revision to Diff 52508. hallas added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52132=52508 BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAIL

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please add the comment as suggested by Thomas. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: loh.tar,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/37/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 25 Feb 2019 10:08:22 + Build duration: 59 min and counting JUnit Tests Name: projectroot

D19255: Only commit XdgOutput::done if changed

davidedmundson edited the summary of this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19255 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f56af9e2ea0a: Fix crash in Dolphin when dropping trashed file in trash (authored by hallas). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52508=52509

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH relyonappimageimportedtarget REVISION DETAIL https://phabricator.kde.org/D18611 To: kossebau, broulik, sitter Cc: sitter, kde-frameworks-devel, kfm-devel, alexde, feverfew,

D19255: Only commit XdgOutput::done if changed

davidedmundson retitled this revision from "WIP: Alternate approach to D19253" to "Only commit XdgOutput::done if changed". davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel updated this revision to Diff 52507. thsurrel added a comment. Rebase REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16913?vs=50295=52507 BRANCH arc_focussearch (branched from master) REVISION DETAIL https://phabricator.kde.org/D16913

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b6cb0fa963db: [appimage thumbnailer] Rely on imported cmake target libappimage (authored by kossebau). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D19255: Only commit XdgOutput::done if changed

davidedmundson added a comment. I wouldn't say it's handling it incorrectly. In the scenario you've give the logical size hasn't changed. > a single wl_output::done event might be generated but not the respective xdg_output::done event. I was under the impression that xwayland

D19298: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R283 KAuth BRANCH compile_without_foreach

D19299: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R244 KCoreAddons BRANCH

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 25 Feb 2019 14:16:20 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Feb 2019 14:16:21 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Feb 2019 14:16:21 + Build duration: 19 min and counting BUILD ARTIFACTS

D16913: Add the possibility to give focus to the KPluginSelector search field

ngraham added a reviewer: Plasma. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D19255: Only commit XdgOutput::done if changed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:5afbaa5e43f9: Only commit XdgOutput::done if changed (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19255?vs=52385=52538#toc REPOSITORY R127 KWayland CHANGES