D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

axionl updated this revision to Diff 52588. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 : Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

D19324: Add code-oss icon

axionl updated this revision to Diff 52587. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 : Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

D19080: [WIP] Make file overwrite a bit safer

dfaure added a comment. And don't forget to remove the [WIP] from your commit log ;-) REPOSITORY R241 KIO BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY The Mustache highlighting

D19080: [WIP] Make file overwrite a bit safer

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > file_unix.cpp:414 > +if (::unlink(_dest_backup.constData()) == -1) { > +qCWarning(KIO_FILE) << "Couldn't remove original dest" << > _dest_backup;

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

ndavis added a comment. Much better. Now for some questions and suggestions. Why does the icon use green on the top of the logo? The light theme version doesn't look bad, but isn't the official logo all blue? In general, we try to preserve the original branding. Why is the dark

D19335: [kdoctools] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19336: [kguiaddons] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R273 KGuiAddons BRANCH

D19335: [kdoctools] make it compile without foreach

ltoscano added a comment. Isn't it a duplicate of D19271 ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns,

D19326: [Kconfig] Compile without foreach

mlaurent retitled this revision from "Compile without foreach" to "[Kconfig] Compile without foreach". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

ngraham accepted this revision. ngraham added a comment. Brilliant, works great! REPOSITORY R241 KIO BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19080: [WIP] Make file overwrite a bit safer

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH safe-overwrite REVISION DETAIL https://phabricator.kde.org/D19080 To: chinmoyr, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

Lekensteyn added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19027 To: Lekensteyn, ngraham, dfaure, fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19332: KProcess compile fix for obsolete QProcess members in 5.13

marten added inline comments. INLINE COMMENTS > apol wrote in kprocess.h:332 > Also should check for QT_DISABLE_DEPRECATED_BEFORE no? Do you mean conditionalise instead on #if !QT_DEPRECATED_SINCE(5, 13), so that if the functions are not disabled in Qt then they are hidden here? That would

D19338: New location for KNSRC files

apol added a comment. +1 cool stuff! this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? Was these files look up was delegated entirely to KConfig? REPOSITORY R304 KNewStuff REVISION DETAIL

D19170: Fix crash while moving files

hallas added a comment. In D19170#418234 , @dfaure wrote: > I think it's an unwanted fact that the chmod job runs in parallel with the del job. > A "return" after creating the chmod job would fix all this. > > But of course it should be

D19170: Fix crash while moving files

hallas updated this revision to Diff 52643. hallas added a comment. Updated fix. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19170?vs=52240=52643 BRANCH fix_crash_while_moving_files (branched from master) REVISION DETAIL

D19170: Fix crash while moving files

hallas added inline comments. INLINE COMMENTS > filecopyjob.cpp:495 > +} else if (job == d->m_chmodJob) { > +if (d->m_delJob) { > +d->m_delJob->kill(Quietly); Should we also set d->m_chmodJob to nullptr here, just like the m_putJob handling branch? >

D19016: Update Android toolchain files to reality

jjazeix added a comment. In D19016#420246 , @apol wrote: > Applications can still override it, note it's a default. > Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk Ok, good for me :).

D19339: Add option to change drive label to places panel context menu

broulik added a comment. Also, this should probably go into Solid StorageVolume with proper backend abstraction REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19339 To: chinmoyr, #dolphin, #frameworks Cc: broulik, ngraham, bruns, kfm-devel, alexde, feverfew,

D19016: Update Android toolchain files to reality

apol added a comment. Applications can still override it, note it's a default. Also note this: https://developer.android.com/distribute/best-practices/develop/target-sdk REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19016 To: vkrause, apol Cc:

D19332: KProcess compile fix for obsolete QProcess members in 5.13

apol added inline comments. INLINE COMMENTS > kprocess.h:332 > // hide those > +#if (QT_VERSION < QT_VERSION_CHECK(5, 13, 0)) > using QProcess::setReadChannelMode; Also should check for QT_DISABLE_DEPRECATED_BEFORE no? REPOSITORY R244 KCoreAddons REVISION DETAIL

D19338: New location for KNSRC files

leinir created this revision. leinir added reviewers: KNewStuff, apol, ngraham, fvogt. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This introduces a cmake

D19338: New location for KNSRC files

leinir added a dependent revision: D19340: Search new knsrc locations. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19339: Add option to change drive label to places panel context menu

ngraham added a comment. Yeah, it would be nice to get this into KIO's own Places Panel model instead so it can be done from any KDE app with a Places Panel. +1 for the feature though! Also screenshots are appreciated. :)

D19319: make it compile without foreach

apol added a comment. Looks odd, it's not necessary any changes? INLINE COMMENTS > kpty.cpp:88 > public: > -virtual void setupChildProcess() override > +void setupChildProcess() override > { Unrelated? Commit separately. REPOSITORY R291 KPty REVISION DETAIL

D19339: Add option to change drive label to places panel context menu

chinmoyr created this revision. chinmoyr added reviewers: Dolphin, Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. chinmoyr requested review of this revision. REVISION SUMMARY Uses org.freedesktop.UDisks2 dbus service for changing drive label. REPOSITORY

D19335: [kdoctools] make it compile without foreach

mlaurent added a comment. oops indeed. I landed it and forgot to git pull :) I will close it now :) REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19335: [kdoctools] make it compile without foreach

mlaurent abandoned this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19339: Add option to change drive label to places panel context menu

chinmoyr planned changes to this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19339 To: chinmoyr, #dolphin, #frameworks Cc: broulik, ngraham, bruns, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D19317: compile without foreach

apol added inline comments. INLINE COMMENTS > pic.cpp:391 > m_description.clear(); > -QStringList entries = > value.toString().split(QStringLiteral("\n\n")); > -Q_FOREACH(const QString entry, entries) { > +const QStringList entries = >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 01:34:32 + Build duration: 6 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 05:51:58 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

D12336: Replace several Q_ASSERTs with proper checks

bruns added a comment. In D12336#333853 , @apol wrote: > If it was silently corrupting the DB maybe the right solution would have been to integrate baloo properly with KCrash. > Like @sitter did in https://phabricator.kde.org/D15573.

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/28/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Feb 2019 06:18:34 + Build duration: 3 min 32 sec and counting BUILD ARTIFACTS

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

loh.tar added a comment. To my surprise are two test fail. SearchBarTest::testFindNextIncremental() SearchBarTest::testSetMatchCaseIncremental() Doing the same by hand looks OK...hm REVISION DETAIL https://phabricator.kde.org/D19367 To: loh.tar, #ktexteditor Cc: kwrite-devel,

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

nibags added a comment. The MustacheJS highlight is modified in this diff: D19328 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18951 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D19317: compile without foreach

mlaurent updated this revision to Diff 52700. mlaurent added a comment. Use auto as requested REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19317?vs=52559=52700 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19317: compile without foreach

mlaurent added inline comments. INLINE COMMENTS > apol wrote in pic.cpp:391 > Probably could do a splitRef here it seems that we can't use it. As it will return a list of QStringRef and we want to use "simplified() on a QStringRef which doesn't exist REPOSITORY R287 KImageFormats REVISION

D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19328 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19324: Add code-oss icon

ndavis added a comment. You also need to optimize the SVG. You can do that by using one of the three SVG optimizers on this page: https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow#svg-optimization I should add that to the HIG at some point in the future. REPOSITORY R266

D19324: Add code-oss icon

ndavis added a comment. I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it? This looks just about ready to land on the master branch, there are just a few more things you need to

D19319: make it compile without foreach

mlaurent updated this revision to Diff 52699. mlaurent added a comment. Remove not necessary change REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19319?vs=52561=52699 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Feb 2019 06:18:34 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Feb 2019 01:40:37 + Build duration: 43 sec and counting JUnit Tests Name: projectroot

D19332: KProcess compile fix for obsolete QProcess members in 5.13

marten created this revision. marten added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY The functions QProcess::setReadChannelMode() and QProcess::readChannelMode() are

D18793: Handle text completion with block selection mode

loh.tar added a comment. Fix this patch also Bug 382213 ? - do not do auto-brackets when block mode is enabled Well, bad title/request. I would expect that each line get the bracket. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18793 To: ahmadsamir,

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY When the document is very big and there is no early match

D18793: Handle text completion with block selection mode

ahmadsamir updated this revision to Diff 52658. ahmadsamir added a comment. Change replaceText to handle inserting word completion with block selection mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18793?vs=51051=52658 BRANCH

D18793: Handle text completion with block selection mode

ahmadsamir added a comment. I changed the diff to make replaceText handle inserting the word completion text. Is this a new behaviour? it exactly matches what users expect when they type something in block selection mode. Also why would this be opt-in? if you type something in

D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg

axionl added a comment. I make a mistake to create a new revision, please delete this one. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19380 To: axionl Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:195 > I wanted to do so first, but that will require to also put the PropertyMap > into the extractAsfTags method, which I think is not worth it. lstASF = asfTags->attribute("WM/Writer"); ... The existing

D18915: Fix batchrename changing extension to lower case

bruns added inline comments. INLINE COMMENTS > batchrenamejob.cpp:160 > > +//The function QMimeDatabase.suffixForFileName always converts the extension > to lower case > +//This function is a wrapper which avoids the coversion to lower case Space after `//` > batchrenamejob.cpp:161 > +//The

D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg

bruns added a comment. Just "Abandom" it, at the very bottom of the page ("Add Action..."). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19380 To: axionl Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D19324: Add code-oss icon

axionl updated this revision to Diff 52696. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 : Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg

axionl abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19380 To: axionl Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D16579: Remove support for non-standard APE tag field names

astippich added a comment. In D16579#418256 , @smithjd wrote: > > Anyway, most of this special handling of mimetypes goes away with D18826 , where TagLib will do the conversion automatically. > > The test

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52679. astippich added a comment. - remove now unnecessary include REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=52675=52679 BRANCH rewrite_taglib_extractor REVISION DETAIL

D19367: [RFC]SearchBar: Don't block GUI when enter incremental pattern

loh.tar updated this revision to Diff 52669. loh.tar added a comment. - Fix my test chunkSize to some real value CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19367?vs=52660=52669 REVISION DETAIL https://phabricator.kde.org/D19367 AFFECTED FILES src/search/katesearchbar.cpp

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52675. astippich added a comment. - return early if map is empty REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=51128=52675 BRANCH rewrite_taglib_extractor REVISION DETAIL

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > smithjd wrote in taglibextractor.cpp:195 > Can this be moved into the asf-specific extractions? I wanted to do so first, but that will require to also put the PropertyMap into the extractAsfTags

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added a comment. I get the feeling that we need to discuss how the PropertyMap should look like and how we achieve a seamless transition in a backwards compatible way. I have slowly been working to resolve T8196 , which is why I am so insisting.

D19371: Tags ioslave: Do not crash for the "tags:/" URL

marten created this revision. marten added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. marten requested review of this revision. REVISION SUMMARY Bug https://bugs.kde.org/show_bug.cgi?id=400594 was fixed by

T3689: Add abi compliance checker to CI

knauss added a revision: D19374: create-abi-dump: set logging for paramiko.transport to WARNING. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19377: check-abi: refactor script. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19376: remove unnessary include.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19375: check-abi: make it possible to break the build.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D19328: MustacheJS: also highlight template files, fix syntax and improve support for Handlebars

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. No objections from my side. Thanks. REPOSITORY R216 Syntax Highlighting BRANCH update-mustache REVISION DETAIL https://phabricator.kde.org/D19328 To: nibags,

D19371: Tags ioslave: Do not crash for the "tags:/" URL

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19371 To: marten, #baloo, ngraham Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18915: Fix batchrename changing extension to lower case

cfoster updated this revision to Diff 52691. cfoster added a comment. - Add function for getting extension All unit tests pass Manually tested invalid extensions. Files with no extensions and files with upper and lower case extensions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D19380: # Enter a commit message. # # Changes: # # icons-dark/apps/48/code.svg # icons/apps/48/code.svg

axionl created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. axionl requested review of this revision. REVISION SUMMARY Tyr to fix the layer and the shadow REPOSITORY R266 Breeze Icons BRANCH code-oss REVISION DETAIL