D19691: ViewInternal: Review drop event

loh.tar updated this revision to Diff 53702. loh.tar retitled this revision from "[WIP] ViewInternal: Review drop event" to "ViewInternal: Review drop event". loh.tar edited the summary of this revision. loh.tar added a comment. - Fix cursor position after undo...harr - Improve readability

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim planned changes to this revision. bonghyunkim added a comment. I finally got some time to install various dependencies to set up the tests and run them, but three tests keep failing. They are: folding_test, testhighlighter_test, htmlhighlighter_test. The error message is

D19696: Add blender thumbnailer

ltoscano added a comment. I have my usual question: shouldn't this go into kdegraphics-thumbnailers? kio-extras shouldn't be a "dump everything which is not somewhere else". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc:

D19697: Fixes the build failure when using ECM Android toolchain

apol added a comment. Maybe it would make more sense to remove them instead? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When changing an `IconItem` from using a local image (e.g. PNG file) to using a

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

dfaure added a comment. I must be missing something. How can a job "examine the real destination" without having the URL of the destination? Is there some redirection happening or something? REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19583 To:

D19677: Port UDisks to using DBus ObjectManager

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Right now it introspects DBus and fetches properties all over the place.

D19677: WIP: Port UDisks to using DBus ObjectManager

broulik retitled this revision from "Port UDisks to using DBus ObjectManager" to "WIP: Port UDisks to using DBus ObjectManager". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D19677 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. The change was ack'ed in this review, and this review closed by the commit. There was no code that required further review, only binary changes. The posted concerns were addressed by D18826 . If you really are that

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2404693b9975: [CopyJob] Treat URL as dirty when renaming file as conflict resolution (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 10:40:45 + Build duration: 12 min and counting BUILD ARTIFACTS

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik added a comment. Isn't "where the job first has to examine the real destination and only can then set it and start." and "In plasma-browser-integration I only get the destination after the job has been started." sufficient? REPOSITORY R288 KJobWidgets REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/56/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Mar 2019 10:40:45 + Build duration: 9 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Mar 2019 10:40:45 + Build duration: 10 min and counting BUILD ARTIFACTS

D19672: [knewstuff] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R304 KNewStuff

D16579: Remove support for non-standard APE tag field names from the test files

mgallien added a comment. In D16579#428835 , @smithjd wrote: > The change was ack'ed in this review, and this review closed by the commit. > > There was no code that required further review, only binary changes. The posted concerns were

Re: KDE Frameworks 5.56.0 released

On lundi 11 mars 2019 08:43:27 CET Kai Uwe Broulik wrote: > Hi, > > > KItemModels > > > >KRearrangeColumnsProxyModel: make the two column-mapping methods public > > I thought that was not allowed? According to [1]: > > You cannot... > * For existing functions of any type: > ** change its

D19681: IconBorder: Accept drag events

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ..and forward them to KateViewInternal. This way is dropping

D19672: [knewstuff] make it compile without foreach

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19672 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19674 To: broulik, #plasma, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19674: [Icon Item] Also clear image icon when using Plasma Svg

This revision was automatically updated to reflect the committed changes. Closed by commit R242:017954185c83: [Icon Item] Also clear image icon when using Plasma Svg (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19679: Support image/vnd.zbrush.pcx mime type

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f74cec16ec01: Support image/vnd.zbrush.pcx mime type (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19679?vs=53647=53648#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D19677: WIP: Port UDisks to using DBus ObjectManager

bruns added a comment. +10 on porting to ObjectManager Will do a proper review later REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D19677 To: broulik, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19679: Support image/vnd.zbrush.pcx mime type

broulik created this revision. broulik added reviewers: Frameworks, elvisangelaccio. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `image/x-pcx` is deprecated TEST PLAN I now

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah! See that's the information I was missing (download job + user chooses interactively). In KIO we typically ask for a dest first, and only then start a job. If you could add a word

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

broulik added a comment. In plasma-browser-integration I get a download started event by the browser right away and only when the user chose a download location I will get notified of that, so the job does not have a `destUrl` in the beginning. REPOSITORY R288 KJobWidgets REVISION DETAIL

D19672: [knewstuff] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R304:20870ce8cc79: [knewstuff] make it compile without foreach (authored by mlaurent). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19672?vs=53633=53650 REVISION

D19672: [knewstuff] make it compile without foreach

leinir accepted this revision. leinir added a comment. Looks good to me... None of the scary ones that'll trigger various nasty side effects as far as i can tell. REPOSITORY R304 KNewStuff BRANCH compile_without_foreach (branched from master) REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/45/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Mar 2019 12:28:25 + Build duration: 2 min 24 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Mar 2019 12:28:25 + Build duration: 7 min 49 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/41/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 12:28:25 + Build duration: 8 min 3 sec and counting BUILD ARTIFACTS

D19679: Support image/vnd.zbrush.pcx mime type

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19679 To: broulik, #frameworks, elvisangelaccio, apol Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun,

D16579: Remove support for non-standard APE tag field names from the test files

bruns added a comment. The change, as you pushed it, was never open for review, so there was not even the chance to review. The new test files change the tested tag from one allowed variant to another. Both variants exist in the wild, and you changed the test coverage to the one you

D19683: autotests: use new signal failedToLoad in ProviderTest

dfaure created this revision. dfaure added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is an attempt to improve error handling to fix CI failures TEST PLAN Running the

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart edited the summary of this revision. mart added a reviewer: Frameworks. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19683: autotests: use new signal failedToLoad in ProviderTest

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This does seem very much sensible, yes, well thought :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D19683 To: dfaure, leinir Cc:

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. F6684042: Screenshot_20190311_162844.png F6684047: Screenshot_20190311_164519.png F6684051: Screenshot_20190311_164524.png REPOSITORY R302

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. @trickyricky26 do you mind if I commandeer this so I can get it finished today? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19683: autotests: use new signal failedToLoad in ProviderTest

dfaure closed this revision. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D19683 To: dfaure, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.10 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.10/11/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 16:49:15 + Build duration: 8 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 09 Mar 2019 09:40:04 + Build duration: 2 days 5 hr and counting

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY when the flag AA_UseHighDpiPixmaps is set, the pixmap is already scaled, no need to scale it

D19696: Add blender thumbnailer

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This extracts thumbnail from .blend files. Before:

D19696: Add blender thumbnailer

chinmoyr edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam created this revision. Herald added a project: Frameworks. sh-zam requested review of this revision. REVISION SUMMARY ECM Android toolchain: https://phabricator.kde.org/source/extra-cmake-modules/browse/master/toolchain/Android.cmake Build failure log:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Mar 2019 17:10:34 + Build duration: 7 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Mar 2019 17:10:34 + Build duration: 20 min and counting JUnit Tests Name:

D19652: Add cross-compilation support for kpackagetool5

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d32f2d4e5ab2: Add cross-compilation support for kpackagetool5 (authored by vkrause). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19652?vs=53590=53680 REVISION

D19692: openwithdialog: use recursive flag in proxy filter

simgunz created this revision. simgunz added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. simgunz requested review of this revision. REVISION SUMMARY Use the flag introduced in Qt 5.10 instead of custom code REPOSITORY R241 KIO

D19418: Make it compiles without deprecated method

arojas added a comment. This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol Cc: arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D19691: [WIP] ViewInternal: Review drop event

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Fix wrong selection when text is moved down - Allow drop

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/15/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 17:10:34 + Build duration: 3 min 49 sec and counting BUILD ARTIFACTS

D19313: Remove URLs being fetched when listing job is `completed`

dpalacio added a comment. Yes, all kdirmodel tests pass REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio, #frameworks, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19313: Remove URLs being fetched when listing job is `completed`

dpalacio closed this revision. dpalacio added a comment. I regained write access and I committed it myself. Sorry for the noise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio, #frameworks, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh,

D19575: Add collapse-all and expand-all action icons

trickyricky26 added a comment. Sure, go ahead. I'm busy right now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/53/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 20:27:42 + Build duration: 23 min and counting BUILD ARTIFACTS

D19691: [WIP] ViewInternal: Review drop event

loh.tar added a comment. > Cursor is wrong placed after undo I'm confused. Can't see how that has worket before this patch. I tend to add a cursor info to the m_dragInfo struct. Reset to that position just before editStart() REPOSITORY R39 KTextEditor REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

broulik added a comment. I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt,

D19313: Remove URLs being fetched when listing job is `completed`

dpalacio added a comment. Could you commit this patch in my stead? I don't have commit access. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio, #frameworks, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

ngraham added a comment. Sweet, this makes so many things look a little bit better. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Mar 2019 20:27:42 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/57/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Mar 2019 20:27:42 + Build duration: 6 min 37 sec and counting JUnit Tests Name:

D19681: IconBorder: Accept drag events

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks ok to me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19681 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel,

D19692: openwithdialog: use recursive flag in proxy filter

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH openwithdialog-recursive-filtering REVISION DETAIL https://phabricator.kde.org/D19692 To: simgunz, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE Frameworks 5.56.0 released

El dilluns, 11 de març de 2019, a les 9:26:43 CET, David Faure va escriure: > On lundi 11 mars 2019 08:43:27 CET Kai Uwe Broulik wrote: > > Hi, > > > > > KItemModels > > > > > >KRearrangeColumnsProxyModel: make the two column-mapping methods public > > > > I thought that was not allowed?

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. In D16579#428993 , @bruns wrote: > The change, as you pushed it, was never open for review, so there was not even the chance to review. Diff 44708 included these changes for review. No one requested changes then,

D19575: Add collapse-all and expand-all action icons

ndavis commandeered this revision. ndavis edited reviewers, added: trickyricky26; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, trickyricky26 Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19665: Add Q_OBJECT to KFilterDev

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19665 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19666: Remove reference from const KConfigIniBackend::BufferFragment

aacid closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19666 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 11 Mar 2019 22:38:17 + Build duration: 6 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/19/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 11 Mar 2019 22:38:17 + Build duration: 11 min and counting BUILD ARTIFACTS

D19668: Convert two old-style connects to new-style

This revision was automatically updated to reflect the committed changes. Closed by commit R271:1ed358b9022e: Convert two old-style connects to new-style (authored by aacid). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19668?vs=53627=53695 REVISION

D19667: Add Q_EMIT to emit signal call

This revision was automatically updated to reflect the committed changes. Closed by commit R244:a37f2df41a03: Add Q_EMIT to emit signal call (authored by aacid). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19667?vs=53626=53694 REVISION DETAIL

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 11 Mar 2019 22:38:17 + Build duration: 4 min 50 sec and counting BUILD ARTIFACTS