KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/20/ Project: kf5-qt5 AndroidQt5.12 Date of build: Sat, 13 Apr 2019 10:01:13 + Build duration: 3 min 14 sec and counting

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. 5.57 released, should ne tried now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund,

D20426: Improve "widget-alternatives" icon

ndavis added a comment. Can you flip the direction of the 16px version? I know the icon you're copying the design of is also like this, but I think it needs to be fixed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: ndavis,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/82/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 09:59:28 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/35/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 09:57:52 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 10:01:26 + Build duration: 24 min and counting BUILD ARTIFACTS

D20503: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20503 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:01:26 + Build duration: 29 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:01:53 + Build duration: 34 min and counting JUnit Tests Name: projectroot

D20426: Improve "widget-alternatives" icon

GB_2 updated this revision to Diff 56127. GB_2 added a comment. Flip 16px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=56111=56127 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20426 AFFECTED FILES

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/73/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 10:03:39 + Build duration: 51 min and counting BUILD ARTIFACTS

D20426: Improve "widget-alternatives" icon

GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20426 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 10:01:37 + Build duration: 1 hr 56 min and counting JUnit Tests Name:

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in globaltest.cpp:110 > qAsConst? I guess QFETCH doesn't make the variables const. indeed. > dfaure wrote in kdirmodel.cpp:263 > qAsConst Ah yep I thought that it was the args from method. I will fix it soon REPOSITORY R241 KIO

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. Yep, but extracting changelogs from commit logs can be mostly automated, including filtering out many commits with the same first line. It's what I do in `g...@git.kde.org:sysadmin/release-tools` branch `frameworks/5.0` file `parse_changelogs.pl`. But yeah, if

KDE CI: Frameworks » attica » kf5-qt5 SUSEQt5.12 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20SUSEQt5.12/20/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 09:56:57 + Build duration: 3 min 12 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 09:58:22 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 09:58:50 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 09:58:22 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 09:59:03 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D20503: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20503 AFFECTED FILES src/karchive.cpp

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 09:57:06 + Build duration: 18 min and counting BUILD ARTIFACTS

D20503: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths

aacid added a subscriber: security-team. aacid added a comment. Discussed this initially with security@ This seems to be a good enough solution unless someone wants to rewrite the function to not be recursive REPOSITORY R243 KArchive REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/81/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 09:59:28 + Build duration: 15 min and counting JUnit Tests Name:

D20503: "Fix" KArchive::findOrCreate running out of stack on VERY LONG paths

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20503 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, michaelh,

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for this contribution. What you did with member variables in the unittest, is generally done with data-driven testing instead -- which I find preferable, better

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:02:13 + Build duration: 37 min and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 10:03:51 + Build duration: 35 min and counting BUILD ARTIFACTS

D20426: Improve "widget-alternatives" icon

GB_2 added a comment. In D20426#449101 , @ndavis wrote: > Can you flip the direction of the 16px version? I know the icon you're copying the design of is also like this, but I think it needs to be fixed. Ok, will do that here. The other

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. Any new feedback ? @fvogt @bruns @dfaure ? REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel,

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu,

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/76/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 09:59:28 + Build duration: 56 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/86/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 10:00:20 + Build duration: 58 min and counting BUILD ARTIFACTS

D20489: [KIO] Make it compile without foreach (Step 1)

cgiboudeaux added a comment. In D20489#449133 , @dfaure wrote: > cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:02:42 + Build duration: 57 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 10:01:26 + Build duration: 1 hr 2 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 10:00:20 + Build duration: 1 hr 5 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:02:54 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

D12222: baloodb: Use complete access filtering for all outputs

astippich added a comment. Herald added a subscriber: kde-frameworks-devel. @bruns this still applies cleanly to current master, do you think this and the dependent revision are still worth it to merge? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 10:02:42 + Build duration: 1 hr 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/52/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 10:00:03 + Build duration: 1 hr 17 min and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/66/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 10:03:38 + Build duration: 1 hr 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 10:02:54 + Build duration: 1 hr 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/76/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:03:38 + Build duration: 1 hr 18 min and counting JUnit Tests

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 10:04:04 + Build duration: 1 hr 26 min and counting JUnit Tests Name:

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

fvogt accepted this revision. fvogt added a comment. Code still looks good to me - I can't comment on the cmake parts though. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc:

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/82/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 13 Apr 2019 12:52:46 + Build duration: 1 min 18 sec and counting JUnit Tests Name:

D20358: Force en locale for propertyinfotest

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ccc0e0b9238e: Force en locale for propertyinfotest (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=56002=56134 REVISION

D20426: Improve "widget-alternatives" icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I can't think of any more suggestions that would be an obvious improvement, so I'll accept this. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/83/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 12:52:46 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 12:52:46 + Build duration: 2 min 24 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 13:31:01 + Build duration: 6 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 171 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/171/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 10:04:25 + Build duration: 3 hr 37 min and counting JUnit

D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

dfaure created this revision. dfaure added a reviewer: cfeck. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY This isn't a tree model. QAbstractTableModel's

D19511: ViewPrivate: Disable read-only mode action when doc is modified

loh.tar abandoned this revision. loh.tar added a comment. To relieve the maintainer it's droped now. But I still have the feeling there could be something improved at these "Read-Only Stuff" REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar,

D20489: [KIO] Make it compile without foreach (Step 1)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f482d8981b0: [KIO] Make it compile without foreach (Step 1) (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20489?vs=56136=56150 REVISION

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent edited the summary of this revision. REPOSITORY R241 KIO BRANCH port_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20515: KCharSelect: add unittest. Hits the assert in QHeaderView.

dfaure created this revision. dfaure added a reviewer: cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Just creating a KCharSelect instance was hitting that QHeaderView bug. A unittest is a

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Apr 2019 01:19:14 + Build duration: 3 min 37 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 14 Apr 2019 01:19:14 + Build duration: 2 min 25 sec and counting JUnit Tests Name:

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added a comment. In D20513#449484 , @ngraham wrote: > Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506? > > Not that the current UX is that great... Baloo in

D20523: Remove a dead declaration

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY There is no implementation and obviously no users REPOSITORY R824 Baloo Widgets BRANCH cleanup REVISION

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns created this revision. bruns added reviewers: Baloo, Dolphin, Frameworks, ngraham, astippich. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY Instead of opening an additional dialog, allow selection and deselection of visible properties directly

D20515: KCharSelect: add unittest. Hits the assert in QHeaderView.

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20515 To: dfaure, cfeck, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20284: Fix l/100 km to MPG conversion

aacid added inline comments. INLINE COMMENTS > convertertest.cpp:71 > +v = c.convert(v, QStringLiteral("l/100 km")); > +QCOMPARE(v.number(), 8.0); > } Could you please also add a test where the initial value is in say MPG and then we have the conversion to liters/100km, mpgi and l/100

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. GIT_SILENT is "trivial, don't look at the commit" -- at least it used to be. Not really applicable to commits such as this one REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: aacid, cgiboudeaux,

D20519: Fix double delete on broken files

aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20519 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. I view the KF5 changelog as the list of things that can be useful to the users of the frameworks (i.e. application developers). When we add API, fix a bug, or change dependencies, that's useful for them to know. When we repair a unittest, fix typos in comments,

D20519: Fix double delete on broken files

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY findOrCreate has some code that tries to recover broken files. That code will delete an empty file if later it looks

D20489: [KIO] Make it compile without foreach (Step 1)

aacid added a comment. In D20489#449216 , @dfaure wrote: > FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of

D20489: [KIO] Make it compile without foreach (Step 1)

aacid added a comment. h, ok, i don't know why we wouldn't want things like this to now show in the autogenerated changelog, but ok, your call :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: aacid, cgiboudeaux,

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

lbeltrame added reviewers: apol, vkrause. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20508: [udisks2] fix media change detection for external optical drives

bugseforuns added a comment. I'm not a software developer, but I applied Rok's patch on Arch Linux and it fixes the problem when unmounting/releasing ISO images. Operating System: Arch Linux KDE Plasma Version: 5.15.4 KDE Frameworks Version: 5.57.0 Qt Version: 5.12.2 REPOSITORY

D20513: Remove last traces of KFileMetaDataWidget from information panel

ngraham added a comment. Won't this close the door on ever being able to implement something like https://bugs.kde.org/show_bug.cgi?id=406506? Not that the current UX is that great... REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns,

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns accepted this revision. bruns added a comment. I think its better go give it sufficient testing time than to wait for more comments. The code has been around for sufficient time, and the last changes were just minor. Thanks for working on this! REPOSITORY R241 KIO BRANCH

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f3b0f220a78d: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc = 2.28 (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55967=56137

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam created this revision. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Don't include same dependency twice, one which was found from `readelf` in `specifydependencies.cmake` and

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam updated this revision to Diff 56151. sh-zam added a comment. minor typo fixed REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56146=56151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 AFFECTED FILES

D19450: DocumentPrivate: Respect indention mode when block selection

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson,

D19450: DocumentPrivate: Respect indention mode when block selection

cullmann added a comment. Just had not looked at this. Looks reasonable, please push that. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad,

D20426: Improve "widget-alternatives" icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d1ccdfcac565: Improve widget-alternatives icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20426?vs=56127=56135 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#449198 , @bruns wrote: > Thanks for working on this! I am very glad :) Thank you for your great reviews. I learned quite a bit along the way. REPOSITORY R241 KIO REVISION DETAIL

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY QQuickItem already has a "smooth" property, which was

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added a reviewer: Dolphin. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D18824: Implement wl_eglstream_controller Server Interface

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. Don't forget to add the isValid check to the KWin patches now. Maybe also add a comment to the KWayland code, what's the reason for the separate create() call and that we want to

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 257 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/257/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 13:31:01 + Build duration: 14 min and counting CONSOLE OUTPUT

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cfb0af25bdfa: ViewInternal: Fix makeVisible(..) (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17857?vs=53252=56144 REVISION DETAIL

D20508: frameworks-solid: udisks2: fix media change detection for external optical drives

rokmandeljc created this revision. rokmandeljc added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rokmandeljc requested review of this revision. REVISION SUMMARY If an external optical drive is connected to system after Solid does its initial introspection, the

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 13:31:01 + Build duration: 7 min 29 sec and counting BUILD ARTIFACTS

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. There is still a couple raw QT_LSTAT in KFileItem https://cgit.kde.org/kio.git/tree/src/core/kfileitem.cpp#n224 . Do you think we should apply the same kind of solution there, with #idef ? I would be in favor of reusing code instead. Eventually moving

D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

pino added a comment. Shouldn't the same applied to `columnCount` too? REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20506 To: dfaure, cfeck Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

This revision was automatically updated to reflect the committed changes. Closed by commit R236:794d10a834a7: KCharSelects internal model: ensure rowCount() is 0 for valid indexes (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20506?vs=56138=56140#toc REPOSITORY

D20506: KCharSelect's internal model: ensure rowCount() is 0 for valid indexes

dfaure added a comment. It's common to say "I have 3 columns everywhere", that's what tree models look like. And if you have zero rows somewhere, it doesn't matter how many columns you have, that's still "nothing". REPOSITORY R236 KWidgetsAddons REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 258 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/258/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 13 Apr 2019 16:27:47 + Build duration: 4 min 1 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/88/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 13 Apr 2019 16:27:47 + Build duration: 7 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 13 Apr 2019 16:27:47 + Build duration: 22 min and counting BUILD ARTIFACTS

D12295: Supporting nested brackets for Kate autobrackets

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: cullmann, #ktexteditor, #kate, dhaumann, brauch, sraizada Cc: loh.tar, brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, michaelh,

D12295: Supporting nested brackets for Kate autobrackets

cullmann commandeered this revision. cullmann edited reviewers, added: sraizada; removed: cullmann. cullmann added a comment. We close this in favor of the other patches. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: cullmann, #ktexteditor, #kate,

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns created this revision. bruns added reviewers: Frameworks, apol, ngraham. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. bruns requested review of this revision. REVISION SUMMARY The whole information panel is not included when Baloo is not found, so there is no

  1   2   >