D24431: Restore cursor thumbnailer

broulik planned changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D24657: Add support for _GTK_FRAME_EXTENTS

ngraham added a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24665: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KArchive to hide deprecated API up to a given version or silence deprecation

D24665: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added reviewers: Frameworks, dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24665: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Created patch manually here, arc claims: stag...@git.kde.org: Permission denied (publickey). not yet reached sysadmin to tell what could be the issue. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To: kossebau,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

meven updated this revision to Diff 67981. meven marked an inline comment as done. meven added a comment. Avoid else after continue; REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21204?vs=65955=67981 BRANCH arcpatch-D21204 REVISION DETAIL

D23760: Create new "Recent folders" icon

meven added a comment. Any plans on updating this icon ? I think we talked about it but I can't remember the conclusion. F7600623: Screenshot_20191015_161452-2.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23760

D23760: Create new "Recent folders" icon

ngraham added a comment. In D23760#547560 , @meven wrote: > Any plans on updating this icon ? > I think we talked about it but I can't remember the conclusion. > F7600623: Screenshot_20191015_161452-2.png

D24468: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R236:b935a737eda7: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24468?vs=67737=67985#toc REPOSITORY R236

D24678: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Plasma, mart, davidedmundson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to Plasma to hide

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ltoscano added a comment. In D24477#547779 , @ndavis wrote: > For some reason, Arc made me the committer and the author instead of just the committer. Maybe because patches sent through the phabricator web interface have no authorship

D24621: [RFC] New Konsole and Yakuake icons

ngraham added a comment. I really like the Yakuake icon that has a subtle "Y" in it. If everyone else does too, maybe that should be moved into a separate patch so we can get it in quickly and then concentrate on the Konsole icon. Personally I'm not 100% sold on integrating the bottom

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ahmadsamir added a comment. In D24672#547744 , @mkoller wrote: > why ? > I don't like lots of these changes. Because it doesn't follow the KDE coding style, AFAICS (and changing it to use that common style will make it easier for

D24681: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KNewStuff to hide deprecated API up

D24678: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. EXCLUDE_DEPRECATED_BEFORE_AND_AT needs to be implemented by someone who has overview of internals, if wanted. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24678 To: kossebau, #plasma, mart, davidedmundson, apol Cc:

D24665: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24665#547727 , @bcooksley wrote: > As part of the transition to Gitlab, Sysadmin removed the staging repositories which a few Phabricator repositories had been configured to use. > > That error can be ignored.

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

ndavis added a comment. For some reason, Arc made me the committer and the author instead of just the committer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham,

D24667: Activate when both associatedWidget and menu are null

kmaterka created this revision. kmaterka added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision. REVISION SUMMARY If associatedWidget and menu are the same then instead of "activate"

D24671: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Given all the `KPACKAGE_*` macros are public, they should be consistently in the namespace, so for that purpose I also simply changed the BASE_NAME of the export macros. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau,

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The KSslErrorUiData variant below covers KTcpSocket too as a source for errors, next to QSslSocket/QNAM. Also,

D24681: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT, as some deprecated API is still used internally, so this needs more clean-up by someone(tm) first. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D24681 To: kossebau, #frameworks, leinir

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

mkoller requested changes to this revision. mkoller added a comment. This revision now requires changes to proceed. why ? I don't like lots of these changes. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel, mkoller

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

cullmann added a comment. As an non-framework module, there is no need to follow the frameworks style, if not wanted. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel, mkoller Cc: cullmann, ognarb, kde-frameworks-devel

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ognarb added a comment. Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214 ? REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: ognarb,

D24673: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Plasma, mart, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KDeclarative to hide deprecated

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

cfeck added a reviewer: mkoller. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel, mkoller Cc: ognarb, kde-frameworks-devel

D24667: Activate when both associatedWidget and menu are null

kmaterka added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:619 > > -if (d->associatedWidget == d->menu) { > +if (d->associatedWidget && d->associatedWidget == d->menu) { > d->statusNotifierItemDBus->ContextMenu(pos.x(), pos.y()); This should fix a situation

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 AFFECTED FILES

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

vkrause added a task: T11544: Remove KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24675 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove added a comment. In D24593#546586 , @filipf wrote: > > b) radial gradients instead of linear on the four sides to make the center darker than the angles. > > Other than this, they look great to me. I think they should be uniformly

D24665: Use ECMGenerateExportHeader to manage deprecated API better

bcooksley added a comment. As part of the transition to Gitlab, Sysadmin removed the staging repositories which a few Phabricator repositories had been configured to use. That error can be ignored. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 15 Oct 2019 14:33:12 + Build duration: 1 min 7 sec and counting JUnit Tests Name:

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ahmadsamir added a comment. T11214 is still being discussed, and we can always run clang-format later on. And uncrustify-kf5 has been used before on some of the KDE repos, so it's sort of have been fine-tuned a bit to KDE. Anyway, I don't mind

D24671: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67991. kossebau added a comment. keep the current filename of the export header file REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24671?vs=67990=67991 BRANCH useECMGenerateExportHeader REVISION DETAIL

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ahmadsamir added a task: T11576: Port kolourpaint away from kdelibs4support. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: kde-frameworks-devel

D24671: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, Plasma, mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KPackage to hide

D24667: Activate when both associatedWidget and menu are null

kmaterka added reviewers: broulik, nicolasfella. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

ahmadsamir added a reviewer: kde-frameworks-devel. ahmadsamir added a subscriber: kde-frameworks-devel. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel Cc: kde-frameworks-devel

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24675 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: Activate when both associatedWidget and menu are null

kmaterka added a comment. This fixes issue from first comment made by @davidedmundson . Second is still not fixed. Let me copy it here: > We have one menu for the whole tray instance >

D24537: Icons for windy weather

ngraham added a comment. I don't mind the cyan myself, though I'll admit my wife (who is an artist) commented on it negatively when I showed it to her. Perhaps make it a bit bluer and then we can get these nice icons in. I'd rather not bikeshed for too long on them. :) REPOSITORY R266

D24497: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68010. kossebau added a comment. update to latest master with new deprecated method REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24497?vs=67736=68010 BRANCH useECMGenerateExportHeader REVISION DETAIL

D24682: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, vkrause. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCalendarCore to hide deprecated API up to a given version or silence deprecation warnings after a given version, using

D24681: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R304 KNewStuff BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24681 To: kossebau, #frameworks, leinir, mlaurent Cc:

D24497: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me REPOSITORY R265 KConfigWidgets BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24497 To: kossebau, #frameworks, mlaurent Cc:

D24682: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > recurrence.h:149 > > +#if KCALENDARCORE_BUILD_DEPRECATED_SINCE(5, 64) > /** Only using `KCALENDARCORE_BUILD_DEPRECATED_SINCE` here and not `KCALENDARCORE_ENABLE_DEPRECATED_SINCE`, because we have no idea yet how all compilers would deal

D24537: Icons for windy weather

cblack updated this revision to Diff 68008. cblack added a comment. Colour changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=67874=68008 BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

cblack updated this revision to Diff 68009. cblack added a comment. Remove excess icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68008=68009 BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24665: Use ECMGenerateExportHeader to manage deprecated API better

bcooksley added a comment. I've now removed the Staging Area URI for the KArchive repository, so you should now be able to use Arcanist with it again. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To: kossebau, #frameworks, dfaure Cc: bcooksley,

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

dfaure added a comment. Looks fine, but a bit verbose. Maybe we could have configValue() overloads (in SlaveBase) for bool, int and QString, to cover the most common use cases? - mapConfig().value(QStringLiteral("MaxCacheAge"), DEFAULT_MAX_CACHE_AGE).toInt(); +

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19504 To: habacker, dfaure, vkrause Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

dfaure accepted this revision. dfaure added a comment. Looks fine, but it seems that the uploaded diff is only the delta compared to the previous diff, not the overall change. Anyhow, feel free to push both. REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL

D24643: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24643 To: kossebau, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks, ngraham, dfaure Cc: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel, LeGast00n,

D24651: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24651 To: kossebau, #frameworks, mirko, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/136/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 15 Oct 2019 07:14:46 + Build duration: 34 min and counting JUnit Tests Name: projectroot

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67943. meven added a comment. Add configValue overloads to simplify code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67772=67943 BRANCH arcpatch-D24582 REVISION DETAIL https://phabricator.kde.org/D24582

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a497d47c45a5: [SlaveBase] Use QMap instead of KConfig to store ioslave config (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23523?vs=67763=67940#toc REPOSITORY R241

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added a comment. In D23523#547265 , @dfaure wrote: > Looks fine, but it seems that the uploaded diff is only the delta compared to the previous diff, not the overall change. Anyhow, feel free to push both. It was on purpose to have

D24655: give all pointers in slavebase a default init to nullptr

sitter created this revision. sitter added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY lest they don't get initialized and then end up crashing should get get deleted

D24655: give all pointers in slavebase a default init to nullptr

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24655 To: sitter, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24655: give all pointers in slavebase a default init to nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2bd18f17e61: give all pointers in slavebase a default init to nullptr (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24655?vs=67944=67947

D24656: [SlaveBase] Prevent crash by properly initializing Kconfig objects

meven created this revision. meven added reviewers: Frameworks, vkrause, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY As suggested at

D24656: [SlaveBase] Prevent crash by properly initializing Kconfig objects

meven abandoned this revision. meven added a comment. Superseeded by https://phabricator.kde.org/D24655 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24656 To: meven, #frameworks, vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24655: give all pointers in slavebase a default init to nullptr

meven added a comment. Thanks @sitter REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24655 To: sitter, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 151 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/151/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 15 Oct 2019 09:16:57 + Build duration: 8 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 138 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/138/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 15 Oct 2019 09:16:22 + Build duration: 9 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 267 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/267/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 15 Oct 2019 07:14:46 + Build duration: 33 min and counting BUILD ARTIFACTS

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven added a comment. In D24582#547267 , @dfaure wrote: > Looks fine, but a bit verbose. Maybe we could have configValue() overloads (in SlaveBase) for bool, int and QString, to cover the most common use cases? > > -

D24641: Collect more information from version control systems

sitter added a comment. Do we have a request for this outside kbibtex? My attitude towards adding things to ECM is always "is there more than one user". ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT seems very specific and opinionated (what's origin? does it count commits in merges? also the

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr updated this revision to Diff 67955. chinmoyr marked 3 inline comments as done. chinmoyr added a comment. Addressed the comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21783?vs=59738=67955 BRANCH arcpatch-D21783 REVISION DETAIL

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.h:964 > Missing "m" prefix like the other members, but wait isn't this BIC? > Adding a new member to an exported class certainly is. This needs to go into > the SlaveBasePrivate class instead. Since we need

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

meven added a comment. If there are no objections I will merge this soonish REPOSITORY R241 KIO BRANCH arcpatch-D23851 REVISION DETAIL https://phabricator.kde.org/D23851 To: meven, broulik, ngraham Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

zzag added a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

zzag removed a dependent revision: D24660: [x11] Add support for _GTK_FRAME_EXTENTS. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24657 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 269 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/269/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 15 Oct 2019 09:16:38 + Build duration: 24 min and counting BUILD ARTIFACTS

D24657: Add support for _GTK_FRAME_EXTENTS

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY _GTK_FRAME_EXTENTS is a property set by the client that specifies extents of the client-side

D24630: Replace all qWarning and related calls with categorised logging

This revision was automatically updated to reflect the committed changes. Closed by commit R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging (authored by ahiemstra). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D24662: Fix non-integer scale copy on creation of OutputChangeSet

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R127 KWayland BRANCH fixOutputChangeSetScaleCopy REVISION DETAIL

D24662: Fix non-integer scale copy on creation of OutputChangeSet

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fixOutputChangeSetScaleCopy REVISION DETAIL https://phabricator.kde.org/D24662 To: kossebau, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWayland to hide deprecated API up to a given

D24662: Fix non-integer scale copy on creation of OutputChangeSet

This revision was automatically updated to reflect the committed changes. Closed by commit R127:264e94052c5c: Fix non-integer scale copy on creation of OutputChangeSet (authored by kossebau). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 71 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/71/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 15 Oct 2019 13:04:43 + Build duration: 20 min and counting BUILD ARTIFACTS

D24662: Fix non-integer scale copy on creation of OutputChangeSet

kossebau added a comment. Found by D24663 when trying to implement EXCLUDE_DEPRECATED_BEFORE_AND_AT and doing test builds :) REPOSITORY R127 KWayland BRANCH fixOutputChangeSetScaleCopy REVISION DETAIL https://phabricator.kde.org/D24662 To:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/25/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 15 Oct 2019 13:04:42 + Build duration: 18 min and counting JUnit Tests Name: