D25219: Only create a session config when actually restoring a session

ngraham added a dependent revision: D11382: Add an option to show tabs from last time when Dolphin starts. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

meven updated this revision to Diff 69470. meven added a comment. Reapply some lost changes REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69469=69470 BRANCH arcpatch-D25215_1 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven updated this revision to Diff 69477. meven added a comment. Split obs changes to D25221 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69474=69477 BRANCH arcpatch-D25215 REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven retitled this revision from "Fix a couple of broken links, update links to https://kde.org/applications/, add obs" to "Fix a couple of broken links, update links to https://kde.org/applications/;. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

ahmadsamir added inline comments. INLINE COMMENTS > jobuidelegate.cpp:365 > > sslMetaData.value(QStringLiteral("ssl_cipher_bits")).toInt(), > - > KSslInfoDialog::errorsFromString(sslMetaData.value(QStringLiteral("ssl_cert_errors"; > +

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. In D24843#560188 , @kmaterka wrote: > In D24843#560023 , @broulik wrote: > > > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every

D25223: Avoid side effects during menu initialization

kmaterka updated this revision to Diff 69489. kmaterka added a comment. Final version, ready for review. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25223?vs=69484=69489 BRANCH master REVISION DETAIL

D25216: Fix translations of $GenericName

meven added a comment. @aspotashev Is it good for ? REPOSITORY R304 KNewStuff BRANCH arcpatch-D25216 REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

meven added a comment. In D25216#560212 , @aspotashev wrote: > LGTM since it fixes the issue. > > A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName

D25216: Fix translations of $GenericName

This revision was automatically updated to reflect the committed changes. Closed by commit R304:91f212f983ef: Fix translations of $GenericName (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69461=69472 REVISION DETAIL

D25221: Add OBS to screenrecorders

meven updated this revision to Diff 69478. meven marked an inline comment as done. meven added a comment. Remove translations REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25221?vs=69476=69478 BRANCH obs-branch REVISION DETAIL

D25223: Avoid side effects during menu initialization

kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Setting some attributes, like visible, enabled, etc has side effects. Do

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

meven updated this revision to Diff 69473. meven added a comment. rebase on master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69470=69473 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED FILES

D25221: Add OBS to screenrecorders

meven created this revision. meven added reviewers: leinir, ngraham. meven added a project: Frameworks. meven requested review of this revision. REVISION SUMMARY BUG: 412320 FIXED-IN: 5.65 TEST PLAN Spectacle > Tools > More REPOSITORY R304 KNewStuff BRANCH obs-branch REVISION

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Code looks sane to me and builds. Haven't done any testing though REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause,

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

meven updated this revision to Diff 69469. meven added a comment. Add OBS entry to screenrecorders REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69460=69469 BRANCH arcpatch-D25215_1 REVISION DETAIL https://phabricator.kde.org/D25215

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

ngraham added a comment. In an ideal world the OBS stuff would be in a separate patch. :) REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25223: Avoid side effects during menu initialization

kmaterka added a comment. The problem was with: m_menu->setVisible(m_visible); setters/getters should not have side effects or any logic, but this method has. Detached menu stayed as top level window and rendered itself. VLC has a bug, each systray menu update creates new

D25223: Avoid side effects during menu initialization

kmaterka edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25221: Add OBS to screenrecorders

nicolasfella added inline comments. INLINE COMMENTS > com.obsproject.Studio.desktop:4 > +GenericName=Streaming/Recording Software > +GenericName[fr]=Logiciel d'enregistrement/diffusion > +Comment=Free and Open Source Streaming/Recording Software Remove the translated strings REPOSITORY R304

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven added a comment. In D25215#560229 , @ngraham wrote: > In an ideal world the OBS stuff would be in a separate patch. :) Done. I interpreted "While you're touching this stuff" wrongly. REPOSITORY R304 KNewStuff BRANCH

D25221: Add OBS to screenrecorders

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH obs-branch REVISION DETAIL https://phabricator.kde.org/D25221 To: meven, leinir, ngraham Cc: nicolasfella, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

ngraham added a comment. No problem, I wasn't being very clear myself. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25132: Use an eyedropper for color-picker icons

ngraham updated this revision to Diff 69471. ngraham added a comment. Update to be a bit more Breezey and address review comments REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69232=69471 BRANCH eyedropper-style-color-picker-icon

D25132: Use an eyedropper for color-picker icons

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

aspotashev accepted this revision. aspotashev added a comment. LGTM since it fixes the issue. A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file? REPOSITORY R304

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

meven updated this revision to Diff 69474. meven added a comment. rebasing on master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69473=69474 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED FILES

D25215: Fix a couple of broken links, update links to https://kde.org/applications/, add obs

meven retitled this revision from "Fix a couple of broken links, update links to https://kde.org/applications/; to "Fix a couple of broken links, update links to https://kde.org/applications/, add obs". meven edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

This revision was automatically updated to reflect the committed changes. Closed by commit R304:cdafed6b395f: Fix a couple of broken links, update links to https://kde.org/applications/ (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25223: Avoid side effects during menu initialization

kmaterka added a comment. Too soon, it is still not finished. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. In D24843#560023 , @broulik wrote: > This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: >

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25226 To: ngraham, #vdg, #frameworks Cc:

D25132: Use an eyedropper for color-picker icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I still think the lines on the side of the tube need to be a bit thicker. They're almost half a pixel thick, which is not in line with what we normally do and it makes them fuzzy

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 413002 FIXED-IN: 5.65 Undecided on the button. Should it be

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

winterz added a comment. FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2. Although I am skipping the .htignore's, there will still be lots of false positives especially in the test programs. Let's see what happens. -Allen REPOSITORY

D25225: Symlink microphone to audio-input-microphone on all sizes

ltoscano created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY Right now microphone.png (which is a fall-back for icons like microphone-sensitivity-{muted,low,medium,high})

D25225: Symlink microphone to audio-input-microphone on all sizes

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R267 Oxygen Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25225 To: ltoscano, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25221: Add OBS to screenrecorders

This revision was automatically updated to reflect the committed changes. Closed by commit R304:d9258f219328: Add OBS to screenrecorders (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25221?vs=69478=69498#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D24959: Add new preferences search icons

astippich updated this revision to Diff 69500. astippich added a comment. - tweak shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24959?vs=68979=69500 BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 AFFECTED FILES

D24959: Add new preferences search icons

astippich added a comment. F7749583: search.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2,

D25216: Fix translations of $GenericName

aspotashev added a comment. I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language: i18nc("@action:inmenu %1=\"$GenericName\"", "%1 -

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven updated this revision to Diff 69460. meven added a comment. Replace remaning kde project links to https://kde.org/applications/ REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69457=69460 BRANCH arcpatch-D25215 REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

meven added a comment. In D25216#560122 , @aspotashev wrote: > I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more

D25216: Fix translations of $GenericName

aspotashev added a comment. In general, string concatenation that you suggested is a big red flag for me as a translator. Concatenation often creates an untranslatable word puzzle. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham

D25216: Fix translations of $GenericName

meven updated this revision to Diff 69461. meven added a comment. Better translator-friendly implementation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69453=69461 BRANCH arcpatch-D25216 REVISION DETAIL

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. While you're touching this stuff, it'll probably be easy to implement https://bugs.kde.org/show_bug.cgi?id=412320 REPOSITORY R304 KNewStuff BRANCH arcpatch-D25215 REVISION DETAIL

D25216: Fix translations of $GenericName

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D25216 REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25216: Fix translations of $GenericName

ngraham added a reviewer: Localization. ngraham added a comment. LGTM but please wait for approval from a translator too. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham, #localization Cc: aspotashev, kde-frameworks-devel,

D25219: Also only create a session config when actually restoring a session

ngraham created this revision. ngraham added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This allows manually invoking session restoration logic without

D25219: Only create a session config when actually restoring a session

ngraham retitled this revision from "Also only create a session config when actually restoring a session" to "Only create a session config when actually restoring a session". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25219 To: ngraham, #frameworks,

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Done, see D25219 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25208: Add missing property to KKeySequenceWidget

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Oddly enough we had all the necessary to manage

D25208: Add missing property to KKeySequenceWidget

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25208 To: ervin, #frameworks, dfaure, davidedmundson, bport Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25209: Register KKeySequenceWidget to KConfigDialogManager

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This makes it usable in a KConfigXT context. Depends

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL

D25211: Add KPropertySkeletonItem

ervin created this revision. ervin added reviewers: Frameworks, dfaure, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This new item allows to use a QObject property as

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Ping. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25209: Register KKeySequenceWidget to KConfigDialogManager

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25209 To: ervin, #frameworks, dfaure, davidedmundson, bport, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin updated this revision to Diff 69440. ervin added a comment. Add missing virtual dtor REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25210?vs=69431=69440 REVISION DETAIL https://phabricator.kde.org/D25210 AFFECTED FILES

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/35/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 07 Nov 2019 14:06:02 + Build duration: 20 hr and counting

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. friendly ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25208: Add missing property to KKeySequenceWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R263:fab6d95a9fad: Add missing property to KKeySequenceWidget (authored by ervin). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25208?vs=69429=69436 REVISION DETAIL

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

vkrause added a comment. Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25210 To: ervin, #frameworks, dfaure, davidedmundson,

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

ervin added a comment. In D25210#559977 , @vkrause wrote: > Ok as such, but I think KConfigSkeletonItemPrivate would need a virtual dtor for this to actually work safely when used by a sub-class? You mean like not leaking memory? woops.

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25210 To: ervin, #frameworks, dfaure, davidedmundson, bport, crossi, vkrause Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25209: Register KKeySequenceWidget to KConfigDialogManager

This revision was automatically updated to reflect the committed changes. Closed by commit R265:c0a8cd4a2a95: Register KKeySequenceWidget to KConfigDialogManager (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25209?vs=69430=69439

D25197: Show a "Loading more..." busy indicator when loading view data

leinir added a comment. In D25197#559686 , @ngraham wrote: > Cool, I'm okay with that. > > The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is. It's at the end of the list, though...

D25197: Show a "Loading more..." busy indicator when loading view data

leinir updated this revision to Diff 69428. leinir added a comment. - Ensure that the indicator is the full height of the view when it's empty REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25197?vs=69398=69428 BRANCH reduce-some-noise (branched from

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.13/36/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 08 Nov 2019 10:42:11 + Build duration: 6 min 18 sec and counting JUnit Tests

D25216: Fix translations of $GenericName

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY $GenericName was translated before being passed to KMoreToolsService::formatString, causing translators to process

D25216: Fix translations of $GenericName

meven added reviewers: leinir, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

meven edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25216 To: meven, leinir, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25216: Fix translations of $GenericName

meven updated this revision to Diff 69453. meven added a comment. Amend comment REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25216?vs=69452=69453 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25216 AFFECTED FILES

D25217: don't delete and recreate wallpaperinterface if not needed

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the wallpaperinterface instance already reacts to wallpaper package change and loads the

D25217: don't delete and recreate wallpaperinterface if not needed

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/dontdelete REVISION DETAIL https://phabricator.kde.org/D25217 To: mart, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25217: don't delete and recreate wallpaperinterface if not needed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b58d7c775299: dont delete and recreate wallpaperinterface if not needed (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25215: Fix a couple of broken links

meven added a comment. In D25215#560047 , @ngraham wrote: > We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf I did not find this url, thanks

D25215: Fix a couple of broken links

meven updated this revision to Diff 69456. meven added a comment. Fix kdf link and update others REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69447=69456 BRANCH arcpatch-D25215 REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven retitled this revision from "Fix a couple of broken links" to "Fix a couple of broken links, update links to https://kde.org/applications/;. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir, ngraham Cc: ngraham, kde-frameworks-devel,

D25215: Fix a couple of broken links, update links to https://kde.org/applications/

meven updated this revision to Diff 69457. meven marked an inline comment as done. meven added a comment. amend comment REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25215?vs=69456=69457 BRANCH arcpatch-D25215 REVISION DETAIL

D25106: Also allow invoking session restoration logic when apps are manually launched

davidedmundson added a comment. > KConfigGui::sessionConfig(); This method behaves weirdly and not what I expected from reading this code. If no-one has explicitly called KConfigGui::sessionConfig it creates a new one using qApp->sessionConfig() regardless of whether we're session

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

broulik added a comment. This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: F7748305: Screenshot_20191108_151344.png (note the

D25215: Fix a couple of broken links

meven created this revision. meven added a reviewer: leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D25215 AFFECTED

D25211: Add KPropertySkeletonItem

ervin updated this revision to Diff 69442. ervin added a comment. Fix member variable naming convention REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69432=69442 REVISION DETAIL https://phabricator.kde.org/D25211 AFFECTED FILES

D25197: Show a "Loading more..." busy indicator when loading view data

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH reduce-some-noise (branched from master) REVISION DETAIL https://phabricator.kde.org/D25197 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel,

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH be-more-friendly-during-initial-load (branched from master) REVISION DETAIL https://phabricator.kde.org/D25173 To: leinir, #knewstuff, #frameworks, ngraham, #vdg Cc:

D25197: Show a "Loading more..." busy indicator when loading view data

This revision was automatically updated to reflect the committed changes. Closed by commit R304:080f5276ae2f: Show a Loading more... busy indicator when loading view data (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25197?vs=69428=69446#toc REPOSITORY R304

D25215: Fix a couple of broken links

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Good catch :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D25215 To: meven, leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25173: Give some more pretty feedback in NewStuff::Page while the Engine is loading

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f1f439cbef94: Give some more pretty feedback in NewStuff::Page while the Engine is loading (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25215: Fix a couple of broken links

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We should use the kde.org/applications links, e.g. https://kde.org/applications/system/org.kde.kdf, not https://utils.kde.org/projects/kdf REPOSITORY R304 KNewStuff