D25572: [KFileWidget] Allow double quotes in filenames

meven updated this revision to Diff 70651. meven added a comment. Remove unrelated change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25572?vs=70499=70651 BRANCH arcpatch-D25572_1 REVISION DETAIL https://phabricator.kde.org/D25572 AFFECTED FILES

D25572: [KFileWidget] Allow double quotes in filenames

meven added a comment. In D25572#569573 , @ngraham wrote: > This isn't working for me. When I create a file named `"foobar".txt`, the file dialog is still unable to open it, saying: That's precisely the unit test included, it works for.

D25638: autotests: Find perl executable on all platforms

aspotashev added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:93 > maybe it would make sense to check for BSD instead? > I don't know much about BSD, but I'd expect the shebang to work there as well. I think it's better to minimize platform-specific if-endifs and make CMake

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. The doc doesn't mention the LANGUAGE var. QLocale::QLocale() Constructs a QLocale object initialized with the default locale. If no default locale was set using setDefault(), this locale will be the same as the one returned by system(). See

D25632: Fix module imports with Python3

cordlandwehr added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D24489: KAutosaveFile not respecting maximum filename length

mardelle added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:92c2886c3714: [WIP] Adding support for mounting KIOFuse URLs for applications that dont use… (authored by feverfew).

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70661. feverfew added a comment. - Get rid of unnecessary copying of URLs - Switch to interface generated at compile time - Delete unused interfaces - Merge branch 'master' into arcpatch-D23384 - remove kiofuseinterface from build - Align

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew reopened this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D25638: autotests: Find perl executable on all platforms

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I approve, given that I wrote the same in D25643 :-) REPOSITORY R172 KCalendar Core BRANCH perl REVISION DETAIL

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. Unfortunately the `kio-fuse -d` output is incomplete, probably because Qt was too smart and logged to the journal instead... It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress? Can you try with thumbnails in dolphin

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570016 , @ngraham wrote: > In D23384#569929 , @feverfew wrote: > > > This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've

D25638: autotests: Find perl executable on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit R172:accdbdd65ee0: autotests: Find perl executable on all platforms (authored by aspotashev). REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25638?vs=70636=70663

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a URL and uses that instead if it makes more sense. This way "dumb" apps get a local

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:56 > +COMMAND ${CMAKE_COMMAND} -E env > + > $,PATH,LD_LIBRARY_PATH>=$ > +$ -i ${CMAKE_CURRENT_BINARY_DIR}/tmp.qrc > -o ${RESOURCE_FILE} This breaks builds with CMake 3.5 - 3.7, as `$` was only

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 3 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/32/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 12:45:16 + Build duration: 3 min 30 sec and counting BUILD ARTIFACTS

D25650: Port foreach

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds, tests pass, dolphin opens REPOSITORY R263 KXmlGui BRANCH

D25572: [KFileWidget] Allow double quotes in filenames

dfaure added a comment. Restarting kdeinit is only needed when making changes that affect kioslaves. Here it's just about a widget, all you need is to start the application from a terminal. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25572 To: meven, #frameworks,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > directorysizejob.cpp:141 > +#endif > +listJob->addMetaData(QStringLiteral("statDetails"), > QString::number(KIO::StatDetail::Basic &

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70669. meven marked an inline comment as done. meven added a comment. Fix: | instead of & to build a QFlags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70543=70669 BRANCH arcpatch-D25010 REVISION DETAIL

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25629: Port away from KTextWidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R263:13cb497277fa: Port away from KTextWidgets (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25629?vs=70619=70672 REVISION DETAIL

D25653: [bookmarksmenu] Improve variable name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY addAddBookmark make some sense as the method name, but as a

D25654: Rename actions to be consistent

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Rename actions to all have Action suffix after D25653

D25655: Remove outdated comments

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY They come from a time before KF5 and are probably outdated since

D25656: Remove unneeded moc include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL

D25657: Clean up includes

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Sort alphabetically and use CamelCase headers TEST PLAN builds

D25658: Remove superflous private

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL

D25659: Add TODO KF6 note

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R294 KBookmarks BRANCH toto REVISION DETAIL

D25632: Fix module imports with Python3

ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. If it still works it's OK to push. REPOSITORY R264 KApiDox BRANCH bugfix/graphvizImportPython3 REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud

D25599: Fix plugin-metadata translations on windows

aacid added a comment. Right, but we set it in initializeLanguages. https://github.com/KDE/kxmlgui/blob/master/src/kswitchlanguagedialog_p.cpp#L81 I think the bug is that initializeLanguages should set the proper stuff in QLocale for windows too. I had this that fixes part of a

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#568067 , @dhaumann wrote: > Any news here? For starters, this needs to be rebased; I'll try and get to it soon. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To:

D24489: KAutosaveFile not respecting maximum filename length

ahmadsamir added a comment. IIUC, FILENAME_MAX corresponds to PATH_MAX, 4096 (bytes; or chars in an array). NAME_MAX is the max. filename (the filename part only, without the canonical path) length, this is 255 on Linux. So using FILENAME_MAX is correct in the code. See:

D25658: Remove superflous private

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL https://phabricator.kde.org/D25658 To: nicolasfella, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards getting rid of KActionCollection dependency.

D25658: Remove superflous private

This revision was automatically updated to reflect the committed changes. Closed by commit R294:29139b7b8f66: Remove superflous private (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25658?vs=70678=70681 REVISION DETAIL

D25660: Add member for editbookmarks action

nicolasfella added a task: T12056: KBookmarks. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:72 > add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) > # Subdirectories > add_definitions(-DTRANSLATION_DOMAIN=\"kxmlgui5\") This comment

D25656: Remove unneeded moc include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL https://phabricator.kde.org/D25656 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25657: Clean up includes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH incl REVISION DETAIL https://phabricator.kde.org/D25657 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25650?vs=70664=70682 REVISION DETAIL

D25650: Port foreach

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:72 > This comment looks wrong Fixed REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25650 To: nicolasfella, #frameworks, apol Cc: apol,

D25659: Add TODO KF6 note

apol added a comment. I'm unsure such comments are useful. :/ Maybe it would work better as a phabricator task or so? REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25659 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25656: Remove unneeded moc include

This revision was automatically updated to reflect the committed changes. Closed by commit R294:1ee83cf07143: Remove unneeded moc include (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25656?vs=70676=70683 REVISION DETAIL

D25657: Clean up includes

This revision was automatically updated to reflect the committed changes. Closed by commit R294:a195de5012b1: Clean up includes (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25657?vs=70677=70684 REVISION DETAIL

D25660: Add member for editbookmarks action

apol added a comment. Maybe this is too of an intermediate step? this patch doesn't really do anything. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25661: Simplify null check

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds, Dolphin's bookmark menu stil opens REPOSITORY R294 KBookmarks

D25660: Add member for editbookmarks action

nicolasfella planned changes to this revision. nicolasfella added a comment. I can do it with the rest of the patch REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25572: [KFileWidget] Allow double quotes in filenames

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks Méven. I can confirm that it works in Gwenview with no other changes. I have to re-compile Kolourpaint, but then it works from there too. Odd. REPOSITORY R241 KIO BRANCH

D25661: Simplify null check

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH nulll REVISION DETAIL https://phabricator.kde.org/D25661 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25661: Simplify null check

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b8609a04c31: Simplify null check (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25661?vs=70687=70688 REVISION DETAIL

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. Why can't we use setDefault? Your linked patch does not look like it would change the behaviour on Windows? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. My head hurts a bit but I think I understand this now ;) I'm not sure what's the use case for disabling this though? (I'm wondering the same about the existing

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570125 , @dfaure wrote: > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into

D25599: Fix plugin-metadata translations on windows

sars added a comment. ki18n does not seem to use QLocale to get the language for translation, but uses LANGUAGE env. Also gettext uses the env variable. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel,

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/2/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/2/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 2 min 6 sec and counting CONSOLE OUTPUT

D24489: KAutosaveFile not respecting maximum filename length

dfaure added a comment. A unittest would be very welcome. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570119 , @feverfew wrote: > In D23384#570016 , @ngraham wrote: > > > In D23384#569929 , @feverfew wrote: > > > > >

D24489: KAutosaveFile not respecting maximum filename length

ngraham edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24489 To: mardelle, #frameworks, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570118 , @fvogt wrote: > Please try both of the following: Done. Here are the log files: F7793378: kio-fuse.log F7793379: strace output.log

D25572: [KFileWidget] Allow double quotes in filenames

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I think this needs more work, we lost some tolerance here, AFAICS. INLINE COMMENTS > kfilewidget.cpp:1751 > > -const int count = line.count(QLatin1Char('"')); > -if

D25599: Fix plugin-metadata translations on windows

aacid added a comment. To be honest i don't remember why we don't use setDefault. It's a solution we could investigate REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570347 , @ngraham wrote: > In D23384#570119 , @feverfew wrote: > > > In D23384#570016 , @ngraham wrote: > > > > >

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. Well it sounds to me like we might need both. But the issue this pr tries to tackle would probably be gone with setDefault REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570349 , @ngraham wrote: > In D23384#570125 , @dfaure wrote: > > > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 20:03:37 + Build duration: 1 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 20:17:12 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 358

D25632: Fix module imports with Python3

This revision was automatically updated to reflect the committed changes. Closed by commit R264:f8ff31dc9af0: Fix module imports with Python3 (authored by cordlandwehr). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25632?vs=70625=70721 REVISION DETAIL

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 70694. nicolasfella added a comment. Rebase REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70693=70694 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660 AFFECTED FILES

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 02:52:07 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.13/28/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 07:34:29 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/43/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 01 Dec 2019 23:05:02 + Build duration: 4 min 30 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 01 Dec 2019 23:05:03 + Build duration: 6 min 2 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:55 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:51:03 + Build duration: 1 hr 1 min and counting JUnit Tests Name:

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY I noticed that QPalette had these, but KColorScheme didn't. Since there is no function to get the number of items in an

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis updated this revision to Diff 70718. ndavis added a comment. - Split up Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70717=70718 BRANCH enum-item-counts (branched from master) REVISION DETAIL

D25660: Add member for editbookmarks action

nicolasfella updated this revision to Diff 70693. nicolasfella added a comment. - Decouple from KActionCollection REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70680=70693 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

kossebau added a comment. In D25589#570375 , @dfaure wrote: > My head hurts a bit but I think I understand this now ;) Indeed, this gets more & more complex, I hope in time for ECM6 there are enough samples collected from real-world

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 208 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/208/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:54 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D25676: Add items to ColorSet and Role enums for the total number of items

ndavis updated this revision to Diff 70717. ndavis added a comment. - Also do Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70716=70717 BRANCH enum-item-counts (branched from master) REVISION DETAIL

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:17:12 + Build duration: 2 min 9 sec and counting JUnit Tests

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/5/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 01 Dec 2019 20:39:27 + Build duration: 2 min 14 sec and counting JUnit Tests

D25599: Fix plugin-metadata translations on windows

aacid added a comment. In D25599#570372 , @sars wrote: > ki18n does not seem to use QLocale to get the language for translation It already does that on non unix appendLanguagesFromQLocale(localeLanguages, QLocale::system()); the

D25630: Port to json metadata

nicolasfella updated this revision to Diff 70698. nicolasfella added a comment. - Use kcoreaddons_desktop_to_json REPOSITORY R150 KDE Telepathy KDE Daemon Module CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25630?vs=70623=70698 BRANCH json REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 42 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/42/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 00:07:50 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Dec 2019 23:50:56 + Build duration: 21 min and counting JUnit Tests Name:

  1   2   >