D25704: [kfilewidget] Load icons by name

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b21a6c1a5b93: [kfilewidget] Load icons by name (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25704?vs=70801=70803 REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/48/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 00:47:30 + Build duration: 4 min 39 sec and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 344 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/344/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 23:57:11 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 77 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 00:35:19 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT

D25704: [kfilewidget] Load icons by name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Skip the indirection over pixmap REPOSITORY R241 KIO BRANCH

D25700: [KHistoryComboBox] Add method to set an icon provider

apol added a comment. +1 Makes sense to me REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 343 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/343/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 23:39:51 + Build duration: 8 min 14 sec and counting BUILD ARTIFACTS

D25704: [kfilewidget] Load icons by name

nicolasfella updated this revision to Diff 70801. nicolasfella added a comment. - [kfilewidget] Load icons by name - Remove include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25704?vs=70800=70801 BRANCH icco REVISION DETAIL

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 210 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/210/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Dec 2019 23:39:46 + Build duration: 9 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/50/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 00:35:22 + Build duration: 1 min 41 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 00:35:15 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 186 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/186/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 02 Dec 2019 23:39:49 + Build duration: 57 min and counting

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/51/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Dec 2019 00:47:31 + Build duration: 7 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 78 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/78/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 00:47:31 + Build duration: 6 min 37 sec and counting BUILD ARTIFACTS

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70799. feverfew added a comment. Chek for userInfo instead of just password REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70773=70799 BRANCH arcpatch-D23384 REVISION DETAIL

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and Role enums for the total number of… (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 225 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/225/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 23:39:50 + Build duration: 12 min and counting BUILD ARTIFACTS

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70802. ndavis added a comment. - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items - fix code style REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70720=70802 BRANCH

D25704: [kfilewidget] Load icons by name

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH icco REVISION DETAIL https://phabricator.kde.org/D25704 To: nicolasfella, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 3 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 211 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/211/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Dec 2019 23:57:11 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Triggered rename dialog. Still have icons in there REPOSITORY R241 KIO

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#571276 , @ngraham wrote: > I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that don't use ioslaves. My impression is that the few apps that have implemented their

D25708: Don't use nullptr to flags

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY IT seems that it was a error during modernize code by using nullptr but it's a flags so we can't use it REPOSITORY

D25708: Don't use nullptr to flags

mlaurent added a reviewer: romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D25708 To: mlaurent, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Can easily be done otherwise. REPOSITORY R241 KIO BRANCH pfo

D25276: reStructuredText: Fix inline literals highlighting preceding characters

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Ok REPOSITORY R216 Syntax Highlighting BRANCH rst-inline-literal-prefix REVISION DETAIL https://phabricator.kde.org/D25276 To: adrianchavesfernandez, mosra, dhaumann Cc:

D25686: Updates from CMake 3.16 final release

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the update! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25686 To: turbov, #framework_syntax_highlighting, cullmann Cc: cullmann,

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. Seems like these changes are unrelated and should maybe be in a separate commit? REPOSITORY R265 KConfigWidgets REVISION DETAIL

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ngraham added reviewers: davidedmundson, hpereiradacosta. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. @feverfew thanks for rebasing https://invent.kde.org/kde/kio-fuse/merge_requests/2. I've tested it and confirmed that it fixes case #2! We can continue that portion of the view in the comments there. REPOSITORY R241 KIO REVISION DETAIL

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ngraham added a subscriber: feverfew. ngraham added a comment. @feverfew thanks for rebasing https://invent.kde.org/kde/kio-fuse/merge_requests/2. I've tested it and confirmed that it fixes case #2! We can continue that portion of the view in the comments there. REPOSITORY R241 KIO

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. All right. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a comment. In D25677#570896 , @ngraham wrote: > > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. > > Seems like these changes are unrelated and should maybe be

D25686: Updates from CMake 3.16 final release

turbov added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25686 To: turbov, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems to fix the issue and I did not detect any regressions in keyboard navigation in open or save dialogs. May be a good idea to wait to commit this until after Frameworks 5.65 is

D25686: Updates from CMake 3.16 final release

turbov created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25686 AFFECTED FILES

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R252:dcadc14c952d: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals… (authored by ngraham).

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70773. feverfew added a comment. Check for password instead of authority REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70661=70773 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384

D25441: Send along the config name with requests

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH send-config-name-with-requests (branched from master) REVISION DETAIL https://phabricator.kde.org/D25441 To: leinir, #knewstuff, #frameworks, #plasma, starbuck, ronaldv, mart

D25678: Document Notifiers setting

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25678 AFFECTED

D25671: Fix git builds against Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25671 To: apol, #frameworks, vkrause Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25517: Add an option to extract binary data and add front cover property

astippich updated this revision to Diff 70723. astippich added a comment. - fix label comment - tweaks REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25517?vs=70303=70723 BRANCH binaryData REVISION DETAIL https://phabricator.kde.org/D25517

D25518: Extract front cover in the taglib extractor

astippich updated this revision to Diff 70724. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=70285=70724 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518 AFFECTED

D25518: Extract front cover in the taglib extractor

astippich added a dependent revision: D25679: Implement writing of front cover in taglibwriter. REPOSITORY R286 KFileMetaData BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel,

D25679: Implement writing of front cover in taglibwriter

astippich added a dependency: D25518: Extract front cover in the taglib extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas,

D25622: partial solution to accept accentuated characters on windows

astippich added a comment. taglibwriter should get the same treatment REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns, #windows Cc: astippich, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D25679: Implement writing of front cover in taglibwriter

astippich created this revision. astippich added reviewers: Baloo, bruns, mgallien, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Complements the extractor support for writing

D25599: Fix plugin-metadata translations on windows

vonreth added a comment. Are you sure? https://github.com/KDE/ki18n/blob/a5477f812c563ffd7fb08b6ec4bd573bc49bb76a/src/klocalizedstring.cpp#L146 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25599 To: sars, aacid, vonreth Cc: kde-frameworks-devel, LeGast00n,

D25511: Drop unused broken KGesture support

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson, vkrause Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25511: Drop unused broken KGesture support

This revision was automatically updated to reflect the committed changes. Closed by commit R263:1fa7e40c7862: Drop unused broken KGesture support (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25511?vs=70268=70731#toc REPOSITORY R263 KXmlGui CHANGES

D25461: [KCM GridDelegate] Use non-attached ToolTip

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The attached version is a light QObject that calls a single tooltip. The non-attached version contains /the entire tooltip instance/ Which on every delegate

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

dfaure added reviewers: vkrause, nicolasfella. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25671: Fix git builds against Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706=70734 REVISION

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Operate on `QRectF`/`QSizeF` and only round back to integer at the end. TEST PLAN

D25311: Add KColumnHeadersProxyModel

davidedmundson added inline comments. INLINE COMMENTS > kcolumnheadersmodel.cpp:83 > + > +if (newSourceModel) { > +connect(newSourceModel, > ::columnsAboutToBeInserted, this, [this](const > QModelIndex&, int first, int last) { connect(modelAboutToBeReset modelReset REPOSITORY

D25682: [WIP] add initial wsdiscovery support

ngraham added a comment. OMG it works!!! I can find my windows Samba share in Dolphin again! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: ngraham, caspermeijn, davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25420: [KFileWidget] Avoid calling slotOk right after the url changed

meven added a comment. ping anyone ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25328: Always rehiglhight() after definition was changed

meven added a comment. In D25328#564202 , @meven wrote: > In D25328#563637 , @cullmann wrote: > > > Hmm, the use case is that it re-highlights if you set an invalid definition? > > > Here it

D25562: Add some friendly "report bugs here" links

ngraham accepted this revision. REPOSITORY R304 KNewStuff BRANCH helpful-linking-for-bugs (branched from master) REVISION DETAIL https://phabricator.kde.org/D25562 To: leinir, #frameworks, #knewstuff, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25311: Add KColumnHeadersProxyModel

vkrause added a comment. In D25311#570700 , @ahiemstra wrote: > @vkrause Is the updated version more what you expected? Yep, thanks, this addresses my concerns. So +1 from me on this. REPOSITORY R275 KItemModels REVISION DETAIL

D25683: KDirOperator: Use a fixed line height for scroll speed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks! REPOSITORY R241 KIO BRANCH diroperator_scrollspeed REVISION DETAIL https://phabricator.kde.org/D25683 To: ahiemstra, ngraham Cc: ngraham,

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570331 , @ngraham wrote: > In D23384#570118 , @fvogt wrote: > > > Please try both of the following: > > > Done. Here are the log files: > > F7793378:

D25311: Add KColumnHeadersProxyModel

ahiemstra marked an inline comment as done. ahiemstra added a comment. @vkrause Is the updated version more what you expected? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel,

D25461: [KCM GridDelegate] Use non-attached ToolTip

broulik added a comment. Kirigami has a `toolTipDelay` in `Units`. The other bit is hardcoded to some heuristic: https://cgit.kde.org/qqc2-desktop-style.git/tree/org.kde.desktop/ToolTip.qml#n48 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25461 To:

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page Ignoring the elephant in the

D25562: Add some friendly "report bugs here" links

leinir updated this revision to Diff 70733. leinir added a comment. - Merge branch 'master' into helpful-linking-for-bugs - Don't use .arg, just embed the URLs directly in the translatable text REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. It appears to open everything remote through kiofuse. - Click a text file in `sftp://foo/bar` will kiofuse it and then open it in Kate - Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open

D25562: Add some friendly "report bugs here" links

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH helpful-linking-for-bugs (branched from master) REVISION DETAIL https://phabricator.kde.org/D25562 To: leinir, #frameworks, #knewstuff, ngraham, davidedmundson Cc:

D25682: [WIP] add initial wsdiscovery support

davidedmundson added a comment. Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: davidedmundson, kde-frameworks-devel, kfm-devel, pberestov,

D25682: [WIP] add initial wsdiscovery support

sitter added a subscriber: caspermeijn. sitter added a comment. In D25682#570845 , @davidedmundson wrote: > Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere? Testing convenience until

D25682: [WIP] add initial wsdiscovery support

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY needs kdsoap >= 1.8.50 (current master). builds a static variant of kdsoap-ws-discovery-client but

D25683: KDirOperator: Use a fixed line height for scroll speed

ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This patch intends to do mostly the same as D19190 , but for KDirOperator.

D25683: KDirOperator: Use a fixed line height for scroll speed

ahiemstra edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25683 To: ahiemstra Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570735 , @fvogt wrote: > > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570830 , @ngraham wrote: > In D23384#570735 , @fvogt wrote: > > > > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to

D25682: [WIP] add initial wsdiscovery support

ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25682 To: sitter Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh,

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH ahmad/separate-browser-html (branched from master) REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24982: Small improvements in some XML files

nibags updated this revision to Diff 70781. nibags added a comment. - Resolve conflicts REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24982?vs=70779=70781 REVISION DETAIL https://phabricator.kde.org/D24982 AFFECTED FILES

D25697: Port away from KIconLoader::SizeSmallMedium

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY There is no direct equivalent of SizeSmallMedium (22) in QStyle.

D25697: Port away from KIconLoader::SizeSmallMedium

nicolasfella added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25697 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

This revision was automatically updated to reflect the committed changes. Closed by commit R241:afb2f80cbbe1: KRun: dont override user preferred app when opening local *.*html and co. files (authored by ahmadsamir, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 224 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/224/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Dec 2019 21:34:25 + Build duration: 2 min 6 sec and counting CONSOLE OUTPUT [...truncated 893

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 341 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/341/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Dec 2019 21:34:24 + Build duration: 2 min 11 sec and counting CONSOLE OUTPUT [...truncated 893

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

dfaure created this revision. dfaure added reviewers: broulik, mart, vkrause, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The old traders could lookup both applications and plugins,

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 185 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/185/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 02 Dec 2019 21:34:25 + Build duration: 3 min 30 sec and counting CONSOLE OUTPUT

D25276: reStructuredText: Fix inline literals highlighting preceding characters

nibags added a comment. @dhaumann I take care to correct the version and commit this REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25276 To: adrianchavesfernandez, mosra Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir added a subscriber: ngraham. ahmadsamir added a comment. @ngraham: I do know how to land a diff :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25697: Port away from KIconLoader::SizeSmallMedium

cfeck added a comment. Traditionally, 22 was used for toolbar icons. You could replace 22 with QStyle::PM_ToolBarIconSize, but it really depends on where you want the icons to appear. Generally, QStyle::PM_SmallIconSize is for icons that are placed next to a single line of text, unless

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

dhaumann added inline comments. INLINE COMMENTS > kapplicationtrader.h:33 > + * > + * Example: say that you want to the list of all applications that can > handle PNG images. > + * The code would look like: Typo: you want to _get_... REPOSITORY R309 KService REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 209 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/209/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Dec 2019 21:34:24 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncated 846

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

dfaure updated this revision to Diff 70787. dfaure added a comment. add missing "get" (this bug was in kmimetypetrader.h already, blatant proof of copy/pasting... ;-) ) REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25698?vs=70785=70787 BRANCH

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. So many hardcoded numbers! Much better indeed. INLINE COMMENTS > kcolorscheme.cpp:88 > > -_effects[0] = 0; > -_effects[1] = 0; > -_effects[2] = 0; > +for(auto

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons (keyboard and session button). The

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25699 To: filipf, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >