D17595: Upstream Dolphin's file rename dialog

elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio Cc: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano,

D17596: [KDirOperator] Allow renaming files from the context menu

meven added inline comments. INLINE COMMENTS > kdiroperator.h:800 > + * prompting the user to choose a new name(s) for the currently selected > items > + * @since 5.56 > + */ Update to @since 5.67 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To:

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R282:7627f64e0103: [networkmanager-qt] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > For KWindowEffects I did put window tracking into the wayland plugin and it > improved the readability of all the client code considerably. > > I would recommend looking at doing so, especially as we

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY - emit changed with good value to ensure reset button is activated

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport added a dependent revision: D26467: KCM runners: fix default button. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Apart from @since version, seems fine to me INLINE COMMENTS > kpluginselector.h:234 > + * Emitted after configuration is changed, tell if configuration > represent default or

D26468: Tests: don't build benchmark test by default

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Benchmark can have a long execution and have little interest for day-day tests. TEST

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26461 To: ahmadsamir, #frameworks, jgrulich, dfaure Cc: kde-frameworks-devel,

D26277: KFilePlaceEditDialog: move logic into isIconEditable()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bdc2df9c1735: KFilePlaceEditDialog: move logic into isIconEditable() (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26277?vs=72341=72883

D17596: [KDirOperator] Allow renaming files from the context menu

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Don't forget to amend commit message (I have update the FIXED-IN: value). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks,

D17596: [KDirOperator] Allow renaming files from the context menu

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 257 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/257/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 06 Jan 2020 13:09:38 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D26457: Introduce shadow API

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in kwindowshadow.h:201 > Could you please point me to that code? kwayland-integration 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in kwindowshadow.h:201 > kwayland-integration > > 0a0c3f23fce265f36e5b8fb2b4b8bd311c7c1beb > > src/windowsystem/windoweffects.cpp Oh, that one...

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

turbov added a comment. In D25811#587606 , @cullmann wrote: > Hi, can you add stuff to the tests or shall we merge this as is? Sorry, I don't have time for this nowadays %( REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

ervin requested changes to this revision. ervin added inline comments. INLINE COMMENTS > kpluginselector.cpp:286 > > +connect(this, ::changed, [=]{ emit > defaulted(this->isDefault()); }); > + We generally don't "this->", also you're capturing too much with =, capturing this would be

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

cullmann added a comment. Ok, then let's merge as is. Thanks for the improvement (+ happy new year). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25811 To: turbov, #framework_syntax_highlighting Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25811 To: turbov, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D26457: Introduce shadow API

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The new API provides a platform-independent way for setting drop-shadows on a window. X11 and

D17595: Upstream Dolphin's file rename dialog

elvisangelaccio added inline comments. INLINE COMMENTS > elvisangelaccio wrote in renamefiledialog.h:48 > So, what should we rename `RenameFileDialog` to? `RenameFileDialog` or > `RenameFileOverwrittenDialog` ? ;) > > Anyway, why wait for KF6 since this is new API? Can't we rename it now? Ah

D26457: Introduce shadow API

zzag updated this revision to Diff 72880. zzag added a comment. Remove pointless default member initializers in KWindowShadowPrivate. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26457?vs=72862=72880 BRANCH kwindowshadow REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D17595_1 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven,

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich, dfaure. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R282 NetworkManagerQt BRANCH

D17595: Upstream Dolphin's file rename dialog

elvisangelaccio added inline comments. INLINE COMMENTS > renamefiledialog.h:48 > + */ > +// TODO KF6 : rename the class RenameFileDialog to RenameDialog and the > class RenameFileDialog to RenameFileOverwrittenDialog or similar. > +class KIOWIDGETS_EXPORT RenameFileDialog : public QDialog So,

D26358: KIO/SMB convert kio protocol declaration to json format

elvisangelaccio added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: elvisangelaccio, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

elvisangelaccio added inline comments. INLINE COMMENTS > krecentfilesmenu.cpp:31 > +QSettings *m_settings; > +size_t m_maximumItems = 10; > +}; Why not `int` since it's what we expose in the API anyway? > krecentfilesmenu.cpp:53 > +

D26457: Introduce shadow API

davidedmundson added a comment. Seems generally very clean and sensible. +1 I want to see plasma-framework/dialog.cpp and breeze ports before we merge. INLINE COMMENTS > kwindowshadow.h:201 > + * > + * Note that the KWindowShadow does not keep track of the platform > surface.

D26457: Introduce shadow API

zzag added a task: T12496: Shadows API in KWindowSystem. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D26457 To: zzag, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26416: Kicker/Documents optimization: Lazily build KFileItem

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build KFileItem (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

mlaurent created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl as it's Qt:: namespaced in qt5.15 REPOSITORY R39 KTextEditor BRANCH port_endl

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator REPOSITORY R242 Plasma Framework (Library) BRANCH port_QRandomGenerator (branched from

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

mlaurent added a reviewer: dfaure. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26463 To: mlaurent, dfaure Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

mlaurent added a reviewer: dfaure. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26465 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n REPOSITORY R242 Plasma Framework (Library) BRANCH port_endl (branched from master) REVISION

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 72881. meven marked 2 inline comments as done. meven added a comment. Rebase, amend, update @since, fix typo in TODO KF6 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=70224=72881 BRANCH arcpatch-D17595_2

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 72882. meven added a comment. Update Copyright year REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=72881=72882 BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED FILES

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure added a comment. Benchmarking is complex ;) 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) 2. you need to actually use those 3 variables otherwise the compiler might optimize out their use. This could be testing their value (NOT

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. I hacked up some (rather crude, to say the least) benchmarking: void KLocalizedStringTest::benchmarkRegexSimple() { QString roleName, cueName, formatName; QString context = QStringLiteral("@info:tooltip/plaintext"); QBENCHMARK

D26453: [Purpose] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: apol, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QRegExp::exactMatch -> QRegularExpression::anchoredPattern() QRegExp::Wildcard ->

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D26415: Ensure to store resource uri without a trailing slash

meven added a comment. In D26415#588501 , @ivan wrote: > TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well. The sqlite database is not used direcly by users so we don't need to have a denominator

D26449: [PoC] Port to KRecentFileMenu

meven added inline comments. INLINE COMMENTS > mainwindow.h:67 > KParts::ReadWritePart *m_part; > -KRecentFilesAction*m_recentFilesAction; > QAction *m_openAction; Rename the variable as well ? REPOSITORY R36 Ark REVISION DETAIL

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

ahmadsamir added a comment. In D26366#588416 , @dfaure wrote: > Benchmarking is complex ;) > > 1. you need to make sure both Qt and your benchmark are built with optimizations enabled (-O2) > 2. you need to actually use those 3 variables

D25682: [WIP] add initial wsdiscovery support

meven added a comment. A few qDebug not to forget to clean before merging. INLINE COMMENTS > kio_smb_browse.cpp:380 > > + > udsentry.fastInsert( KIO::UDSEntry::UDS_NAME, udsName ); remove > kio_smb_browse.cpp:544 > if (dir_is_root) { > + qDebug() << "dir is

D26415: Ensure to store resource uri without a trailing slash

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well. REPOSITORY R6 KActivities BRANCH master REVISION DETAIL https://phabricator.kde.org/D26415

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Two smaller issues, nothing critical INLINE COMMENTS > baloosettings.kcfgc:6 > +DefaultValueGetters=true > +GenerateProperties=true > +ParentInConstructor=true I don't think

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

ervin added inline comments. INLINE COMMENTS > bport wrote in kpluginselector_p.h:205 > The method declaration changed and the connected slot already provide the > value Right, I missed the relevant connect. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To:

D26457: Introduce shadow API

zzag added inline comments. INLINE COMMENTS > zzag wrote in kwindowshadow.h:201 > Oh, that one... Yeah, perhaps it will be worth to handle surface > creation/destruction in kwayland-integration. Okay, looks like it's do-able. However, we would need to call `QWidget::winId()` in

D26472: Add GraphQL highlighting definition

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. More syntax definitions is always nice ;=) Has tests + no hardcoded colors. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D26470: [Solid] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(). TEST PLAN make && ctest

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham updated this revision to Diff 72897. ngraham marked an inline comment as done. ngraham added a comment. Fix @since value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17596?vs=72641=72897 BRANCH arcpatch-D17596 REVISION DETAIL

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham added a comment. @since value needs to be updated. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26358: KIO/SMB convert kio protocol declaration to json format

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Well, at least it doesn't hurt anything and it's more technically correct. :) REPOSITORY R320 KIO Extras BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26358

D26420: Add a logging category to smb ioslave

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1360c1f0e224: Add a logging category to smb ioslave (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72901=72902 REVISION DETAIL

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72901. meven added a comment. rebase REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72749=72901 BRANCH arcpatch-D26420_2 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26470: [Solid] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R245:11ec991bd14b: [Solid] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26470?vs=72894=72903 REVISION

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 06 Jan 2020 15:52:17 + Build duration: 1 min 40 sec and counting JUnit Tests Name:

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

ervin accepted this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from .desktop files AND .directory files

ngraham added a comment. In D26331#588152 , @count wrote: > In D26331#588073 , @ngraham wrote: > > > Thanks! @count, can you provide us with your full name and email address so we can land this

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport added inline comments. INLINE COMMENTS > ervin wrote in kpluginselector.cpp:389 > This logic looks wrong to me. > > isChanged indicates if an entry state was changed during the course of the > call to defaults(). It's very possible it's false when getting out of the > loop. > If that's

D17596: [KDirOperator] Allow renaming files from the context menu

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

meven accepted this revision as: meven. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport updated this revision to Diff 72908. bport added a comment. Take in consideration ervin feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26400?vs=72701=72908 REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport marked an inline comment as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

meven added a comment. D17595 just landed, just tested this patch REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann,

D26358: KIO/SMB convert kio protocol declaration to json format

This revision was automatically updated to reflect the committed changes. Closed by commit R320:0354fd11f1f0: KIO/SMB convert kio protocol declaration to json format (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72743=72900

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport updated this revision to Diff 72906. bport added a comment. Increment version signal was introduced and remove uneeded blank line REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26466?vs=72885=72906 REVISION DETAIL

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport marked 9 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

dfaure accepted this revision. dfaure added a comment. Last day before what? The world explodes soon? :) KF 5.66 is already tagged, as planned (first saturday of the month). REPOSITORY R241 KIO BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 To:

D17595: Upstream Dolphin's file rename dialog

meven added a comment. last days for last minute review @dfaure REPOSITORY R241 KIO BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio Cc: elvisangelaccio, lydia, dfaure, sitter,

D26472: Add GraphQL highlighting definition

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D26472 AFFECTED

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

ervin added inline comments. INLINE COMMENTS > bport wrote in kpluginselector.cpp:389 > isPluginEnabled represent the current state (i.e. after load) so we compare > the file value with default value I thought that was the current GUI state not the current storage state and got confused. I

D17595: Upstream Dolphin's file rename dialog

ngraham added a comment. This will be so nice to finally have done! REPOSITORY R241 KIO BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio Cc: elvisangelaccio, lydia, dfaure, sitter,

D26470: [Solid] Port QRegExp to QRegularExpression

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R245 Solid BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26470 To: ahmadsamir, #frameworks, dfaure,

D17595: Upstream Dolphin's file rename dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f5341d3d7e2: Upstream Dolphins file rename dialog (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=72882=72922 REVISION DETAIL

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport updated this revision to Diff 72909. bport added a comment. fix REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26400?vs=72908=72909 REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES src/file/CMakeLists.txt

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma, bruns Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

ervin accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma, bruns Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krecentfilesmenu.cpp:33 > + > +QString titleWithSensibleWidth() > +{ ... const? > krecentfilesmenu.cpp:85 > +QString m_group =

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

dfaure added a comment. So, the old way was 76 times faster than the new regexp :-) I'm not surprised, though, it's consistent with my experience with regexps. This might be a good reason to use the manual-search way. Especially now that you tested it for both performance and

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 88 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/88/ Project: kf5-qt5 AndroidQt5.13 Date of build: Mon, 06 Jan 2020 23:25:18 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT

D26453: [Purpose] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26453 To: ahmadsamir, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked 8 inline comments as not done. nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in krecentfilesmenu.cpp:31 > Why not `int` since it's what we expose in the API anyway? I'm getting a warning about signed/unsigned compare otherwise REPOSITORY R236

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 72928. nicolasfella marked 8 inline comments as done. nicolasfella added a comment. - Rework internals to do fewer allocations and file IO REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=72844=72928

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven marked an inline comment as done. meven added a comment. Thanks for the suggestion @dfaure INLINE COMMENTS > jobtest.cpp:2045 > f.close(); > -QCOMPARE(f.size(), 1000); //~10MB > +QCOMPARE(f.size(), 5); //~500MB to make sure copy is not too > fast, or the tests

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

meven added inline comments. INLINE COMMENTS > dhaumann wrote in kdiroperator.h:428 > Imho the API documentation should be improved (I am aware it was copied). > > Returns a map of all available actions. The action map remains unchanged > throughout the entire lifetime of the diroperator

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9aeb3bef288f: Port endl as \n or std::cout ... std::endl when we wrote directly on console or… (authored by mlaurent). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH port_multi_hash (branched from master) REVISION DETAIL https://phabricator.kde.org/D26450 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 258 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/258/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 06 Jan 2020 19:41:09 + Build duration: 4 hr 2 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 88 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/88/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 06 Jan 2020 23:25:18 + Build duration: 1 hr 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 259 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/259/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 06 Jan 2020 23:44:09 + Build duration: 1 hr 17 min and counting JUnit Tests Name:

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26463 To: mlaurent, dfaure, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

dfaure added inline comments. INLINE COMMENTS > mlaurent wrote in kconfig_compiler.cpp:694 > I think that it was a problem when QTextStream used QString which doesn't > flush it. > code is a QString I think you're confusing two cases. The "underlying device" goes away before the QTextStream

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/89/ Project: kf5-qt5 AndroidQt5.13 Date of build: Mon, 06 Jan 2020 23:52:09 + Build duration: 1 min 15 sec and counting

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella added inline comments. INLINE COMMENTS > cfeck wrote in krecentfilesmenu.h:104 > Weren't there ABI issues with std::list? > > Also, missing reference on url. We use std::list in other frameworks and IIRC no one complained REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D24629: RFC: Introduce KClockSkewNotifier class

zzag reclaimed this revision. zzag added a comment. D25962 adds one usage of (K)ClockSkewNotifier in KWin. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24629 To: zzag, #frameworks Cc: apol, davidedmundson,

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. There is still an issue with the tests : It won't pass in wondws. So I am thinking duplicating the test `JobTest::cancelCopyAndCleanDest` and using an #ifdef to circumvent windows limitations. REPOSITORY R241 KIO REVISION DETAIL

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

dfaure added inline comments. INLINE COMMENTS > meven wrote in kdiroperator.h:428 > Personally I would add an enum of static strings, so that user code can > discover easily the features and that the documentation follows the code more > easily. What's an enum of strings? You mean just an

D25117: file ioslave: stop copying as soon as the ioslave is killed

dfaure added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:2045 > This may-be excessive, but I needed that since I have a fast nvme drive. The alternative is to export an env var that makes the ioslave call some msleep()... REPOSITORY R241 KIO REVISION DETAIL

  1   2   >