D27463: KconfigXT: Add a value attribute to Enum field choices

meven added a comment. In D27463#613114 , @davidre wrote: > If you touch the xsd do you neeed to increase the version number? That would be a good practice but how to publish a 1.1 version ? And what is the point ? I mean this xsd and as

D27468: Don't double delete CommentsModel

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Quite right. Looks like some leftovers from before that caching was added, shippit :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D27468 To:

D27468: Don't double delete CommentsModel

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5c7ee50bf900: Don't double delete CommentsModel (authored by davidedmundson). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27468?vs=75866&id=75886 REVISION DET

D27460: fix layout size hints for button labels

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Please update tests/components to have it failing before and now passing. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.or

D27459: Port QLinkedList which is deprecated in qt5.15

apol added a comment. In D27459#613205 , @aacid wrote: > Are we sure we can lose the features of QLinkedList here? > > maybe makes more sense to use std::list that has the same features as QLinkedList? I thought so too, but we just it

Re: 2 kirigami fixes for a point release

On 2020-02-16 14:43, Albert Astals Cid wrote: Maybe i explain myself wrongly, i'm not blaming distros at all. They made a decision, we/I may agree with them or not, that's *my/our* problem, what I was disagreeing is to us having to do extra work because someone elses (the distros) decision.

Re: New Framework Review: KDAV

Hi, > In mostly all files it is not clear if the LGPL or the GPL is meant (stating > "GNU Library General Public License" and referring to the GPL text at the > end of the statement). This license statement is used for all files except > autotests/fakesever.cpp and autotests/fakeserver.h. > Luckil

Re: Standardizing Qt logging categories used in KF

On Mon, Feb 17, 2020 at 7:43 PM Friedrich W. H. Kossebau wrote: > > Hi, > > while going through the KF modules to adapt to the new > ecm_qt_install_logging_categories() macro* to auto-generate KDebugSettings > .categories (& .renamecategories) files I once more found there is no real > naming patt

D27459: Port QLinkedList which is deprecated in qt5.15

dfaure added a comment. This code only seems to do append() and contains(), a QVector (contiguous area of memory) is better than a std::list (individual nodes spread all over the memory, more cache lines to load) REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) RE

D27475: Make kwapper/kshell spawn klauncher5 if needed

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In an attempt to phase kinit out plasma will at some point stop spawning klauncher5 This means we ne

D27476: [KDBusConnectionPool] Handle the case of no qApp

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If we don't have a QApplication we can't use the thread-local QDBusConnection, but we can at least retur

D27475: Make kwapper/kshell spawn klauncher5 if needed

davidedmundson added a comment. Requires D27476 to not crash REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D27475 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

meven added a dependent revision: D27477: KCM/Kwinoptions: Port title bar and window actions tabs UI and conf to KConfigXT. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: davidre, kde-frameworks-devel, LeGast00n, c

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75917. meven added a comment. Default value must refere to the choice name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75852&id=75917 BRANCH arcpatch-D27463 REVISION DETAIL https://phabricator.kde.org/D2

D27478: Add a --replace option to kded5

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allows restarting kded5 properly, useful when trying new modules. TEST PLAN resta

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75922. mart added a comment. - some quirks to make it more similar to pc2 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75833&id=75922 BRANCH phab/buttonslayout REVISION DETAIL https://ph

D27460: fix layout size hints for button labels

mart added a comment. latest version, plasmacontrols 2 and 3 one beside the other F8110874: Screenshot_20200218_160904.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma, davidedmun

D27475: Make kwapper/kshell spawn klauncher5 if needed

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > find_package(KF5Config ${KF5_DEP_VERSION} REQUIRED) > +find_package(KF5DBusAddons ${KF5_DEP_VERSION} REQUIRED) > find_package(KF5DocTools ${KF5_DEP_VERSION}) I suppose this should be if (NOT WIN32)? I'm not entirely sure why it

D27476: [KDBusConnectionPool] Handle the case of no qApp

apol added inline comments. INLINE COMMENTS > kdbusconnectionpool.cpp:66 > +if (!QCoreApplication::instance()) { > +return QDBusConnection::sessionBus(); > +} It feels like we should be using the s_perThreadConnection when we're not on a QApplication. Non-QApplications might st

D27475: Make kwapper/kshell spawn klauncher5 if needed

davidedmundson updated this revision to Diff 75924. davidedmundson added a comment. update REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27475?vs=75914&id=75924 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27475 AFFECTED FILES CMakeLis

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > button3.qml:90 > text: "AA" > -// implicitWidth: minimumWidth FIXME, there is no equivalent? > +implicitWidth: Layout.minimumWidth > } this doesn't contain an icon, which is the

D27460: fix layout size hints for button labels

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in button3.qml:90 > this doesn't contain an icon, which is the majority of what this patch is > about added REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabrica

D27460: fix layout size hints for button labels

mart updated this revision to Diff 75927. mart added a comment. - add an icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27460?vs=75922&id=75927 BRANCH phab/buttonslayout REVISION DETAIL https://phabricator.kde.org/D27460 AFFEC

D27083: [PC2]Give Label integer width.

gvgeo added a comment. @davidedmundson ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis, davidedmundson Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zach

D24004: Teach kwaylandscanner about PrimarySelection

meven added a comment. ping reviewers :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24004 To: gladhorn, #kwin Cc: meven, davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24004: Teach kwaylandscanner about PrimarySelection

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm skeptical that kwaylandscanner adds anything, especially when we want to pretty much clone a class, but sure. In terms of the names. As for V1. We're not entire

D27460: fix layout size hints for button labels

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in button3.qml:90 > added You didn't even run this :( 1. icon.name not icon.source 2. now the comment next to it is wrong 3. there's a binding loop 4. if I make a test without any text, which is what the thing you're supposedly

D27083: [PC2]Give Label integer width.

davidedmundson added a comment. From a logical viewpoirnt it doesn't make sense. It's a binding loop. Changing the width will re-lay out, which will change the paintedWidth, which will change the width. Practically QQuickTextItem has a catch against that (see qquicktext.cpp: internalWidthU

D27475: Make kwapper/kshell spawn klauncher5 if needed

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D27475 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27083: [PC2]Give Label integer width.

gvgeo added a comment. I see, so paintedHeight is not exactly perfect above. > But I don't really understand how this helps anything in a reliable way. > Layouts will override widths after a layout invalidation. Correctly set anchors would override it. RowLayout, FlowLayout and Gr

D27083: [PC2]Give Label integer width.

gvgeo added a comment. Should I close this patch then? The only place I've seen this problem is in tests. I don't know if there is any place that is affected. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavi

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

ngraham added reviewers: vkrause, apol. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27334 To: kossebau, svuorela, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

ngraham added a comment. Oops, you're right! My mistake, sorry. Will resume the review. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngr

D26769: Always strip html if server does not support it

ngraham added a comment. +1 yes please REPOSITORY R289 KNotifications BRANCH stripcorrently REVISION DETAIL https://phabricator.kde.org/D26769 To: nicolasfella, #frameworks, broulik, mart Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

ngraham added inline comments. INLINE COMMENTS > CTestCostData.txt:1 > +--- Seems like this file was added in error > LastTest.log:3 > +-- > +End testing: Jan 29 14:08 CET Seems like this file was added in error REPOSITORY R237 KConfig

Re: 2 kirigami fixes for a point release

> > IMHO distributions using Plasma LTS, Plasma team & other stakeholders should > > team up here and maintain a matching LTS branch of Frameworks together at > > the > > central KDE repos together. Well, and a version also satisfying other > > clients > > of KF, like non-workspace applications f

D27459: Port QLinkedList which is deprecated in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R263:c5863523f3aa: Port QLinkedList which is deprecated in qt5.15 (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27459?vs=75830&id=75936 REVISIO

D27083: [PC2]Give Label integer width.

gvgeo added a comment. > Also, why is only PC2 affected? Just checked again, apparently made a mistake. All the labels are affected. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27083 To: gvgeo, #plasma, #vdg, ndavis, davidedmundson Cc: dav

Re: 2 kirigami fixes for a point release

On 2/17/20 11:08 PM, Luca Beltrame wrote: In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto: think KDE software should be presented to users. Basically, we acknowledge that Neon is already an actual OS--the "KDE OS"--and we Please don't suggest such downstream-hostile solu

Re: 2 kirigami fixes for a point release

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote: Yes, this has been questioned a few times. Also seeing Plasma LTS used together with a non-LTS Qt is a bit strange. But somehow it seems there has not been enough pain for those using the Plasma LTS to change something. Possibly because distribu

Re: 2 kirigami fixes for a point release

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote: Yes, this has been questioned a few times. Also seeing Plasma LTS used together with a non-LTS Qt is a bit strange. But somehow it seems there has not been enough pain for those using the Plasma LTS to change something. Possibly because distribu

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

martonmiklos created this revision. martonmiklos added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. martonmiklos requested review of this revision. REVISION SUMMARY Add FreeCAD FCMacro extension

Re: 2 kirigami fixes for a point release

El dimarts, 18 de febrer de 2020, a les 4:03:05 CET, Nate Graham va escriure: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our* > > problem, what I was

Re: 2 kirigami fixes for a point release

In data martedì 18 febbraio 2020 19:26:21 CET, Nate Graham ha scritto: > Neon is already an OS, whether or not you want to admit it. It's > installed from an ISO. A hardware vendor (Slimbook) is shipping it on Erm, where did I say that in my reply? ;) I merely say that going "Neon or else unsup

Re: 2 kirigami fixes for a point release

On 2/18/20 2:13 PM, Luca Beltrame wrote: In data martedì 18 febbraio 2020 19:26:21 CET, Nate Graham ha scritto: Neon is already an OS, whether or not you want to admit it. It's installed from an ISO. A hardware vendor (Slimbook) is shipping it on Erm, where did I say that in my reply? ;)

Re: 2 kirigami fixes for a point release

On 2/18/20 1:37 PM, Albert Astals Cid wrote: I still don't see why this is a problem, as said Plasma depends on a myriad of libraries that are building each with their own release model, most probably with no bugfix releases at all either. The "we don't control the whole stack" argument does

D27430: [PATCH] General update for CartoCSS syntax highlighting

sommer added a comment. Yep. Here comes an updated version for test.mss: /* kate: hl CartoCSS This file contains some content coming from https://github.com/gravitystorm/openstreetmap-carto with CC0 license. This file is just for testing katepart highligh

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH prifixesreview REVISION DETAIL https://phabricator.kde.org/D27334 To: kossebau, svuorela, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 302 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/302/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 19 Feb 2020 04:45:01 + Build duration: 7 min 15 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 310 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/310/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 19 Feb 2020 04:45:01 + Build duration: 8 min 17 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 435 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/435/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 19 Feb 2020 04:45:01 + Build duration: 19 min and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0.xmllo

D27152: Introduce FilesystemEntry class

hallas updated this revision to Diff 75961. hallas marked 17 inline comments as done. hallas added a comment. Updated patch with review comments REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27152?vs=74977&id=75961 BRANCH introduce_filesystem_entry REVIS

Re: Banning QNetworkAccessManager

On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ > akademy2019/public/events/135 on that subject. > > On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: > [...] > > Prior to now, i've taken the approach o