D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added a comment. In D27533#615478 , @dhaumann wrote: > Still, I wonder whether we should postpone adding the MarkInterfaceV2 until the KF6 branch. Then we have it properly fixed in KF6. KF5 will stay around for a few more years

D27097: Port from QRegExp to QRegularExpression

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK for deprecating Incremental. A full revert (at KF6 time) of commit 9ac82e27ad0322e444c16 looks

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven added a comment. In D27539#615654 , @dfaure wrote: > This is about an icon name. Apps don't (shouldn't) "check the value". > > We should return application-octet-stream if we did find the file, but mimetype determination failed. That's

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76148. meven added a comment. Add an https test case REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76147=76148 BRANCH arcpatch-D27539 REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > global.cpp:240 > // Let KFileItem::iconName handle things for us > -if (i == unknown || i.isEmpty() || mt.isDefault()) { > +if

D27550: Support Qt 5.14 on Android

vkrause updated this revision to Diff 76160. vkrause added a comment. Improve compile-time conditional to only build the new code with Qt >= 5.14. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76117=76160 BRANCH master REVISION DETAIL

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.h:86 > class KTEXTEDITOR_EXPORT KTextEditor::DocumentPrivate : public > KTextEditor::Document, > -public > KTextEditor::MarkInterface, > +

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. Looking pretty good so far. The only icons that have 24px versions but no 22px versions are the following from the actions category: 24/align-horizontal-node.svg 24/align-vertical-node.svg 24/audio-volume-high.svg 24/audio-volume-low.svg

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D27539 REVISION DETAIL https://phabricator.kde.org/D27539 To: meven, ngraham, #frameworks, dfaure, broulik, sitter Cc: sitter, kde-frameworks-devel, LeGast00n, cblack,

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

anthonyfieroni added inline comments. INLINE COMMENTS > kossebau wrote in kateviewhelpers.cpp:1963 > Possibly `QIcon::paint()` might be also working here as wanted? Needs someone > with HiDPI to check if all things behave as wanted. The old code with all the > `devicePixelRatioF()` made me

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 304 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/304/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 22 Feb 2020 11:36:09 + Build duration: 17 min and counting JUnit Tests Name: projectroot

D27573: Fix issue finding the Boost include directories

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Thanks! Can you please give me your email address so I can merge this with the correct authorship information? REPOSITORY R6 KActivities REVISION DETAIL

D27451: Drop KToolInvocation support from KRun::runService

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This makes runService and runApplication almost the same, right? KRecentDocument::add seems missing in runApplication, but that's a bug, so one could just call the other? REPOSITORY

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. Out of the ones listed above, these are symlinks: 24/font.svg 24/gnumeric-format-border-all.svg 24/gnumeric-format-border-none.svg 24/gnumeric-format-border-outside.svg 24/gnumeric-object-label.svg 24/gnumeric-object-line.svg

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

dfaure added a comment. This is about an icon name. Apps don't (shouldn't) "check the value". We should return application-octet-stream if we did find the file, but mimetype determination failed. That's what this mimetype and its icon are about. We should return unknown if we have

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

dhaumann added a comment. Ok, then I am fine with this. Maybe add a KF6 task to the KF6 board? INLINE COMMENTS > kossebau wrote in katedocument.h:86 > See the warning in the API docs, nobody should rely on this private API, so > the BIC here is okay. > The class is exported for the unit

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76156. meven marked 2 inline comments as done. meven added a comment. Improve comment, remove unnecessary check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76148=76156 BRANCH arcpatch-D27539 REVISION DETAIL

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann Cc: anthonyfieroni, dhaumann, kwrite-devel,

D27550: Support Qt 5.14 on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R249:91c5e2ff604e: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76160=76161 REVISION DETAIL

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

This revision was automatically updated to reflect the committed changes. Closed by commit R241:eb20176d1a42: KIO::iconNameForUrl: fix searching for kde protocol icons (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76156=76162

D27153: port sftp to Result system to force serialization of error/finish condition

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Nice work! Found 2 bugs though. INLINE COMMENTS > kio_sftp.cpp:1306 > rc = ssh_channel_poll(mSftp->channel, 1); > -} > - > -if (rc < 0) { > +} else if (rc <

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. In D27245#614915 , @kossebau wrote: > What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy `LICENSES/LGPL-2.1-only.txt`? > Or are both

D27562: [kcmcontrols] Respect header/footer visibility

nicolasfella edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Did additional code digging in the Plan repository and I think that all stated copyright claims are valid. INLINE COMMENTS > cgiboudeaux wrote in holidayparserdriverplan.cpp:6-13 > The original text lacks clarity.

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr marked 2 inline comments as done. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27573: Fix issue finding the Boost include directories

dalbers added a reviewer: KActivities. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D27573 To: dalbers, #kactivities Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27573: Fix issue finding the Boost include directories

dalbers created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dalbers requested review of this revision. REVISION SUMMARY Replaces ${Boost_INCLUDE_DIR} with ${Boost_INCLUDE_DIRS}. REPOSITORY R6 KActivities REVISION DETAIL

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

This revision was automatically updated to reflect the committed changes. Closed by commit R236:835c64d1b693: [KMessageWidget] Draw it with QPainter instead of using stylesheet (authored by davidre). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27038: [KMessageWidget] Allow the style to change our palette

davidre added a comment. Ping REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven added a comment. In D27539#615288 , @dfaure wrote: > kfileitemtest still passes? It does, and I added more tests. A question I have is that in case we don't find an icon depending on how we determine it we can return

D27539: KIO::iconNameForUrl: fix searching for kde protocol icons

meven updated this revision to Diff 76147. meven added a comment. Add some tests REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27539?vs=76106=76147 BRANCH arcpatch-D27539 REVISION DETAIL https://phabricator.kde.org/D27539 AFFECTED FILES

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katedocument.h:86 > Why private class is exported, changing parent of an exported class is BIC. See the warning in the API docs, nobody should rely on this private API, so the BIC here is okay. The class is exported for

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. `draw-highlight` got a bit mangled: F8124601: Screenshot_20200222_043230.PNG I think it's because both the viewbox and the height/width were set, which made the scaling at 22px equal to 0.26459. This looks fine when we're

D27363: KHolidays: Convert license statements to SPDX expressions

cordlandwehr updated this revision to Diff 76151. cordlandwehr marked 2 inline comments as done. cordlandwehr added a comment. Add missing SPDX identifier REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27363?vs=75737=76151 BRANCH spdx REVISION DETAIL

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

davidre added a comment. Ping REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. The following 24px icon symlinks are linked to 22px icons. Maybe it's material for another patch, but I figured I'd bring it up. configure-shortcuts.svg -> ../../devices/22/input-keyboard.svg dblatex.svg -> ../../places/22/network-server-database.svg

D27573: Fix issue finding the Boost include directories

dalbers added a comment. That'd be `dan...@lbe.rs`, thank you! I'll close the PR I mistakenly opened on GitHub. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D27573 To: dalbers, #kactivities, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n,

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

anthonyfieroni added a reviewer: aacid. anthonyfieroni added a comment. +1 REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 437 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/437/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Feb 2020 11:36:07 + Build duration: 4 hr 1 min and counting BUILD ARTIFACTS

D27580: Updates for CMake 3.17

turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Feb 2020 12:20:13 + Build duration: 3 hr 48 min and counting JUnit Tests Name:

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. I've fixed the 22px files that had height/width and viewbox set. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27573: Fix issue finding the Boost include directories

This revision was automatically updated to reflect the committed changes. Closed by commit R6:53d8ae317c6c: Fix issue finding the Boost include directories (authored by dalbers, committed by nicolasfella). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

aacid added a comment. Any particular reason you added me? REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. After you rebase this, I'd say this patch is ready to go. REPOSITORY R266 Breeze Icons BRANCH autogenerate-24px-icons (branched from master) REVISION DETAIL

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. I've added the icons that were only in actions/24 to actions/22. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 438 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/438/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Feb 2020 15:37:40 + Build duration: 5 hr 3 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 312 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/312/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 22 Feb 2020 11:36:09 + Build duration: 9 hr 47 min and counting BUILD ARTIFACTS

D27586: templates: Convert license statements to SPDX headers

kossebau created this revision. kossebau added reviewers: cordlandwehr, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R306 KParts BRANCH spdxlicensefortemplate REVISION DETAIL

D27038: [KMessageWidget] Allow the style to change our palette

apol added a comment. But then now we are not refreshing the palette when it changes outside, no? How about adding a boolean value when it's already happening to prevent the infinite recursion? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To:

D27587: templates: Convert license statements to SPDX headers

kossebau created this revision. kossebau added reviewers: Kate, cordlandwehr. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH spdxlicensefortemplate REVISION

D27588: templates: Convert license statements to SPDX headers

kossebau created this revision. kossebau added reviewers: cordlandwehr, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R308 KRunner BRANCH spdxlicensefortemplate REVISION DETAIL

D27589: Try to apply the colorscheme of the current theme to QIcons

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Patch works as advertised and the code LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre edited the test plan for this revision. davidre added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Before icons loaded internally with QIcon::fromTheme were being colored with the colors from the current global

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 313 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/313/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 22 Feb 2020 22:23:32 + Build duration: 30 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/64/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 22 Feb 2020 22:23:28 + Build duration: 28 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 439 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/439/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Feb 2020 04:37:03 + Build duration: 13 min and counting BUILD ARTIFACTS

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 314 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/314/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 23 Feb 2020 04:37:03 + Build duration: 6 min 25 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 305 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/305/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 23 Feb 2020 04:37:03 + Build duration: 9 min 0 sec and counting JUnit Tests Name: