D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY For KCM modules, clicking the "Help" button when khelpcenter isn't installed should open the corresponding document

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir added a dependent revision: D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27616: [UrlHandler] optimise the code and less if nesting

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Depends on D27615 TEST PLAN make && ctest REPOSITORY R273 KGuiAddons BRAN

D27615: [UrlHandler] Handle opening the online docs for KCM modules

ahmadsamir added a dependent revision: D27616: [UrlHandler] optimise the code and less if nesting. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

rocka created this revision. rocka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rocka requested review of this revision. REVISION SUMMARY Recent version of telegram-desktop added support for using system icon theme for tray icon. Th

D27603: KDNSSD: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27603 To: cordlandwehr, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

davidre edited the summary of this revision. davidre added a reviewer: Fuchs. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27602: KDbusAddons: Convert license statement to SPDX

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27602 To: cordlandwehr, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

bcooksley added a comment. Please note that the FreeBSD breakage has now started to cause Dependency Builds on the CI system to fail. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, k

D27451: Drop KToolInvocation support from KRun::runService

davidedmundson added a comment. > This makes runService and runApplication almost the same, right? Yeah, that was the goal. > KRecentDocument::add seems missing in runApplication, but that's a bug If that is a bug, then we may as well share the implementation. I'll do that. REPO

D27601: KConfig: Convert to SPDX license statements

cgiboudeaux added inline comments. INLINE COMMENTS > kconfigbackend_p.h:6 > + > +Portions: > +SPDX-FileCopyrightText: 1997 Matthias Kalle Dalheimer I don't think this is useful > kconfigini_p.h:6 > > - This library is free software; you can redistribute it and/or > - modify it un

D27620: [krun] Share implementation of runService and runApplication

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Since they now effectively do the same thing. This patch also saves recent documents when runApplication

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 354 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/354/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 10:28:49 + Build duration: 2 min 35 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 207 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/207/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 10:28:49 + Build duration: 2 min 37 sec and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.14 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.14/31/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 10:28:49 + Build duration: 2 min 9 sec and counting JUnit Tests Name

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. looks like it's not posix sh, but bash code REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, b

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.h:766 > + > +public: > +QString value() const { It's a struct you can drop the public: here. > kcoreconfigskeleton.h:76

D27557: Auto-generate 24px monochrome icons

sitter added a comment. `{}` expansions are bashism. Never ever test files meant for sh with bash and be mindful that many distributions will symlink /bin/bash to /bin/sh. There is a huge amount of not so subtle syntax differences between POSIX sh and bash that an sh-only implementation wi

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 137 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/137/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 11:00:15 + Build duration: 48 sec and counting CONSOLE OUTPUT [...trunca

D27589: Try to apply the colorscheme of the current theme to QIcons

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iconitem.cpp:600 > } else if (!m_icon.isNull()) { > + > KIconLoader::global()->setCustomPalette(KColorScheme::createApplicationPalette(Plasma::Theme()

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin added a comment. In D27059#612205 , @dfaure wrote: > Well, I'm not the KConfig maintainer, mdawson is :-) Well, my understanding is that mdawson is MIA, so I rely on the old "dfaure as default maintainer" model. ;-) REPOSITORY R2

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, please don't forget to address dfaure's comment before pushing though. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #framew

D27557: Auto-generate 24px monochrome icons

sitter added a comment. Oh, oh boy, there's many more things wrong with this than just the bashism :| @ndavis @ngraham why don't you generate the 24x version inside the source? `COMMAND ${BASH_EXE} ${CMAKE_SOURCE_DIR}/generate-24px-versions.sh ${BREEZE_INSTALL_DIR}` this is b

D27557: Auto-generate 24px monochrome icons

sitter added a comment. Bhushan already has D27614 for the installation problem. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, kde-frameworks-de

D27614: build: fix the build where install prefix is not user-writable

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I'd rather have the excess spaces been done away with. Otherwise LGTM, please rebase and land. REPOSITORY R266 Breeze Icons BRANCH bshah/fix-build REVISION DETAIL https://phabricato

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. Should we just revert for now? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

davidre added a comment. Also we need to have this on Windows, too. Breeze-icons is part of Frameworks and these were exported/installed files. A user could easily have a reference to one of the files somewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D

D27557: Auto-generate 24px monochrome icons

sitter added a comment. @davidre we provide a theme, if someone explicitly looks for a specific file within that theme that'd be squarely outside the supported realm of a theme. it'd prevent improving the theme which may mean changing scaling rules and removing the then useless sizes. REPOS

D27557: Auto-generate 24px monochrome icons

davidre added a comment. I disagree but it's not my call REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bru

D27614: build: fix the build where install prefix is not user-writable

bshah updated this revision to Diff 76278. bshah added a comment. rebase REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76256&id=76278 BRANCH bshah/fix-build REVISION DETAIL https://phabricator.kde.org/D27614 AFFECTED FILES icons-dark

D27614: build: fix the build where install prefix is not user-writable

This revision was automatically updated to reflect the committed changes. Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix is not user-writable (authored by bshah). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27614?vs=76278

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 138 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/138/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 25 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 253 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/253/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 19

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 145 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/145/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 11:42:36 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated 19

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/28/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 11:42:35 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi updated this revision to Diff 76281. crossi added a comment. fix comment REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27059?vs=75829&id=76281 REVISION DETAIL https://phabricator.kde.org/D27059 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 12:30:45 + Build duration: 26 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 254 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/254/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 49 sec and counting CONSOLE OUTPUT [...truncated 20

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/29/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 57 sec and counting CONSOLE OUTPUT [..

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 146 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/146/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 12:30:46 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT [...truncat

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/140/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 12:39:20 + Build duration: 31 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 147 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/147/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 12:39:20 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated 19

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 255 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/255/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 12:39:21 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated 19

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/30/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 12:39:21 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

This revision was automatically updated to reflect the committed changes. Closed by commit R237:c8bf5e96cf2f: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in… (authored by crossi). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D270

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 31 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/31/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 148 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/148/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 2 min 8 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 141 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/141/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 256 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/256/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:01:12 + Build duration: 3 min 52 sec and counting JUnit Tests Name: (root)

D27557: Auto-generate 24px monochrome icons

sitter added a comment. This is now working again. The symlink tests fail though. That still needs fixing by someone who isn't me. Here's my feedback: For bash or sh scripts: - make sure a sh script is actually POSIX compliant by running it through a POSIX sh implementation -

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 32 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/32/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 53 sec and counting CONSOLE OUTPUT [..

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 257 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/257/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 2 min 17 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/149/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 2 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/142/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:34:52 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre updated this revision to Diff 76284. davidre added a comment. - Introduce Plasma::Theme::palette REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27589?vs=76197&id=76284 BRANCH qiconcolor (branched from master) REVISION DETAIL

D27622: only find bash once

sitter created this revision. sitter added a reviewer: bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 AFFECT

D27622: only find bash once

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > +find_program(BASH_EXE bash) > +add_feature_info("24x24 generation" BASH_EXE "'bash' is require to > generate 24x24 variants") > + *required REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://p

D27624: only install generated icons if they were generated

sitter created this revision. sitter added a reviewer: bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY which is conditional on not being win32. this should fix win32 builds REPOSITORY R266 B

D27622: only find bash once

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27622 To: sitter, bshah, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27624: only install generated icons if they were generated

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27624 To: sitter, bshah, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

This revision was automatically updated to reflect the committed changes. Closed by commit R266:82fc5404d041: only find bash once (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27622?vs=76285&id=76291#toc REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE ht

D27624: only install generated icons if they were generated

This revision was automatically updated to reflect the committed changes. Closed by commit R266:22a845115bc2: only install generated icons if they were generated (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27624?vs=76288&id=76292

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/143/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/150/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 37 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 258 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/258/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 33 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/33/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 24 Feb 2020 13:54:12 + Build duration: 2 min 48 sec and counting JUnit Tests

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. Thanks for the patch! But...it's blue: :) F8128783: Screenshot_20200224_073346.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: ngraham, kde-frameworks

D27617: [breeze-icons] Add telegram-desktop tray icons

ndavis added a comment. In D27617#616925 , @ngraham wrote: > Thanks for the patch! > > But...it's blue: :) > > F8128783: Screenshot_20200224_073346.png Weird. I can't see anything obviously w

D27153: port sftp to Result system to force serialization of error/finish condition

sitter updated this revision to Diff 76300. sitter added a comment. fix problems found by dfaure I've also added Q_REQUIRED_RESULT to fail() and pass() to help not forget to do something with the return value. there's no reason to call them and ignore the constructed object REPOSITORY

D27617: [breeze-icons] Add telegram-desktop tray icons

rocka added a comment. What's the version of telegram-desktop? Would it still be blue if change workspace theme to breeze-dark? If it works fine in breeze-dark and telegram version is 1.9.12, it maybe a upstream bug

D25682: add initial wsdiscovery support

This revision was automatically updated to reflect the committed changes. Closed by commit R320:41397521423b: add initial wsdiscovery support (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25682?vs=73704&id=76301#toc REPOSITORY R320 KIO Extras CHANGES SINCE LAST

D23339: Fix memory leak in ConfigView and Dialog

dvratil updated this revision to Diff 76305. dvratil added a comment. - Rebase on current master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23339?vs=64284&id=76305 BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.o

D23339: Fix memory leak in ConfigView and Dialog

dvratil added reviewers: Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27627: Fix initialization order

dvratil created this revision. dvratil added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabr

D27502: Create ConfigView an unmanaged ConfigWidget

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > loader.h:6 > */ > -#ifndef SONNET_LOADER_P_H > -#define SONNET_LOADER_P_H > +#ifndef SONNET_LOADER_H > +#define SONNET_LOADER_H What's the reason for loader b

D27504: WIP: RFC: smb faster copy to local

sitter added inline comments. INLINE COMMENTS > hallas wrote in kio_smb_dir.cpp:49 > Yes, you could (and should ;) ) use standard C++ for this, i.e.: > > std::unique_ptr buf; > buf = std::make_unique(segmentSize); we use c++11 so can't use make_unique and QBA seems excessive given the use.

D24641: Collect more information from version control systems

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I guess nobody has further input then. LGTM. Ship it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24641 To: thomasfischer, sitter, kossebau Cc: k

D27497: Fix code generation for entries with min/max

ervin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

ervin added a comment. A few smallish issues only, otherwise LGTM. INLINE COMMENTS > KConfigSourceGenerator.cpp:316 > { > - stream() << " " << itemPath(entry, cfg()) << " = " > +QString innerItemVarStr(innerItemVar(entry, cfg())); > +if (!entry->signalList.isEmpty()) { I'd const

D27620: [krun] Share implementation of runService and runApplication

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > krun.cpp:716 > +if (!flags.testFlag(DeleteTemporaryFiles)) { > +// Remember we opened those urls, for the "recent documents" menu in > kicker > +for (co

D27620: [krun] Share implementation of runService and runApplication

apol added a comment. Don't we need KDesktopFile::isAuthorizedDesktopFile now? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27620 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

apol accepted this revision. REPOSITORY R252 Framework Integration BRANCH messagewidget (branched from master) REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid, anthonyfieroni, apol Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D27616: [UrlHandler] optimise the code and less if nesting

apol added a comment. LGTM otherwise INLINE COMMENTS > urlhandler.cpp:55 > +// not a KDE application > +QDesktopServices::openUrl(u); > } won't this recurse forever? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir, #fra

D23339: Fix memory leak in ConfigView and Dialog

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, mic

D27627: Fix initialization order

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27627 To: dvratil, #plasma, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ng

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. Yes, I have 1.9.12. I don't yet have an available update to 1.19.14 or later, sadly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michae

D27628: Buttons: allow to scale up icons

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY always scale icons unless a size is specified in the api. this makes icon sizing more in line

D27628: Buttons: allow to scale up icons

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27628 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

ngraham added a comment. +1 visually and behaviorally; fixes the issues described in D27260 and D27449 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27628 To: mart, #pla

D25743: Expose IndexerState enum to QML

ngraham added a comment. Ping. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25743 To: davidedmundson, #baloo, ngraham Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposh

D23339: Fix memory leak in ConfigView and Dialog

davidedmundson accepted this revision as: davidedmundson. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23339 REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michael

D27594: Remove unused KDBusConnectionPool include

This revision was automatically updated to reflect the committed changes. Closed by commit R241:faace55f0bea: Remove unused KDBusConnectionPool include (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27594?vs=76207&id=76315 REVISION DETAIL

D27607: Deprecate KDBusConnectionPool

vkrause updated this revision to Diff 76316. vkrause added a comment. Set EXCLUDE_DEPRECATED_BEFORE_AND_AT. REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76241&id=76316 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27607 AF

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76317. hchain added a comment. const, change method name, reformat code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75987&id=76317 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES autot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 306 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/306/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 6 min 55 sec and counting JUnit Tests Name: projectro

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 315 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/315/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 6 min 41 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 440 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/440/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Feb 2020 17:20:31 + Build duration: 8 min 23 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.68.0

  1   2   >