D28770: Avoid blocking the UI thread

sandsmark added inline comments. INLINE COMMENTS > broulik wrote in currency.cpp:57 > Can probably just use `QNetworkConfigurationManager::isOnline()`? IIRC that's less reliable (e. g. if you don't use networkmanager or connman). the whole bearer thing is a bit messy, I guess that's why it's

D28787: Fix PC3 BusyIndicator binding loop

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3743e9d67453: Fix PC3 BusyIndicator binding loop (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28787?vs=79980=80012

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is needed if users of this class are expected to add the action manually to their program actionCollection.

D28745: Skip caching thumbnails on encrypted filesystems

marcingu updated this revision to Diff 80021. marcingu added a comment. Removing extra whitespaces REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=79986=80021 REVISION DETAIL https://phabricator.kde.org/D28745 AFFECTED FILES

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack,

D28770: Avoid blocking the UI thread

sandsmark added a comment. In D28770#646989 , @broulik wrote: > I don't fully understand the need for a thread here. > It merely blocks because the API is synchronous and thus we create a nested eventloop. > I don't think the writing and

D28770: Avoid blocking the UI thread

sandsmark updated this revision to Diff 80004. sandsmark marked 5 inline comments as done. sandsmark added a comment. Fixed review comments REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28770?vs=79910=80004 REVISION DETAIL

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > trashsizecache.cpp:131 > +qint64 max_mtime = 0; > +const auto checMaxTime = [max_mtime] (const qint64 lastModTime) -> > qint64 { > +return

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/48/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 13:51:38 + Build duration: 5 min 23 sec and counting JUnit Tests Name:

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 80016. meven marked 2 inline comments as done. meven added a comment. Fix, typo, pass max_mtime by ref to lambda REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=80008=80016 BRANCH arcpatch-D24773_1 REVISION

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added inline comments. INLINE COMMENTS > dfaure wrote in trashsizecache.cpp:131 > Interesting. One benefit of lambdas is that they can work on local variable; > I would have captured max_mtime by reference and modified it inside the > lambda. > Written this way (which I guess more "pure

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 13 Apr 2020 13:06:09 + Build duration: 23 sec and counting CONSOLE OUTPUT

D25267: Improve XCF support

sandsmark abandoned this revision. sandsmark added a comment. I messed up and it got linked to the wrong phabricator review... Here it is anyways: https://cgit.kde.org/kimageformats.git/commit/?id=c60e77c048d32ccf743cec695743b77b2b25dc87 REPOSITORY R287 KImageFormats REVISION DETAIL

D28746: Show previews on encrypted filesystems

marcingu updated this revision to Diff 80022. marcingu added a comment. Removing extra whitespaces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28746?vs=79991=80022 REVISION DETAIL https://phabricator.kde.org/D28746 AFFECTED FILES

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

This revision was automatically updated to reflect the committed changes. Closed by commit R294:9075f6345cfa: [KBookMarksMenu] Set objectName for newBookmarkFolderAction (authored by ahmadsamir). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 80008. meven marked 3 inline comments as done. meven added a comment. Add lambdas to factorize code, comments update, move a couple of DiscSpaceUtil::sizeOfPath to where there are needed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a comment. > But I'm wondering how much effort we want to put into finding the latest mtime, this is starting to sound like a very expensive operation. I agree let's not got too deep down the rabbit hole. This is not a very common use case > When kio_trash takes care

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

dfaure added a comment. I mean, the user can press cancel, that's when QColorDialog returns an invalid color. If there was a concept like an invalid font we could do the same here, but there's no such concept in QFont. So yep, no better way. REPOSITORY R236 KWidgetsAddons REVISION

D28769: Add Icelandic Krona

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28769 To: sandsmark, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, bruns

D28745: Skip caching thumbnails on encrypted filesystems

ngraham retitled this revision from "Skipping catching of thumbnails on encrypted filesystems" to "Skip caching thumbnails on encrypted filesystems". ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu,

D28769: Add Icelandic Krona

sandsmark updated this revision to Diff 7. sandsmark added a comment. Forgot to base it on master instead of my feature branch. REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28769?vs=79909=7 REVISION DETAIL

D28746: Show previews on encrypted filesystems

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in previewjob.cpp:718 > unrelated change Now there are extra spaces on that line. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham,

D28745: Skipping catching of thumbnails on encrypted filesystems

ngraham accepted this revision. ngraham added inline comments. INLINE COMMENTS > thumbnail.cpp:724 > // no cached version is available, a new thumbnail must be > created > - > QSaveFile thumbnailfile(thumbPath.absoluteFilePath(thumbName)); There are extra spaces on

D28797: Removing extra whitespaces

marcingu created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. marcingu requested review of this revision. REVISION SUMMARY Removing extra whitespaces REPOSITORY R320 KIO Extras REVISION DETAIL

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D24773_1 REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28535: [KIO-MTP] Fix null pointer dereference

This revision was automatically updated to reflect the committed changes. Closed by commit R320:94e7b64325f9: [KIO-MTP] Fix null pointer dereference (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28535?vs=79252=79998 REVISION

D28793: [KBookMarksMenu] Set objectName for newBookmarkFolderAction

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R294 KBookmarks BRANCH l-new-folder-action (branched from master) REVISION DETAIL https://phabricator.kde.org/D28793 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R236:56090c8f380e: [KFontRequester] Port from QFontDialog to KFontChooserDialog (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

Re: Update on Status of Gitlab Migration

On Sat, Apr 11, 2020 at 11:36 AM Ben Cooksley wrote: > > Good morning Community, > > I'm pleased to report that this week we reached a major milestone, > with all the necessary technical components now being in place on our > side for our migration to Gitlab to take place. Regarding this: is the

D25267: Improve XCF support

aacid added a comment. In D25267#647129 , @sandsmark wrote: > I messed up and it got linked to the wrong phabricator review... Here it is anyways: > >

D28746: Show previews on encrypted filesystems

marcingu marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/49/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 16:04:00 + Build duration: 5 min 46 sec and counting JUnit Tests Name:

D28796: Update Logtalk language syntax support

pmoura created this revision. pmoura added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. pmoura requested review of this revision. REVISION SUMMARY Adds support for new built-predicates and fixes escape sequences in

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in kfontrequester.cpp:188 > Plus we can't end up with a non-valid QFont, the dialog is filled from > QFontDataBase; so unless the user went and uninstalled the font while the > dialog was open, it should be OK. Also, font

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

kossebau added a comment. Ping? I have seen a few projects having CMAKE_AUTOUIC set to ON, due to copy-pasted cmake code, or having converted to ki18n only during development. So let's help them to avoid unneeded file generation while they are finding the cmake skills. And this would

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontrequester.cpp:188 > It's really not obvious from the above that this modifies m_selFont. > > But I see QFont has no isValid() so we can't adopt an API like > QColorDialog::getColor (plus KFontChooserDialog has been

D28746: Show previews on encrypted filesystems

ivan accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae0beded1fd9: Show previews on encrypted filesystems (authored by marcingu, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28746?vs=80022=80024

D28746: Show previews on encrypted filesystems

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

ngraham added a comment. Excellent job. This is a real improvement. Keep the great patches coming! :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a dependent revision: D28794: Allow to display to use UDS_RECURSIVE_SIZE in status bar UDS_RECURSIVE_SIZE. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24773 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: kde-frameworks-devel, LeGast00n,

D28800: Always create actioncollection

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Otherwise subclasses that unconditionally use m_actionCollection will get crashes. Observed in D28789

D28800: Always create actioncollection

nicolasfella added reviewers: Frameworks, dfaure, stefanocrocco. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D28800 To: nicolasfella, #frameworks, dfaure, stefanocrocco Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: Regarding this: is the subdomain going to stay invent.kde.org once we have officially moved? I find it's a bit confusing to use that instead of gitlab.kde.org I agree. gitlab.kde.org would make more sense to me, mirroring phabricator.kde.org.

D26918: Improve KNotification API docs

nicolasfella added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella, #frameworks, broulik, jucato Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: WIP: Use CSS grid to improve layout

ognarb created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ognarb requested review of this revision. REPOSITORY R264 KApiDox BRANCH flex-grid REVISION DETAIL https://phabricator.kde.org/D28811 AFFECTED

D28088: Fix warnings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:298ce0ed7ff4: Fix warnings (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 23:39:32 + Build duration: 3 min 5 sec and counting JUnit Tests

Re: Update on Status of Gitlab Migration

On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley wrote: > > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > > Regarding this: is the subdomain going to stay invent.kde.org once we > > > have officially moved? I find it's a bit confusing

Re: Update on Status of Gitlab Migration

On Tue, 14 Apr 2020, 11:45 am Aleix Pol, wrote: > On Mon, Apr 13, 2020 at 8:30 PM Ben Cooksley wrote: > > > > On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > > > > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > > > Regarding this: is the subdomain going to stay invent.kde.org once

D26650: Use KService to look for Filelight

ngraham added a comment. Ping @shubham REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27220: add pix icon

ngraham added a comment. @camiloh, how do you feel about this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh, #vdg Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D26918: Improve KNotification API docs

cblack requested changes to this revision. cblack added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Mainpage.dox:13 > +In order to perform a notification, you need to create a description file, > which contains > +default parameters of the notification. It

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham added a dependent revision: D28804: Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Update on Status of Gitlab Migration

On Tue, Apr 14, 2020 at 3:35 AM Nate Graham wrote: > > On 4/13/20 4:44 AM, Albert Vaca Cintora wrote: > > Regarding this: is the subdomain going to stay invent.kde.org once we > > have officially moved? I find it's a bit confusing to use that instead > > of gitlab.kde.org > > I agree.

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham added a dependent revision: D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 262551 Depends on D28802

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b3fc2aedd86: Always create actioncollection (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28800?vs=80034=80051 REVISION DETAIL

D28805: Tweak kcmcontrols docs

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R296 KDeclarative BRANCH tweakdocs REVISION DETAIL https://phabricator.kde.org/D28805 AFFECTED FILES

D28800: Always create actioncollection

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) REPOSITORY R294 KBookmarks BRANCH emptycoll REVISION

D28802: Add standard shortcut for "Show/Hide Hidden Files"

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH add-show-hide-hidden-files-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/51/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 20:09:33 + Build duration: 5 min 0 sec and counting JUnit Tests Name:

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

ngraham added a comment. Will do! REPOSITORY R241 KIO BRANCH use-standard-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28803 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

This revision was automatically updated to reflect the committed changes. Closed by commit R237:65cc12ab3ec8: Add standard shortcut for Show/Hide Hidden Files (authored by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28802?vs=80039=80049 REVISION

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Please land approx 20mn after D28802 to give CI time to update KConfig first ;) (or check when build.kde.org says it got rebuilt) REPOSITORY R241

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d3977bdeacbb: [KDirOperator] Use new Show/Hide Hidden Files standard shortcut (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28805: Tweak kcmcontrols docs

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

ngraham created this revision. ngraham added reviewers: Plasma, apol, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Use a MultiPointTouchHandler as the top-level item to handle touch input.

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Add a standard shortcut for this action so it can be synchronized between

D28805: Tweak kcmcontrols docs

nicolasfella added a reviewer: jucato. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28805 To: nicolasfella, #frameworks, jucato Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

nicolasfella added a comment. In D28800#647508 , @dfaure wrote: > (but now konqueror creates another one, so the konqueror patch needs to changed to "if exactly 5.69" only, right?) makes sense REPOSITORY R294 KBookmarks BRANCH

D25267: Improve XCF support

sandsmark added a comment. In D25267#647148 , @aacid wrote: > Seems like the windows build is broken :/ > > https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.14/16/console Seems like I forgot to use

D24773: kio_trash: Add size, modification, access and create date for trash:/

This revision was automatically updated to reflect the committed changes. Closed by commit R241:570b48e656c7: kio_trash: Add size, modification, access and create date for trash:/ (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24773?vs=80016=80061#toc REPOSITORY

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 543 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/543/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 14 Apr 2020 05:41:33 + Build duration: 15 min and counting BUILD ARTIFACTS

D28745: Skipping catching of thumbnails on encrypted filesystems

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > thumbnail.cpp:730 > +const auto thumbRootMount = mountsList.findByPath(thumbRoot); > +std::copy_if(mountsList.begin(), mountsList.end(), >

D28746: Show previews on encrypted filesystems

marcingu marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28745: Skipping catching of thumbnails on encrypted filesystems

marcingu updated this revision to Diff 79986. marcingu added a comment. Review fixes REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=79826=79986 REVISION DETAIL https://phabricator.kde.org/D28745 AFFECTED FILES thumbnail/thumbnail.cpp To:

D28746: Show previews on encrypted filesystems

marcingu updated this revision to Diff 79985. marcingu added a comment. Review fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28746?vs=79832=79985 REVISION DETAIL https://phabricator.kde.org/D28746 AFFECTED FILES src/widgets/previewjob.cpp To:

D28745: Skipping catching of thumbnails on encrypted filesystems

marcingu marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D28787: Fix PC3 BusyIndicator binding loop

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-busyindicator-binding-loop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28787 To: ngraham, #plasma, davidedmundson, broulik Cc:

D28746: Show previews on encrypted filesystems

ivan added inline comments. INLINE COMMENTS > previewjob.cpp:692 > { > +bool isEncrypted = > encryptedMountsList.findByPath(currentItem.item.url().toLocalFile()); > bool save = bSave && `const` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To:

D28770: Avoid blocking the UI thread

broulik added a comment. I don't fully understand the need for a thread here. It merely blocks because the API is synchronous and thus we create a nested eventloop. I don't think the writing and parsing of the cache file is a real bottleneck here. INLINE COMMENTS > currency.cpp:57 > +

D28745: Skipping catching of thumbnails on encrypted filesystems

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n,

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

bruns updated this revision to Diff 79989. bruns added a comment. put statics in namespace REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28776?vs=79946=79989 REVISION DETAIL https://phabricator.kde.org/D28776 AFFECTED FILES

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfontrequester.cpp:188 > + > +const int result = KFontChooserDialog::getFont(m_selFont, flags, > q->parentWidget()); > It's really not obvious from the above

D28746: Show previews on encrypted filesystems

marcingu updated this revision to Diff 79991. marcingu added a comment. Moving boolean variables to the front of logic statement. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28746?vs=79985=79991 REVISION DETAIL https://phabricator.kde.org/D28746

D28746: Show previews on encrypted filesystems

marcingu marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

This revision was automatically updated to reflect the committed changes. Closed by commit R245:340e1ac7c38f: [FstabWatcher] Use static QStringLiteral instead of macro (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28778?vs=79990=79992

D28779: [Fstab] Use new style connect API

bruns edited the summary of this revision. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28779 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 10:27:11 + Build duration: 2 min 10 sec and counting JUnit Tests Name:

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

This revision was automatically updated to reflect the committed changes. Closed by commit R245:3adf5d472448: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28782?vs=79955=79994

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 10:29:41 + Build duration: 1 min 37 sec and counting JUnit Tests Name:

D28746: Show previews on encrypted filesystems

ivan added inline comments. INLINE COMMENTS > previewjob.cpp:697 > > !currentItem.item.url().adjusted(QUrl::RemoveFilename).toLocalFile().startsWith(thumbRoot)) > -&& !sequenceIndex; > +&& !sequenceIndex && !isEncrypted; > QImage thumb;

D28746: Show previews on encrypted filesystems

dfaure added inline comments. INLINE COMMENTS > previewjob.cpp:307 > > +//Prepare encryptedMountsList for which will be used in ::slotThumbData > const auto mountsList = KMountPoint::currentMountPoints(); "for which will be used" ... remove `for` ? REPOSITORY R241 KIO REVISION

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

bruns updated this revision to Diff 79990. bruns added a comment. move statics into namespace REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28778?vs=79949=79990 REVISION DETAIL https://phabricator.kde.org/D28778 AFFECTED FILES

D28779: [Fstab] Use new style connect API

This revision was automatically updated to reflect the committed changes. Closed by commit R245:62de28267684: [Fstab] Use new style connect API (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28779?vs=79951=79993 REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 13 Apr 2020 10:31:41 + Build duration: 2 min 5 sec and counting JUnit Tests Name:

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > trashimpl.cpp:1098 > + > +// Find lateest modification date > +if (res.mtime > latestModifiedDate) { typo: latest > trashsizecache.cpp:144 >

  1   2   >