D29745: look for kded as runtime dep

2020-06-02 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:15869b83200f: look for kded as runtime dep (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29745?vs=82839=83201 REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-02 Thread Méven Car
meven added a comment. In D29397#674365 , @kossebau wrote: > To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where we/you could just use the for-now-KF-only theme

D29258: Don't use notifybysnore.h on MSYS2

2020-06-02 Thread Piyush Aggarwal
brute4s99 added a comment. I still do not understand the utility of this patch. What do you hope to fix by this patch exactly? > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. which compiler are you referring to here?

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 156 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/156/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 02 Jun 2020 15:12:40 + Build duration: 6 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 157 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/157/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 02 Jun 2020 15:12:40 + Build duration: 4 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 655 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/655/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Jun 2020 15:12:40 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 92 - Fixed!

2020-06-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/92/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 02 Jun 2020 13:20:14 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

D18915: Fix batchrename changing extension to lower case

2020-06-02 Thread David Faure
dfaure added a comment. The fix will be in 5.15.1. Can you add Qt version checks if you intend to keep the KIO workaround? Or we just say it's fixed in Qt and we discard this. Your choice. But the unittest would make sense to keep (with Qt version checks, if there's no workaround).

D17816: Support for xattrs on kio copy/move

2020-06-02 Thread Gleb Popov
arrowd added a comment. Almost every comment have been addressed. Please, give this another look. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 158 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/158/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 02 Jun 2020 22:34:18 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D17816: Support for xattrs on kio copy/move

2020-06-02 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > file_unix.cpp:142 > +ssize_t listlen = 0; > +QByteArray keylist(listlen, Qt::Uninitialized); > +do { just `QByteArray keylist;` > file_unix.cpp:143 > +QByteArray keylist(listlen, Qt::Uninitialized); > +do { > +

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 656 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/656/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 02 Jun 2020 22:34:18 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 157 - Still Unstable!

2020-06-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/157/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 02 Jun 2020 22:34:18 + Build duration: 17 min and counting BUILD ARTIFACTS

D17816: Support for xattrs on kio copy/move

2020-06-02 Thread Gleb Popov
arrowd updated this revision to Diff 83203. arrowd marked 17 inline comments as done. arrowd added a comment. - Address comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83192=83203 BRANCH arcpatch-D17816 REVISION DETAIL