D11874: change 24px view-media-artist icon

astippich added a comment. ping @andreask REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: #frameworks, michaelh, ngraham, bruns

D12156: implement reading of rating tag

astippich added a comment. I agree, there are several problems coming from the fact that we basically have two sources for the same property, which can potentially conflict. Btw, we already have the same issue with the comment property. In D12156#257888

D12320: [RFC] add ability to read embedded cover files

astippich retitled this revision from "{RFC] add ability to read embedded cover files" to "[RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo,

D12320: {RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33934. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - adjust to feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12801: search for album artist and albumartist tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY album artist and albumartist tags

D12320: [RFC] add ability to read embedded cover files

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > mgallien wrote in embeddedimagedata.h:40 > You should be using a std::unique_ptr instead of a raw pointer. You also > should take care of either forbidding copy (operator= and copy constructor) > or

D12800: split tests for better readability

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY create separate test functions

D12320: [RFC] add ability to read embedded cover files

astippich marked 4 inline comments as done. astippich added a comment. Thanks a lot! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich,

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 33955. astippich added a comment. - fix usage of qflags - use unique_ptr REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33934=33955 BRANCH cover_read REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260761 , @anthonyfieroni wrote: > I do *same* thing in KIO-Extras https://phabricator.kde.org/source/kio-extras/browse/master/thumbnail/audiocreator.cpp Yeah, I found that when I was looking into

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. @anthonyfieroni The preview is actually working perfectly fine, my configuration was wrong. I swear I checked it before :) sorry for the noise REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien,

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34012. astippich added a comment. - add an AllImages flag - add simple documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=33955=34012 BRANCH cover_read REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. In D12320#260789 , @anthonyfieroni wrote: > In D12320#260768 , @astippich wrote: > > > Unfortunately, found it only after I wrote all that myself :/ > > > Sorry i

D12801: search for album artist and albumartist tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5b6caa0b118b: search for album artist and albumartist tags in taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12800: split tests for better readability

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0c738df2c2b7: split tests for better readability (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12800?vs=33935=34059 REVISION

D12932: handle string lists as input

astippich added a comment. Unfortunately I couldn't find tests that execute this code path. Do we have test for this somewhere? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D12932: handle string lists as input

astippich created this revision. astippich added a reviewer: bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY handles string lists as inputs for

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 34829. astippich added a comment. - simplify code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=34012=34829 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D12320 AFFECTED FILES

D12992: New elisa icon

astippich added a comment. In D12992#266673 , @mgallien wrote: > In D12992#266288 , @alex-l wrote: > > > F5863162: image.png > > > > ^ I'm for this one

D12932: handle string lists as input

This revision was automatically updated to reflect the committed changes. Closed by commit R293:03ab297f2512: handle string lists as input (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34323=34395 REVISION DETAIL

D12950: add test which checks the property types

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Check the type of the

D12156: implement reading of rating tag

astippich added a comment. any comments on the previous discussion? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12156: implement reading of rating tag

astippich updated this revision to Diff 34398. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - rebase on master - implement rating tag for m4a REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12932: handle string lists as input

astippich updated this revision to Diff 34318. astippich added a comment. - incorporate feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34314=34318 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

astippich updated this revision to Diff 34323. astippich added a comment. - fix mistakes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12932?vs=34318=34323 BRANCH string_lists REVISION DETAIL https://phabricator.kde.org/D12932 AFFECTED FILES

D12932: handle string lists as input

astippich added a comment. with D11365 applied (e.g. multiple entries are string lists) and using a file with multiple artists balooshow -x testmultiple.opus Bitrate: 67000 Channels: 1 Duration: 1 Genre:

D12932: handle string lists as input

astippich marked 4 inline comments as done. astippich added a comment. Thanks, and sorry, copied and pasted too quickly without thinking this through REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12932 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D13460: implement the lyrics tag for taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the ability to read the

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 35940. astippich added a comment. - rebase again after test data changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=35934=35940 BRANCH cover_read REVISION DETAIL

D12320: add ability to read embedded cover files

astippich retitled this revision from "[RFC] add ability to read embedded cover files" to "add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni,

D12320: [RFC] add ability to read embedded cover files

astippich marked 8 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D11874: change 24px view-media-artist icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:5218c83647ca: change 24px view-media-artist icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11874?vs=31124=35939 REVISION DETAIL

D12156: implement reading of rating tag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0b0f2d2eb36d: implement reading of rating tag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=35242=35938 REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

astippich updated this revision to Diff 35934. astippich added a comment. - implement feedback - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=34829=35934 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D12320

D11874: change 24px view-media-artist icon

astippich added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11874 To: astippich, #vdg, andreask Cc: kde-frameworks-devel, michaelh, ngraham, bruns,

D12320: add ability to read embedded cover files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:885616cee7a0: add ability to read embedded cover files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=35940=36219 REVISION

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? would be nice to ship it with Kf 5.48 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov,

D12156: implement reading of rating tag

astippich updated this revision to Diff 35242. astippich added a comment. - update comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=34398=35242 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. Sorry, I meant Kf 5.47, so deadline on Saturday. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. working fine here, but someone more qualified should have a look at the code REPOSITORY R244 KCoreAddons BRANCH d13583 REVISION DETAIL https://phabricator.kde.org/D13583 To:

D13700: implement the replaygain tags

astippich added a comment. I decided to store the values as string, including the "dB" unit. Another possibility would be to store them as floats, but this would require adjustments to baloo first. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To:

D13700: implement the replaygain tags

astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the ability to read the

D13700: implement reading of the replaygain tags

astippich retitled this revision from "implement the replaygain tags" to "implement reading of the replaygain tags". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13700: implement reading of the replaygain tags

astippich added a comment. In D13700#282253 , @bruns wrote: > "dB" is nothing more than deci-Bel, i.e. 0.1 Bel. You can convert the value to e.g. mB or uB. This looks unfamiliar, but is e.g. also used by the CRDA WiFi compliance tool. I

D12320: add ability to read embedded cover files

astippich added a comment. sorry for the caused inconvenience REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: bcooksley, dfaure, anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich added a comment. Unfortunately it does not apply here because the base commit cannot be found. Also, may I already add an request? It would be great if the unit Hertz is included since it is used in baloo-widgets REPOSITORY R244 KCoreAddons REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich added a comment. baloo handles floats actually just fine REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 36901. astippich added a comment. - use floats to store the replaygain tags REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=36571=36901 BRANCH replaygain REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. In D12156#252575 , @mgallien wrote: > If I have correctly understood the ideas behind the conception of Baloo, we should probably prefer to store the rating with a "native" solution instead of the xattr one that is

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 33375. astippich added a comment. - new reader for embedded image data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=32493=33375 BRANCH cover_read REVISION DETAIL

D12320: {RFC] add ability to read embedded cover files

astippich retitled this revision from "add ability to read embedded cover files" to "{RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov,

D12320: {RFC] add ability to read embedded cover files

astippich added a comment. So, this is a next attempt trying to create a solution that works for everyone. It is not yet perfect, but I'd like to get some feedback if such an approach is favorable. A new class is created that will handle the cover art. This way, there won't be any

D12156: implement reading of rating tag

astippich added a comment. ping @mgallien REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D10293: remove view-media-playlist from preferences icons

astippich created this revision. astippich added reviewers: Breeze, VDG, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the view-media-playlist icon in the

D10293: remove view-media-playlist from preferences icons

astippich added a comment. I don't know if it is acceptable to just remove the icon. I also don't know if this is used anywhere. Stumbled upon while looking into icons for the Elisa music player where this icon then creates strange results. I think another workaround would be to create a

D10292: change 32px icons for playlist shuffle and repeat

astippich updated this revision to Diff 26512. astippich added a comment. update to 1px of line width, was 1.5 due to the scaling REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=26497=26512 BRANCH playlist_shuffle_repeat REVISION DETAIL

D10292: change 32px icons for playlist shuffle and repeat

astippich created this revision. astippich added reviewers: Breeze, VDG, andreaska. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY the 32px icons for media-playlist-shuffle

D10279: add 24px media-album-cover icon

astippich updated this revision to Diff 26484. astippich added a comment. - do the same thing for dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26461=26484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10279

D10279: add 24px media-album-cover icon

astippich updated this revision to Diff 26495. astippich added a comment. use a proper feature branch, which I forgot to use before REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26484=26495 BRANCH media-album-cover REVISION DETAIL

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Before: F5691700: Screenshot_20180204_134019.png F5691702: Screenshot_20180204_134042.png After, which is also how the 24px and lower icons look like: F5691706:

D10292: change 32px icons for playlist shuffle and repeat

astippich edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska Cc: #frameworks, michaelh, ngraham

D10365: New icon for Elisa music player

astippich added a comment. I was a little bit hesitant at first, but I'm starting to like the idea of a cassette as an icon for Elisa. But I think the text in the icon is not required. It will usually be so small that no-one can read it. Anyways, Matthieu should have a comment about this.

D10279: add 24px media-album-cover icon

astippich created this revision. astippich added a reviewer: Breeze. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY media-album-cover icon is missing for the 24px size,

D10279: add 24px media-album-cover icon

astippich added a comment. It just adds a missing link to an already existing icon, is a screenshot needed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10279 To: astippich, #breeze Cc: ngraham, #frameworks, michaelh

D10803: handle more tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY adds the ability to read more tags through taglib when

D10803: handle more tags in taglibextractor

astippich added a comment. First of all, please review carefully for ABI compatibility, I do not know what to watch for that. So I decided to walk into the minefield that tags are. Everyone implements it differently. I've implemented some tags that seem to be supported across a wide

D10293: remove view-media-playlist from preferences icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6927b97af007: remove view-media-playlist from preferences icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10293?vs=26499=27719

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Thanks for the feedback! So the correct fix would be to change the 22px and 24px icons to use circles around the icons? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask Cc:

D10279: add 24px media-album-cover icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ff179872c915: add 24px media-album-cover icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26495=27718 REVISION DETAIL

D10279: add 24px media-album-cover icon

astippich added a comment. Hi, it would be nice to get some feedback on this. Same for D10293 and D10292 . If this is not the proper way to contribute to breeze icons, please point me in the right direction.

D10803: handle more tags in taglibextractor

astippich planned changes to this revision. astippich added a comment. In D10803#213783 , @michaelh wrote: > In D10803#213767 , @astippich wrote: > > > I don't know dolphin works, but given how

D13460: implement the lyrics tag for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:535de62bec16: implement the lyrics tag for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13460?vs=35941=36476

D13584: KFormat: Replace byte specific implementation with generic one

astippich added a comment. I've been running with it for a while and found no issues, but only giving +1 this time because of the fallout from the other patch (which I didn't catch, so others should have a look) REPOSITORY R244 KCoreAddons REVISION DETAIL

D13906: add missing include

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9ba0d27ef263: add missing include (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13906?vs=37210=40405 REVISION DETAIL

D14121: KFormat: Add unit tests for mili/micro SI prefixes

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. test itself is fine, but I spotted a typo. INLINE COMMENTS > kformattest.cpp:118 > + > +QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1, > KFormat::UnitPrefix::Mili,

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:944 > Could you check if it is not faster to use QLatin1String here ? At least if my interpretations of callgrind are correct, it's exactly the same. REPOSITORY R286 KFileMetaData REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40824. astippich marked 5 inline comments as done. astippich added a comment. - add documentation, remove unrelated changes and debug info - get rid of string comparisons for id3v2 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 40861. astippich added a comment. - use different test data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40858=40861 BRANCH taglib_write REVISION DETAIL https://phabricator.kde.org/D15220

D15220: implement more basic tags for taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement all basic tags directly provided by taglib for

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:255 > you can use TStringToQString > `data.replayGainTrackGain = > TStringToQString(userTextFrame->fieldList().back());` toCString() was actually completely unnecessary. I removed it since

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40851. astippich marked 4 inline comments as done. astippich added a comment. - improve readability and add check REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40824=40851 BRANCH replaygain

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:50 > This is definitely broken: > http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d > > `const wchar_t* TagLib::String::toCWString() const` > > > Returns a standard

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 41119. astippich marked 2 inline comments as done. astippich added a comment. - remove space and adjust comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40851=41119 BRANCH replaygain REVISION

D12950: add test which checks the property types

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich commandeered this revision. astippich edited reviewers, added: kossebau; removed: astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich updated this revision to Diff 37205. astippich added a comment. -fix the no-meta test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13885?vs=37148=37205 BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885

D13885: taglibextractor: Restore extracting audio props without tags existing

This revision was automatically updated to reflect the committed changes. Closed by commit R286:41c075129d46: taglibextractor: Restore extracting audio props without tags existing (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich edited the summary of this revision. astippich edited the test plan for this revision. REPOSITORY R286 KFileMetaData BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo,

D13906: add missing include

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the include of qmap to the

D12950: add test which checks the property types

astippich added a comment. I would like to work on D11365 again where it was suggested to add the test first. As you can see from the tests, the types defined for each property in KFileMetaData do not match the output for the taglibextractor. The types

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich added a comment. Sorry for causing the regressions and thanks for the fix! I just checked all the no-meta files. The reason that they did not cause the tests to fail is that they still have at least one tag defined that is not read (encoder settings for example). I think it

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. after D11049 where the frames for the media buttons were removed I think this is quite needed for a consistent look and feel. I also added 32px version for no repeat and no shuffle which I need for a toggle button for #elisa

D10292: change 32px icons for playlist shuffle and repeat

astippich updated this revision to Diff 29110. astippich added a comment. - add more 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=26512=29110 BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292

D10918: taglibextractor: Refactor for better readability

astippich added a comment. Btw, I'm not opposed anymore for merging before D10803 , as I need some more time to think about the value types and probably also need to extend the tests. I will adapt to the changes afterwards. REPOSITORY R286

D10918: taglibextractor: Refactor for better readability

astippich accepted this revision. astippich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > michaelh wrote in taglibextractor.cpp:331 > I think it is. At this point only `ogg`, `flac` and `opus` should be left. > Also I only refactored and didn't change

D10492: add 64px media icons for elisa

astippich added a comment. Sorry for being so late to the party, but I just found this while reading the Frameworks 5.44 release notes. First of all, I am really grateful for the new icon. Actually, it would be really cool if we could also get a colorized version of a "media-artist" icon,

D11365: also test for value types in taglibextractortest and fix errors

astippich created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY taglib tests never tested for the expected value type. add this to the tests and fix

D11360: provide sample rate in kHz

astippich added a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11360 To: astippich, #frameworks Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11365: also test for value types in taglibextractortest and fix errors

astippich added reviewers: Frameworks, Baloo. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo Cc: #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

  1   2   3   4   5   6   7   8   9   10   >