Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

uploaded/files/2016/07/18/6cbb3f10-9513-478b-a865-9fc791c006d5__linktoapplication_afterpatch.png after_patch https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png Thanks, Chinmoy Ranjan Pradhan ___

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

9fc791c006d5__linktoapplication_afterpatch.png after_patch https://git.reviewboard.kde.org/media/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

extension with the filename or not. - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/#review97622 --- On July 20, 201

Review Request 128492: [kio] Minor typo in file ioslave

2 Diff: https://git.reviewboard.kde.org/r/128492/diff/ Testing --- File Attachments the error message https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/70053ddf-d72d-4ffe-936a-c38068de5d0d__erroemessage.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128492: [kio] Minor typo in file ioslave

it on my behalf :) - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128492/#review97688 --- On July 21, 2016, 3:34 a.m

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

oard.kde.org/media/uploaded/files/2016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128492: [kio] Minor typo in file ioslave

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 1f30604a4cd1a96d8b733cdae53c5adbe38fda59 by Albert Astals Cid on behalf of Chinmoy Ranjan Pradhan to branch master. Repository: kio Description --- This fixes a typo in file

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/#review97725 --- On July 21, 2016, 4:30 p.m., Chinmoy Ranjan Pradhan wrote: > > ---

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2e613b1 Diff: https://git.reviewboard.kde.org/r/128499/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

ilemenu.cpp 2e613b1 Diff: https://git.reviewboard.kde.org/r/128499/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

it.reviewboard.kde.org/r/128499/#review97746 ------- On July 22, 2016, 6:35 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

desktop path. Diffs (updated) - src/filewidgets/knewfilemenu.cpp 2e613b1 Diff: https://git.reviewboard.kde.org/r/128499/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

ilemenu.cpp 2e613b1 Diff: https://git.reviewboard.kde.org/r/128499/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

ilemenu.cpp 7374417 Diff: https://git.reviewboard.kde.org/r/128499/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128501: KNewFileMenu: Fix creating link to application

01/diff/ Testing --- Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128501: KNewFileMenu: Fix creating link to application

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 525232d30ee682de4778667c8244778b50620e67 by David Faure on behalf of Chinmoy Ranjan Pradhan to branch master. Bugs: 363673 https://bugs.kde.org/show_bug.cgi?id=363673

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 2dd13d36f3f9810c8d92acfff89e9cd6e1c63689 by David Faure on behalf of Chinmoy Ranjan Pradhan to branch master. Repository: kio Description --- When creating a new file, if a

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

ia/uploaded/files/2016/07/18/2e9f5fa5-eaaa-4abc-a0ac-f492fb01faa3__newfile_aftepatch.png add new device menu https://git.reviewboard.kde.org/media/uploaded/files/2016/07/21/1e115e07-3546-4abe-b913-9e841c21f672__new_addition.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

. - Chinmoy Ranjan Pradhan On July 23, 2016, 7:09 p.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 128527: FileUndoManager: Undoing symlink creation

--- build Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

(updated) - autotests/fileundomanagertest.h c663f92 autotests/fileundomanagertest.cpp 761cc76 src/filewidgets/knewfilemenu.cpp bb6fc04 src/widgets/fileundomanager.cpp ed5edb0 Diff: https://git.reviewboard.kde.org/r/128527/diff/ Testing --- build Thanks, Chinmoy Ranjan

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

-- On July 31, 2016, 9:28 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128527/ > -

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

> On July 31, 2016, 9:47 a.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > <https://git.reviewboard.kde.org/r/128527/diff/2/?file=472624#file472624line421> > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: &g

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

/filewidgets/knewfilemenu.cpp bb6fc04 Diff: https://git.reviewboard.kde.org/r/128527/diff/ Testing --- build Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

>fileundomanager unittest - to use KIO::link The only issue with using KIO::link is that creating new links in Folder View plasmoid will fail due to the checks in CopyJob::linkNextFile. - Chinmoy --- This is an automatically gen

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

63f92 autotests/fileundomanagertest.cpp 761cc76 src/filewidgets/knewfilemenu.cpp bb6fc04 Diff: https://git.reviewboard.kde.org/r/128527/diff/ Testing --- build Thanks, Chinmoy Ranjan Pradhan ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 116d7dfddbfc4b3433954f79711a4f19ee32d48b by Chinmoy Ranjan Pradhan to branch master. Repository: kio Description --- This patch adds the support for undoing creation of new

Review Request 128618: Fix creating symlink in Folder View

-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128618: Fix creating symlink in Folder View

cause the destination doesn't exist at the time of stat. - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98157 -------------

Re: Review Request 128618: Fix creating symlink in Folder View

gt; > See line 410, the local path for the dest is even stored already: > > m_dest = QUrl::fromLocalFile(sLocalPath); > > > > So you should be able to just use if (m_dest.isLocalFile()) { ... } > > here. > > Chinmoy Ranjan Pradhan wrote: &g

Re: Review Request 128618: Fix creating symlink in Folder View

gt; > See line 410, the local path for the dest is even stored already: > > m_dest = QUrl::fromLocalFile(sLocalPath); > > > > So you should be able to just use if (m_dest.isLocalFile()) { ... } > > here. > > Chinmoy Ranjan Pradhan wrote: &g

Re: Review Request 128618: Fix creating symlink in Folder View

gt; > See line 410, the local path for the dest is even stored already: > > m_dest = QUrl::fromLocalFile(sLocalPath); > > > > So you should be able to just use if (m_dest.isLocalFile()) { ... } > > here. > > Chinmoy Ranjan Pradhan wrote: &g

Re: Review Request 128618: Fix creating symlink in Folder View

ments error message https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128618: Fix creating symlink in Folder View

simpler way would be to overload kio::link. What do you say? - Chinmoy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98236 --------------

Re: Review Request 128618: Fix creating symlink in Folder View

ests in kio's jobtest.cpp as starting point: > > void createSymlink(); > > void createSymlinkAsShouldSucceed(); > > void createSymlinkAsShouldFail(); > > and add tests for any other code path you see in your code. > > Chinmoy Ranjan Pradhan wrote: >

Re: Review Request 128618: Fix creating symlink in Folder View

/diff/ Testing --- All tests pass. File Attachments error message https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128618: Fix creating symlink in Folder View

sting --- All tests pass. File Attachments error message https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128618: Fix creating symlink in Folder View

https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128618: Fix creating symlink in Folder View

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit b27d51f61d5d89390026bbb094218df2f39dd343 by Chinmoy Ranjan Pradhan to branch master. Repository: kio Description --- KIO::link creates symlink when either protocol+host+port

Review Request 128889: Fix KFileItem::overlays returning empty string values

ompletely empty, size=0) This patch attempts to fix the issue. Diffs - src/core/kfileitem.cpp b5ed5fd Diff: https://git.reviewboard.kde.org/r/128889/diff/ Testing ------- Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 128889: Fix KFileItem::overlays returning empty string values

-symbiolic-link} and for a plain text file it'll be like : {""} (here it should be completely empty, size=0) This patch attempts to fix the issue. Diffs - src/core/kfileitem.cpp b5ed5fd Diff: https://git.reviewboard.kde.org/r/128889/diff/ Testing ------- Thanks, Chinmoy Ranjan Pradhan

Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

://git.reviewboard.kde.org/r/129737/diff/ Testing --- File Attachments Error message https://git.reviewboard.kde.org/media/uploaded/files/2017/01/01/b32cbf34-4232-4a7e-9cd7-fe4d30e2fc75__kio_error.png Thanks, Chinmoy Ranjan Pradhan

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

--------- On Jan. 1, 2017, 8:55 a.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129737/ >

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

Thanks, Chinmoy Ranjan Pradhan

D7563: Add privilegeExecution field to file protocol description

chinmoyr updated this revision to Diff 80341. chinmoyr marked an inline comment as done. chinmoyr added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Rebased on master. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.

D7563: Add privilegeExecution field to file protocol description

chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:1331 > +KAuth::Action::DetailsMap details; > +details.insert(KAuth::Action::AuthDetail::DetailMessage, > QStringLiteral("Authenticat

D7563: Add privilegeExecution field to file protocol description

chinmoyr added a comment. In D7563#23 , @ngraham wrote: > What's the status of this patch? I will push this patch after fixing all security issues with kauth support in KIO. (T8075 ) BRANCH master

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30332. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. 1. Made method const. 2. Increment iterator only if erasing failed. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=28541&id=30332 BRAN

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30333. chinmoyr added a comment. Added the missing assignment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=30332&id=30333 BRANCH D10820 REVISION DETAIL https://phabricator.kde.org/D10820 AFFECTED FILES

D10824: Delete IdleSlave having temporary authorization

chinmoyr added a comment. David, what about this patch? It seems to me deleting the IdleSlave object is the only way to kill the ioslave from here. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr, dfaure, #frameworks Cc: #frameworks, michaelh, ngrah

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr updated this revision to Diff 31156. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Addressed David's issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10568?vs=27316&id=31156 BRANCH arcpatch-D10568 REVISION DETAIL http

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.cpp:517 > BTW now that there are 5 duplicated lines below the //reset comment (in error > and finished), it would be worth extracting a reset function... I think it will be better to have a separate commit for that. >

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8b34864135f8: Remove handling of privilege operation confirmation prompts from KIO::Job (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10567?vs=

D10568: Handle privilege operation confirmation prompts in SlaveBase

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0e45fcffd182: Handle privilege operation confirmation prompts in SlaveBase (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10568?vs=31156&id=3122

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr updated this revision to Diff 31227. chinmoyr added a comment. Rebased on D10568 Merged D10437 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10818?vs=28537&id=31227 BRANCH

D10437: Update file ioslave's temporary authorization list

chinmoyr closed this revision. chinmoyr added a comment. Merged with D10818 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10437 To: chinmoyr, #frameworks, dfaure, fvogt Cc: markg, anthonyfieroni, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr added inline comments. INLINE COMMENTS > slavebase.cpp:129 > int m_privilegeOperationStatus; > +QSet m_tempAuths; > @dfaure where should I place this variable? Just before "m_confirmationAsked"? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.k

D10818: Store PolicyKit action which the slave is authorized to perform

chinmoyr updated this revision to Diff 31249. chinmoyr added a comment. Rearranged member vars REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10818?vs=31227&id=31249 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10818 AFFECTED FILES src/co

D10818: Store PolicyKit action which the slave is authorized to perform

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ec4df175be47: Store PolicyKit action which the slave is authorized to perform (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10818?vs=31249&id=3

D11010: Add MSG_SLAVE_STATUS_V2 to slave interface

This revision was automatically updated to reflect the committed changes. Closed by commit R241:004cb9da1913: Add MSG_SLAVE_STATUS_V2 to slave interface (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11010?vs=28540&id=31251 REVISION DETAIL

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now or in near future. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10638 To: chinmoyr, #frameworks Cc: michaelh, ngraham

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, ngraham

D10636: Add support for revoking temporary authorization in KAuth

chinmoyr abandoned this revision. chinmoyr added a comment. Not required right now REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10636 To: chinmoyr, #frameworks Cc: fvogt, dfaure, michaelh, ngraham

D10820: Send slave's polkit authorization status to the host

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ea4329c36830: Send slave's polkit authorization status to the host (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10820?vs=30333&id=31252#toc REPOSITORY R241 KIO CHA

D10822: Store temporary authorization status in IdleSlave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d38b373c8b76: Store temporary authorization status in IdleSlave (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10822?vs=28581&id=31254 REVISION

D10824: Delete IdleSlave having temporary authorization

This revision was automatically updated to reflect the committed changes. Closed by commit R303:bbf120b78773: Delete IdleSlave having temporary authorization (authored by chinmoyr). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10824?vs=28536&id=31255 REVISION

D10141: Restore Persistence=session for the file ioslave kauth helper

chinmoyr accepted this revision. chinmoyr added a comment. This revision is now accepted and ready to land. I think it is now okay to push this diff as the issues pertaining to warning dialogs have been fixed. See T8075 . REPOSITORY R241 KIO BRANCH mas

D10141: Restore Persistence=session for the file ioslave kauth helper

chinmoyr added a comment. In D10141#242463 , @fvogt wrote: > No objections from me - as long as the feature is disabled correctly, which it currently isn't. > > See also https://phabricator.kde.org/T8075#136728. https://cgit.kde.org/

D6834: [KNewFileMenu] Enable creating new files in read-only folders

chinmoyr abandoned this revision. chinmoyr added a comment. Not required due to design changes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr, dfaure Cc: #frameworks, michaelh, bruns

D6199: Allow deleting from write-protected location in dolphin

chinmoyr abandoned this revision. chinmoyr added a comment. Not required due to design changes REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6199 To: chinmoyr, elvisangelaccio, #frameworks, #dolphin Cc: Zren, dfaure, #konqueror

D12291: Accept file descriptor only from root owned process

chinmoyr created this revision. chinmoyr added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Limiting file ioslave to recieve file descriptor only from root owned process helps to make sure that

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32412. chinmoyr edited the summary of this revision. chinmoyr added a comment. Removed dependency on D10273 Rebased on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=2

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32413. chinmoyr added a comment. Fix compilation error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=32412&id=32413 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 AFFECTED FILES src/ios

D10411: Create socket file in user's runtime directory

chinmoyr updated this revision to Diff 32414. chinmoyr edited the summary of this revision. chinmoyr added a comment. Rebased on D10409 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10411?vs=26832&id=32414 BRANCH master

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr abandoned this revision. chinmoyr added a comment. Changes split in D12291 and D10411 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 33761. chinmoyr added a comment. Used QString::toLocal8Bit() instead of QFile::encodeName(). QFile wasn't supposed to be included in this commit. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10410?vs=26831&id=33761 BRA

D10411: Create socket file in user's runtime directory

chinmoyr updated this revision to Diff 33765. chinmoyr added a comment. Rebased on D10410 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10411?vs=32414&id=33765 BRANCH master REVISION DETAIL https://phabricator.kde.org

D12744: Add null pointer check when creating SocketAddress

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY If for some reason SocketAddress:make_address() fails to

D10411: Create socket file in user's runtime directory

chinmoyr added a dependent revision: D12744: Add null pointer check when creating SocketAddress. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependency: D10411: Create socket file in user's runtime directory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependent revision: D12745: Unify API for file descriptor sharing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Pass socket path as const char* to SocketAddress, FdSend

D10411: Create socket file in user's runtime directory

chinmoyr abandoned this revision. chinmoyr added a comment. Split into D12744 and D12745 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh,

D10273: Create proper SocketAddress

chinmoyr abandoned this revision. chinmoyr added a comment. Split into D12744 and D12745 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks, dfaure, ossi Cc: ossi, thi

D10411: Create socket file in user's runtime directory

chinmoyr reclaimed this revision. chinmoyr added a comment. This revision is now accepted and ready to land. Sorry, abandoned it by mistake. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngrah

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr removed a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh, b

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr removed a dependency: D9966: [KIO] Fix issues with sharing of file descriptor. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 33776. chinmoyr marked an inline comment as done. chinmoyr added a comment. Updated the comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=32410&id=33776 BRANCH master REVISION DETAIL https://phabricator

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33819. chinmoyr added a comment. Print the invalid socket path in case of error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33775&id=33819 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33820. chinmoyr added a comment. Print the invalid socket path in case of an error. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33769&id=33820 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 33821. chinmoyr added a comment. Rebased on updated D12744 . REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33819&id=33821 BRANCH master REVISION DETAIL https://phabricato

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 33831. chinmoyr added a comment. Used qPrintable() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33820&id=33831 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 AFFECTED FILES src/ioslave

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr added a comment. Restricted Application added a subscriber: kde-frameworks-devel. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. In D12745#268946 , @ossi wrote: > why aren't you standardizing on std::string? that's cleaner than raw char pointers. > i know we discussed this before to some degree, but i don't remember the particulars. It

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr added a comment. SocketAddress is used only in FdSender and FdRecevier. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:57 > that's a good addition, but it isn't logically part of this patch, because it > adds a new feature (cleanup at exit) instead of only refactoring. So shall I c

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr added a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh, bru

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 34959. chinmoyr marked 2 inline comments as done. chinmoyr added a dependency: D9966: [KIO] Fix issues with sharing of file descriptor. chinmoyr added a comment. Do the first unlink in FdReceiver constructor CHANGES SINCE LAST UPDATE https://phabricato

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 34960. chinmoyr added a comment. corrected the unlink position CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10410?vs=34959&id=34960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10410 AFFECTED FILES src/ioslaves/file/fdre

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 34961. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. fixed the issues mentioned REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33831&id=34961 BRANCH master REVISION DETAIL https://phab

  1   2   3   4   5   6   >