Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit d396744cc15b489e7cc74c30e9995423f17871a6 by Albert Astals Cid on behalf of Damjan Georgievski to branch Plasma/5.9. Bugs: 365722 https://bugs.kde.org/show_bug.cgi?id=365722 Repository: kwallet

Re: Review Request 129955: fix off by one in the socket filename

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit fa1fbc2568fdfcf3f6ffa7370c3d26a3a47b9a5e by Aleix Pol on behalf of Damjan Georgievski to branch Plasma/5.9. Repository: kwallet-pam Description --- from the snprintf man page

Review Request 129955: fix off by one in the socket filename

- pam_kwallet.c c89bf6d Diff: https://git.reviewboard.kde.org/r/129955/diff/ Testing --- Thanks, Damjan Georgievski

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

--- Thanks, Damjan Georgievski

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

> On Jan. 8, 2017, 4:09 p.m., David Faure wrote: > > pam_kwallet.c, line 422 > > <https://git.reviewboard.kde.org/r/129526/diff/1/?file=486385#file486385line422> > > > > trailing spaces > > Damjan Georgievski wrote: > > according to http://

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

tps://git.reviewboard.kde.org/r/129526/#review101873 ------- On Nov. 21, 2016, 11:30 p.m., Damjan Georgievski wrote: > > --- > This is an automatically generated e-mail

D16520: proper kwalletd dbus service file for the legacy name

damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

damjang edited the summary of this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

damjang created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. damjang requested review of this revision. REVISION SUMMARY the org.kde.kwalletd legacy (kde4) name/interface is implemented by kwalletd5. this patch makes a proper dbus

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. In D16520#350807 , @apol wrote: > Won't this break co-installability with kdelibs4? in what way exactly? note that the kwallet package already did install org.kde.kwalletd.service, but also, kdelibs4 apps

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. > So now both kdelibs4 and kf5-kwallet will be installing org.kde.kwalletd.service and the package manager will complain. that was the case even before my patch REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. is it ok if the waiting on the legacy kwallet4 is made synchronous? wiring all those signals will make my head explode :) wait 5 sec, otherwise give up on the migration? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To:

D16520: proper kwalletd dbus service file for the legacy name

damjang added a comment. > but before doing this change the migration agent has to be changed. Can you expand on this what needs to be changed? I'd be happy to do it if it's in my capability REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D16520 To: damjang,