de.org/r/127386/diff/
Testing
---
Compiles...
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93581
---
On March 15, 2016, 5:52 p.m., Dominik Haumann wrote:
>
>
-41b41a135ca1__kate2015.png
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93716
-----------
On März 19, 2016, Mittag, Dominik Haumann wrote:
>
> ---
> This is an autom
d)
-
mtp/devicecache.cpp 8c5c7cf
Diff: https://git.reviewboard.kde.org/r/127386/diff/
Testing
---
Compiles...
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> >
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum,
> > solidDevNum);
> >
> > is removed. This somehow imp
> Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should
> > be Qt::BypassWindowManagerHint anyway)
> >
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the
> > QComboBox dropdown. May point an implementation weakeness/bug in t
> On März 17, 2016, 5:26 nachm., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> >
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum,
> > solidDevNum);
> >
> > is removed. This somehow imp
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> >
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum,
> > solidDevNum);
> >
> > is removed. This somehow imp
> Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should
> > be Qt::BypassWindowManagerHint anyway)
> >
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the
> > QComboBox dropdown. May point an implementation weakeness/bug in t
> Try adding Qt::FramelessWindowHint (Qt::X11BypassWindowManagerHint should
> > be Qt::BypassWindowManagerHint anyway)
> >
> > PS: it's rather worrysome that Qt::Popup fails since it *is* set for the
> > QComboBox dropdown. May point an implementation weakeness/bug in t
check the pointer for obvious
reasons).
- Dominik Haumann
On März 19, 2016, 8:31 nachm., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
mtp-clients
(from other DEs) are said to work, but couldn't really find something useful
for now...
- Dominik Haumann
On March 16, 2016, 4:41 p.m., Dominik Haumann wrote:
>
> ---
> This is an automatically generated e-mail. T
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127386/#review93581
---
On March 16, 2016, 4:41 p.m., Dominik Haumann wrote:
>
&g
> On März 17, 2016, 7:46 vorm., Kevin Funk wrote:
> > Ship It!
sorry to be late here, but please increase the version number in the language
element. otherwise internal caches are not rebuilt...
- Dominik
---
This is an automatically g
Testing
---
Works on Windows as expected.
File Attachments
Completion Popup
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png
Thanks,
Dominik Haumann
___
K
-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93783
---
On March 20, 2016, 12:06 p.m., Dominik Haumann wrote:
>
> ---
> This is an automatically generate
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93780
-------
On March 20, 2016, 12:06 p.m., Dominik Haumann wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/#review93837
---
ping
- Dominik Haumann
On March 20, 2016, 12:06 p.m
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote:
> > The only real difference to the original version is that the line
> >
> > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum,
> > solidDevNum);
> >
> > is removed. This somehow imp
way to get a patch
accepted, but I have the feeling this patch is not getting much attention,
despite me trying to get input for days.
- Dominik Haumann
On March 20, 2016, 12:06 p.m., Dominik Haumann wrote:
>
> ---
> T
iff: https://git.reviewboard.kde.org/r/127486/diff/
Testing
---
- unit tests still pass
- The encoding prober does not crash at the location anymore - it crashes a bit
later (another issue)
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-framew
iewboard.kde.org/r/127488/diff/
Testing
---
Kate/Kwrite launch without crash.
Unit tests still pass.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
], I'm happy to update
the review request accordingly.
[1] http://doc.qt.io/qt-5/qchar.html#isPrint-1
- Dominik Haumann
On March 24, 2016, 9:06 p.m., Dominik Haumann wrote:
>
> ---
> This is an automatically generated e-mail. T
> On March 24, 2016, 9:11 p.m., Dominik Haumann wrote:
> > Btw: If you think QChar::isPrint() is a better choice [1], I'm happy to
> > update the review request accordingly.
> >
> > [1] http://doc.qt.io/qt-5/qchar.html#isPrint-1
Oh, and for a correct review,
marked as submitted.
Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.
Changes
---
Submitted with commit 906e6a1409389c5abc501f0172c5dff21fdc6edd by Dominik
Haumann to branch master.
Repository: kcompletion
Description
---
In https://git.reviewboard.kde.org/r
n.
Diffs (updated)
-
src/probers/UnicodeGroupProber.cpp 1d86f08
Diff: https://git.reviewboard.kde.org/r/127486/diff/
Testing
---
- unit tests still pass
- The encoding prober does not crash at the location anymore - it crashes a bit
later (another issue)
Thanks,
Domin
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127486/#review93955
-------
On March 25, 2016, 4:53 p.m., Dominik Haumann wrote:
>
> ---
, please discard this review request, the code
is correct as is.
- Dominik Haumann
On March 26, 2016, 7:23 a.m., Anthony Fieroni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewbo
> On March 26, 2016, 12:55 p.m., Dominik Haumann wrote:
> > This issue was just fixed by Kare, see kwrite-devel mailing list and commit
> > https://quickgit.kde.org/?p=ktexteditor.git&a=commit&h=f7f330b21aa394a62ac95ea9bee075f372ff6d9c
> >
> > A
hether the int it non-negative
- only then, isprint() is called.
Diffs (updated)
-
autotests/kencodingprobertest.cpp 937bc13
src/probers/UnicodeGroupProber.cpp 1d86f08
Diff: https://git.reviewboard.kde.org/r/127488/diff/
Testing
---
Kate/Kwrite launch without crash.
Unit tests
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit d9a99dce9d63cab0429ac94acb160304e2bfa36f by Dominik
Haumann to branch master.
Bugs: 357341
https://bugs.kde.org/show_bug.cgi?id=357341
Repository: kcodecs
Description
---
With the patch
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 1e8b5370ddd2751d00ef823840077ae1562faf52 by Dominik
Haumann to branch master.
Bugs: 357341
https://bugs.kde.org/show_bug.cgi?id=357341
Repository: kcodecs
Description
---
When loading
).
Diffs
-
src/probers/UnicodeGroupProber.cpp cfbb06b
src/probers/ctype_test_p.h 0421f99
Diff: https://git.reviewboard.kde.org/r/127522/diff/
Testing
---
make test -> all tests PASS.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mai
ASS.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 1596261e68c2665f143e95e44dc666398761daed by Dominik
Haumann to branch master.
Repository: kcodecs
Description
---
This patch does two things:
1. use std::count() instead of deprecated qCount
marked as submitted.
Review request for KDE Frameworks, David Faure and Philipp Schmidt.
Changes
---
Submitted with commit cba927613b6da1b36ecbd5cfadfff3bff8729f86 by Dominik
Haumann to branch master.
Bugs: 325335
https://bugs.kde.org/show_bug.cgi?id=325335
Repository: kio-extras
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127549/#review94203
---
Ship it!
Looks good to me.
- Dominik Haumann
On April
Hi all,
I wonder, whether the correct fix would be to change the default icon
for KStandardAction::Close from "window-close" to "document-close"?
Cheers,
Dominik
-- Forwarded message --
From: Dominik Haumann
Date: Sat, Apr 30, 2016 at 11:02 PM
Subject: [kat
Hi all,
do we have a mechanism in KDE to find out whether a file is a truly
local file, or a remote file?
With remote file I mean e.g. a sshfs mounted location that appears in
the file system, which integrates seamlessly into the local
filesystem, but in truth, it is not a local file.
As initial
On Sun, May 1, 2016 at 6:28 PM, Dominik Haumann wrote:
> Hi all,
>
> do we have a mechanism in KDE to find out whether a file is a truly
> local file, or a remote file?
>
> With remote file I mean e.g. a sshfs mounted location that appears in
> the file system, which integ
usages are still correct, afaics.
Diffs
-
src/document/katedocument.cpp d552b45
Diff: https://git.reviewboard.kde.org/r/127805/diff/
Testing
---
Compiles.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-dev
---
Use lazy evaluation instead of comparing all filesystem types first, and then
returning true/false.
Diffs
-
src/core/kmountpoint.cpp 5feb3a8
Diff: https://git.reviewboard.kde.org/r/127808/diff/
Testing
---
Compiles.
Thanks,
Dominik Haumann
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit ee86cc6d5c5fe22066f6e655b0d59b7e22b0b2b8 by Dominik
Haumann to branch master.
Repository: kio
Description
---
Use lazy evaluation instead of comparing all filesystem types first, and then
n Grulich wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
>
> (Updated May 5, 2016, 10:53 a.m.)
>
>
> Review request for Kate, KDE Framework
> On May 5, 2016, 10:07 a.m., Jan Grulich wrote:
> > Looks that review board cannot handle indic characters. I posted them here:
> > https://paste.kde.org/piptzo584
>
> Dominik Haumann wrote:
> I guess backspace should remove the entire character, i.e. as much as
e to delete this if.
src/document/katedocument.cpp (line 3153)
<https://git.reviewboard.kde.org/r/127843/#comment64612>
Same here, not needed if.
src/document/katedocument.cpp (line 3207)
<https://git.reviewboard.kde.org/r/127843/#comment64613>
if not needed
- Dominik Haumann
> On May 7, 2016, 9:40 a.m., Dominik Haumann wrote:
> > I can see that the patch works, since Qt's QTextLayout functions are used
> > for cursor navigation.
> >
> > I dislike the part that exposes the "currentTextLayout()", since it exposes
> >
On Tuesday 28 January 2014 15:05:30 Kevin Funk wrote:
> Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi:
> > With another addition to qfiledialogtest in
> > frameworks/frameworkintegration another potential bug can be exposed:
> >
> > Calling
> >
> > $ ./qfiledialogtest --nameFilter "c (*
On Sunday 26 January 2014 18:53:42 Gregor Mi wrote:
> With another addition to qfiledialogtest in
> frameworks/frameworkintegration another potential bug can be exposed:
>
> Calling
>
> $ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h (*.h)"
> --selectNameFilter "h (*.h)"
>
> does no
Lists.txt fb58b3a
Diff: https://git.reviewboard.kde.org/r/115478/diff/
Testing
---
The attached unit test currently fails due to a bug in the Qt QPA.
With the Qt patch above, (2) in the unit test passes, so one is able to call
QFileDialog::selectNameFilter().
However, (1) remains broke
ly, visit:
https://git.reviewboard.kde.org/r/115478/#review48954
---
On Feb. 4, 2014, 5:07 p.m., Dominik Haumann wrote:
>
> ---
> This is an automatically generated e-mail. To rep
> On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote:
> > Two (related) things concern me about this:
> >
> > You're putting stuff that references the particular Qt platform plugin name
> > into desktop files, and you're doing it with something not prefixed with
> > X-KDE-
> >
> > I'm not even su
> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote:
> > Has the Qt patch been submitted upstream?
>
> Dominik Haumann wrote:
> Meanwhile yes: https://codereview.qt-project.org/#change,77390
>
> Alex Merry wrote:
> I don't think it's useful to hav
Hi,
a fresh Qt5 from stable branch, and a fresh frameworks build results in this
error when building solid:
$ make
[ 0%] Automatic moc for target KF5Solid
[ 0%] Built target KF5Solid_automoc
[ 1%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/managerbase.cpp.o
In file included from
/
On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote:
> Hi,
>
> a fresh Qt5 from stable branch, and a fresh frameworks build results in this
> error when building solid:
>
> $ make
> [ 0%] Automatic moc for target KF5Solid
> [ 0%] Built target KF5Solid_autom
On Wednesday, February 26, 2014 07:52:21 Martin GräÃlin wrote:
> On Tuesday 25 February 2014 21:27:02 Dominik Haumann wrote:
> > On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote:
> > > Hi,
> > >
> > > a fresh Qt5 from stable branch, and a fresh fr
On Wednesday, February 26, 2014 14:00:45 Ivan ÄukiÄ wrote:
> On Wednesday, 26. February 2014. 13.15.51 Treeve Jelbert wrote:
> > doing a clean rebuild
> >
> > gcc-4.8.2
>
> Qt5.3?
It fails for me as well with the same error. Yes, Qt 5.3.
Greetings,
Dominik
taking care of this!
- Dominik Haumann
On Feb. 27, 2014, 12:25 p.m., Aurélien Gâteau wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
Building KF5 mostly works, except I now get the error (cleaned build + install
folder) below when building kate. It looks as if Qt4 is somehow in the way now.
This used to work before, so is there any way to get it working again?
The detailed cmake logs are on paste.kde.org (see below).
Greetings
On Tuesday 04 March 2014 20:52:45 Michael Pyne wrote:
> On Tue, March 4, 2014 22:56:03 Dominik Haumann wrote:
> > Building KF5 mostly works, except I now get the error (cleaned build +
> > install folder) below when building kate. It looks as if Qt4 is somehow in
> > the way n
ttest.cpp PRE-CREATION
src/platformtheme/kdeplatformfiledialoghelper.cpp c82b821
Diff: https://git.reviewboard.kde.org/r/115478/diff/
Testing
---
The attached unit test currently fails due to a bug in the Qt QPA.
With the Qt patch above, (2) in the unit test passes, so one is able
the Qt QPA.
With the Qt patch above, (2) in the unit test passes, so one is able to call
QFileDialog::selectNameFilter().
However, (1) remains broken.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi,
getting an existing directory is still broken with current frameworks
integration. A call of:
QString dir = QFileDialog::getExistingDirectory();
results in this image: http://wstaw.org/m/2014/03/18/plasma-desktopdF1903.png
Whereas what you actually want is this:
http://wstaw.org/m/2014/0
On Friday, March 21, 2014 12:05:51 Martin Klapetek wrote:
> On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol wrote:
> > Hi Dominik,
> > I've been looking though it and it seems like in this case we should be
> > showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on
> > the
> > result o
On Monday 31 March 2014 17:27:33 Ben Cooksley wrote:
> On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi
wrote:
> > On 30/03/14 12:41, Aleix Pol wrote:
> >> On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi
> >>
> >> mailto:codeminis...@publicstatic.de>>
wrote:
> >> On 30/03/14 11:29, Gregor Mi wrote:
>
On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote:
> El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure:
> > On Monday 31 March 2014 17:27:33 Ben Cooksley wrote:
> > > On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi
> > >
> > >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117396/#review55066
---
Ship it!
The patch looks good, except that the '/' characters
editing parts,
could you have a quick look?
- Dominik Haumann
On May 3, 2014, 12:57 a.m., Sven Brauch wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
You can use auto here, if wanted (you can use auto much more often in your
patch, btw.):
if (auto gridLayout = qobject_cast(layout)) {
d->addWidgetsFromGridLayout(gridLayout, column);
return;
}
if (auto formLayout = qobject_cast(layout)) {
// ...
> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote:
> > What about adding something like this to Qt ?
>
> Christoph Feck wrote:
> First, I was thinking the same. The efforts with KF5 work was to get as
> much features as possible into Qt, and only keep the stuff that
On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote:
> On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote:
>
>
> > * sandsmark cleaned up KTextEditorSpellingInterface;
>
> I think this was discussed before, but I forgot it again :(
>
> The KTextEditor stuff, will it stay in KDELibs for
On Tuesday 05 November 2013 17:20:27 Dominik Haumann wrote:
> On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote:
> > On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote:
> >
> >
> > > * sandsmark cleaned up KTextEditorSpellingInterface;
> >
> &
On Sunday 10 November 2013 09:47:41 David Faure wrote:
> On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote:
> > > Input welcome.
> >
> > Once upon a time those interfaces were invented to enable KPilot (yes,
> > those times) to be able to use the hexedit widget I did then, without
Hi,
currently, http://community.kde.org/Frameworks/Epics/Modularization shows a
list of modules in the respective Tiers. It does not, however, show whether
it's functional, integration or a solution.
Imo if would be good to have this as column, too. Since then a quick look
allows us (for insta
On Sunday 10 November 2013 17:57:00 Kevin Ottens wrote:
> Hello,
>
> Since there's been several times discussions about having a kind of "Tier 0"
> for building our frameworks containing what is right now in ECM kde-modules
> directory, but the idea was never really on the table because of the ext
On Monday, November 11, 2013 02:22:43 Aleix Pol wrote:
> On Sun, Nov 10, 2013 at 9:58 PM, Dominik Haumann wrote:
> > Hi,
> >
> > currently, http://community.kde.org/Frameworks/Epics/Modularization shows
> > a
> > list of modules in the respective Tiers. It do
Hi Aleix,
KToolInvocation::invokeHelp() was removed. We used it like this:
KToolInvocation::invokeHelp("advanced-editing-tools-commandline","kate");
According to https://git.reviewboard.kde.org/r/111298/, is the preferred
replacement to go with something along this lines:
QUrl u("help://k
On Sunday 01 December 2013 19:26:22 Martin Graesslin wrote:
> On Sunday 01 December 2013 18:42:58 Dominik Haumann wrote:
> > Hi Aleix,
> >
> > KToolInvocation::invokeHelp() was removed. We used it like this:
> > KToolInvocation::invokeHelp("advanced-
Hi,
porting KSaveFile to QSaveFile, I stumbled into the following:
// This method has been made private so that it cannot be called,
// in order to prevent mistakes.
void QSaveFile::close()
{
qFatal("QSaveFile::close called");
}
In Kate, we use a QSaveFile saveFile(...); and then use
KCom
Hi David,
On Wednesday 04 December 2013 14:42:19 David Faure wrote:
> On Monday 02 December 2013 22:31:43 Dominik Haumann wrote:
> > Hi,
> >
> > porting KSaveFile to QSaveFile, I stumbled into the following:
> >
> > // This method has been made private so th
On Tuesday 10 December 2013 23:31:33 David Faure wrote:
> On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote:
> > However, here it comes: Changing
> > -KCompressionDevice device(&file, false,
> > KCompressionDevice::GZip);
> > +KCompre
On Thursday 19 December 2013 08:25:21 Cornelius Schumacher wrote:
> On Wednesday 18 December 2013 David Faure wrote:
> > The "frameworks" branch of kdelibs is now closed forever.
> > 57 repositories have been created instead (*).
> >
> > (*)
> > apidoxkcodecs kdbusaddons
On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote:
> On Thursday 19 of December 2013 14:57:33 Dominik Haumann wrote:
> > On Wednesday, December 18, 2013 19:42:43 Michal Humpula wrote:
> > > Git commit 4e6c1c3d8cd6dbe4d826ce6720169fd94d8848f6 by Michal Humpula.
> &
On Tuesday 10 December 2013 23:31:33 David Faure wrote:
> On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote:
> > It seems that the behavior for "None" is different. Interestingly,
> > KSaveFile also behaved like this (KFilterDev did not change after all I
&g
Hi,
the KTextEditor interfaces as well as Kate and KWrite are ported to the
frameworks libs and Qt5 for some weeks now (big thanks to Michal!).
It's quite stable and therefore it can safely be included into kdesrc-build
by default.
The required change is:
diff --git a/kf5-qt5-build-include b/kf
Building KIO:
In file included from
/home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0:
/home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error:
ki18n/klocalizedstring.h: No such file or directory
#include "ki18n/klocalizedstring.h"
On Saturday 04 January 2014 13:33:59 Dominik Haumann wrote:
> Building KIO:
>
> In file included from
> /home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0:
> /home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error:
> ki18n/klocalizedstring.
Hi,
in KDE4 times we had e.g. in KMessageWidget:
if (KGlobalSettings::graphicEffectsLevel() &
KGlobalSettings::SimpleAnimationEffects)
{
// do animation
}
Seems this was dependent on the style but read from some config value that was
set through the kcm 'style', clicking "Configure" n
On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote:
> ok. So this should go to kstyle (nothing oxygen explicit in there).
>
> In fact, kstyle returns:
>
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
>
> return g.readEntry("GraphicEffectsLevel", 0);
>
> m
On Saturday 04 January 2014 23:11:14 David Faure wrote:
> On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote:
> > On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote:
> > > ok. So this should go to kstyle (nothing oxygen explicit in there).
> > >
&g
is hidden.
Diffs
-
src/kmessagewidget.h a17bccf
src/kmessagewidget.cpp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks,
Dominik Haumann
___
Kde-framew
pp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/li
---
src/kmessagewidget.h a17bccf
src/kmessagewidget.cpp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-framew
nerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115101/#review47655
---
On Jan. 18, 2014, 6:13 p.m., Dominik Haumann wrote:
>
> ---
> This is an automat
E-CREATION
autotests/kmessagewidgetautotest.cpp PRE-CREATION
src/kmessagewidget.h a17bccf
src/kmessagewidget.cpp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks,
Domin
,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
3611812
Diff: https://git.reviewboard.kde.org/r/115142/diff/
Testing
---
Thanks,
Dominik Haumann
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
xt 6ea9d12
autotests/kmessagewidgetautotest.h PRE-CREATION
autotests/kmessagewidgetautotest.cpp PRE-CREATION
src/kmessagewidget.h a17bccf
src/kmessagewidget.cpp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks
test.h PRE-CREATION
autotests/kmessagewidgetautotest.cpp PRE-CREATION
src/kmessagewidget.h a17bccf
src/kmessagewidget.cpp deb82a3
Diff: https://git.reviewboard.kde.org/r/115101/diff/
Testing
---
In Kate Part, not commited so far, though.
Thanks,
Domin
1 - 100 of 1384 matches
Mail list logo
