Re: Review Request 122910: Introduce KMoreTools

2015-03-15 Thread Dominik Haumann
the comments. So I consider this as work in progress, right? I - Dominik Haumann On March 11, 2015, 11:06 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 122910: Introduce KMoreTools

2015-03-15 Thread Dominik Haumann
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: src/kmoretools/kmoretools.h, line 287 https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line287 @return, never @returns. Further, can you be mor verbose? @return Returns the tools

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

2015-04-02 Thread Dominik Haumann
() instead? src/services/kservice.cpp (line 149) https://git.reviewboard.kde.org/r/123223/#comment53660 I wonder whether QFileInfo(entryPath).completeBaseName() does exactly the same as entryPathToName(entryPath) ? See: http://doc.qt.io/qt-5/qfileinfo.html#completeBaseName - Dominik

Re: Review Request 122981: add new method KGlobalAccel::globalShortcut(componentName, actionId)

2015-04-17 Thread Dominik Haumann
://git.reviewboard.kde.org/r/122981/#comment54084 Afaik, if the string is empty, QString() is better than QLatin1String() - Dominik Haumann On April 17, 2015, 7:49 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit

Re: KF5 Update Meeting Minutes 2013-w45

2013-11-05 Thread Dominik Haumann
On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: snip * sandsmark cleaned up KTextEditorSpellingInterface; I think this was discussed before, but I forgot it again :( The KTextEditor stuff, will it stay in KDELibs for

Re: kdelibs/interfaces/khexedit

2013-11-10 Thread Dominik Haumann
On Sunday 10 November 2013 09:47:41 David Faure wrote: On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote: Input welcome. Once upon a time those interfaces were invented to enable KPilot (yes, those times) to be able to use the hexedit widget I did then, without having

List of Frameworks

2013-11-10 Thread Dominik Haumann
Hi, currently, http://community.kde.org/Frameworks/Epics/Modularization shows a list of modules in the respective Tiers. It does not, however, show whether it's functional, integration or a solution. Imo if would be good to have this as column, too. Since then a quick look allows us (for

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Dominik Haumann
On Sunday 10 November 2013 17:57:00 Kevin Ottens wrote: Hello, Since there's been several times discussions about having a kind of Tier 0 for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra

Re: Re: List of Frameworks

2013-11-10 Thread Dominik Haumann
On Monday, November 11, 2013 02:22:43 Aleix Pol wrote: On Sun, Nov 10, 2013 at 9:58 PM, Dominik Haumann dhaum...@kde.org wrote: Hi, currently, http://community.kde.org/Frameworks/Epics/Modularization shows a list of modules in the respective Tiers. It does not, however, show whether

KToolInvokation

2013-12-01 Thread Dominik Haumann
Hi Aleix, KToolInvocation::invokeHelp() was removed. We used it like this: KToolInvocation::invokeHelp(advanced-editing-tools-commandline,kate); According to https://git.reviewboard.kde.org/r/111298/, is the preferred replacement to go with something along this lines: QUrl

Re: KToolInvokation

2013-12-01 Thread Dominik Haumann
On Sunday 01 December 2013 19:26:22 Martin Graesslin wrote: On Sunday 01 December 2013 18:42:58 Dominik Haumann wrote: Hi Aleix, KToolInvocation::invokeHelp() was removed. We used it like this: KToolInvocation::invokeHelp(advanced-editing-tools-commandline,kate) ; According

Re: Using KCompressionDevice with QSaveFile

2013-12-10 Thread Dominik Haumann
Hi David, On Wednesday 04 December 2013 14:42:19 David Faure wrote: On Monday 02 December 2013 22:31:43 Dominik Haumann wrote: Hi, porting KSaveFile to QSaveFile, I stumbled into the following: // This method has been made private so that it cannot be called, // in order to prevent

Re: Using KCompressionDevice with QSaveFile

2013-12-10 Thread Dominik Haumann
On Tuesday 10 December 2013 23:31:33 David Faure wrote: On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: However, here it comes: Changing -KCompressionDevice device(file, false, KCompressionDevice::GZip); +KCompressionDevice device(file, false

Re: The KDE Frameworks have been splitted

2013-12-19 Thread Dominik Haumann
On Thursday 19 December 2013 08:25:21 Cornelius Schumacher wrote: On Wednesday 18 December 2013 David Faure wrote: The frameworks branch of kdelibs is now closed forever. 57 repositories have been created instead (*). (*) apidoxkcodecs kdbusaddons kdewebkit

Re: Re: [kate/frameworks] part: port from KDialog to QDialog (KateGlobal::configDialog)

2013-12-19 Thread Dominik Haumann
On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote: On Thursday 19 of December 2013 14:57:33 Dominik Haumann wrote: On Wednesday, December 18, 2013 19:42:43 Michal Humpula wrote: Git commit 4e6c1c3d8cd6dbe4d826ce6720169fd94d8848f6 by Michal Humpula. Committed on 18/12/2013 at 19

Re: Using KCompressionDevice with QSaveFile

2013-12-27 Thread Dominik Haumann
On Tuesday 10 December 2013 23:31:33 David Faure wrote: On Tuesday 10 December 2013 21:48:09 Dominik Haumann wrote: It seems that the behavior for None is different. Interestingly, KSaveFile also behaved like this (KFilterDev did not change after all I guess). I'm surprised, because

including Kate in kdesrc-build

2013-12-30 Thread Dominik Haumann
Hi, the KTextEditor interfaces as well as Kate and KWrite are ported to the frameworks libs and Qt5 for some weeks now (big thanks to Michal!). It's quite stable and therefore it can safely be included into kdesrc-build by default. The required change is: diff --git a/kf5-qt5-build-include

compile error

2014-01-04 Thread Dominik Haumann
Building KIO: In file included from /home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0: /home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error: ki18n/klocalizedstring.h: No such file or directory #include ki18n/klocalizedstring.h

Re: compile error

2014-01-04 Thread Dominik Haumann
On Saturday 04 January 2014 13:33:59 Dominik Haumann wrote: Building KIO: In file included from /home/dh/kde/kf5/src/frameworks/kio/src/core/filecopyjob.cpp:27:0: /home/dh/kde/kf5/usr/include/KF5/KI18n/KLocalizedString:1:36: fatal error: ki18n/klocalizedstring.h: No such file or directory

KDE-wide Animation settings

2014-01-04 Thread Dominik Haumann
Hi, in KDE4 times we had e.g. in KMessageWidget: if (KGlobalSettings::graphicEffectsLevel() KGlobalSettings::SimpleAnimationEffects) { // do animation } Seems this was dependent on the style but read from some config value that was set through the kcm 'style', clicking Configure

Re: KDE-wide Animation settings

2014-01-04 Thread Dominik Haumann
On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote: ok. So this should go to kstyle (nothing oxygen explicit in there). In fact, kstyle returns: KConfigGroup g(KSharedConfig::openConfig(), KDE-Global GUI Settings); return g.readEntry(GraphicEffectsLevel, 0); mmm. No clue

Re: KDE-wide Animation settings

2014-01-04 Thread Dominik Haumann
On Saturday 04 January 2014 23:11:14 David Faure wrote: On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote: On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote: ok. So this should go to kstyle (nothing oxygen explicit in there). In fact, kstyle returns

Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
. Diffs - src/kmessagewidget.h a17bccf src/kmessagewidget.cpp deb82a3 Diff: https://git.reviewboard.kde.org/r/115101/diff/ Testing --- In Kate Part, not commited so far, though. Thanks, Dominik Haumann ___ Kde-frameworks-devel

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
Diff: https://git.reviewboard.kde.org/r/115101/diff/ Testing --- In Kate Part, not commited so far, though. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
/kmessagewidget.h a17bccf src/kmessagewidget.cpp deb82a3 Diff: https://git.reviewboard.kde.org/r/115101/diff/ Testing --- In Kate Part, not commited so far, though. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-18 Thread Dominik Haumann
://git.reviewboard.kde.org/r/115101/#review47655 --- On Jan. 18, 2014, 6:13 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-19 Thread Dominik Haumann
autotests/kmessagewidgetautotest.cpp PRE-CREATION src/kmessagewidget.h a17bccf src/kmessagewidget.cpp deb82a3 Diff: https://git.reviewboard.kde.org/r/115101/diff/ Testing --- In Kate Part, not commited so far, though. Thanks, Dominik Haumann

Review Request 115142: add EXPORT_NAME to kf5 template

2014-01-20 Thread Dominik Haumann
, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115142: add EXPORT_NAME to kf5 template

2014-01-20 Thread Dominik Haumann
3611812 Diff: https://git.reviewboard.kde.org/r/115142/diff/ Testing --- Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115101: add signal KMessageWidget::hideAnimationFinished()

2014-01-20 Thread Dominik Haumann
autotests/kmessagewidgetautotest.h PRE-CREATION autotests/kmessagewidgetautotest.cpp PRE-CREATION src/kmessagewidget.h a17bccf src/kmessagewidget.cpp deb82a3 Diff: https://git.reviewboard.kde.org/r/115101/diff/ Testing --- In Kate Part, not commited so far, though. Thanks, Dominik

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Dominik Haumann
On Tuesday, January 28, 2014 16:40:51 Kevin Ottens wrote: Hello everyone, [...] * sebas has been working on high dpi support; Where? In Plasma 2? QML stuff? Styles? Widgets? Can you elaborate? Greetings, Dominik ___ Kde-frameworks-devel mailing

Re: KF5 Update Meeting Minutes 2014-w5

2014-01-28 Thread Dominik Haumann
On Tuesday 28 January 2014 18:22:17 Martin Klapetek wrote: On Tue, Jan 28, 2014 at 6:07 PM, Dominik Haumann dhaum...@kde.org wrote: On Tuesday, January 28, 2014 16:40:51 Kevin Ottens wrote: Hello everyone, [...] * sebas has been working on high dpi support; Where? In Plasma

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-01-30 Thread Dominik Haumann
On Tuesday 28 January 2014 15:05:30 Kevin Funk wrote: Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi: With another addition to qfiledialogtest in frameworks/frameworkintegration another potential bug can be exposed: Calling $ ./qfiledialogtest --nameFilter c (*.cpp)

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-02-04 Thread Dominik Haumann
On Tuesday 28 January 2014 15:05:30 Kevin Funk wrote: Am Sonntag, 26. Januar 2014, 18:53:42 schrieb Gregor Mi: With another addition to qfiledialogtest in frameworks/frameworkintegration another potential bug can be exposed: Calling $ ./qfiledialogtest --nameFilter c (*.cpp)

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-02-04 Thread Dominik Haumann
On Sunday 26 January 2014 18:53:42 Gregor Mi wrote: With another addition to qfiledialogtest in frameworks/frameworkintegration another potential bug can be exposed: Calling $ ./qfiledialogtest --nameFilter c (*.cpp) --nameFilter h (*.h) --selectNameFilter h (*.h) does not select the

Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-02-04 Thread Dominik Haumann
test currently fails due to a bug in the Qt QPA. With the Qt patch above, (2) in the unit test passes, so one is able to call QFileDialog::selectNameFilter(). However, (1) remains broken. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-02-04 Thread Dominik Haumann
://git.reviewboard.kde.org/r/115478/#review48954 --- On Feb. 4, 2014, 5:07 p.m., Dominik Haumann wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115653: Introduce a showOnCurrentPlatform method to KService

2014-02-11 Thread Dominik Haumann
On Feb. 11, 2014, 10:53 a.m., Alex Merry wrote: Two (related) things concern me about this: You're putting stuff that references the particular Qt platform plugin name into desktop files, and you're doing it with something not prefixed with X-KDE- I'm not even sure platform is

building Solid

2014-02-25 Thread Dominik Haumann
Hi, a fresh Qt5 from stable branch, and a fresh frameworks build results in this error when building solid: $ make [ 0%] Automatic moc for target KF5Solid [ 0%] Built target KF5Solid_automoc [ 1%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/managerbase.cpp.o In file included from

Re: building Solid

2014-02-25 Thread Dominik Haumann
On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote: Hi, a fresh Qt5 from stable branch, and a fresh frameworks build results in this error when building solid: $ make [ 0%] Automatic moc for target KF5Solid [ 0%] Built target KF5Solid_automoc [ 1%] Building CXX object src

Re: Re: Re: building Solid

2014-02-26 Thread Dominik Haumann
On Wednesday, February 26, 2014 07:52:21 Martin Gräßlin wrote: On Tuesday 25 February 2014 21:27:02 Dominik Haumann wrote: On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote: Hi, a fresh Qt5 from stable branch, and a fresh frameworks build results in this error when

Re: Re: kactivities5 build failure

2014-02-26 Thread Dominik Haumann
On Wednesday, February 26, 2014 14:00:45 Ivan Čukić wrote: On Wednesday, 26. February 2014. 13.15.51 Treeve Jelbert wrote: doing a clean rebuild gcc-4.8.2 Qt5.3? It fails for me as well with the same error. Yes, Qt 5.3. Greetings, Dominik

Re: Review Request 116116: Fix build with Qt 5.3

2014-02-27 Thread Dominik Haumann
for taking care of this! - Dominik Haumann On Feb. 27, 2014, 12:25 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116116

Building KF5/Kate fails

2014-03-04 Thread Dominik Haumann
Building KF5 mostly works, except I now get the error (cleaned build + install folder) below when building kate. It looks as if Qt4 is somehow in the way now. This used to work before, so is there any way to get it working again? The detailed cmake logs are on paste.kde.org (see below).

Re: Building KF5/Kate fails

2014-03-09 Thread Dominik Haumann
On Tuesday 04 March 2014 20:52:45 Michael Pyne wrote: On Tue, March 4, 2014 22:56:03 Dominik Haumann wrote: Building KF5 mostly works, except I now get the error (cleaned build + install folder) below when building kate. It looks as if Qt4 is somehow in the way now. This used to work before

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-03-09 Thread Dominik Haumann
/115478/diff/ Testing --- The attached unit test currently fails due to a bug in the Qt QPA. With the Qt patch above, (2) in the unit test passes, so one is able to call QFileDialog::selectNameFilter(). However, (1) remains broken. Thanks, Dominik Haumann

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

2014-03-10 Thread Dominik Haumann
::selectNameFilter(). However, (1) remains broken. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

2014-03-18 Thread Dominik Haumann
Hi, getting an existing directory is still broken with current frameworks integration. A call of: QString dir = QFileDialog::getExistingDirectory(); results in this image: http://wstaw.org/m/2014/03/18/plasma-desktopdF1903.png Whereas what you actually want is this:

Re: Re: Frameworksintegration of QFileDialog::getExistingDirectory (was: add test for QFileDialog::getExistingDirectory / bug?)

2014-03-21 Thread Dominik Haumann
On Friday, March 21, 2014 12:05:51 Martin Klapetek wrote: On Wed, Mar 19, 2014 at 8:26 PM, Aleix Pol aleix...@kde.org wrote: Hi Dominik, I've been looking though it and it seems like in this case we should be showing KDirSelectDialog instead of a QDialog+KFileWidget, depending on the

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-31 Thread Dominik Haumann
On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote:

Re: Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-04-01 Thread Dominik Haumann
On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de Ok. Any idea about

Re: Review Request 117396: syntax: enable folding new HTML5 block-level elements

2014-04-06 Thread Dominik Haumann
request :-) src/syntax/data/html.xml https://git.reviewboard.kde.org/r/117396/#comment38407 Aren't you missing the '/' characters? /article ... - Dominik Haumann On April 6, 2014, 2 a.m., T.C. Hollingsworth wrote

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Dominik Haumann
editing parts, could you have a quick look? - Dominik Haumann On May 3, 2014, 12:57 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Dominik Haumann
)) { // ... } - Dominik Haumann On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-04 Thread Dominik Haumann
On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: What about adding something like this to Qt ? Christoph Feck wrote: First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our

Review Request: new signal void KMessageWidget::linkActivated()

2012-10-25 Thread Dominik Haumann
/kmessagewidget.cpp fdda163 Diff: http://git.reviewboard.kde.org/r/107036/diff/ Testing --- Tested in kmessagewidgettest, see diff. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Finalized proposal for changes to i18n in KF5

2012-12-27 Thread Dominik Haumann
On Saturday, December 22, 2012 10:44:22 AM Chusslove Illich wrote: I have written up the headers and Doxygen pages for the Ki18n framework as it should finally look like, available here: http://nedohodnik.net/misc/ki18n-kf5-01/html/index.html

Re: Re: KGlobalSettings move to kde4support

2013-06-18 Thread Dominik Haumann
On Tuesday, June 18, 2013 08:14:50 Kevin Ottens wrote: Hello, On Monday 17 June 2013 19:43:33 Aleix Pol wrote: So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. Ah good, it was in my

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-08-13 Thread Dominik Haumann
and then remove the line 360? IncludeRules context=code / Hi, nice. Could you please send a revised version with the issues addressed? - Dominik Haumann On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote

Re: Review Request 119755: Support more number types in haskell highlighting

2014-08-13 Thread Dominik Haumann
number in the language element. - Dominik Haumann On Aug. 13, 2014, 4:33 p.m., Bastian Holst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119755

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-08-15 Thread Dominik Haumann
lineEndContext=#stay name=List or QuasiQuote fallthrough=true fallthroughContext=#pop and then remove the line 360? IncludeRules context=code / - Dominik Haumann On Aug. 14, 2014, 8:39 p.m., Bastian Holst wrote

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Dominik Haumann
On Tuesday 02 September 2014 12:48:07 Martin Gräßlin wrote: On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: On Monday, September 01, 2014 12:59:04 Elias Probst wrote: I've noticed, that (except of only a very few) nearly all SVG files are committed as SVGZ to our git

Re: OSX/CI: kate uses invalid category

2014-09-07 Thread Dominik Haumann
On Saturday, September 06, 2014 02:54:04 PM Marko Käning wrote: When building kate I suddenly see tons of these warnings popping up: Rename to *-apps-*.png. Can you try again? Thanks, Dominik CMake Warning at /opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdesupport/extra-cmake-modu

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Dominik Haumann
://git.reviewboard.kde.org/r/120110/#comment46137 Please fix the spaces. - Dominik Haumann On Sept. 9, 2014, 8:15 a.m., Joseph Wenninger wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: OSX/CI: kate uses invalid category

2014-09-09 Thread Dominik Haumann
On Sunday, September 07, 2014 05:57:30 PM Marko Käning wrote: On 07 Sep 2014, at 13:34 , Dominik Haumann dhaum...@kde.org wrote: On Saturday, September 06, 2014 02:54:04 PM Marko Käning wrote: When building kate I suddenly see tons of these warnings popping up: Rename to *-apps-*.png. Can

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Dominik Haumann
regressions, we'll fix it then. Could you add some spaces around operators like == and after commas? It makes the code much more easy to read. src/view/kateview.cpp https://git.reviewboard.kde.org/r/120147/#comment46267 this should be right spacer, right? :-) - Dominik Haumann On Sept. 11

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-14 Thread Dominik Haumann
/kmessagewidget.cpp https://git.reviewboard.kde.org/r/120160/#comment46354 I believe this is missing after line 441: emit hideAnimationFinished(); - Dominik Haumann On Sept. 12, 2014, 12:16 p.m., Fabio D'Urso wrote

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-18 Thread Dominik Haumann
On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote: All in all, the patch looks good, but it misses emitting the signals hideAnimationFinished() and showAnimationFinished(). Why? Without your patch, you can be *sure* that after calling show() or animatedShow() the signal

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-09-19 Thread Dominik Haumann
On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: After some discussion with the SDK and Book groups in the sprint, I think we should move this into the kde:kwidgetsaddons repository, in an examples subdirectory. Laurent Navet wrote: do you want me to move this from

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-09-29 Thread Dominik Haumann
On Aug. 15, 2014, 12:22 p.m., Dominik Haumann wrote: src/syntax/data/haskell.xml, line 363 https://git.reviewboard.kde.org/r/119767/diff/2/?file=305500#file305500line363 This question persists: The rule DetectChar attribute=Normal context=List or QuasiQuote char

Re: Review Request 120442: Fix comments in Haskell highlighting

2014-10-01 Thread Dominik Haumann
? It's much faster than a RegExpr, see: https://docs.kde.org/stable/en/applications/kate/kate-highlight-rules-detailled.html Like this: StringDetect attribute=Comment context=#stay String={--} / - Dominik Haumann On Sept. 30, 2014, 7:14 p.m., Bastian Holst wrote

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-10-01 Thread Dominik Haumann
, and since you seem to use these highlightings in your daily use, feel free to commit. Thanks for the updates! - Dominik Haumann On Aug. 14, 2014, 8:39 p.m., Bastian Holst wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Why so many QStyles

2014-10-04 Thread Dominik Haumann
On Friday 03 October 2014 00:09:11 Aleix Pol wrote: On Thu, Oct 2, 2014 at 10:10 PM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: hi all, I guess its a question to Qt experts or possibly low level KF5 experts. When comparing debugging outputs when running app + style against

Re: changelog for KF 5.3

2014-10-05 Thread Dominik Haumann
On Sunday 05 October 2014 11:59:59 Christoph Cullmann wrote: Here's what I wrote from the changes in git (the CHANGELOG keyword isn't used enough yet...) Please tell me about anything I missed. I am especially unsure about KTextEditor (so many changes!), KService (I guess a

blogging about technical details (was: Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem)

2014-10-11 Thread Dominik Haumann
Hi all, imho, these are changes that get mostly unnoticed, and hence close to no one will use this feature. I personally would find it very cool if there were lots and lots of blogs on the planet for these technical details. It would also communicate a bit more of the internals to potentially

Re: Review Request 120443: Add ctags configuration option to highlighting

2014-10-11 Thread Dominik Haumann
On Oct. 10, 2014, 7:55 p.m., Christoph Cullmann wrote: Hi, I think that should not be in KTextEditor. Thats really special and given that only a very limited amount of languages with ctags specials exists, it would make more sense to just have a heuristic in the project plugin to

Re: blogging about technical details (was: Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem)

2014-10-15 Thread Dominik Haumann
On Sunday 12 October 2014 22:57:33 David Faure wrote: On Saturday 11 October 2014 16:40:55 Dominik Haumann wrote: Hi all, imho, these are changes that get mostly unnoticed, and hence close to no one will use this feature. I personally would find it very cool if there were lots and lots

Re: private export

2014-10-15 Thread Dominik Haumann
On Tuesday 14 October 2014 14:37:30 Jeremy Whiting wrote: Hello, In KNewStuff autotests there are two disabled tests that build and work if I export the Author and EntryInternal classes, but these two classes are private (declared in _p.h files) so I'd rather not export them, since they

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-07 Thread Dominik Haumann
it in KF5. Other reviews welcome. - Dominik Haumann On Dec. 7, 2014, 10:49 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-12-13 Thread Dominik Haumann
Frameworks, Christoph Cullmann, Dominik Haumann, and Kevin Funk. Repository: ktexteditor Description --- In KDevelop we currently hit this often since our old class previously returned a reference for the start/end getters of range and cursor. With the help of C++11 ref

Re: KF 5.6 changelog

2015-01-03 Thread Dominik Haumann
On Saturday 03 January 2015 14:39:11 Dominik Haumann wrote: On Saturday 03 January 2015 14:32:58 Dominik Haumann wrote: Hi Helio, your change with respect to libgit2 is still not reverted :-( I'll do that now for you. Right now, the broken libgit2 is tagged in KF5.6... @David

Re: KF 5.6 changelog

2015-01-03 Thread Dominik Haumann
On Saturday 03 January 2015 14:32:58 Dominik Haumann wrote: Hi Helio, your change with respect to libgit2 is still not reverted :-( I'll do that now for you. Right now, the broken libgit2 is tagged in KF5.6... @David: libgit2 v0.21 is known to have issues that crash ktexteditor

Re: KF 5.6 changelog

2015-01-03 Thread Dominik Haumann
Hi Helio, your change with respect to libgit2 is still not reverted :-( I'll do that now for you. Right now, the broken libgit2 is tagged in KF5.6... @David: libgit2 v0.21 is known to have issues that crash ktexteditor. Therefore, we depend on the currently unreleased libgit2 v0.22. This

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-07 Thread Dominik Haumann
from what you can find on the gnu homepage). src/kcombobox.h https://git.reviewboard.kde.org/r/122462/#comment52277 Doxygen is fine with these two spaces as well... (everywhere). - Dominik Haumann On Feb. 6, 2015, 11:03 p.m., David Gil Oliva wrote

Re: Review Request 120443: Add ctags configuration option to highlighting

2015-08-23 Thread Dominik Haumann
) :-) - Dominik Haumann On Sept. 30, 2014, 8:34 p.m., Bastian Holst wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120443

Re: Review Request 124315: Change keyboard shortcut to avoid conflict with next tab

2015-08-23 Thread Dominik Haumann
is currently unused in Kate/Kile/KDevelop it seems, to should be a good choice. The feature itself is fairly new still and hence probably rather unknown, so changing the shortcut now is fine. Please commit. - Dominik Haumann On July 10, 2015, 7:56 a.m., Simon Persson wrote

Re: Review Request 120443: Add ctags configuration option to highlighting

2015-08-24 Thread Dominik Haumann
On Mon, Aug 24, 2015 at 10:16 AM, David Faure fa...@kde.org wrote: On Sunday 23 August 2015 12:19:10 Dominik Haumann wrote: Are there still parts in this patch that are relevant? If so, can you update the patch to reflect it? Otherwise, please discard it (we can't do this, unfortunaltely

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Dominik Haumann
On Tue, Oct 20, 2015 at 8:23 PM, Christoph Cullmann wrote: > I think that is more or less what we had in the past with the "kdewin" > installer, > that is like the cygwin installer pulling in all stuff you need and a set of > applications > in some common prefix. > > I am

Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

2016-05-28 Thread Dominik Haumann
e the color or any other attribute of dsError. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

2016-05-28 Thread Dominik Haumann
org/r/128035/#review95950 --- On May 28, 2016, 4:30 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128035/ >

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

2016-05-28 Thread Dominik Haumann
marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit 24bec2f4f596d881ec43099558d3111542616f7a by Dominik Haumann to branch master. Repository: ktexteditor Description --- The enum dsError should be included in the count, so we need

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

2016-05-28 Thread Dominik Haumann
marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit bb1968631c2931c8a67b5f4bfc92a0553d00bc83 by Dominik Haumann to branch master. Bugs: 363441 https://bugs.kde.org/show_bug.cgi?id=363441 Repository: ktexteditor Description

Re: Review Request 128036: Fix default encoding to UTF-8

2016-05-28 Thread Dominik Haumann
t even this is a bit fuzzy in KDE, since in Kate the user still doesn't see what's really going on. Anyways, this patch is good, please commit ;) - Dominik Haumann On May 28, 2016, 3:09 p.m., Christoph Cullmann wrote: > > --- > This

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

2016-05-28 Thread Dominik Haumann
r/128034/#review95943 --- On May 28, 2016, 12:32 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 128035: KTextEditor: Fix foreground color of replaced text

2016-05-28 Thread Dominik Haumann
--- Works now. Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Dominik Haumann
ill access a nullptr. Please guard against this and return nullptr, in case the thisLine is invalid. - Dominik Haumann On May 26, 2016, 10:06 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127843: Properly remove composed characters

2016-05-26 Thread Dominik Haumann
you remove the one deprecated comment? Besides that, please commit! src/document/katedocument.cpp (line 3119) <https://git.reviewboard.kde.org/r/127843/#comment64848> please delete this comment - Dominik Haumann On May 26, 2016, 1:07 p.m., Jan Grulich

Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-15 Thread Dominik Haumann
/diff/ Testing --- Compiles... Thanks, Dominik Haumann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-16 Thread Dominik Haumann
ally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93581 ------- On March 15, 2016, 5:52 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.

Review Request 127522: kcodec: Simplify code (qCount -> std::count, homegrown isprint -> QChar::isPrint)

2016-03-29 Thread Dominik Haumann
). Diffs - src/probers/UnicodeGroupProber.cpp cfbb06b src/probers/ctype_test_p.h 0421f99 Diff: https://git.reviewboard.kde.org/r/127522/diff/ Testing --- make test -> all tests PASS. Thanks, Dominik Haumann ___ Kde-frameworks-devel mai

  1   2   3   4   5   6   7   >