Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-12-02 Thread Kevin Funk
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84496 --- On Aug. 27, 2015, 7:31 a.m., Kevin Funk wrote: > > --

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Kevin Funk
/#comment61240> Duplicated documentation. Just `\sa KAboutPerson::fromJSON`? - Kevin Funk On Dec. 14, 2015, 11:45 a.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-21 Thread Kevin Funk
side (other reviewers welcome). - Kevin Funk On Dec. 21, 2015, 9:45 a.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
. Repository: knewstuff Description --- Fixes issues leading to creation of QTBUG-47240 Diffs - src/CMakeLists.txt cc606444e48b0e519551183c022ccecdac0aa62f Diff: https://git.reviewboard.kde.org/r/126453/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
it: https://git.reviewboard.kde.org/r/126453/#review89837 --- On Dec. 21, 2015, 4:06 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126453: Fix library order

2016-01-01 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting. Changes --- Submitted with commit 38685ad63b08a6c1c4de2c2ecd525188aecd3e94 by Kevin Funk to branch master. Repository: knewstuff Description --- Fixes issues leading to creation of QTBUG-47240

Re: Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126617/#review90490 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:57 p.m

Re: Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126616/#review90491 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:53 p.m

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/#review90492 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:51 p.m

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90493 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:45 p.m

Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

2016-01-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/#review90838 --- Ship it! Ship It! - Kevin Funk On Jan. 10, 2016, 11:03

Review Request 126745: Fix karchive autotests on Windows

2016-01-14 Thread Kevin Funk
tests/CMakeLists.txt 39881f90c614200a6c840b67d14e6c518f8e57e9 Diff: https://git.reviewboard.kde.org/r/126745/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

2016-01-17 Thread Kevin Funk
/ Feel free to patch your self-built Qt on Windows for now... :) - Kevin Funk On Jan. 15, 2016, 10:30 p.m., Kåre Särs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126745: Fix karchive autotests on Windows

2016-01-18 Thread Kevin Funk
e the data in case examples/ changes. Diffs (updated) - autotests/CMakeLists.txt 39881f90c614200a6c840b67d14e6c518f8e57e9 Diff: https://git.reviewboard.kde.org/r/126745/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing

Re: Review Request 126745: Fix karchive autotests on Windows

2016-01-20 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Patrick Spendrin. Changes --- Submitted with commit 123235fc5f036e42afce90bce7d1c06742679080 by Kevin Funk to branch master. Repository: karchive Description --- Still not perfect (no proper dependencies set), but better

Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
--- As seen in GammaRay Diffs - src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f Diff: https://git.reviewboard.kde.org/r/126969/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Volker Krause. Changes --- Submitted with commit 11055706bca380b75da48b8f5d4c27c53d86372d by Kevin Funk to branch master. Repository: kitemmodels Description --- As seen in GammaRay Diffs - src

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-19 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/127031/#comment63107> Maybe also add a hint / some code which shows how to use that uint? I.e. point to Qt's QT_VERSION_CHECK documentation or copy/paste it. - Kevin Funk On Feb. 19, 2016, 12:46 p.m., David Edmu

Re: Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-26 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/127177/#comment63232> Remove indentation. Same below. - Kevin Funk On Feb. 25, 2016, 5:16 p.m., Thomas Friedrichsmeier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 127211: Properly use static QMaps

2016-02-28 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92877 --- Ship it! Ship It! - Kevin Funk On Feb. 28, 2016, 9:52

Re: Review Request 127265: Fix windows build of Ki18n

2016-03-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127265/#review93140 --- Ship it! Ship It! - Kevin Funk On March 3, 2016, 5:49

Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE

2016-03-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/#review93396 --- Ship it! Ship It! - Kevin Funk On March 10, 2016, 7:04

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

2016-03-14 Thread Kevin Funk
> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Kevin Funk
is a better fit for this question. Cheers, Kevin > R. > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfun

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127406/#review93635 --- Ship it! Ship It! - Kevin Funk On March 17, 2016, 12

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-03-19 Thread Kevin Funk
gh to judge. Generally I'd say "yes". Does `iconPath(..., KIconLoader::MatchBest)` return results you'd have received with `iconPath(..., KIconLoader::MatchExact)`? - Kevin Funk On March 15, 2016, 1:52 a.m.,

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Kevin Funk
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review94684 --- On Dec. 3, 2015, 8 a.m., Kevin Funk wrote: > > ---

Re: dbus-less frameworks on osx

2016-05-10 Thread Kevin Funk
sure if they need to be dbus-less. IOW: Go ahead! :) Cheers, Kevin > > > > for example, i have just built kauth without dbus and i can prepare a > > review request with a (nice) patch for this > > Having suggested this in the past: I think that's a good idea and I fu

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-16 Thread Kevin Funk
well. See next comment. CMakeLists.txt (line 32) <https://git.reviewboard.kde.org/r/127911/#comment64739> `cmake -E make_directory` first? - Kevin Funk On May 16, 2016, 6:21 a.m., Gleb Popov wrote: > > --- > This i

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95522 --- Ship it! Ship It! - Kevin Funk On May 17, 2016, 5:55

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-27 Thread Kevin Funk
ocumented, command line options > which are useful. Documentation is available at > http://kdesrc-build.kde.org/documentation/, and if you build kdesrc-build > it should install a man page to $KDEDIR/share/man/man1 or thereabouts. > > I've recently become a big fan of --resume-from (or -after), --stop-before > (or -after) and --ignore-modules options myself. And always --pretend. > > Regards, > - Michael Pyne Cheers -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
IC fixes the build for me. Greets -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: > Hey, > > I get the following compile errors when compiling anything that depends on > libKF5XsltKde.a from kdoctools: > > When compiling kio: > > [ 53%] Built target kio_file > /home/krf/bin/ld: error:

Re: Compile errors originating from libKF5XsltKde.a

2014-02-27 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 15:24:30 schrieb Kevin Funk: > Am Donnerstag, 27. Februar 2014, 13:06:38 schrieb Kevin Funk: > > Hey, > > > > I get the following compile errors when compiling anything that depends on > > libKF5XsltKde.a from kdoctools: > > >

Review Request 116124: Always compile static lib with -fPIC

2014-02-27 Thread Kevin Funk
--- Always compile static lib with -fPIC See http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012375.html Diffs - src/CMakeLists.txt 0329bd383415b4fa265c1edd7f0f7d384fd17395 Diff: https://git.reviewboard.kde.org/r/116124/diff/ Testing --- Thanks, Kevin Funk

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-28 Thread Kevin Funk
Am Donnerstag, 27. Februar 2014, 21:15:54 schrieb Michael Pyne: > On Thu, February 27, 2014 11:35:16 Kevin Funk wrote: > > Am Mittwoch, 26. Februar 2014, 23:27:08 schrieb Michael Pyne: > > > On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: > > > > Also, whil

Re: Review Request 116124: Always compile static lib with -fPIC

2014-03-02 Thread Kevin Funk
Diff: https://git.reviewboard.kde.org/r/116124/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/includes/KTextEditor/SearchInterface f7dffc91739e82cceffea35de0632cb19e92ab0a src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e Diff: https://git.reviewboard.kde.org/r/117017/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53937 --- On March 24, 2014, 10:48 a.m., Kevin Funk wrote: > > --- > This

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
do the frameworks devs think about it? Greets [1] http://qt-project.org/doc/qt-5/index.html [2] http://qt-project.org/doc/qt-5/overviews-main.html [3] http://qt-project.org/doc/qt-5/qtexamplesandtutorials.html -- Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Writing a Frameworks book at Randa

2014-04-09 Thread Kevin Funk
On Wednesday 09 April 2014 15:42:47 Aleix Pol wrote: > On Wed, Apr 9, 2014 at 3:05 PM, Kevin Funk wrote: > > On Wednesday 09 April 2014 02:25:18 Valorie Zimmerman wrote: > > > Hello folks, I know that August is months away, but if you want your > > > Frameworks bo

Hitting assertion in kio-trash (KF5KIOCore)

2014-04-16 Thread Kevin Funk
;.trashinfo' or '.trashinfo SOME_NUMBER'. In case of the latter, the assert will always be hit. Any ideas? Did KIO::RenameDialog::suggestName change? Reproducable with: ./plugins/git/tests/kdevgit-test testRemoveEmptyFolder from kdevplatform.git. Greets -- Kevin Funk __

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-23 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/117695/#comment39333> Early-return? if (!replacetabs) return str; ... - Kevin Funk On April 23, 2014, 8:49 a.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail.

Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk
cpp 91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

2014-05-02 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/#review57150 --- Ship it! LGTM - Kevin Funk On May 2, 2014, 4:12 p.m

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk
view57148 --- On May 2, 2014, 4:10 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 117951: trash: Fix KUrl->QUrl porting bug

2014-05-02 Thread Kevin Funk
cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba Diff: https://git.reviewboard.kde.org/r/117951/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-framewo

Re: Hitting assertion in kio-trash (KF5KIOCore)

2014-05-02 Thread Kevin Funk
On Wednesday 16 April 2014 21:31:01 Kevin Funk wrote: > Hey, > > While running unit tests from kdevplatform I hit the following assert in > trash/trashimpl.cpp (from workspace/kio-extras) > > Output of the unit test (which attempts to trash some folders): > trying to crea

Re: KTextEditor & Frameworks question

2014-01-06 Thread Kevin Funk
tried to build kdevplatform against the ktexteditor framework -- Didn't work because CMake didn't find KF5TextEditorConfig.cmake. The problem is that all your .cmake files are missing the KF5 prefix which other frameworks apparently have set. CMake cannot find the framework via find_pack

Re: KTextEditor & Frameworks question

2014-01-07 Thread Kevin Funk
F5TextEditor/KF5TextEditorTargets.cmake 49:add_library(KF5::KF5TextEditor SHARED IMPORTED) he KF5 suffix should be dropped, no? I'd fix myself but atm I don't know where that magic line is generated from. Cheers -- Kevin Funk ___ Kde-frameworks-

Re: KTextEditor & Frameworks question

2014-01-07 Thread Kevin Funk
Am Dienstag, 7. Januar 2014, 21:20:40 schrieb Kevin Funk: > Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: > > Hi, > > > > I just tried to fix the naming issues. > > > > Does that try here look better > > > > http://quickgit.kd

Review Request 115347: Remove Qt5Xml dependency

2014-01-27 Thread Kevin Funk
--- Remove Qt5Xml dependency Not needed, no? Diffs - CMakeLists.txt 94afe9f5f414a437e519242026ebaf2a838ffc88 Diff: https://git.reviewboard.kde.org/r/115347/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing

Re: Review Request 115347: Remove Qt5Xml dependency

2014-01-28 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: add test for QFileDialog::getExistingDirectory / bug?

2014-01-28 Thread Kevin Funk
; > with 2c1ee08a21a1f16f9c2523718224598de8fc0d4f I added a test for > > QFileDialog::getExistingDirectory. > > > > When I execute > > > > ./qfiledialogtest --staticFunction getExistingDirectory > > > > then a dialog opens th

Re: More work available

2012-08-02 Thread Kevin Funk
ntil now I didnt actually have time or didnt know where to start, but I guess the above link should help me to get started. I'd really like to get more involved into kdelibs API development and/or Qt upstream work. Anyway, for now, and for the next week I'm at the aforesaid beach, though.

Review Request: Port some uses of KProcess to QProcess

2012-09-18 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Port some uses of KUrl to QUrl

2012-09-18 Thread Kevin Funk
6f5eae6147e2fbef25025976a17869af4d0f12f9 kio/tests/kruntest.cpp 92496bd1d4b98ea8f7dc13977cd3d2aa0dae7145 kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 Diff: http://git.reviewboard.kde.org/r/106501/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request: Port some uses of KUrl to QUrl

2012-09-19 Thread Kevin Funk
dae7145 kio/tests/krununittest.cpp 314da79b9ee4f95bcc9f768a95810f7de3125ac1 Diff: http://git.reviewboard.kde.org/r/106501/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: Review Request 106501: Port some uses of KUrl to QUrl

2013-02-07 Thread Kevin Funk
nt :) - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106501/#review26876 --- On Sept. 19, 2012, 10:19 p.m., K

Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-06 Thread Kevin Funk
o5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-08 Thread Kevin Funk
(5, 0, 0) (qglobal.h). That means basic functions such as QString::fromAscii are disabled because they're marked as deprecated since 5.0. Question is: Do we really want to override the default value for QT_DISABLE_DEPRECATED_BEFORE? - Kevin Funk On July 6, 2014, 10:17 p.m., Kevin Funk

Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk

Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
visit: https://git.reviewboard.kde.org/r/119241/#review62182 ------- On July 12, 2014, 9:41 a.m., Kevin Funk wrote: > > --- > This is an automatically generate

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Kevin Funk
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Kevin Funk
ettings. > > Sune Vuorela wrote: > agreed. > > Kevin Funk wrote: > Yep. I'm also *strongly* in favor of adjusting the code instead of > enabling the define. > > In fact, I thought I've fixed all of KF5. (It isn't?). > There are so

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-08-05 Thread Kevin Funk
ault] Is there any reason for it to be there? Diffs - cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-framework

Re: kio_trash

2014-08-27 Thread Kevin Funk
x27;trash'. " (We're using KIO::trash, but the CI doesn't provide this particular slave because it's part of different module) Greets [1] http://build.kde.org/view/kdevelop/job/kdevplatform_frameworks_qt5/154/testReport/(root)/TestSuite/test_kdevgit/ -- Kevin Funk | kf..

Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
public API) Thanks [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKMimeType.html#a3417e83a30cff614a01a29ca2a615443 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-fram

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
On Friday 12 September 2014 10:50:36 David Faure wrote: > On Friday 12 September 2014 09:39:42 Kevin Funk wrote: > > Heya, > > > > Context: Forward-porting some patches in KDevelop involving KMimeType API. > > > > I've just noticed that in Qt5, QMime

Re: OSX/CI: plasmate fails to build on branch frameworks

2014-09-15 Thread Kevin Funk
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Note: Plasmate needs to be fixed to work on the current kdevplatform. We've done the invasive KUrl->QUrl port there which of course broke source compatibility. Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Build error with frameworkintegration

2014-09-29 Thread Kevin Funk
t; > > > cc1plus: some warnings being treated as errors > > > > I even tried a clean rebuild of all kde frameworks master, and qt 5.4 > > > > How do I turn off werror? > > > > Thanks. > > ___ > > Kde-

Review Request 120435: Declare InheritanceChecker before actual use

2014-09-30 Thread Kevin Funk
478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/#review67849 --- Bump. This is a super trivial patch. :) - Kevin Funk On

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-11 Thread Kevin Funk
-- src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Replacement for KMimeType::isBinaryData?

2014-10-28 Thread Kevin Funk
Heya, I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is there some? http://lxr.kde.org/ident?v=kf5-qt5&_i=isBinaryData&_remember=1 shows exactly two users of this function. Worth considering upstreaming to Qt? -- Kevin Funk | kf...@kde.org | htt

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m

Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Kevin Funk
--- Can't change that now because it would be BIC. Diffs - src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 Diff: https://git.reviewboard.kde.org/r/121082/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-11 Thread Kevin Funk
sting --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: How to port KTabBar::mouseMiddleClick?

2014-11-11 Thread Kevin Funk
indow *subWindow = subWindowFromIndex(tabAt(event->pos())); 590-if (!subWindow) { 591-event->ignore(); 592-return; 593-} 594- 595-subWindow->close(); 596-} Worth trying to patch this into QTabBar right away, I think. Cheers -- Kevin Funk | kf...@kde.org | htt

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks

Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-18 Thread Kevin Funk
/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-18 Thread Kevin Funk
--- Use correct version in kbuildsycoca5 executable Diffs - src/kbuildsycoca/kbuildsycoca.cpp 69b142745863218169d7da5a048293d6ab6b1978 Diff: https://git.reviewboard.kde.org/r/121173/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

2014-11-19 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-24 Thread Kevin Funk
e1c9f34cf24eb516c540db3288c93ad5bd093df3 src/document/katedocument.cpp aac17c719cbabf78c2135062fe566671713cea02 src/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 121276: KPluginInfo::category() instead of property("X-KDE-PluginInfo-Category")

2014-11-27 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121276/#review71029 --- Ship it! Ship It! - Kevin Funk On Nov. 27, 2014, 6:07 p.m

Where are my systray icons cont'd

2014-11-27 Thread Kevin Funk
my-systray-icons/ [2] https://developer.pidgin.im/ticket/16456 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where are my systray icons cont'd

2014-11-28 Thread Kevin Funk
On Thursday 27 November 2014 21:10:10 Kevin Funk wrote: > Heya, > > I'm still missing my beloved systray icons for a few applications in Plasma > 5 on Ubuntu 14.10 (using distro provided packages). > > I have every package installed according to [1] (sni-qt, libindicator*

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-12-19 Thread Kevin Funk
ettings/viewmodes/viewsett > ingstab.cpp.o 2 errors generated. > [ 50%] make[2]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewte > st.cpp.o] Error 1 make[1]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 -- Kevin Funk |

FYI: KF5Plasma fails to build under MSVC

2014-12-30 Thread Kevin Funk
tant expr'). Note: Rest builds fine. -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Replacement for KMimeType::isBinaryData?

2015-01-05 Thread Kevin Funk
u have more knowledge about mimetypes than us. Can we maybe just check > > whether the mimetype of sourceFile inherits text/plain? > > Excellent idea. This would go a long way indeed. > > I tried to find if this wouldn't work for some mimetypes, but I can't find > an exa

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-06 Thread Kevin Funk
ongg: > > CMake Error at CMakeLists.txt:64 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > > CMake Error at CMakeLists.txt:67 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > --- > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

2015-01-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121931/#review73523 --- Ship it! Ship It! - Kevin Funk On Jan. 8, 2015, 6:10 p.m

Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
27; as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-de

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
N Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
here it can, and includes '#include "moc_.cpp"' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk __

  1   2   3   4   5   6   >