D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga added a comment. I've just updated my KDE Identity account - my full name and email address can now be found by searching the username "nhiga" on KDE Identity - People . I'm sorry for the inconvenience caused. REPOSITORY R241 KIO

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga created this revision. nhiga added a reviewer: kde-frameworks-devel. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY If Krusader is installed, the `krarc` protocol is available and Dolphin may use it to open ZIP archives. In this case, when

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

nhiga added a comment. With `krarc`, users can open 7z and RAR files as folder in Dolphin (with patches [1] [2]). This is also useful for Gwenview - if you have pictures in a 7z or RAR archive, then you can view them in Gwenview without decompressing the whole archive to another location.

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga added a comment. This patch may be related to Bug 411330 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, kde-frameworks-devel Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga created this revision. nhiga added a reviewer: kde-frameworks-devel. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY With D23476 , this patch should let users who have Krusader installed to view files inside

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga edited the summary of this revision. nhiga edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, #frameworks, cfeck, pino, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

nhiga added a comment. When this patch is applied and Krusader is not installed: Dolphin (with "Open archives as folder" enabled): Opens the 7z/RAR archive using Ark. Gwenview: 7z/RAR archives will not appear (probably because it is unsupported without krarc). REPOSITORY R241 KIO

D23730: Add new protocol for 7z archives

nhiga created this revision. nhiga added a project: Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. nhiga requested review of this revision. REVISION SUMMARY This patch adds a new protocol, sevenz, for 7z archives by utilizing K7Zip. Previously, users have to

D23730: Add new protocol for 7z archives

nhiga added a comment. Notes: 1. This patch requires D23490 and the following KIO patch: diff --git a/src/filewidgets/kurlnavigator.cpp b/src/filewidgets/kurlnavigator.cpp index 80aa975..5a6c720 100644 ---

D23730: Add new protocol for 7z archives

nhiga added a comment. @meven There is a weird bug if I name the protocol as "7z" or "7zip": 1. If I double click on the 7z file, Dolphin gives the "invalid protocol" error. 2. If I try to manually enter the URL in Dolphin, i.e. `7z:/tmp/bar.7z` or `7zip:/tmp/bar.7z`, it does not

D23730: Add new protocol for 7z archives

nhiga edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D23780: Add new protocol for 7z archives

nhiga created this revision. nhiga added reviewers: Frameworks, cfeck, pino, dfaure, meven. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY D23730 adds the `sevenz` protocol for 7z archives by utilizing K7Zip, so

D22297: Add id="current-color-scheme" to collapse-all icons

nhiga created this revision. nhiga added a reviewer: VDG. nhiga added a project: Frameworks. nhiga requested review of this revision. REVISION SUMMARY BUG: 409546 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 AFFECTED FILES

D22297: Add id="current-color-scheme" to collapse-all icons

nhiga added a comment. Summary will be filled in later. Related: D19575 , Bug 409546 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg Cc:

D22297: Add id="current-color-scheme" to collapse-all icons

nhiga added a reviewer: davidhurka. nhiga added a subscriber: davidhurka. nhiga added a comment. @davidhurka Would you please try this diff and see if it resolves the bug? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg, davidhurka

D22297: Add id="current-color-scheme" to collapse-all icons

nhiga edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg, davidhurka Cc: davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D27419: Update Japanese holidays

nhiga created this revision. nhiga added reviewers: dvratil, winterz. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch is purely cosmetic since the predicted Vernal and Autumnal Equinox Days of 2021 are the same as the official

D27419: Update Japanese holidays

nhiga added a comment. In D27419#612064 , @winterz wrote: > I tested these changes locally. works > > do you have commit access? No, I do not have commit access. (I think commit access is only granted to active

D29223: Update Taiwanese holidays

nhiga created this revision. nhiga added reviewers: winterz, cgiboudeaux. nhiga added projects: KDE PIM, Frameworks. nhiga requested review of this revision. REVISION SUMMARY This patch improves upon @shrapnel 's work on the accuracy of the Taiwanese

D29223: Update Taiwanese holidays

nhiga added a comment. Notes: 1. Holidays for indigenous peoples have not been included. Some of them seem to have a fixed date, but for other festivals we know the range but not the exact dates. For example, it is known that 豐年祭(收穫祭) is celebrated between July 1 and September 30

D29223: Update Taiwanese holidays

nhiga added a comment. In D29223#658229 , @cgiboudeaux wrote: > I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan? The new file name follows the same naming scheme used by the PRC

D28874: Taiwanese holidays

nhiga added a comment. Thank you for your attempt to add Taiwanese holidays to KDE. However, I am afraid that this patch has to be reviewed again. The dates for some holidays (including, but not limited to, Spring Festival (also known as "Lunar New Year") and the Mid-Autumn Festival)

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 81833. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81321=81833 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh holidays/plan2/holiday_tw_zh-tw To: nhiga,

D29223: Update Taiwanese holidays

nhiga added a comment. Some historical arrangements of some holidays (e.g. Children's Day between 1998-2010) are currently ignored, but I believe this is less important. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim,

D29223: Update Taiwanese holidays

nhiga added a comment. > On the Spring festival 春節 of 2020, the publicholidays.tw page and the official source listed on that page both showed Jan 23 to 29 as the days off. I think both of us can be correct: - I referred to this document by Ministry of the Interior, R. O. C.

D29223: Update Taiwanese holidays

nhiga marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause,

D28874: Taiwanese holidays

nhiga added a comment. By the way, the holiday file for People's Republic of China (i.e. mainland China) also needs update too because the dates of Lunar calendar based holidays are only available for 2009. The comment in the file says "these have to wait for lunar calendar support", but

D29223: Update Taiwanese holidays

nhiga set the repository for this revision to R175 KHolidays. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham,

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 82085. nhiga added a comment. Added 植樹節. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81833=82085 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh

D29223: Update Taiwanese holidays

nhiga added a comment. Officially-recognized days (including 言論自由日) and the dates for 2020 can be found in this document

D29223: Update Taiwanese holidays

nhiga added a comment. @cgiboudeaux Thanks for the heads-up. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh,

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a reviewer: cgiboudeaux. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a comment. > specified the start year of Peace Memorial Day 228和平紀念日 Great! This is what I have missed in my patch. > The star * ones are specified using the "lunar new year date" minus/plus some days, hoping to make it easier to adapt to additional years in the future.

D29372: Taiwan: Use "zh_TW" language code

nhiga added a comment. I would say that the file should also be renamed. //My comment from D29223 :// > The new file name follows the same naming scheme used by the PRC (mainland China) holiday file, holiday_cn_zh-cn