D6808: Mark MPa and PSI as common units

2017-07-21 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Resolves https://bugs.kde.org/show_bug.cgi?id=379171 REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D6808

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

2017-08-19 Thread Nathaniel Graham
ngraham added a comment. FYI this has caused a conflict in Kate: https://bugs.kde.org/show_bug.cgi?id=383721 Also, I have created a patch to add the new shortcuts to Konsole, which does not use `KStandardShortcut`s: https://phabricator.kde.org/D7354 REPOSITORY R237 KConfig REVISION

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

2017-08-19 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio Cc: #frameworks

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

2017-08-19 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This speculative commit will populate UDS_CREATION_TIME if the Linux Kernel and QT version support it, following changes to do the same in

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-08-22 Thread Nathaniel Graham
ngraham added a comment. I haven't forgotten about this, but life has intervened and I'm not going to have time to work on it for a few days, maybe even a couple of weeks. If anyone else wants to run with it and take over, I won't be in the least bit offended. If not, I'll resume work at

D7423: Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. This patch doesn't actually directly use statx(); it goes through QFile, which is used to populate the statbuf object. QT has gained support for using statx() in Linux where available in current git master

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

2017-08-20 Thread Nathaniel Graham
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it" to "Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik,

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't)

2017-08-20 Thread Nathaniel Graham
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if QT version and Linux kernel support it (no effect if they don't)" to "Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't)". REPOSITORY R241 KIO REVISION DETAIL

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

2017-08-20 Thread Nathaniel Graham
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't)" to "Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689". REPOSITORY R241 KIO

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Noted! Thanks, Luigi. I'd like to add BUG: 286689 to the commit message on a separate line. Does the title of this revision become the commit message? If so, how do I add another line? The text field doesn't seem to support multi-line strings. REPOSITORY R241 KIO

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

2017-08-20 Thread Nathaniel Graham
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect if they don't) BUG: 286689" to "Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it". ngraham edited the summary of this revision. ngraham edited the

D7423: Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it

2017-08-20 Thread Nathaniel Graham
ngraham added a comment. Great, thanks guys. Thanks for bearing with me here. I'll see if I can test with the unreleased qtbase. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio Cc: ltoscano, #frameworks

D7810: Add missing icon sizes

2017-09-19 Thread Nathaniel Graham
ngraham added reviewers: VDG, jensreuterberg. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg, jensreuterberg Cc: #frameworks

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-22 Thread Nathaniel Graham
ngraham added reviewers: KDE Applications, Frameworks, broulik, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: #frameworks

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-22 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 333219 When the user clicks on a non-editable navigation bar to enter edit mode, always pre-select the URL. We mimic the

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-22 Thread Nathaniel Graham
ngraham added a comment. I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of

D7929: [WIP] Add new Column View option to KDirOperator

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: ngraham, elvisangelaccio, lbeltrame, #frameworks

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-22 Thread Nathaniel Graham
ngraham added a comment. Opps, I've corrected the bug number. You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location. Though you're right that it also

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-22 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 364884 Only match real MIME types when doing string matching to prevent pulling in unrelated files whose types match the string.

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-22 Thread Nathaniel Graham
ngraham added a comment. It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-22 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, nicolasfella, dfaure, kossebau, vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-23 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Fair enough. Your points are stronger than mine, now that I think about it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio,

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 19829. ngraham added a comment. Grouping the startsWith() and contains() entries REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7948?vs=19827=19829 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7948

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 19827. ngraham added a comment. Use startsWith() instead of contains() for greater speed and correctness, and do this for text MIME types as well REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7948?vs=19816=19827

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham added a comment. Ah, excellent idea. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-09-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. FWIW, this looks good to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-22 Thread Nathaniel Graham
ngraham added a comment. Anybody object? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp Cc: alexeymin, #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano,

D8021: Don't switch Location Bar mode with Escape key

2017-10-06 Thread Nathaniel Graham
ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: rkflx, #frameworks

D7810: Add missing icon sizes

2017-10-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch, Mandian! Can you mention some details of your testing process in the Test Plan section, and maybe attach some before-and-after screenshots? Also make sure this change doesn't cause any regressions when running software in a non-MATE (i.e.

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Any remaining concerns? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Unless I'm holding it wrong, https://lxr.kde.org/ident?_i=Comma&_remember=1 doesn't appear show any other uses of Ctrl+, as a keyboard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc:

D7810: Add missing icon sizes

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks. ngraham added a comment. This seems okay to me, but I'm pretty new and I'd really like sign-off from someone more experienced first. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810 To: mandian, #breeze, #vdg,

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-14 Thread Nathaniel Graham
ngraham updated this revision to Diff 20768. ngraham added a comment. Update current version REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8303?vs=20767=20768 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8303 AFFECTED FILES

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: aacid. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications, #frameworks, aacid Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Any progress? This is too good a change to not merge. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added reviewers: Dolphin, KDE Applications, Frameworks. ngraham added a project: Dolphin. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications, #frameworks Cc:

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Honestly I think it's fine the way it is: in the details view, we have a nice compact string that doesn't make the column too wide, and in the Information Panel, we have a longer string that provides more information and isn't too big since text can wrap there.

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-15 Thread Nathaniel Graham
ngraham marked an inline comment as done. ngraham added a comment. @markg I actually like the current verbose format. That's somewhat unrelated to this; can we track that change, if any, with a new patch? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D8303

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Darn, that's a shame. Looks like I was holding it wrong. I'll find another shortcut that doesn't conflict. Any suggestions? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: argonel, kfunk, marten,

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Great, thank you! REPOSITORY R824 Baloo Widgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D8303 To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef,

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. I do find myself doing this a lot, yes. I know a lot of people who, upon downloading a new piece of software, the first thing they do is check out the preferences window to see what's available. It's a subtle thing, but throughout the macOS world where the shortcut

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham retitled this revision from "Use Ctrl+, as the standard shortcut for "Configure "" to "Use Ctrl+Alt+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL

D7130: KMoreTools: Update and fix desktopfiles

2017-10-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R304:7d3992479ea1: KMoreTools: Update and fix desktopfiles (authored by gregormi, committed by ngraham). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D7130: KMoreTools: Update and fix desktopfiles

2017-10-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Derp derp derp. Works fine now. REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio,

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

2017-10-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R824:38681e7d27f5: Show Date Modified information by default in Dolphins Information Panel and… (authored by ngraham). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D7130: KMoreTools: Update and fix desktopfiles

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. I'm afraid this still doesn't merge cleanly onto Dolphin's master branch for me. `arc patch D7130` reports the following: This diff is against commit e2d0a8108ec04a208d384176d53f413686ed35f2, but the commit is nowhere in the working copy. Try to apply it

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 20821. ngraham added a comment. lxr.kde.org showed several programs using Ctrl+, but nothing uses Ctrl+Alt+, REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=20738=20821 BRANCH master REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. No worries, take your time. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: ngraham, alexeymin, #frameworks

D8296: Use Alt+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut for "Configure "" to "Use Alt+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL

D8296: Use Alt+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham added a comment. Alt+, is definitely better, yeah. Also, now we are actually preserving recovering Mac users' muscle memory, since the Alt key on a PC keyboard is in the same place as the Command key on a Mac keyboard. REPOSITORY R237 KConfig REVISION DETAIL

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

2017-10-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 20839. ngraham added a comment. Switch to Alt+, since that makes a bit more sense and actually preserves recovering Mac users' muscle memory (Alt being in the same place as the Command key) REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a comment. Sounds good. What's lxr? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: graesslin, broulik, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. My pleasure. It's always nice to get bugs fixed. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks

D8296: Use Alt+, as the standard shortcut for "Configure "

2017-10-17 Thread Nathaniel Graham
ngraham added a comment. Any objections to Alt+, ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks Cc: #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use Ctrl+, as the standard keyboard shortcut to invoke KDE programs' "Configure " menu items. Right now there is no shortcut defined for

D8296: Use Ctrl+, as the standard shortcut for "Configure "

2017-10-14 Thread Nathaniel Graham
ngraham added a reviewer: VDG. ngraham added a comment. FWIW, I did some basic testing on that and couldn't find any conflicts among Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, Skanlite. REPOSITORY R237 KConfig REVISION DETAIL

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. @markg, I strongly disagree that "recent files" are not useful in open/save dialogs. As I've mentioned before, a common use case that this enables is when you save an item from one program and need to open it in another without having a Dolphin window open that

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. I could get behind only adding it to Open File dialogs. Let me have a think on that. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp Cc: andreaska,

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. That said, it's not just me who wants this in Dolphin, too. There's a Bugzilla ticket with one dupe and 32 votes: https://bugs.kde.org/show_bug.cgi?id=357542 Also, we have a semi-functional version of this already in the form of the Places panel's Recently

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-10-12 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D7446#154734, @anthonyfieroni wrote: > You can add recent documents as an action like in Kate. Places model looks in not correct destination. I'm not sure exactly what this is referring to. Can you clarify? REPOSITORY

D8332: Added baloo urls into places model

2017-10-16 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Dolphin, KDE Applications. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications Cc: ngraham, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-16 Thread Nathaniel Graham
ngraham added a comment. I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682. Updating that accordingly. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-11 Thread Nathaniel Graham
ngraham added a comment. https://phabricator.kde.org/D7700 is definitely better. My patch here was just a quick-and-dirty way to get it quickly. We can close mine if that gets committed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks,

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-10 Thread Nathaniel Graham
ngraham added a reviewer: emmanuelp. ngraham added a comment. Any remaining objections? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio, aacid, emmanuelp Cc:

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-10 Thread Nathaniel Graham
ngraham added reviewers: dfaure, emmanuelp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror,

D8036: Make KStandardGuiItem::discard match QDialogButtonBox::Discard

2017-09-28 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8036 To: ngraham, davidedmundson, #frameworks, cfeck Cc: #frameworks

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck Cc: cfeck, #frameworks

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham added a reviewer: davidedmundson. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson Cc: cfeck, #frameworks

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham added a comment. Submitted a patch for that, too: https://phabricator.kde.org/D8036 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson Cc: cfeck, #frameworks

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham added a comment. Agreed. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson Cc: cfeck, #frameworks

D8036: Make KStandardGuiItem::discard match QDialogButtonBox::Discard

2017-09-28 Thread Nathaniel Graham
ngraham added reviewers: davidedmundson, Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8036 To: ngraham, davidedmundson, #frameworks Cc: #frameworks

D8036: Make KStandardGuiItem::discard match QDialogButtonBox::Discard

2017-09-28 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make KStandardGuiItem::discard match QDialogButtonBox::Discard, which is being changed in https://phabricator.kde.org/D8029

D8024: Change icon for discard changes in a dialog to dialog-cancel

2017-09-28 Thread Nathaniel Graham
ngraham added a comment. Hmm, I think edit-delete is the correct icon here, for two reasons: 1. That's what upstream Qt defaults to 2. dialog-cancel is more appropriate for a Cancel button (in fact that's what cancel is already using). But Discard is a more destructive action than

D8007: popplerextractor: don't try to guess the title if there isn't one.

2017-09-28 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, #okular Cc: #frameworks

D8007: popplerextractor: don't try to guess the title if there isn't one.

2017-09-28 Thread Nathaniel Graham
ngraham edited reviewers, added: aacid; removed: Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, aacid Cc: #frameworks

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, dfaure, davidedmundson. ngraham added a comment. Thanks for the patch! Instead of a bugzilla link, you can just use a special keyword: "BUG: 375249" This will ensure that the bug gets closed once the patch is accepted and merged. REPOSITORY R320

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-30 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I gave this a shot and it's an excellent change--a huge improvement over the status quo. I have two suggestions for further ergonomic refinement: - When the text field has

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-01 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D8056#151057, @simgunz wrote: > > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all > > I like the idea

D8098: Strip down and re-write the tags KIO slave.

2017-10-01 Thread Nathaniel Graham
ngraham added a comment. Fantastic work. I wasn't able to apply it with `arc`, though: This diff is against commit 9383ea8927579555301eb378c1ce299dde2a2d08, but the commit is nowhere in the working copy. Try to apply it against the current working copy state?

D8098: Strip down and re-write the tags KIO slave.

2017-10-01 Thread Nathaniel Graham
ngraham added a reviewer: vhanda. ngraham added a comment. Oh, I'm a dolt. I was trying to apply this to KIO, not Baloo. Ignore me; works fine when you're not holding it wrong. :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-29 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg Cc: alexeymin, #frameworks

D8021: Don't switch Location Bar mode with Escape key

2017-09-27 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 383984 Don't switch from editable to breadcrumb mode when htting the Escape key. Clients already implement their own ways to

D8021: Don't switch Location Bar mode with Escape key

2017-09-27 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, elvisangelaccio, broulik, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8021 To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure Cc: #frameworks

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 385158 Use edit-delete icon for buttons that execute destructive discard actions. This is what Upstream Qt originally had, but we

D8029: Use edit-delete icon for destructive discard action

2017-09-28 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added reviewers: Frameworks, VDG, dfaure, rkflx. ngraham removed a project: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8029 To: ngraham, #frameworks, #vdg, dfaure, rkflx Cc: #frameworks

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-08-27 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, navarromorales, firef, andrebarros,

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-08-27 Thread Nathaniel Graham
ngraham updated this revision to Diff 18867. ngraham added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. This update implements the following requested changes: 1. Located after Home bookmark and before Trash bookmark

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added a reviewer: aacid. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio, aacid Cc: elvisangelaccio, cfeck,

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-02 Thread Nathaniel Graham
ngraham updated this revision to Diff 19112. ngraham retitled this revision from "Add Tags browser places item to Dolphin and file pickers by default" to "Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled". ngraham edited the summary of this revision.

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-03 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D7668#142562, @elvisangelaccio wrote: > Note that this only works if there are no custom places yet (probably not a big deal). Yes, the idea here is to change the default setting for new installs, and this code is only run

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-03 Thread Nathaniel Graham
ngraham updated this revision to Diff 19135. ngraham added a comment. Used a different mechanism for gating this code on Baloo being active. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7668?vs=19112=19135 REVISION DETAIL https://phabricator.kde.org/D7668

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-03 Thread Nathaniel Graham
ngraham marked an inline comment as done. ngraham added a comment. The latest change should take care of that concern; I changed the `#ifdef`to `if (KProtocolInfo::isKnownProtocol(QStringLiteral("tags")))`, which should cover the case where Baloo was disabled after compilation but before

D7130: KMoreTools: Update and fix desktopfiles

2017-09-02 Thread Nathaniel Graham
ngraham added reviewers: KDE Applications, davidedmundson. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson Cc: ltoscano, #frameworks

D7668: Add Tags browser places item to Dolphin and file pickers by default

2017-09-02 Thread Nathaniel Graham
ngraham added a comment. This is similar to the change in https://phabricator.kde.org/D7446. These hidden features are so powerful; we need to reveal them! The one issue that I foresee with adding this is if a novice user clicks on it before any tags have been created, they might be

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-02 Thread Nathaniel Graham
ngraham added reviewers: broulik, elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror,

  1   2   3   4   5   6   7   8   9   10   >