T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, a

T8349: Improve Places panel usability and presentation

ngraham added a comment. Yeah, that's weird. Let's throw it on the pile. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx,

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov, manueljlin

D17816: Support for xattrs on kio copy/move

ngraham added a comment. @bruns? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kan

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Can you change your status to approved? @dfaure, one final look maybe? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhauman

D17816: Support for xattrs on kio copy/move

ngraham added a comment. After almost two years, I'm so happy to see this land! REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber,

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Phabricator didn't actually close the revision after I landed it because @bruns forgot to change his status to accepted. You can close this now, @arrowd. Great work! REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #framework

D28745: Skip caching thumbnails on encrypted filesystems

ngraham added a comment. Is this unblocked now that https://invent.kde.org/frameworks/solid/-/merge_requests/19 has been merged? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: sitter,

D28745: Skip caching thumbnails on encrypted filesystems

ngraham added a comment. OK great! Thanks for your patience through this very long process. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: sitter, dfaure, thiago, bruns, meven, ngra

D28745: Skip caching thumbnails on encrypted filesystems

ngraham added a comment. Cool, thanks! Can you go to Add Action > Abandon? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: sitter, dfaure, thiago, bruns, meven, ngraham, kde-frameworks-

D17816: Support for xattrs on kio copy/move

ngraham added a comment. What is the status of this? How do we move forwards? I know this has gone on a long time and we're all getting tired, but I think we can push this past the finish line without too much trouble, hopefully. :) REVISION DETAIL https://phabricator.kde.org/D17816 To: a

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Gotcha, thanks! REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, n

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22102 To: ngraham, #plasma, #vdg, mart, broulik Cc: ndavis, anthonyfieroni, pino, davidedmundson, filipf, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. In D27951#626346 , @trmdi wrote: > When drop an image to the desktop in the FolderView layout, there would be no menu, so users can not change the wallpaper by drag&drop in this case. How do you think about this?

D28033: Create ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch creates the `ExpandableListItem`, a re-usable PlasmaComponents3 item t

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28036: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28034: [WIP] [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28035: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a dependent revision: D28037: [Applet] Port to ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

ngraham added a subscriber: bruns. ngraham added a comment. Discussion points: - Is this even the right paradigm to use for extra actions? Or should we instead use a SwipeListItem and put the extra actions in an overflow menu, and use the expanded view only for custom content? - Should

D28033: Create ExpandableListItem

ngraham added a comment. In D28033#627184 , @cblack wrote: > In D28033#627180 , @davidre wrote: > > > I would love if we could find a way to show that the item is expandable > > > I would proba

D28033: Create ExpandableListItem

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28014: smb: do not double finish

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-mount-doublefinish REVISION DETAIL https://phabricator.kde.org/D28014 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cb

D27544: Fix update scenarios with no explicit downloadlink selected

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Probably wait for at least one more review from someone smarter and more familiar with this code than I am. :) REPOSITORY R304 KNewStuff BRANCH fix-update (branched from

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. In D27951#627078 , @trmdi wrote: > I think the user has to choose. When he chose dndToMove, that means he prefers the move action to others (copy, link, extract, set as wallpaper...) My interpretation of the use c

D27444: Added plasmoid heading svg

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @ndavis does the SVG look good to you? REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To: nic

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent work. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundso

D27444: Added plasmoid heading svg

ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham added a task: T10470: Improve the visuals of tray popups. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2

D28033: Create ExpandableListItem

ngraham added a comment. If it were a flat button, I'd want to make the default action button flat too, or else they wouldn't match. Here's how that would look: F8174983: Toolbuttons.png And here's how it would look with both of them as non-flat Pus

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77603. ngraham added a comment. - Add an opacity animation when expanded view is shown - Add a button on the right to expand and collapse the expanded view - Clean and simplify expand()/collapse() code a bit REPOSITORY R242 Plasma Framework (Library)

D17816: Support for xattrs on kio copy/move

ngraham added a comment. Thanks for coming back to finish this up! @dfaure and @bruns, does it look okay now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall Cc: scheirle, anthonyfieroni, tmarshall, arro

D27951: Allow users to change dropAction to MoveAction through kdeglobals

ngraham added a comment. All right, let's see what #VDG people and @davidedmundson have to say. I would like for this to go in in some form, but we have to make sure that everyone's okay with it. REPOSITORY R241 KIO REVISION DETAIL https://phabrica

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77635. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77603&id=77635 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phabricator

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77636. ngraham added a comment. Rebase better REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77635&id=77636 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phab

D28050: Add edit-reset

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH edit-beginning-end (branched from master) REVISION DETAIL https://phabricator.kde.org/D28050 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, mi

D28046: Change document-revert style to be more like edit-undo

ngraham added a comment. Retroactive +1; really very nice. Much clearer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28046 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27923: [FileIndexScheduler] Cleanup firstRun handling

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabrica

D21466: Recommend rebooting after installing Samba

This revision was automatically updated to reflect the committed changes. Closed by commit R432:8a104aa4fb41: Recommend rebooting after installing Samba (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21466?vs=588

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ngraham added a reviewer: ndavis. ngraham added a comment. @ndavis I know you had some idea for which icon to use, and an idea to make it a clickable button, right? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meve

D27923: [FileIndexScheduler] Cleanup firstRun handling

ngraham added a comment. In D27923#627611 , @bruns wrote: > In D27923#627606 , @ngraham wrote: > > > Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) >

D25815: Transmission-Qt tray icon added

ngraham added a comment. @ndavis, since you already submitted an alternative icon, maybe you could take this over. @vinzenzv would that be okay with you? REVISION DETAIL https://phabricator.kde.org/D25815 To: vinzenzv, #vdg, ndavis, ngraham Cc: broulik, ndavis, ngraham, iasensio, kde-frame

D28033: Create ExpandableListItem

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandableListItem.qml:2 > It shouldn't be in PC3. It's new API from qqc2.A Where should it live? PC2? Kirigami? > davidedmundson wrote in ExpandableListItem.qml:23 > Unused? Not unused, it's needed for `Highlight`, which

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77686. ngraham marked 4 inline comments as done. ngraham added a comment. - Address review comments - Improve inline comments for clarify - Use a pointing hand cursor when hovering over the item to indicate that it's clickable - Make subtitle wrappin

D28033: Create ExpandableListItem

ngraham marked 5 inline comments as done. ngraham added a comment. By switching to the PC3 `BusyIndicator`, I'm now seeing a binding loop that doesn't make sense to me: file:///home/nate/kde/usr/lib64/qml/org/kde/plasma/components.3/ExpandableListItem.qml:191:13: QML BusyIndicator: Bi

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77688. ngraham added a comment. Fix one thing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77687&id=77688 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phab

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77687. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77686&id=77687 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phabricator

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77691. ngraham added a comment. Add TODOs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77688&id=77691 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phabrica

D27855: [Debug] Improve readability of positioninfo debug format

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27855 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27771 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D27772: [WriteTransaction] Extend position test case

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27772 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D27853: [WriteTransactionTest] Test removal of positions only

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27853 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh jeez. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27854 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast0

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77695. ngraham added a comment. Use `StyledText` instead of `RichText` because `RichText` doesn't support eliding (see https://bugreports.qt.io/browse/QTBUG-16567) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricat

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77701. ngraham added a comment. - Create a re-usable public `toggleExpanded()` function and use it internally - Make the busy indicator a bit smaller so it doesn't make the list item taller when it appears REPOSITORY R242 Plasma Framework (Library) C

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77702. ngraham added a comment. Don't auto-collapse when the default action button is clicked; this can interfere with actions where you want the button to show a custom expanded view, as in the Networks widget REPOSITORY R242 Plasma Framework (Library

D25815: Transmission-Qt tray icon added

ngraham added a comment. Does this have to live in the plasma theme? Could it live in the Breeze icon theme? REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas

D25517: Add an option to extract image data and add front cover property

ngraham accepted this revision. ngraham added a comment. I agree, let's get this in now and refactor it later. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D25421: [kio_tags] improve log message when the database can't be opened

ngraham accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25421 To: ahmadsamir, #baloo, astippich, ngraham, bruns Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoo

D28078: guard against duplicated service discoveries

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah. REPOSITORY R320 KIO Extras BRANCH smb-no-dupes REVISION DETAIL https://phabricator.kde.org/D28078 To: sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensi

D25679: Implement writing of front cover in taglibwriter

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH tagLibBinaryWrite REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGas

D27871: sftp: fix seekPos + file resuming when part file is of size 11

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Let's land this now as-is and make that change universally in a separate patch before we bikeshed it to death. :) REPOSITORY R320 KIO Extras BRANCH sftp-seekpos REVISION DETAIL ht

D28093: [breeze-icons] add TeamViewer tray icons

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @ndavis? REPOSITORY R266 Breeze Icons BRANCH teamviewer-tray (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28093: [breeze-icons] add TeamViewer tray icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:cff8c406dd71: [breeze-icons] add TeamViewer tray icons (authored by rocka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28093?vs=77810

D27416: Add small icons for KeePassXC

This revision was automatically updated to reflect the committed changes. Closed by commit R266:036ba91a2bc3: Add small icons for KeePassXC (authored by wsdfhjxc, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27416?vs=77809&id=7785

D26983: Enable adding place as first child

ngraham added a comment. That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing away the work is pretty sad. REPOSITORY R241 KIO REVISION DETAIL https://phabrica

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pending a fix in Telegram itself? On that subject, has anyone submitted a bug report to them about their inappropriate use of pixmaps? REPOSITORY R266 Breeze Icons REVISION DE

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77935. ngraham marked 4 inline comments as done. ngraham added a comment. Move to PlasmaExtraComponents REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77702&id=77935 BRANCH ExpandableListI

D28033: Create ExpandableListItem

ngraham added a comment. Will beef up the docs next INLINE COMMENTS > davidedmundson wrote in ExpandableListItem.qml:230 > I meant the duration Not sure what you mean by "random." It's a multiple of a standard duration that I chose to look good (IMO). REPOSITORY R242 Plasma Framework (Li

D28033: Create ExpandableListItem

ngraham added a comment. (WRT duration) What should I do then? Hardcode something? Add a new duration in a separate patch? The only standard durations we have are all quite short; neither one feels suitable for the animation I'm using here. Also we multiply distance units by factors all

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77946. ngraham added a comment. Add API docs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77935&id=77946 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phabr

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 77947. ngraham added a comment. Fix a whitespace thingy REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77946&id=77947 BRANCH ExpandableListItem (branched from master) REVISION DETAIL ht

D28093: [breeze-icons] add TeamViewer tray icons

ngraham added a comment. I didn't notice it before, but this patch makes TeamViewer's app icon always use the monochrome version now: F8183406: Screenshot_20200318_132426.png We already have a Breeze icon for TeamViewer called `teamviewer` note the

D27617: [breeze-icons] Add telegram-desktop tray icons

ngraham added a comment. So... how do we fix this so that you can use a nice monochrome Breeze icon in your system tray? Whose code needs to change? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs, ndavis Cc: broulik, alexeymin, Ily

D28033: Create ExpandableListItem

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michae

D28093: [breeze-icons] add TeamViewer tray icons

ngraham added a comment. That will help for people using thick panels who see larger icons, but users of thin panels will still get the monochrome icon. It's yet another example of our inability to deterministically T10413: Find a way to specify whether to use monochrome or color icons i

D28033: Create ExpandableListItem

ngraham added a comment. I agree 150ms for shortDuration is much more sensible; the current speed it too short to even notice that something is animating. I think we need more durations though. My proposal would be something like this: shortDuration: 150ms mediumDuration: 250ms longD

D18878: Force NT1 protocol when listing smb:// network [work in progress]

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. We now have WS-Discovery support, so I don't think this patch is needed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolp

D28033: Create ExpandableListItem

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D28033: Create ExpandableListItem

ngraham added a comment. In fact it looks like Kirigami already uses 150 for short and 250 for long, so there's an argument for making Plasma consistent with that. Will submit patches. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngr

D28144: Make animation durations consistent with Kirigami values

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now longDuration is 120ms and shortDuration is 24ms. This p

D28033: Create ExpandableListItem

ngraham added a comment. D28143: Add "veryLongDuration" animation duration D28144: Make animation durations consistent with Kirigami values REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://p

D28144: Make animation durations consistent with Kirigami values

ngraham updated this revision to Diff 78035. ngraham added a comment. Don't forget kirigamiplasmastyle REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28144?vs=78031&id=78035 BRANCH improved-durations (branched from master) REVISION DE

D28144: Make animation durations consistent with Kirigami values

ngraham updated this revision to Diff 78036. ngraham added a comment. Forgot one more thing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28144?vs=78035&id=78036 BRANCH improved-durations (branched from master) REVISION DETAIL http

D27760: WIP | Added BatchMoveJob

ngraham added a comment. The general concept seems sane to me, but let's make sure @dfaure agrees. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27760 To: emateli, dfaure, ngraham Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D27504: smb faster copy to local

ngraham added a comment. Still +1 functionally. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast

D27255: nota

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @ndavis? REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To: m

D27235: add calindori icon in the new pm style

ngraham added a comment. Generally LGTM, though I agree that the hole in the top seems unnecessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27210: add KDEconnect Icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Also this needs the corresponding dark versions submitted as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg, #kde

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ngraham accepted this revision. REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

ngraham added a comment. Shipit! REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D24895: [RFC] Drop implicit size from PC buttons

ngraham added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, cblack, GB_2, michaelh, bruns

D25515: Only extract lyrics when the plain text flag is set

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane. REPOSITORY R286 KFileMetaData BRANCH lyricsExtraction REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-framew

D28144: Make animation durations consistent with Kirigami values

ngraham added a dependent revision: D28033: Create ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) BRANCH improved-durations (branched from master) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, LeGast

D28033: Create ExpandableListItem

ngraham edited the summary of this revision. ngraham added a dependency: D28144: Make animation durations consistent with Kirigami values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, david

D28144: Make animation durations consistent with Kirigami values

This revision was automatically updated to reflect the committed changes. Closed by commit R242:049978008b12: Make animation durations consistent with Kirigami values (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2814

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78103. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77947&id=78103 BRANCH ExpandableListItem (branched from master) REVISION DETAIL https://phabricator

D28033: Create ExpandableListItem

ngraham updated this revision to Diff 78104. ngraham added a comment. Use the new `veryLongDuration` duration instead a multiple of `longDuration` REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78103&id=78104 BRANCH Expandable

D28033: Create ExpandableListItem

ngraham marked 4 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D28163: Add input-dialpad and call-voicemail

ngraham added a comment. The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, m

  1   2   3   4   5   6   7   8   9   10   >