Review Request 126164: Request proper dbus name for kioexec

rvice name is not added when porting to qt5/kf5. Diffs - src/kioexec/CMakeLists.txt 91284a3 src/kioexec/main.cpp 68ed374 Diff: https://git.reviewboard.kde.org/r/126164/diff/ Testing --- Dolphin now does not freeze in this case. Thanks, Xuetian

Re: Review Request 126164: Request proper dbus name for kioexec

s.txt 91284a3 src/kioexec/main.cpp 68ed374 Diff: https://git.reviewboard.kde.org/r/126164/diff/ Testing --- Dolphin now does not freeze in this case. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 126222: Fix rating widget flickering when selecting rating with mouse

ing(2) setHalfStepsEnabled(false) setMaxRating(1) setHalfStepsEnabled(false) setMaxRating(1) setHalfStepsEnabled(true) setMaxRating(5) setHalfStepsEnabled(true) Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

On Dec. 2, 2015, 4:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126222/ >

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kd

Review Request 126231: Fix a small artifact of kratingwidget on hidpi

Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

, rating becomes 2. Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

up, click on 1st star, rating becomes 2. Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126231: Fix a small artifact of kratingwidget on hidpi

. Now it draws correctly. File Attachments Demonstrate the problem https://git.reviewboard.kde.org/media/uploaded/files/2015/12/03/5fd4f10d-cc2a-49f4-b6b1-ac5ac1d1e9e5__screenshot24.png Thanks, Xuetian Weng ___ Kde-frameworks

Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

N src/filewidgets/kurlnavigator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng _

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

igator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

igator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng _

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

t with private interface. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89378 --- On Dec. 12,

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

emote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127166: Fix xcb port of klauncher and clean up the code.

her/klauncher.h 31bfaaa src/klauncher/klauncher.cpp 7ea9da9 Diff: https://git.reviewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

gn to it in the function. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92707 --- On Feb. 24

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92811 --- ping - Xuetian Weng On Feb. 24, 2016, 5:19 a.m., Xuetian

Review Request 127201: Fix svg icon path resolving in IconItem

svg?? introduced in https://git.reviewboard.kde.org/r/126557/ Diffs - src/declarativeimports/core/iconitem.cpp 085f284 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian W

Re: Review Request 127201: Fix svg icon path resolving in IconItem

otests/data/icons/test-theme/index.theme PRE-CREATION autotests/iconitemtest.h 9fd3063 autotests/iconitemtest.cpp f675465 src/declarativeimports/core/iconitem.cpp c65a9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconI

Re: Review Request 127201: Fix svg icon path resolving in IconItem

e icon is not rendered with the same svg backend but it will pass for now. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 -----

Re: Review Request 127201: Fix svg icon path resolving in IconItem

IconItem. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so

Re: Review Request 127201: Fix svg icon path resolving in IconItem

9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/

Review Request 127261: Fix dead lock when program use kauth exits.

can exits upon logout/exit. Tested with kquitapp5 kded5. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

kends/dbus/DBusHelperProxy.cpp 20dad0a Diff: https://git.reviewboard.kde.org/r/127261/diff/ Testing --- Now kded5 can exits upon logout/exit. Tested with kquitapp5 kded5. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Review Request 127271: Disable session restore for kwalletd5

etd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

eviewboard.kde.org/r/127261/#review93082 --- On March 2, 2016, 8:58 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 127261: Fix dead lock when program use kauth exits.

> On March 3, 2016, 7:05 a.m., Martin Gräßlin wrote: > > nice work! I had run into it in the past and didn't succeed investigating > > it. > > Xuetian Weng wrote: > https://bugreports.qt.io/browse/QTBUG-51648 > > As pointed out by Thiago on irc,

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

ction if needed. Diffs (updated) - src/klauncher/klauncher.h 31bfaaa src/klauncher/klauncher.cpp 7ea9da9 Diff: https://git.reviewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-f

Re: Review Request 127261: Fix dead lock when program use kauth exits.

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 702475557d5d2f6680f01169b4e33881be9b35b7 by David Faure on behalf of Xuetian Weng to branch master. Repository: kauth Description --- I'm on Qt 5.6 RC, and just not

Re: Review Request 127271: Disable session restore for kwalletd5

t.reviewboard.kde.org/r/127271/#review93187 ------- On March 3, 2016, 8:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian W

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian W

Re: Review Request 127271: Disable session restore for kwalletd5

it. Diffs (updated) - src/runtime/kwalletd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

ewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

it. Diffs (updated) - src/runtime/kwalletd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127271: Disable session restore for kwalletd5

--- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121303: detect kde4 home better in kde4 migration

kde exists. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121303: detect kde4 home better in kde4 migration

Testing --- return ~/.kde4 first even ~/.kde exists. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121303: detect kde4 home better in kde4 migration

g/r/121303/diff/ Testing --- return ~/.kde4 first even ~/.kde exists. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121303: detect kde4 home better in kde4 migration

------- On Dec. 4, 2014, 8:22 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121303/ > -

Re: Review Request 121303: detect kde4 home better in kde4 migration

ration.cpp d8d564a Diff: https://git.reviewboard.kde.org/r/121303/diff/ Testing --- return ~/.kde4 first even ~/.kde exists. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailma

Review Request 121411: Don't trigger animation if size changed.

Diffs - src/declarativeimports/core/iconitem.cpp ed3bb978f01cca98315fd425778139e4b9eeb64f Diff: https://git.reviewboard.kde.org/r/121411/diff/ Testing --- Looks fine on tray icon and lock screen, no blurry transition anymore. Thanks, Xuetian

Re: Review Request 121411: Don't trigger animation if size changed.

correct size icon. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71665 --- On Dec. 9, 2014,

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequentl

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? > > Xuetian Weng wrote: > 1. icon size (the widget size) doesn't change frequentl

Re: Review Request 121411: Don't trigger animation if size changed.

Testing (updated) --- Looks fine on tray icon and lock screen, less blurry transition. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121411: Don't trigger animation if size changed.

hanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

cfg PRE-CREATION thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION thumbnail/CMakeLists.txt e9ab79b thumbnail/jpegcreator.cpp de4902b thumbnail/jpegcreatorsettings.kcfg 8f68f46 Diff: https://git.reviewboard.kde.org/r/122082/diff/ Testing --- compiles. Thanks, Xuetian W

Re: Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

tps://git.reviewboard.kde.org/r/122082/diff/ Testing --- compiles. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

deleted, don't call other related functions on this KNotification. 3. watcher is safer to call deleteLater on watcher first. Diffs - src/notifybypopup.cpp 95937fc Diff: https://git.reviewboard.kde.org/r/122393/diff/ Testing --- Above code doesn't crash an

Re: Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

Above code doesn't crash anymore. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

sting --- Above code doesn't crash anymore. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

----- On Feb. 2, 2015, 8:59 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122393/ > ---

Re: Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

sting --- Above code doesn't crash anymore. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122393: Fix dangling pointer and possible memory leak in knotifications

cpp 95937fc Diff: https://git.reviewboard.kde.org/r/122393/diff/ Testing --- Above code doesn't crash anymore. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122396: Fix knotifyconfig leak

fybyktts.h 43756f7 src/notifybyktts.cpp a2a15a9 src/notifybylogfile.h 6ea2850 src/notifybylogfile.cpp ca3faf9 Diff: https://git.reviewboard.kde.org/r/122396/diff/ Testing --- Works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailin

Re: Review Request 122396: Fix knotifyconfig leak

0ac src/notifybypopup.h a605a77 src/notifybypopup.cpp 2f08146 Diff: https://git.reviewboard.kde.org/r/122396/diff/ Testing --- Works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.o

Re: Review Request 122396: Fix knotifyconfig leak

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122396/#review75271 ------- On Feb. 3, 2015, 12:15 a.m., Xuetian Weng wrote: > >

Re: Review Request 122396: Fix knotifyconfig leak

a77 src/notifybypopup.cpp 2f08146 Diff: https://git.reviewboard.kde.org/r/122396/diff/ Testing --- Works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122438: Notiy config leak fix try 2

src/knotificationplugin.h 3438e7d src/notifybypopup.h a605a77 src/notifybypopup.cpp 2f08146 src/CMakeLists.txt 3e5821a Diff: https://git.reviewboard.kde.org/r/122438/diff/ Testing --- works. Thanks, Xuetian Weng ___ Kde-frameworks-

Re: Review Request 122438: Notiy config leak fix try 2

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75461 ------- On Feb. 5, 2015, 9:43 a.m., Xuetian Weng wrote: > > --- > This

Re: Review Request 122438: Notiy config leak fix try 2

works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

/kdeplatformfiledialoghelper.cpp 94f2059 Diff: https://git.reviewboard.kde.org/r/125154/diff/ Testing --- So far I'm not able to reproduce 350758 for now. I uses lokalize merge file window to test since it's the easiest one for me to reproduce 350758. Thanks, Xu

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

Diff: https://git.reviewboard.kde.org/r/125154/diff/ > > > Testing > --- > > So far I'm not able to reproduce 350758 for now. > I uses lokalize merge file window to test since it's the easiest one for me > to reproduce 350758. > > > Thanks, > > Xuetian Weng > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

he app. > However I tested the proposed patch and it does not solve the problem for > me... > > Xuetian Weng wrote: > Hi, you did remind me that I also hit this on kdenlive. But it seems that > this does fix for kdenlive. I tried ctrl+o dialog and was not able to &

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

it's the easiest one for me to reproduce 350758. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125208: Workaround bug 350758

p.h 5936dfb src/platformtheme/kdeplatformfiledialoghelper.h dfbbed1 src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 Diff: https://git.reviewboard.kde.org/r/125208/diff/ Testing --- not able to reproduce the bug. Thanks, Xuetian Weng

Re: Review Request 125208: Workaround bug 350758

cpp f805ef2 src/platformtheme/kdeplatformfiledialogbase.cpp 8e696bd src/platformtheme/kdeplatformfiledialogbase_p.h 5936dfb src/platformtheme/kdeplatformfiledialoghelper.h dfbbed1 src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 Diff: https://git.reviewboard.kde.o

Re: Review Request 125208: Workaround bug 350758

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/#review85299 --- On Sept. 12, 2015, 9:40 p.m., Xuetian Weng wrote: > > --- > This

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

loghelper.h dfbbed1 src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 Diff: https://git.reviewboard.kde.org/r/125208/diff/ Testing --- not able to reproduce the bug. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

se_p.h 5936dfb src/platformtheme/kdeplatformfiledialoghelper.h dfbbed1 src/platformtheme/kdeplatformfiledialoghelper.cpp 94f2059 Diff: https://git.reviewboard.kde.org/r/125208/diff/ Testing --- not able to reproduce the bug. Thanks, Xuetian Weng _

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

work on test machine? - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/#review86251 --- On Sept. 30, 20

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

unit/(root)/TestSuite/frameworkintegration_kfiledialog_unittest/ > > seems to indicate that your commit broke the tests, now the test program > > gets stuck and never terminates. > > Xuetian Weng wrote: > It works here localily. Maybe for some reason that > QTest::qWaitForWindowExposed wi

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

unit/(root)/TestSuite/frameworkintegration_kfiledialog_unittest/ > > seems to indicate that your commit broke the tests, now the test program > > gets stuck and never terminates. > > Xuetian Weng wrote: > It works here localily. Maybe for some reason that > QTest::qWaitForWindowExposed wil

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote: > > Looks good! The only thing that I'm not sure about is whether 1000 bytes > > are guaranteed to be enough. Some quick Googling tells me that path lengths > > of 4096 are possible. Maybe we could allocate a temporary large array on > > t

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

a temporary large array on > > the heap if the readlink call fails with the 1000 byte buffer on the stack? > > Xuetian Weng wrote: > Just FYI, even PATH_MAX may not exists on some system (AFAIK, hurd, > allowed by posix). > And though st.st_size is mentioned in readl

Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

arent will not cause ksycoca data being recreated again and again. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

and again. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

iff: https://git.reviewboard.kde.org/r/125537/diff/ Testing --- Now a sub directory with larger timestamp than parent will not cause ksycoca data being recreated again and again. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

marked as submitted. Review request for KDE Frameworks, Albert Astals Cid and David Faure. Changes --- Submitted with commit 0a39ba6ec01600efeb9e334fa457dd725e2e3749 by David Faure on behalf of Xuetian Weng to branch master. Repository: kservice Description --- In

Re: Review Request 125705: Use LANG for month names in calendar applet

) <https://git.reviewboard.kde.org/r/125705/#comment59864> This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe even LANGUAGE should also be considered. But I guess using the first item from QLocale().uiLanguages() would just work. - Xuetian Weng On Oct. 19, 2015

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote: > > src/declarativeimports/calendar/calendar.cpp, line 197 > > > > > > uilanguages is not good for direct inputing into QLocale (yes i know, > > it's stupi

Review Request 125885: Support socks5 proxy in KTcpSocket

imap agent, connect through socks5 proxy. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

-------- On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125885/ > -

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

> On Oct. 31, 2015, 8:39 a.m., David Faure wrote: > > This is clearly missing an "else" for other cases like an http proxy, can > > you add it, even without being able to test it? > > > > In any case this is a clear improvement. > > Xuetian Weng wro

Review Request 125904: Save proxy url with correct scheme.

proxy and ftp proxy will result in "ftp://"; and "socks://". Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125904: Save proxy url with correct scheme.

/r/125904/diff/ Testing --- Save socks proxy and ftp proxy will result in "ftp://"; and "socks://". Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125904: Save proxy url with correct scheme.

make sure that loading url configuration will hide url scheme correctly. Diffs - src/kcms/kio/kproxydlg.cpp c8fd0cd Diff: https://git.reviewboard.kde.org/r/125904/diff/ Testing --- Save socks proxy and ftp proxy will result in "ftp://"; and "socks://". T

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

iewboard.kde.org/r/125885/#review87847 --- On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, vi

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80433. xuetianweng added a comment. Try to fill the gap if we increase the line height with representitive char. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=69848&id=80433 BRANCH arcpatch-D25339 R

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80438. xuetianweng added a comment. handle the range with multiple lines. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80433&id=80438 BRANCH arcpatch-D25339 REVISION DETAIL https://phabricator.kd

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#563937 , @cullmann wrote: > Actually, I could live with: > > 1. All lines are a bit higher, for me that makes reading even easier. But the rendering shall have no glitches. > 2. Some lines have differe

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. F8244684: Screenshot_20200417_222110.png Add a screenshot to demostrate the change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann Cc

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80444. xuetianweng added a comment. Fix the handling when layout formats has background. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80438&id=80444 BRANCH arcpatch-D25339 REVISION DETAIL https:/

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80606. xuetianweng added a comment. Clean up the code a little bit and adding comments. Also fix a small bug if m_fontHeight has big difference with m_fontMetrics's height. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricat

  1   2   >