D10358: Repair copying file to VFAT without warnings.
dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. Even moving to a ntfs filesystem without the rights to change owner doesn't end in an empty file. Very good job. BRANCH silence_vfat_warnings REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
dfaure updated this revision to Diff 26728. dfaure added a comment. rebased CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10358?vs=26686&id=26728 BRANCH silence_vfat_warnings REVISION DETAIL https://phabricator.kde.org/D10358 AFFECTED FILES src/ioslaves/file/file.cpp src/ioslaves/file/file_unix.cpp To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
dfaure added a comment. Proper fix for the data loss in https://phabricator.kde.org/D10376. I'll rebase this one on top of it, to keep the silencing of the other warnings over vfat (other than the "nobody shall be allowed to peek" code). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
dfaure added a comment. OK, this shows that we need to fix a bigger issue before silencing the warnings on VFAT. But I just noticed something. The instructions you posted to kde-frameworks-devel for reproducing the bug are somewhat broken. sudo mount -t vfat -o uid=,fmask=0007,dmask=,rw,noexec,loop fat.fs /mnt/vfat leads to files that don't have "owner" permission, so one can't read the files he creates. $ echo a > /mnt/vfat/myfile zsh: permission denied: myfile $ cd /mnt/vfat ; touch foo ; ls -l -rwxrwx--- 1 root root 0 7 févr. 23:05 foo $ cat foo cat: foo: Permission denied Something like fmask= or fmask=0111 (if no file should be executable) seems much more sensible, so that I can edit my own files. The bug is still there though, I'll look into it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. Copying to a VFAT has no problems. Moving to a VFAT has the following problem: An Access Denied Information appears after the file have been created. In both cases, there is no data loss. In ntfs, as it is said that it supports chown (if you have the rights to do it), this patch doesn't fix the data loss. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10358 To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
D10358: Repair copying file to VFAT without warnings.
dfaure created this revision. dfaure added reviewers: chinmoyr, markg, jtamate. Restricted Application added a project: Frameworks. dfaure requested review of this revision. REVISION SUMMARY The refactoring returned the wrong value, which led to warnings, but it was also in the wrong place. We want KIO::chown() to fail explicitly, while we want chown during a file copy to be ignored on e.g. VFAT systems. TEST PLAN Copying a file to a VFAT partition no longer warns/errors. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10358 AFFECTED FILES src/ioslaves/file/file.cpp src/ioslaves/file/file_unix.cpp To: dfaure, chinmoyr, markg, jtamate Cc: #frameworks, michaelh, ngraham
