D12037: Immediately apply termInConstruction when term is complete

2018-04-08 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c7c5a0bffbea: Immediately apply termInConstruction when 
term is complete (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12037?vs=31638&id=31682

REVISION DETAIL
  https://phabricator.kde.org/D12037

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

2018-04-08 Thread Michael Heidelbach 
michaelh accepted this revision as: michaelh.
michaelh added a comment.
This revision is now accepted and ready to land.


  "Immediately add term to stack when it is complete" as commit message?

REPOSITORY
  R293 Baloo

BRANCH
  b392620_fix_term_stack

REVISION DETAIL
  https://phabricator.kde.org/D12037

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

2018-04-07 Thread Stefan Brüns 
bruns removed a task: T2: sudoku activity string must be changed: ".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12037

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

2018-04-07 Thread Stefan Brüns 
bruns updated this revision to Diff 31638.
bruns added a comment.


  rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12037?vs=31632&id=31638

BRANCH
  b392620_fix_term_stack

REVISION DETAIL
  https://phabricator.kde.org/D12037

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

2018-04-07 Thread Stefan Brüns 
bruns added dependencies: D11888: Handle adjacent special characters correctly, 
D12007: Add test case for parsing of double opening '(('.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12037

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

D12037: Immediately apply termInConstruction when term is complete

2018-04-07 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Term::Or and Term::And delimit the term in construction, but did not
  add the term to the stack. This necessitated to save the last seen
  operation, but use the previous operation from the stack when adding
  to it. Unfortunately the last seen operation was not restored correctly
  after pushing and popping from the stack.
  
  Instead of adding more state to the parser, immediately add a completed
  term to the stack, which allows to remove the temporary last operation.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  t2

REVISION DETAIL
  https://phabricator.kde.org/D12037

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp
  src/lib/advancedqueryparser.cpp

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin