D12218: Remove Reload button from the file dialogs' toolbar

ngraham abandoned this revision. ngraham added a comment. I'd be in favor of putting it into `KUrlNavigator`. But in retrospect, I see people's point regarding its usefulness somewhere visible in the dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To:

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#271375 , @rkflx wrote: > In D12218#271290 , @davidedmundson wrote: > > > > It can be useful for network views, but those are a minority of use cases > > > >

D12218: Remove Reload button from the file dialogs' toolbar

rkflx added a comment. In D12218#271290 , @davidedmundson wrote: > > It can be useful for network views, but those are a minority of use cases > > Every large scale KDE deployment (from my POV by far our most important userbase) has a

D12218: Remove Reload button from the file dialogs' toolbar

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Usability rules normally are that anything a user needs should be accessible without a context menu. > It can be useful for network views, but those are a

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Should we land this onto the `file-dialog-improvements` branch, or are folks still unsure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc:

D12218: Remove Reload button from the file dialogs' toolbar

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: abetts, markg, broulik, rkflx, #dolphin, michaelh, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: markg, broulik, rkflx, #dolphin, michaelh, bruns

D12218: Remove Reload button from the file dialogs' toolbar

rkflx added a comment. Can we find a compromise? For example, the Places panel already seems to know when something is on a remote location. Could we show Refresh only for remote folders? The toolbar reorganizing itself would also make users aware of the need to manually refresh in some

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#247481 , @ngraham wrote: > In D12218#247400 , @markg wrote: > > > As i said, it's all relative. I barely use any of the buttons but the one i do use is refresh. >

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: markg, broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. In D12218#247400 , @markg wrote: > As i said, it's all relative. I barely use any of the buttons but the one i do use is refresh. > I only need it when i'm impatient (for instance when wanting to click on a file that

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. >> Refresh on the other hand is something i use relatively often, more then any of the other buttons. > > Curious to know: What do you need Refresh for? Maybe there's need for some changes so you won't have to hit that button manually so often? As i said,

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. I personally find the reload button much more useful to have there. ... (looking at the buttons) ... Why not removing back, forward and up? This is not an ironic or sarcastic suggestion! Just be frank, how often do you use back? How often do you use forward

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. In D12218#247125 , @broulik wrote: > Is it also accessible from the menu in the top right? No, that's a settings menu, not a toolbar overflow menu. Ultimately the toolbar should be editable, to satisfy all

D12218: Remove Reload button from the file dialogs' toolbar

broulik added a comment. Is it also accessible from the menu in the top right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: rkflx, #dolphin, michaelh, ngraham, bruns

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. ngraham added subscribers: Dolphin, rkflx. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO REVISION DETAIL

D12218: Remove Reload button from the file dialogs' toolbar

ngraham created this revision. ngraham added a reviewer: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Horizontal space on the toolbar is precious and scarce, and that Reload button is taking up some of it. Once there's a Reload button in the context menu, it can