D12538: Select item without clicking the Open/Save button

ngraham added a comment. Oops, I was the one who was confused, sorry. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

rkflx added a comment. > [remove] BUG: 267749 Now I'm confused: Isn't what we do here exactly what the bug reporter wanted? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham,

D12538: Select item without clicking the Open/Save button

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254871 , @rkflx wrote: > @ngraham Is this still the case with the changed scope of the patch? Yeah, it's fine now that we're going to handle the single-click overwrite use case in another patch.

D12538: Select item without clicking the Open/Save button

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. Thanks, works great now for single click users. Glad we could skip a huge discussion ;) However, for double click mode and Save, descending into directories is kinda broken.

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254764 , @rkflx wrote: > Given the concerns with selection markers in single-select mode and thus for Save in general, and them being potentially far off in the future, can we think about changing this patch

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33204. anemeth added a comment. Add comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33203=33204 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12538: Select item without clicking the Open/Save button

anemeth added a comment. @rkflx thanks for digging through those old commits. I added that code again, but for saving only. Unfortunately I could not test it with single click because the setting has vanished (??) F5824410: aaa.PNG REPOSITORY

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33203. anemeth added a comment. Only doubleclick triggers save overwrite REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33165=33203 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12538: Select item without clicking the Open/Save button

rkflx added a comment. > https://bugs.kde.org/show_bug.cgi?id=267749 Wow, reading the bug again, my suggestions is fitting right in! Double click to trigger Save for single click users. Only after some confusion in Comment 1 the only slightly related question of overwriting came up in

D12538: Select item without clicking the Open/Save button

rkflx added a comment. After sleeping over this, I don't feel comfortable the way this is supposed to work for single click: Selection markers only really make sense when enabling multi-select mode. Abusing a single selection marker in single-select mode to mean "put the filename in the

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33165. anemeth removed a subscriber: rkflx. anemeth added a comment. Moved filename line edit focus to D12545 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33159=33165 BRANCH

D12538: Select item without clicking the Open/Save button

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (As mentioned before, this can't and won't land until other things have been fixed and implemented first) REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master)

D12538: Select item without clicking the Open/Save button

ngraham added a comment. Thanks, that's better. This makes me realize that there's a pre-existing bug: the selected text includes the filename extension, and it probably shouldn't. We should fix that in another patch though. REPOSITORY R241 KIO REVISION DETAIL

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33159. anemeth added a comment. Sorry, now fixed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33157=33159 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33157. anemeth added a comment. Remove unintentional changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33156=33157 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12538: Select item without clicking the Open/Save button

anemeth added a comment. Whoops, some unintentional changes made it in, will fix soon... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33156. anemeth added a comment. Focus filename lineEdit on highlight REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33137=33156 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12538: Select item without clicking the Open/Save button

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In double-click mode, this eliminates the desirable behavior whereby after a single click, the name field becomes focused so you can type a new name. We want to keep that,

D12538: Select item without clicking the Open/Save button

ngraham added a comment. We also need to fix the apps that erroneously supply their own overwrite dialog instead of letting the dialog handle it--as illustrated in Alex's video: the overwrite dialog appears only after the file dialog is gone, because it's a specia, thing that Kate displays

D12538: Select item without clicking the Open/Save button

ngraham added a comment. @jtamate, it's a valid concern, but if you don't want the single-click behavior, you should turn off single-click. Once we fix the lack of selection markers, then it will be easier to select an existing file whose name you want the saved file 's name to begin with.

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254334 , @broulik wrote: > Does the file dialog have those selector overlays Dolphin has? No; see https://bugs.kde.org/show_bug.cgi?id=185793 We'll need to fix that before this lands. REPOSITORY

D12538: Select item without clicking the Open/Save button

broulik added a comment. Does the file dialog have those selector overlays Dolphin has? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth added a comment. In D12538#254239 , @jtamate wrote: > I'm one of those that choose a file and add a "_2" to the filenames. ;-) > > Please, please, ask the KDE Usability Project about this change. This patch is part of task

D12538: Select item without clicking the Open/Save button

jtamate added a comment. I'm one of those that choose a file and add a "_2" to the filenames. ;-) Please, please, ask the KDE Usability Project about this change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: jtamate,

D12538: Select item without clicking the Open/Save button

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth retitled this revision from "Select item without clicking the open/save button" to "Select item without clicking the Open/Save button". anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a

D12538: Select item without clicking the open/save button

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL