D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  Oops, I was the one who was confused, sorry.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  > [remove] BUG: 267749
  
  Now I'm confused: Isn't what we do here exactly what the bug reporter wanted?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  In D12538#254871 , @rkflx wrote:
  
  > @ngraham Is this still the case with the changed scope of the patch?
  
  
  Yeah, it's fine now that we're going to handle the single-click overwrite use 
case in another patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  Thanks, works great now for single click users. Glad we could skip a huge 
discussion ;)
  
  However, for double click mode and Save, descending into directories is kinda 
broken. You might want to fix that before shipping…
  
  > Activate files in the filepicker without having to click on the Open/Save 
button first, but instead single/double clicking on the icon, depending on the 
mouse settings.
  
  Please update your summary too, and ideally reference those 3 commits I 
mentioned, as they contain useful information and you copied most of the patch 
from there.
  
  In D12538#254372 , @ngraham wrote:
  
  > (As mentioned before, this can't and won't land until other things have 
been fixed and implemented first)
  
  
  @ngraham Is this still the case with the changed scope of the patch?

INLINE COMMENTS

> kfilewidget.cpp:1179
> +// accept). This way the user can choose a file and add a "_2" for 
> instance to the filename.
> +// Double clicking however will trigger this, regardless of 
> single/double click mouse setting,
> +// see: _k_slotViewDoubleClicked

Do you mean "override" instead of "trigger" here?

> kfilewidget.cpp:2156-2162
> +void KFileWidgetPrivate::_k_slotViewDoubleClicked(const QModelIndex )
> +{
> +if (operationMode == KFileWidget::Saving && index.isValid()) {
> +q->slotOk();
> +}
> +}
> +

I'd move that right under `:_k_slotIconSizeSliderMoved`, to keep ordering at 
least somewhat consistent with the declaration.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  In D12538#254764 , @rkflx wrote:
  
  > Given the concerns with selection markers in single-select mode and thus 
for Save in general, and them being potentially far off in the future, can we 
think about changing this patch to double-click to overwrite, so single-click 
would still allow to append `_2` to the filename, a likely more common 
operation? Users who set click behaviour to double click everywhere would not 
be affected by this change at all!
  >
  > (And please think twice before making this discussion about a general 
single vs. double click debate again; I'm trying to improve single click to 
make more sense for the common use cases here, as we agreed upon as a sensible 
direction. Thanks ;)
  
  
  Makes sense. I'll let you be the judge of what behavior makes the most sense 
for single-click, since I don't use it. However to maybe set the record 
straight: I don't hate single-click; in fact, I love it conceptually! I'm very 
interested in improving the UX, particularly regarding ease-of-use with 
selections. If reverting to double-click makes sense here for usability, then 
let's do it.
  
  In D12538#254782 , @anemeth wrote:
  
  > @rkflx thanks for digging through those old commits.
  >  I added that code again, but for saving only.
  >  Unfortunately I could not test it with single click because the setting 
has vanished (??)
  
  
  Yep, see https://bugs.kde.org/show_bug.cgi?id=393547
  
  Hopefully Roman will fix this soon. In the meantime, you'll have to toggle it 
by editing `kate ~/.config/kdeglobals`; add `SingleClick=(true|false)` to the 
`[KDE]` section.

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33204.
anemeth added a comment.


  Add comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33203=33204

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth added a comment.


  @rkflx thanks for digging through those old commits.
  I added that code again, but for saving only.
  Unfortunately I could not test it with single click because the setting has 
vanished (??)
  
  F5824410: aaa.PNG 

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33203.
anemeth added a comment.


  Only doubleclick triggers save overwrite

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33165=33203

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  > https://bugs.kde.org/show_bug.cgi?id=267749
  
  Wow, reading the bug again, my suggestions is fitting right in! Double click 
to trigger Save for single click users. Only after some confusion in Comment 1 
the only slightly related question of overwriting came up in Comment 4, but 
this is not what the bug was originally about…

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Henrik Fehlauer]

rkflx added a comment.


  After sleeping over this, I don't feel comfortable the way this is supposed 
to work for single click: Selection markers only really make sense when 
enabling multi-select mode. Abusing a single selection marker in single-select 
mode to mean "put the filename in the line edit so it is editable" feels really 
weird, and if you are doing this more often than overwriting (which might be 
very likely!) hitting the small icon is quite cumbersome.
  
  IOW, I don't think the workaround which was promised to @jtamate's concern is 
good enough, and suggesting to switch to double click only to sustain a "pure" 
single click does not make sense to me either.
  
  The question for single click is: What is the primary action which should be 
triggered immediately? Is it overwriting, or is it putting the filename in the 
field? For Dolphin and the Open dialog it is clear that actually opening is the 
primary action. For Save I'd argue that overwriting is only the secondary 
option, and thus should be triggered by the second click only.
  
  I did some digging, and indeed this seems to be how it was originally 
implemented: 4ccd77256a0c 
 
added what this patch is now trying to remove again. Then right after that, 
f729c291cdbb 
 
allowed double clicking to overwrite without moving the mouse to the Save 
button. Somehow the latter commit got broken later on, I guess in 7f08f13809bc 
 
("Hope I didn't miss anything." haha). Maybe that slot should have triggered 
only for `KFileWidget::Saving`?
  
  Given the concerns with selection markers in single-select mode and thus for 
Save in general, and them being potentially far off in the future, can we think 
about changing this patch to double-click to overwrite, so single-click would 
still allow to append `_2` to the filename, a likely more common operation? 
Users who set click behaviour to double click everywhere would not be affected 
by this change at all!
  
  ---
  
  Historical side note: In KDE3 with single click enabled, the first click 
would select in file dialogs, the second click would accept. In KDE4 accepting 
was refined to single click for Open, but the double click was kept for Save, 
which makes sense to me.
  
  (And please think twice before making this discussion about a general single 
vs. double click debate again; I'm trying to improve single click to make more 
sense for the common use cases here, as we agreed upon as a sensible direction. 
Thanks ;)

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33165.
anemeth removed a subscriber: rkflx.
anemeth added a comment.


  Moved filename line edit focus to D12545 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33159=33165

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns, rkflx

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  (As mentioned before, this can't and won't land until other things have been 
fixed and implemented first)

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  Thanks, that's better. This makes me realize that there's a pre-existing bug: 
the selected text includes the filename extension, and it probably shouldn't. 
We should fix that in another patch though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33159.
anemeth added a comment.


  Sorry, now fixed

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33157=33159

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33157.
anemeth added a comment.


  Remove unintentional changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33156=33157

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth added a comment.


  Whoops, some unintentional changes made it in, will fix soon...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth updated this revision to Diff 33156.
anemeth added a comment.


  Focus filename lineEdit on highlight

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12538?vs=33137=33156

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In double-click mode, this eliminates the desirable behavior whereby after a 
single click, the name field becomes focused so you can type a new name. We 
want to keep that, while also showing the overwrite dialog on double-click.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg, ngraham
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  We also need to fix the apps that erroneously supply their own overwrite 
dialog instead of letting the dialog handle it--as illustrated in Alex's video: 
the overwrite dialog appears only after the file dialog is gone, because it's a 
specia, thing that Kate displays instead of using the save dialog's own 
overwrite warning.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  @jtamate, it's a valid concern, but if you don't want the single-click 
behavior, you should turn off single-click. Once we fix the lack of selection 
markers, then it will be easier to select an existing file whose name you want 
the saved file 's name to begin with.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham added a comment.


  In D12538#254334 , @broulik wrote:
  
  > Does the file dialog have those selector overlays Dolphin has?
  
  
  No; see https://bugs.kde.org/show_bug.cgi?id=185793
  
  We'll need to fix that before this lands.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Kai Uwe Broulik]

broulik added a comment.


  Does the file dialog have those selector overlays Dolphin has?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth added a comment.


  In D12538#254239 , @jtamate wrote:
  
  > I'm one of those that choose a file and add a "_2" to the filenames.  ;-)
  >
  > Please, please, ask the KDE Usability Project about this change.
  
  
  This patch is part of task T8552  which 
also tackles usability.
  If you have double click enabled, upon single clicking the icon it gets 
selected where you can add "_2".
  If you have single click enabled, well, I'm not quite sure about that...
  @ngraham what do you think about this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Jaime Torres Amate]

jtamate added a comment.


  I'm one of those that choose a file and add a "_2" to the filenames.  ;-)
  
  Please, please, ask the KDE Usability Project about this change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

[Alex Nemeth]

anemeth retitled this revision from "Select item without clicking the open/save 
button" to "Select item without clicking the Open/Save button".
anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.
anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12538

To: anemeth, #frameworks, #vdg
Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the open/save button

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  doubleclick_save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12538

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: anemeth
Cc: #frameworks, michaelh, bruns