D13394: C++: update for c++20 and fix some syntax errors

2018-07-14 Thread jonathan poelen
jpoelen added a comment. Thank you, but I already made the request and it was accepted last night. I will do the next push :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann,

D13394: C++: update for c++20 and fix some syntax errors

2018-07-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a2343cae2bb5: C++: update for c++20 and fix some syntax errors (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D13394: C++: update for c++20 and fix some syntax errors

2018-07-14 Thread Christoph Cullmann
cullmann added a comment. Restricted Application added a project: Kate. Restricted Application added a subscriber: kwrite-devel. To get this in, I will push it for you. If you need some reason for a developer account, you can just link this request. REPOSITORY R216 Syntax Highlighting

D13394: C++: update for c++20 and fix some syntax errors

2018-06-23 Thread jonathan poelen
jpoelen added a comment. I do not have a developer account, but I can do it. This is not a problem because I will contribute again. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann,

D13394: C++: update for c++20 and fix some syntax errors

2018-06-21 Thread Dominik Haumann
dhaumann added a comment. @jpoelen Can you push yourself, or do you still not have a KDE contributor account? REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-frameworks-devel,

D13394: C++: update for c++20 and fix some syntax errors

2018-06-18 Thread jonathan poelen
jpoelen added inline comments. INLINE COMMENTS > dhaumann wrote in gcc.xml:576-577 > These can be WordDetect as well, right? It does not work because of ':'. But Putting it in `weakDeliminator` will break things. For this to work, it would need `additionalDeliminator` and `weakDeliminator`

D13394: C++: update for c++20 and fix some syntax errors

2018-06-17 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good for me! Thanks for the improvements. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann,

D13394: C++: update for c++20 and fix some syntax errors

2018-06-16 Thread Christoph Cullmann
cullmann added a comment. Will take a look ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

2018-06-16 Thread jonathan poelen
jpoelen updated this revision to Diff 36229. jpoelen added a comment. - C++: test with clang:: in an attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13394?vs=35729=36229 BRANCH cpp REVISION DETAIL

D13394: C++: update for c++20 and fix some syntax errors

2018-06-12 Thread Dominik Haumann
dhaumann added a subscriber: cullmann. dhaumann added a comment. To be honest, I cannot claim I can follow all changes, since this is a big update. But in general the usage of the rules look good. The autotest output (html highlighting) looks good to me, it contains nice improvements

D13394: C++: update for c++20 and fix some syntax errors

2018-06-06 Thread jonathan poelen
jpoelen edited the summary of this revision. jpoelen added a reviewer: dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

2018-06-06 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - new keywords, attributes and standard macros - hexadecimal floatting point (c++17)