D16579: Musepack disk number field name is DISC.

smithjd updated this revision to Diff 44708. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Since the discussion around this patch has also included the Album Artist field, add the changes required for this field to this review. REPOSITORY R286

D16579: Musepack disk number field name is DISC.

bruns added a comment. In D16579#352406 , @smithjd wrote: > In D16579#352282 , @bruns wrote: > > > In D16579#352279 , @smithjd wrote: > > > > > I would

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#352282 , @bruns wrote: > In D16579#352279 , @smithjd wrote: > > > I would instead recommend a tag editor that properly tags APE files, such as puddletag.

D16579: Musepack disk number field name is DISC.

bruns added a comment. In D16579#352279 , @smithjd wrote: > I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats

D16579: Musepack disk number field name is DISC.

smithjd added a comment. I would instead recommend a tag editor that properly tags APE files, such as puddletag. APE-using formats are less mainstream than id3 using formats. Users with APE-using formats usually know WHY they use their format of choice, and will know there are potential

D16579: Musepack disk number field name is DISC.

astippich added a comment. In D16579#352255 , @smithjd wrote: > I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the

D16579: Musepack disk number field name is DISC.

smithjd added a comment. I would also argue that accepting values from tag field names that have identically-purposed, widely-acceptable alternatives is irresponsible. Changing your tags to meet the standard then is a more viable course of action. REPOSITORY R286 KFileMetaData REVISION

D16579: Musepack disk number field name is DISC.

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. In D16579#352218 , @smithjd wrote: > In D16579#352191 , @astippich wrote: > > > Yes,

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#352191 , @astippich wrote: > In D16579#352147 , @smithjd wrote: > > > In D16579#351910 , @astippich wrote: > > > >

D16579: Musepack disk number field name is DISC.

astippich added a comment. In D16579#352147 , @smithjd wrote: > In D16579#351910 , @astippich wrote: > > > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It

D16579: Musepack disk number field name is DISC.

smithjd updated this revision to Diff 44638. smithjd added a comment. - Change the unit test to check if the APE 'disc' value is correct. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44607=44638 BRANCH master-musepackFixes (branched

D16579: Musepack disk number field name is DISC.

smithjd added a comment. In D16579#351910 , @astippich wrote: > The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. > I've found references

D16579: Musepack disk number field name is DISC.

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. The ape tag tests fail with this patch, but the test is actually wrong in that regard. It tests for an empty disc number, which I haven't noticed before. I've found

D16579: Musepack disk number field name is DISC.

smithjd added a comment. Useful tag mapping information: https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16579: Musepack disk number field name is DISC.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Fix the Musepack disk field. REPOSITORY R286 KFileMetaData BRANCH master-musepackFixes (branched from