D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#396483 , @loh.tar wrote: > Well, I'm not a Sonnet Guru, more a normal user. Me too; your views are appreciated all the same. REPOSITORY R246 Sonnet REVISION DETAIL

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue. My comment is more about what I would expect or what I would try to achieve. I didn't investigate from where is

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395928 , @loh.tar wrote: > Just my thoughts: > > - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. The user

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. @loh.tar: I'll think that over, thanks for the pointers :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Just my thoughts: - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. - To set the dict to the system locale seems to me the less smartest trick. If everybody want such

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395530 , @pino wrote: > In D18317#395513 , @pino wrote: > > > This makes a "core" library grow a dependency on widgets -- not really a good idea, considering

D18317: Don't fail if defaultLanguage dictionary can't be loaded

pino added a comment. In D18317#395513 , @pino wrote: > This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that. In addition to the above, there are also

D18317: Don't fail if defaultLanguage dictionary can't be loaded

pino added a comment. This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino,

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ngraham added a reviewer: loh.tar. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir created this revision. ahmadsamir added a reviewer: sandsmark. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the files of the the dictionary set in defaultLanguage= can't be loaded, instead of failing silently, try to load the