D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a task: T10325: 5.16 Login screen redesign. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a dependent revision: D19129: [sddm-theme] Apply new username prompt and user list icons. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik,

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment. In D19020#414802 , @ngraham wrote: > I love it. Looks perfect to me now. Thanks :D Will be landing it shortly REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master)

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. I love it. Looks perfect to me now. REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51997. rooty added a comment. Use more integers REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51993=51997 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51993. rooty added a comment. Make Z's larger REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51985=51993 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: filipf, trickyricky26, ndavis, broulik,

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment. I actually did resize this one too because you can never be quite sure which 22 px icon will be used hahahah And I grazed the top margin a little bit but I actually managed to stay within all the other margins REPOSITORY R242 Plasma Framework (Library) BRANCH

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51985. rooty added a comment. Resize 22 px switch user icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51982=51985 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually those concerns should be in the icon theme patch, never mind. I'm good with this now! Thoughts, other #vdg people? Shall we land this?

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a comment. Oh and one more minor thing: the Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display: F6621746: Screenshot_20190218_105639.png F6621748: Screenshot_20190218_105747.png

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51982. rooty added a comment. Remove second filled in user from 22 px switch user icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51954=51982 BRANCH user-prompt-list-icons (branched

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Nathaniel Graham
ngraham added a comment. Almost perfect! I have one remaining visual nitpick: F6621734: Black.png Can we make the small version of the switch user icon have a body that's not filled in with Shade Black? That way it will match the small versions

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Filip Fila
filipf added a comment. I think the current revision is quite nice. We could always pick apart details and other potential solutions, but the icons get the point across and look good. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To:

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty added a comment. In D19020#414339 , @ndavis wrote: > That last little square in the username bothers me. If only I could use text/lettering... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty updated this revision to Diff 51954. rooty added a comment. Remove second square from username bar REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51938=51954 BRANCH user-prompt-list-icons (branched from master)

D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Noah Davis
ndavis added a comment. In D19020#414317 , @rooty wrote: > In D19020#414300 , @abetts wrote: > > > Well, maybe it is time to call it and be done. I don't think we are going to please everyone right

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment. In D19020#414300 , @abetts wrote: > Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51938. rooty added a comment. Center user prompt icon vertically REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51920=51938 BRANCH user-prompt-list-icons (branched from master) REVISION

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Andres Betts
abetts added a comment. Well, maybe it is time to call it and be done. I don't think we are going to please everyone right now. Maybe our best option is to have you, as the proponent of this idea, make the decision after long debate. REPOSITORY R242 Plasma Framework (Library) REVISION

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment. In D19020#414285 , @abetts wrote: > I think the icon is pretty much there. Maybe the label can help the meaning come across. What about: > > "Enter User" > "Type User" > "Change User" haha it was actually

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Andres Betts
abetts added a comment. I think the icon is pretty much there. Maybe the label can help the meaning come across. What about: "Enter User" "Type User" "Change User" REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg,

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment. In D19020#414231 , @trickyricky26 wrote: > As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment. As they are now it's long, short, long (exact same length as rectangle number 1), shorter than height (which looks bad imo). There are no medium lengths and the same length is used twice. I would suggest giving every bar a different length. If you're

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment. In D19020#414224 , @trickyricky26 wrote: > I like it! > > I think the "Type User" Icon would look better if the bars acting as placeholder text were a bit less regular in width and would not be shorter than they are

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread TrickyRicky
trickyricky26 added a comment. I like it! I think the "Type User" Icon would look better if the bars acting as placeholder text were a bit less regular in width and would not be shorter than they are tall (which is the case for the rightmost rectangle). Also, can the usernames in the

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51920. rooty added a comment. Replace "Other..." icon with newer version REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51909=51920 BRANCH user-prompt-list-icons (branched from master)

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty added a comment. @abetts F6620144: image.png This is what I came up for the login/password field idea. What do you think? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg,

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Krešimir Čohar
rooty updated this revision to Diff 51909. rooty added a comment. Add new switch user icons REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51821=51909 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a dependent revision: D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik,

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51821. rooty added a comment. Fix suspend icon height REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51793=51821 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty updated this revision to Diff 51793. rooty added a comment. Use Zs instead of stars REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51727=51793 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham added a comment. Yeah in and of itself, the snowflake is good. I think it just needs something added to it so it doesn't look like it turns on the air conditioning as Kai alluded to. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Krešimir Čohar
rooty added a comment. In D19020#412775 , @ngraham wrote: > +1 on the List Users icon. Perfect. > > For the Type User icon, I'm not sure it needs to be in a circle. With the new moon-style suspend icon on the left side, it might be better to

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. +1 on the List Users icon. Perfect. For the Type User icon, I'm not sure it needs to be in a circle. With the new moon-style suspend icon on the left side, it might be

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Noah Davis
ndavis added a comment. In D19020#412584 , @broulik wrote: > What's the air conditioning do? suspend to disk? > > +1 on the moon for suspend Yes. The previous symbol was a sun-like symbol (22px old version left of 32px new version):

D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Kai Uwe Broulik
broulik added a comment. What's the air conditioning do? suspend to disk? +1 on the moon for suspend REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: broulik, kde-frameworks-devel, michaelh,

D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty edited the summary of this revision. rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty updated this revision to Diff 51727. rooty added a comment. Add suspend moon/crescent and hibernate snowflake (thanks Noah!) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51718=51727 BRANCH user-prompt-list-icons

D19020: [breeze-icons] Revamp system.svgz

2019-02-14 Thread Krešimir Čohar
rooty retitled this revision from "[breeze-icons] WIP, Add "Type User" and "List Users" icons" to "[breeze-icons] Revamp system.svgz". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: